Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196937/?format=api
{ "id": 2196937, "url": "http://patchwork.ozlabs.org/api/patches/2196937/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-gpio/patch/20260216160946.2977985-1-wens@kernel.org/", "project": { "id": 42, "url": "http://patchwork.ozlabs.org/api/projects/42/?format=api", "name": "Linux GPIO development", "link_name": "linux-gpio", "list_id": "linux-gpio.vger.kernel.org", "list_email": "linux-gpio@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260216160946.2977985-1-wens@kernel.org>", "list_archive_url": null, "date": "2026-02-16T16:09:45", "name": "pinctrl: sunxi: Implement gpiochip::get_direction()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "943fd6017728438af6d7e28731f67b2431404a29", "submitter": { "id": 76129, "url": "http://patchwork.ozlabs.org/api/people/76129/?format=api", "name": "Chen-Yu Tsai", "email": "wens@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-gpio/patch/20260216160946.2977985-1-wens@kernel.org/mbox/", "series": [ { "id": 492325, "url": "http://patchwork.ozlabs.org/api/series/492325/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-gpio/list/?series=492325", "date": "2026-02-16T16:09:45", "name": "pinctrl: sunxi: Implement gpiochip::get_direction()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492325/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196937/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196937/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-gpio+bounces-31723-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-gpio@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=BBDPV3eH;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-31723-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"BBDPV3eH\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201" ], "Received": [ "from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF75g3BHhz1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 17 Feb 2026 03:09:59 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id B677D3009514\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 16 Feb 2026 16:09:54 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 0E0CF3321CD;\n\tMon, 16 Feb 2026 16:09:54 +0000 (UTC)", "from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id C593731D735;\n\tMon, 16 Feb 2026 16:09:53 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 28C6EC116C6;\n\tMon, 16 Feb 2026 16:09:53 +0000 (UTC)", "by wens.tw (Postfix, from userid 1000)\n\tid 654195FB53; Tue, 17 Feb 2026 00:09:50 +0800 (CST)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1771258193; cv=none;\n b=sJpUGL8hIYMCYwbV2r9WD6LCyR/rrY0S6Klbw8LnovTdXLsG5NCg9St9ZABCS+BLF4VPl70b5lGsV4mLmMB+IWCkyVHI0H1Oj8xzNVQOf2/ssw6pq8Uoyt5aLBc0CzE6Awpu/QURTjIF6uPXeP7pcq/0rpEbIG7EE5RmDDsG9CE=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1771258193; c=relaxed/simple;\n\tbh=UqDRMXV5CMeqJBNwQ0YkRTV0b+lq3bdiw6cfPXkbP64=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=rY6/MYXs6Iuv0IBsmrObQHKgYQhGuB63MzJgxYbPm2n+eCWPbiz7ucJWvCawGqlOMR+uojN7iKaPM9RiaI9nY5xlHaa6ZsLxC6Q4jbULoTCBmG2TOgO7HkQzNBsumLZrK+s2b2v6T6DqagQ16U1VghrhEvJ7chgh8ZK7xAwV8Y4=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=BBDPV3eH; arc=none smtp.client-ip=10.30.226.201", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1771258193;\n\tbh=UqDRMXV5CMeqJBNwQ0YkRTV0b+lq3bdiw6cfPXkbP64=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=BBDPV3eH8Q/jbeyyBHiwVTpfeb2mNul2+YX/xPSgJoTjEucI1HanEqbx50xf7Yn5m\n\t xJ+yX0mboUAw3Zp/EujV1LWAEUgvcvRX7CnsnSL8rRxmWt+9VxxlzVnVb6JW+U29a6\n\t i4M8Jl2rU+CJWazDcoTepInW0QtDkIFi4+lt0UeDNfr84jAyDjauQxpWHHlT5JugH1\n\t HYjKkJxUtOriwv8C8SlbiP9X70uaetXyy3W/iwdWa3fys16FHpDpN/T3XI90q0b5lx\n\t 2XrafkqvDu3eusyLEulEx0rWeqyz9xRWy1UCfW7vzcJ+sBFlEYfjcB7A8Mfb5v/wSw\n\t G+5IkUB5UBFfg==", "From": "Chen-Yu Tsai <wens@kernel.org>", "To": "Chen-Yu Tsai <wens@kernel.org>,\n\tJernej Skrabec <jernej@kernel.org>,\n\tSamuel Holland <samuel@sholland.org>,\n\tBartosz Golaszewski <brgl@kernel.org>,\n\tLinus Walleij <linusw@kernel.org>", "Cc": "James Hilliard <james.hilliard1@gmail.com>,\n\tAndre Przywara <andre.przywara@arm.com>,\n\tlinux-gpio@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org,\n\tlinux-sunxi@lists.linux.dev,\n\tlinux-kernel@vger.kernel.org", "Subject": "[PATCH] pinctrl: sunxi: Implement gpiochip::get_direction()", "Date": "Tue, 17 Feb 2026 00:09:45 +0800", "Message-ID": "<20260216160946.2977985-1-wens@kernel.org>", "X-Mailer": "git-send-email 2.47.3", "Precedence": "bulk", "X-Mailing-List": "linux-gpio@vger.kernel.org", "List-Id": "<linux-gpio.vger.kernel.org>", "List-Subscribe": "<mailto:linux-gpio+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-gpio+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "After commit e623c4303ed1 (\"gpiolib: sanitize the return value of\ngpio_chip::get_direction()\"), a warning will be printed if the\ngpio driver does not implement this callback.\n\nImplement it for the sunxi driver. This is simply a matter of reading\nout the mux value from the registers, then checking if it is one of\nthe GPIO functions and which direction it is.\n\nSigned-off-by: Chen-Yu Tsai <wens@kernel.org>\n---\nThis is an alternative to James's version. My version does one lookup\ninstead of three.\n\n drivers/pinctrl/sunxi/pinctrl-sunxi.c | 51 +++++++++++++++++++++++++++\n 1 file changed, 51 insertions(+)", "diff": "diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c\nindex 0fb057a07dcc..27b2a3e9d78d 100644\n--- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c\n+++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c\n@@ -204,6 +204,32 @@ sunxi_pinctrl_desc_find_function_by_pin(struct sunxi_pinctrl *pctl,\n \treturn NULL;\n }\n \n+static struct sunxi_desc_function *\n+sunxi_pinctrl_desc_find_function_by_pin_and_mux(struct sunxi_pinctrl *pctl,\n+\t\t\t\t\t\tconst u16 pin_num,\n+\t\t\t\t\t\tconst u8 muxval)\n+{\n+\tfor (unsigned int i = 0; i < pctl->desc->npins; i++) {\n+\t\tconst struct sunxi_desc_pin *pin = pctl->desc->pins + i;\n+\t\tstruct sunxi_desc_function *func = pin->functions;\n+\n+\t\tif (pin->pin.number != pin_num)\n+\t\t\tcontinue;\n+\n+\t\tif (pin->variant && !(pctl->variant & pin->variant))\n+\t\t\tcontinue;\n+\n+\t\twhile (func->name) {\n+\t\t\tif (func->muxval == muxval)\n+\t\t\t\treturn func;\n+\n+\t\t\tfunc++;\n+\t\t}\n+\t}\n+\n+\treturn NULL;\n+}\n+\n static int sunxi_pctrl_get_groups_count(struct pinctrl_dev *pctldev)\n {\n \tstruct sunxi_pinctrl *pctl = pinctrl_dev_get_drvdata(pctldev);\n@@ -930,6 +956,30 @@ static const struct pinmux_ops sunxi_pmx_ops = {\n \t.strict\t\t\t= true,\n };\n \n+static int sunxi_pinctrl_gpio_get_direction(struct gpio_chip *chip,\n+\t\t\t\t\t unsigned int offset)\n+{\n+\tstruct sunxi_pinctrl *pctl = gpiochip_get_data(chip);\n+\tconst struct sunxi_desc_function *func;\n+\tu32 pin = offset + chip->base;\n+\tu32 reg, shift, mask;\n+\tu8 muxval;\n+\n+\tsunxi_mux_reg(pctl, offset, ®, &shift, &mask);\n+\n+\tmuxval = (readl(pctl->membase + reg) & mask) >> shift;\n+\n+\tfunc = sunxi_pinctrl_desc_find_function_by_pin_and_mux(pctl, pin, muxval);\n+\tif (!func)\n+\t\treturn -ENODEV;\n+\n+\tif (!strcmp(func->name, \"gpio_out\"))\n+\t\treturn GPIO_LINE_DIRECTION_OUT;\n+\tif (!strcmp(func->name, \"gpio_in\") || !strcmp(func->name, \"irq\"))\n+\t\treturn GPIO_LINE_DIRECTION_IN;\n+\treturn -EINVAL;\n+}\n+\n static int sunxi_pinctrl_gpio_direction_input(struct gpio_chip *chip,\n \t\t\t\t\tunsigned offset)\n {\n@@ -1601,6 +1651,7 @@ int sunxi_pinctrl_init_with_flags(struct platform_device *pdev,\n \tpctl->chip->request = gpiochip_generic_request;\n \tpctl->chip->free = gpiochip_generic_free;\n \tpctl->chip->set_config = gpiochip_generic_config;\n+\tpctl->chip->get_direction = sunxi_pinctrl_gpio_get_direction;\n \tpctl->chip->direction_input = sunxi_pinctrl_gpio_direction_input;\n \tpctl->chip->direction_output = sunxi_pinctrl_gpio_direction_output;\n \tpctl->chip->get = sunxi_pinctrl_gpio_get;\n", "prefixes": [] }