Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196927/?format=api
{ "id": 2196927, "url": "http://patchwork.ozlabs.org/api/patches/2196927/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ovn/patch/20260216152021.1169859-1-dceara@redhat.com/", "project": { "id": 68, "url": "http://patchwork.ozlabs.org/api/projects/68/?format=api", "name": "Open Virtual Network development", "link_name": "ovn", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260216152021.1169859-1-dceara@redhat.com>", "list_archive_url": null, "date": "2026-02-16T15:20:21", "name": "[ovs-dev] inc-proc-eng: Assert that node states are in the right range.", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "46076c557bdf094b832a7263ce26eb227e8c811e", "submitter": { "id": 76591, "url": "http://patchwork.ozlabs.org/api/people/76591/?format=api", "name": "Dumitru Ceara", "email": "dceara@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/ovn/patch/20260216152021.1169859-1-dceara@redhat.com/mbox/", "series": [ { "id": 492319, "url": "http://patchwork.ozlabs.org/api/series/492319/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ovn/list/?series=492319", "date": "2026-02-16T15:20:21", "name": "[ovs-dev] inc-proc-eng: Assert that node states are in the right range.", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492319/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196927/comments/", "check": "fail", "checks": "http://patchwork.ozlabs.org/api/patches/2196927/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "ovs-dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "ovs-dev@lists.linuxfoundation.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=aLPnDNmv;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)", "smtp3.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=aLPnDNmv", "smtp3.osuosl.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF61S3LfVz1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 17 Feb 2026 02:21:16 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 5E433607C8;\n\tMon, 16 Feb 2026 15:21:14 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id DfwYtnX6mwE6; Mon, 16 Feb 2026 15:21:12 +0000 (UTC)", "from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp3.osuosl.org (Postfix) with ESMTPS id 0A5EC60BC8;\n\tMon, 16 Feb 2026 15:21:12 +0000 (UTC)", "from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id B7D6AC0035;\n\tMon, 16 Feb 2026 15:21:11 +0000 (UTC)", "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n by lists.linuxfoundation.org (Postfix) with ESMTP id A5174C0033\n for <ovs-dev@openvswitch.org>; Mon, 16 Feb 2026 15:21:10 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 7D92760BD7\n for <ovs-dev@openvswitch.org>; Mon, 16 Feb 2026 15:21:10 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id ExQXQgjd5axK for <ovs-dev@openvswitch.org>;\n Mon, 16 Feb 2026 15:21:10 +0000 (UTC)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by smtp3.osuosl.org (Postfix) with ESMTPS id A63DB60BC5\n for <ovs-dev@openvswitch.org>; Mon, 16 Feb 2026 15:21:08 +0000 (UTC)", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-616-e1gqpZSvOeGL5nLgoybb8A-1; Mon,\n 16 Feb 2026 10:21:06 -0500", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id B1B5D180047F\n for <ovs-dev@openvswitch.org>; Mon, 16 Feb 2026 15:21:05 +0000 (UTC)", "from cecil-rh.redhat.com (unknown [10.44.34.118])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id AEDCC1955F43; Mon, 16 Feb 2026 15:21:04 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.9.56;\n helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 0A5EC60BC8", "OpenDKIM Filter v2.11.0 smtp3.osuosl.org A63DB60BC5" ], "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=170.10.133.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=dceara@redhat.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp3.osuosl.org A63DB60BC5", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771255267;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=pxSiu0WK6STGELMo+vgJZVCmLt5JEGe7uSkBxhhiYaU=;\n b=aLPnDNmvwiTVNph+C0Eif4/CDO+S52FzkrqbwskA5kNheymVTFnpB4TVujqLso0RnXHcwF\n NTXszB3++sxGdFWqXTqI1oulvKvoAAqWtQgY8/7wLlBaKaAxJe3wvTWgaENNwkaqK3iR64\n wjIUbS5sra/sbMCBQiH1guLkJqpQBV0=", "X-MC-Unique": "e1gqpZSvOeGL5nLgoybb8A-1", "X-Mimecast-MFC-AGG-ID": "e1gqpZSvOeGL5nLgoybb8A_1771255265", "To": "ovs-dev@openvswitch.org", "Date": "Mon, 16 Feb 2026 16:20:21 +0100", "Message-ID": "<20260216152021.1169859-1-dceara@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "jwJoYekZwnw_IpQXKqQVG8_PDKj-ppdHaDWANAnSWFs_1771255265", "X-Mimecast-Originator": "redhat.com", "Subject": "[ovs-dev] [PATCH ovn] inc-proc-eng: Assert that node states are in\n the right range.", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "From": "Dumitru Ceara via dev <ovs-dev@openvswitch.org>", "Reply-To": "Dumitru Ceara <dceara@redhat.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ovs-dev-bounces@openvswitch.org", "Sender": "\"dev\" <ovs-dev-bounces@openvswitch.org>" }, "content": "Incremental processing run() callbacks must always move the node to a\nvalid state (< EN_STATE_MAX). That's always the case but the code was\nnot explicitly checking for that which caused coverity to come up with\nfalse positive reports like:\n\n 4. index_parm: Indexing array engine_node_state_name of size 4 with state.\n 364 VLOG_DBG(\"node: %s, old_state %s, new_state %s, reason: %s.\",\n 365 node->name, engine_node_state_name[node->state],\n 366 engine_node_state_name[state], reason);\n\nTo guide the code analysis, add an assertion that fails if that's not\nthe case.\n\nSuggested-by: Ales Musil <amusil@redhat.com>\nSigned-off-by: Dumitru Ceara <dceara@redhat.com>\n---\n lib/inc-proc-eng.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/lib/inc-proc-eng.c b/lib/inc-proc-eng.c\nindex dd06a88c1d..a4b6c8cde3 100644\n--- a/lib/inc-proc-eng.c\n+++ b/lib/inc-proc-eng.c\n@@ -353,6 +353,8 @@ engine_set_node_state(struct engine_node *node,\n enum engine_node_state state,\n const char *reason_fmt, ...)\n {\n+ ovs_assert(state < EN_STATE_MAX);\n+\n if (node->state == state) {\n return;\n }\n", "prefixes": [ "ovs-dev" ] }