Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196922/?format=api
{ "id": 2196922, "url": "http://patchwork.ozlabs.org/api/patches/2196922/?format=api", "web_url": "http://patchwork.ozlabs.org/project/buildroot/patch/20260216-host-dtc-build-failure-v1-1-75dd77ff4650@bootlin.com/", "project": { "id": 27, "url": "http://patchwork.ozlabs.org/api/projects/27/?format=api", "name": "Buildroot development", "link_name": "buildroot", "list_id": "buildroot.buildroot.org", "list_email": "buildroot@buildroot.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260216-host-dtc-build-failure-v1-1-75dd77ff4650@bootlin.com>", "list_archive_url": null, "date": "2026-02-16T14:26:33", "name": "package/dtc: fix host build with glibc 2.43", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "bf81d645632348c6dabe0f2dcfa2f87607878965", "submitter": { "id": 85775, "url": "http://patchwork.ozlabs.org/api/people/85775/?format=api", "name": "Alexis Lothoré", "email": "alexis.lothore@bootlin.com" }, "delegate": { "id": 89618, "url": "http://patchwork.ozlabs.org/api/users/89618/?format=api", "username": "juju", "first_name": "Julien", "last_name": "Olivain", "email": "juju@cotds.org" }, "mbox": "http://patchwork.ozlabs.org/project/buildroot/patch/20260216-host-dtc-build-failure-v1-1-75dd77ff4650@bootlin.com/mbox/", "series": [ { "id": 492316, "url": "http://patchwork.ozlabs.org/api/series/492316/?format=api", "web_url": "http://patchwork.ozlabs.org/project/buildroot/list/?series=492316", "date": "2026-02-16T14:26:33", "name": "package/dtc: fix host build with glibc 2.43", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492316/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196922/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196922/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<buildroot-bounces@buildroot.org>", "X-Original-To": [ "incoming-buildroot@patchwork.ozlabs.org", "buildroot@buildroot.org" ], "Delivered-To": [ "patchwork-incoming-buildroot@legolas.ozlabs.org", "buildroot@buildroot.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=buildroot.org header.i=@buildroot.org\n header.a=rsa-sha256 header.s=default header.b=jrKtvFCC;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=buildroot.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=buildroot-bounces@buildroot.org; receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF4pb4NJfz1xwF\n\tfor <incoming-buildroot@patchwork.ozlabs.org>;\n Tue, 17 Feb 2026 01:26:47 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id B6D3760B8A;\n\tMon, 16 Feb 2026 14:26:45 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id NQ_ewvTo3JZZ; Mon, 16 Feb 2026 14:26:44 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id A7D2060B8B;\n\tMon, 16 Feb 2026 14:26:44 +0000 (UTC)", "from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id 2FF5E1EB\n for <buildroot@buildroot.org>; Mon, 16 Feb 2026 14:26:43 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 14D564031B\n for <buildroot@buildroot.org>; Mon, 16 Feb 2026 14:26:43 +0000 (UTC)", "from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id DA7xoVnqU1Au for <buildroot@buildroot.org>;\n Mon, 16 Feb 2026 14:26:42 +0000 (UTC)", "from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56])\n by smtp2.osuosl.org (Postfix) with ESMTPS id E8FF540245\n for <buildroot@buildroot.org>; Mon, 16 Feb 2026 14:26:41 +0000 (UTC)", "from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233])\n by smtpout-02.galae.net (Postfix) with ESMTPS id 096B51A0F9F;\n Mon, 16 Feb 2026 14:26:40 +0000 (UTC)", "from mail.galae.net (mail.galae.net [212.83.136.155])\n by smtpout-01.galae.net (Postfix) with ESMTPS id CDBB0606CF;\n Mon, 16 Feb 2026 14:26:39 +0000 (UTC)", "from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon)\n with ESMTPSA id AF2D11036916C; Mon, 16 Feb 2026 15:26:38 +0100 (CET)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=buildroot-bounces@buildroot.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp3.osuosl.org A7D2060B8B", "OpenDKIM Filter v2.11.0 smtp2.osuosl.org E8FF540245" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=buildroot.org;\n\ts=default; t=1771252004;\n\tbh=zqwnHmRTN5vhyMldlKWhnt6IlOirQXdctGU4Ezr6Hwk=;\n\th=Date:To:Cc:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From:Reply-To:From;\n\tb=jrKtvFCCYenDUkthcJ/pYqqRoEhe+9DkLyU2G6FAmp/CsCwOvI6TTO5MTDtv0TCLf\n\t Hl/voVbcOkQrS/pCDPPJeghrlJyk1T53ogbIw/jXIbavPZoPHORsOX6fjXxKZ64Iw/\n\t 6V498IIs17/jyNeQGQOp4/1g4JEmY0JdJqa8RYfw42tLfbZPO0fDpZiBM1arvAmvMF\n\t a4+RRw/io8BzC1BLl0/4H381ngB0hFvgFS6QespPvnTZmWIWQuo8zmoG6o3Ue+NTKy\n\t OMaJeAXdYdPtdKkec4xcCWJAEwV/LajmsNNJToa94vdX/52kXMt0hvU93TY26fbCmJ\n\t xkaS/64HdGDhg==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=185.246.84.56;\n helo=smtpout-02.galae.net; envelope-from=alexis.lothore@bootlin.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp2.osuosl.org E8FF540245", "Date": "Mon, 16 Feb 2026 15:26:33 +0100", "MIME-Version": "1.0", "Message-Id": "<20260216-host-dtc-build-failure-v1-1-75dd77ff4650@bootlin.com>", "X-B4-Tracking": "v=1; b=H4sIAAAAAAAC/x3MSQqAMAxA0atI1ga0izpcRVxommqgVOkggnh3i\n 8u3+P+ByEE4wlg9EPiSKIcvaOsKaF/8xiimGFSjdKNajfsRE5pEuGZxBu0iLgdGst3aE2mjhw5\n KfAa2cv/jaX7fD6CswrRoAAAA", "X-Change-ID": "20260216-host-dtc-build-failure-cf7b8cc6d697", "To": "buildroot@buildroot.org", "Cc": "Thomas Petazzoni <thomas.petazzoni@bootlin.com>,\n Brandon Maier <brandon.maier@gmail.com>,\n =?utf-8?q?Alexis_Lothor=C3=A9?= <alexis.lothore@bootlin.com>", "X-Mailer": "b4 0.14.3", "X-Last-TLS-Session-Version": "TLSv1.3", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=bootlin.com; s=dkim;\n t=1771251999; h=from:subject:date:message-id:to:cc:mime-version:content-type:\n content-transfer-encoding; bh=IvLwDfZNR0KhxGknG5RuDEbPwB8WA+A1+8bFYBmcS+4=;\n b=nlPFGlt/7jj6akNgpFpIWC4I1zgM98KTYezNXnwlT/tTlSVSQppDjjHYPhx3Bl3ahGU3r4\n PaBgWEj/fq3+KbpMWYRAV0t9FNQ8hqkN0clhqW4cLkNixUjFd2jcYG8jqX6CsDflcOb7mZ\n Zh8cVbCjIpfWCHIEIxMcsF4glI1IyUT+YGQtdLQ0zeu3eJzfyBKbHhFaGfnivDatGcCLus\n b8CGnv3eUVZD2O+kd5Mt0INTQFnxU0BNvFNtMAr9onX4dN75ZxFygyEBfwaPGeZU+R6j3S\n 3roFSy+7u0NgbkKXQyW9PG8dWbxoQUPcaE4tyDUBP2CZ1YgrkCdc+99CxPFP2Q==", "X-Mailman-Original-Authentication-Results": [ "smtp2.osuosl.org;\n dmarc=pass (p=reject dis=none)\n header.from=bootlin.com", "smtp2.osuosl.org;\n dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com\n header.a=rsa-sha256 header.s=dkim header.b=nlPFGlt/" ], "Subject": "[Buildroot] [PATCH] package/dtc: fix host build with glibc 2.43", "X-BeenThere": "buildroot@buildroot.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Discussion and development of buildroot <buildroot.buildroot.org>", "List-Unsubscribe": "<https://lists.buildroot.org/mailman/options/buildroot>,\n <mailto:buildroot-request@buildroot.org?subject=unsubscribe>", "List-Archive": "<http://lists.buildroot.org/pipermail/buildroot/>", "List-Post": "<mailto:buildroot@buildroot.org>", "List-Help": "<mailto:buildroot-request@buildroot.org?subject=help>", "List-Subscribe": "<https://lists.buildroot.org/mailman/listinfo/buildroot>,\n <mailto:buildroot-request@buildroot.org?subject=subscribe>", "From": "=?utf-8?q?Alexis_Lothor=C3=A9_via_buildroot?= <buildroot@buildroot.org>", "Reply-To": "=?utf-8?q?Alexis_Lothor=C3=A9?= <alexis.lothore@bootlin.com>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "buildroot-bounces@buildroot.org", "Sender": "\"buildroot\" <buildroot-bounces@buildroot.org>" }, "content": "When trying to build host-dtc on a host with glibc 2.43, the build fails\non the following error:\n\n libfdt/fdt_overlay.c: In function ‘overlay_fixup_phandle’:\n libfdt/fdt_overlay.c:424:21: error: assignment discards ‘const’\n qualifier from pointer target type [-Werror=discarded-qualifiers]\n 424 | sep = memchr(fixup_str, ':', fixup_len);\n | ^\n libfdt/fdt_overlay.c:434:21: error: assignment discards ‘const’\n qualifier from pointer target type [-Werror=discarded-qualifiers]\n 434 | sep = memchr(name, ':', fixup_len);\n | ^\n fdtput.c: In function ‘create_node’:\n fdtput.c:235:11: error: assignment discards ‘const’ qualifier from\n pointer target type [-Werror=discarded-qualifiers]\n 235 | p = strrchr(node_name, '/');\n | ^\n cc1: all warnings being treated as errors\n make[2]: *** [Makefile:359: fdtput.o] Error 1\n make[2]: *** Waiting for unfinished jobs....\n cc1: all warnings being treated as errors\n make[2]: *** [Makefile:359: libfdt/fdt_overlay.o] Error 1\n make[1]: *** [package/pkg-generic.mk:273:\n /home/alexis/src/buildroot/dtc/build/host-dtc-1.7.2/.stamp_built] Error 2\n make: *** [Makefile:83: _all] Error 2\n\nThe issue can be reproduced on master with this minimal defconfig on a\nhost having glibc 2.43:\n\n BR2_x86_64=y\n BR2_TOOLCHAIN_EXTERNAL=y\n BR2_PACKAGE_QORIQ_MC_UTILS=y\n\n(QORIQ_MC_UTILS will pull HOST_DTC)\n\nThis error is due to some functions prototype update in glibc 2.43 for\nISO C23 (see [1], point 3 in the NEWS list). The corresponding fix has\nalready been integrated upstream, but it has not been released since\nthen.\n\nBring the corresponding upstream patch to allow host-dtc to build on\naffected hosts.\n\n[1] https://lists.gnu.org/archive/html/info-gnu/2026-01/msg00005.html\n\nSigned-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>\n---\nThe issue affects both master and 2025.02.x\n---\n .../dtc/0002-fix-discarded-const-qualifiers.patch | 88 ++++++++++++++++++++++\n 1 file changed, 88 insertions(+)\n\n\n---\nbase-commit: beabd8baeef37f1780f52e3c9d464c611731ba98\nchange-id: 20260216-host-dtc-build-failure-cf7b8cc6d697\n\nBest regards,", "diff": "diff --git a/package/dtc/0002-fix-discarded-const-qualifiers.patch b/package/dtc/0002-fix-discarded-const-qualifiers.patch\nnew file mode 100644\nindex 000000000000..95db886389cd\n--- /dev/null\n+++ b/package/dtc/0002-fix-discarded-const-qualifiers.patch\n@@ -0,0 +1,88 @@\n+From 9a1c801a1a3c102bf95c5339c9e985b26b823a21 Mon Sep 17 00:00:00 2001\n+From: Stephen Gallagher <sgallagh@redhat.com>\n+Date: Tue, 6 Jan 2026 14:19:30 -0500\n+Subject: Fix discarded const qualifiers\n+\n+It's unsafe to implicitly discard the const qualifier on a pointer. In\n+overlay_fixup_phandle(), this was probably just an oversight, and making\n+the \"sep\" variable a const char * is sufficient to fix it.\n+\n+In create_node(), however, the \"p\" variable is directly modifying the\n+buffer pointed to by \"const char* node_name\". To fix this, we need to\n+actually make a duplicate of the buffer and operate on that instead.\n+\n+This introduces a malloc()/free() and an unbounded strdup() into the\n+operation, but fdtput isn't a long-running service and the node_name\n+argument comes directly from argv, so this shouldn't introduce a\n+significant performance impact.\n+\n+Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>\n+Signed-off-by: David Gibson <david@gibson.dropbear.id.au>\n+Upstream: https://git.kernel.org/pub/scm/utils/dtc/dtc.git/commit/?id=9a1c801a1a3c102bf95c5339c9e985b26b823a21\n+Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>\n+\n+---\n+ fdtput.c | 8 +++++---\n+ libfdt/fdt_overlay.c | 3 ++-\n+ meson.build | 1 +\n+ 3 files changed, 8 insertions(+), 4 deletions(-)\n+\n+diff --git a/fdtput.c b/fdtput.c\n+index 05f2b93..fdb581a 100644\n+--- a/fdtput.c\n++++ b/fdtput.c\n+@@ -254,19 +254,21 @@ static int create_paths(char **blob, const char *in_path)\n+ static int create_node(char **blob, const char *node_name)\n+ {\n+ \tint node = 0;\n+-\tchar *p;\n++\tconst char *p;\n++\tchar *path = NULL;\n+ \n+ \tp = strrchr(node_name, '/');\n+ \tif (!p) {\n+ \t\treport_error(node_name, -1, -FDT_ERR_BADPATH);\n+ \t\treturn -1;\n+ \t}\n+-\t*p = '\\0';\n+ \n+ \t*blob = realloc_node(*blob, p + 1);\n+ \n+ \tif (p > node_name) {\n+-\t\tnode = fdt_path_offset(*blob, node_name);\n++\t\tpath = xstrndup(node_name, (size_t)(p - node_name));\n++\t\tnode = fdt_path_offset(*blob, path);\n++\t\tfree(path);\n+ \t\tif (node < 0) {\n+ \t\t\treport_error(node_name, -1, node);\n+ \t\t\treturn -1;\n+diff --git a/libfdt/fdt_overlay.c b/libfdt/fdt_overlay.c\n+index e6b9eb6..51a3859 100644\n+--- a/libfdt/fdt_overlay.c\n++++ b/libfdt/fdt_overlay.c\n+@@ -407,7 +407,8 @@ static int overlay_fixup_phandle(void *fdt, void *fdto, int symbols_off,\n+ \t\tconst char *fixup_str = value;\n+ \t\tuint32_t path_len, name_len;\n+ \t\tuint32_t fixup_len;\n+-\t\tchar *sep, *endptr;\n++\t\tconst char *sep;\n++\t\tchar *endptr;\n+ \t\tint poffset, ret;\n+ \n+ \t\tfixup_end = memchr(value, '\\0', len);\n+diff --git a/meson.build b/meson.build\n+index 66b44e8..501b706 100644\n+--- a/meson.build\n++++ b/meson.build\n+@@ -18,6 +18,7 @@ add_project_arguments(\n+ '-Wshadow',\n+ '-Wsuggest-attribute=format',\n+ '-Wwrite-strings',\n++ '-Wdiscarded-qualifiers',\n+ ]),\n+ language: 'c'\n+ )\n+-- \n+cgit 1.2.3-korg\n+\n+\n", "prefixes": [] }