Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196871/?format=api
{ "id": 2196871, "url": "http://patchwork.ozlabs.org/api/patches/2196871/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-74-e676662e4514@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260216-audio-v1-74-e676662e4514@redhat.com>", "list_archive_url": null, "date": "2026-02-16T11:16:03", "name": "[74/85] audio: replace ldebug with trace events", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "5a0a465eacf555a103d6b46e9e317ce2c5d4c936", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-74-e676662e4514@redhat.com/mbox/", "series": [ { "id": 492294, "url": "http://patchwork.ozlabs.org/api/series/492294/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492294", "date": "2026-02-16T11:14:52", "name": "audio: cleanups & add a manual test", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492294/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196871/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196871/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Qr8v+z9+;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF0sP1JGwz1xwF\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 16 Feb 2026 22:28:57 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vrwfZ-0008F0-HV; Mon, 16 Feb 2026 06:21:37 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrwdG-0007kz-RP\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:19:15 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrwdF-0008SJ-2V\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:19:14 -0500", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-383-t-1jchMZMYSArAE2aATl6g-1; Mon,\n 16 Feb 2026 06:19:09 -0500", "from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 07E8C1800342; Mon, 16 Feb 2026 11:19:07 +0000 (UTC)", "from localhost (unknown [10.45.242.26])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id D83CC18004AD; Mon, 16 Feb 2026 11:19:05 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771240752;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=jh01TnR1WKr53dWUDRQLe2CRWCIsdVlOiG3qS34GaeQ=;\n b=Qr8v+z9+5DPTyaREJwtAcA3sEYWk9i6iZL0fWPlOjnBHIyiunWs4U5bVIz5YjR/oBY7khI\n QP99EGyVj65r97oBJBaXIKz3DcMFPJ7qCVZsoS7AFdxjLPRfLUwCw4DEZY48VldlnX+9U4\n zVksCSu0TMtgaMiZGJoY6rP8xGFGwz0=", "X-MC-Unique": "t-1jchMZMYSArAE2aATl6g-1", "X-Mimecast-MFC-AGG-ID": "t-1jchMZMYSArAE2aATl6g_1771240747", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Mon, 16 Feb 2026 12:16:03 +0100", "Subject": "[PATCH 74/85] audio: replace ldebug with trace events", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260216-audio-v1-74-e676662e4514@redhat.com>", "References": "<20260216-audio-v1-0-e676662e4514@redhat.com>", "In-Reply-To": "<20260216-audio-v1-0-e676662e4514@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Gerd Hoffmann <kraxel@redhat.com>, Eduardo Habkost <eduardo@habkost.net>,\n Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>,\n Christian Schoenebeck <qemu_oss@crudebyte.com>,\n Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>,\n Thomas Huth <huth@tuxfamily.org>, Alexandre Ratchov <alex@caoua.org>,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Laurent Vivier <laurent@vivier.eu>, \"Michael S. Tsirkin\" <mst@redhat.com>,\n Manos Pitsidianakis <manos.pitsidianakis@linaro.org>,\n Alistair Francis <alistair@alistair23.me>,\n \"Edgar E. Iglesias\" <edgar.iglesias@gmail.com>,\n Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Mark Cave-Ayland <mark.caveayland@nutanix.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=2585;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=LJcSuW2BtX9Mst8LxXKghg7ubBSgT/CUaX2Tj3sx1Wg=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvxSPE7di7Rch31YMastXMAVy+GZfzsJE4IK6\n Fvi8O83bZqJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL8UgAKCRDa6OEJdZac\n 5T+GEACpbLJzGOjg525NzPv4kC8pvkMsd0iF3XyMVgKJam1cBlQj3If6dK7B8zrxLr6BFknjArQ\n ySqgc1cXCqWLFgXK4BMJcHo5CaL8u/DHoi1lJFSbZPa+NoBEPGUB8wyGBt9XHsYytZenl7wUXFh\n vM6h/Zf+lGgdEykhcOCMTMx27HyCWYOehMkaHxvBBxG0PbsVIr3z7BbJllfUWG75bPZijIBe8VK\n yikCQXRwIhP3WfGV3DgTl31aWi2WuZ3J86HhKeT+7pAIwP6vO3yvZ/zmr7VqH3qzJJOv+rRzWb2\n NqMtIlJ5Q+nhaelSKGv8fHPak1ZQfPvEGbUeMcNLA25auYn6u+eDKs5PxsFJhlcQ6ukmGUFuj+T\n emyrxm6uBHi9u313nbGOiOjH5NcCfJJu8tbkEjUHi3b0C6s8wED1MJFeO7pAP1aQl7Q0j2kFXv0\n 1pk8oozJhDROqsGgwEgnV6S1xEXoEBaA1OgjEjWW3CjoGg0ThJUX+Sv2SeEDMYBdrmfPjAVcxdu\n GpFi+SNC05FTnDNB7BafVusVJoozRXEcFi/k5wmYawxlmmh7bpOl0uG6u7yGQHShan845xSZrtt\n 1C8it1U+Jmz/hkiO6SFY45YeG6vVaXDP3W3sMmwQiAUHmyaubvCB1G1lE5WK1MnLbevRjvAriTt\n ksLlNbUW3axPwlQ==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.93", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Replace the ldebug macro calls with proper trace events:\n- audio_get_avail: traces available samples in capture stream\n- audio_open_out/audio_open_in: traces stream open parameters\n\nThis provides structured tracing that can be enabled at runtime\nwithout requiring debug builds.\n\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\nReviewed-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>\n---\n audio/audio_template.h | 7 +++++--\n audio/audio-mixeng-be.c | 6 +-----\n audio/trace-events | 7 +++++++\n 3 files changed, 13 insertions(+), 7 deletions(-)", "diff": "diff --git a/audio/audio_template.h b/audio/audio_template.h\nindex 3da91a4782c..c47a2f202f0 100644\n--- a/audio/audio_template.h\n+++ b/audio/audio_template.h\n@@ -507,8 +507,11 @@ static SW *glue(audio_mixeng_backend_open_, TYPE) (\n k = AUDIO_MIXENG_BACKEND_GET_CLASS(s);\n pdo = glue(audio_get_pdo_, TYPE)(s->dev);\n \n- ldebug (\"open %s, freq %d, nchannels %d, fmt %d\\n\",\n- name, as->freq, as->nchannels, as->fmt);\n+#ifdef DAC\n+ trace_audio_open_out(name, as->freq, as->nchannels, as->fmt);\n+#else\n+ trace_audio_open_in(name, as->freq, as->nchannels, as->fmt);\n+#endif\n \n if (audio_bug(__func__, audio_validate_settings(as))) {\n audio_print_settings (as);\ndiff --git a/audio/audio-mixeng-be.c b/audio/audio-mixeng-be.c\nindex d05202aabae..84e4d136de3 100644\n--- a/audio/audio-mixeng-be.c\n+++ b/audio/audio-mixeng-be.c\n@@ -881,11 +881,7 @@ static size_t audio_get_avail(SWVoiceIn *sw)\n return 0;\n }\n \n- ldebug (\n- \"%s: get_avail live %zu frontend frames %u\\n\",\n- SW_NAME (sw),\n- live, st_rate_frames_out(sw->rate, live)\n- );\n+ trace_audio_get_avail(SW_NAME(sw), live, st_rate_frames_out(sw->rate, live));\n \n return live;\n }\ndiff --git a/audio/trace-events b/audio/trace-events\nindex f33be2dd8e3..4749c54fc04 100644\n--- a/audio/trace-events\n+++ b/audio/trace-events\n@@ -58,3 +58,10 @@ audio_be_set_active_out(void *sw, bool on) \"sw=%p, on=%d\"\n audio_timer_start(int interval) \"interval %d ms\"\n audio_timer_stop(void) \"\"\n audio_timer_delayed(int interval) \"interval %d ms\"\n+\n+# audio-mixeng-be.c\n+audio_get_avail(const char *name, size_t live, uint32_t frontend_frames) \"%s: get_avail live %zu frontend frames %u\"\n+\n+# audio_template.h\n+audio_open_out(const char *name, int freq, int nchannels, int fmt) \"open %s, freq %d, nchannels %d, fmt %d\"\n+audio_open_in(const char *name, int freq, int nchannels, int fmt) \"open %s, freq %d, nchannels %d, fmt %d\"\n", "prefixes": [ "74/85" ] }