Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196865/?format=api
{ "id": 2196865, "url": "http://patchwork.ozlabs.org/api/patches/2196865/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-73-e676662e4514@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260216-audio-v1-73-e676662e4514@redhat.com>", "list_archive_url": null, "date": "2026-02-16T11:16:02", "name": "[73/85] audio: replace int endianness with bool big_endian in audsettings", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b32afa148611cf39bb634baf48f47ec66b18712a", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-73-e676662e4514@redhat.com/mbox/", "series": [ { "id": 492294, "url": "http://patchwork.ozlabs.org/api/series/492294/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492294", "date": "2026-02-16T11:14:52", "name": "audio: cleanups & add a manual test", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492294/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196865/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196865/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=L6sPCos8;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF0qr51K5z1xwF\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 16 Feb 2026 22:27:36 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vrwfh-0000a9-6A; Mon, 16 Feb 2026 06:21:45 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrwdG-0007jL-C2\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:19:15 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrwdD-0008SB-4R\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:19:14 -0500", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-341-FnCv0qhAMbqPYgWbIvTNAw-1; Mon,\n 16 Feb 2026 06:19:06 -0500", "from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 078471956060; Mon, 16 Feb 2026 11:19:04 +0000 (UTC)", "from localhost (unknown [10.45.242.26])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 4F9D919560AD; Mon, 16 Feb 2026 11:19:03 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771240750;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=jntLF8LgSwELUiTDp0fDgXaQYj3kXStV51lpxXjNGtE=;\n b=L6sPCos8v282CrsoyjeMO5l/uSSKKTPjXtA5Ix3Ccbje05EcmaprnVsgEG87MfZmqtBofk\n AGOdVJF9Pz7eFIJaPM8d337SZp85BSQlIL2lxelDt4JlvXV4cS3HXXUpHyjzM2CImYYCpv\n vs1eLow+lxm6EbEipJPRT6LCVBFxRAo=", "X-MC-Unique": "FnCv0qhAMbqPYgWbIvTNAw-1", "X-Mimecast-MFC-AGG-ID": "FnCv0qhAMbqPYgWbIvTNAw_1771240744", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Mon, 16 Feb 2026 12:16:02 +0100", "Subject": "[PATCH 73/85] audio: replace int endianness with bool big_endian\n in audsettings", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260216-audio-v1-73-e676662e4514@redhat.com>", "References": "<20260216-audio-v1-0-e676662e4514@redhat.com>", "In-Reply-To": "<20260216-audio-v1-0-e676662e4514@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Gerd Hoffmann <kraxel@redhat.com>, Eduardo Habkost <eduardo@habkost.net>,\n Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>,\n Christian Schoenebeck <qemu_oss@crudebyte.com>,\n Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>,\n Thomas Huth <huth@tuxfamily.org>, Alexandre Ratchov <alex@caoua.org>,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Laurent Vivier <laurent@vivier.eu>, \"Michael S. Tsirkin\" <mst@redhat.com>,\n Manos Pitsidianakis <manos.pitsidianakis@linaro.org>,\n Alistair Francis <alistair@alistair23.me>,\n \"Edgar E. Iglesias\" <edgar.iglesias@gmail.com>,\n Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Thomas Huth <thuth@redhat.com>,\n Mark Cave-Ayland <mark.caveayland@nutanix.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=29670;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=eda24egNwmutPTFgtvu5N2Y467+Bchz6V0rlBRhfQmU=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvxRxOp/Os2G5es71qM5vaek21/WveE1JjUgk\n pTtW8AeE/+JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL8UQAKCRDa6OEJdZac\n 5eJaEACh6y3rwtNX1/L2zrdmmA7/dSdA0+ianT4FujGUPOt54aWWH2FmgbrSM5CuKcMQez62CVA\n DkIZFjXmOSpD0u95pXAVCHKBBcjprJ3gXqzLZEqdn1s2qrc4zjAKQ5hbRlM2F2Akewm7e+WVJ6j\n GgJaGWppVDFFZOb0fvQDNGv0Euc/fFD2EUqymzyOan6PXjaoQxTMrLMgOzfeCZydWeeC0H/7M3g\n xoXvFqB3nti58sDRHnAdIv82BTBgJO5C/Bsj3Ym0KjbnY67YCwhaLPC0I3WaqSf3BwTSSQyvO6F\n My3os6WAGyNegWC/nfg+dIgU6Rw6qHFptMRF9zjFzD0rSpu+5EpAM4/87To8ohjx3pjBVdD+4Dw\n ol5PXP1XGlx69t7aUnf8h7R+jYXEf552bh1E/q+X49MFjvv1KqN3KEhWT15ft3ZzlfEQzOTvG+c\n 6n0SMNv0lnrLUnRBjZr2lFKb9eUWsVIZCFwAOrQM/EndYfJ8dUuNMsklhJzEsy+d3MgXC50sUIM\n VwJUBhzayQFsT70+nWWYVbDf8tCep40NzsJKer5Cu/ej0A440yJ6bzovw6kJ03HsUhw29XNBgbc\n yO0RStYYKFUHCRZ1c9z6yMsQVD8Xi4fXlC2n4ZEJXXrKUPd5X034BxGi/+fvQOzjzy561dp5sQy\n wg3T33ZouM2WZuA==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.12", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "The endianness field used an int to represent a boolean concept, with\n0 meaning little-endian and 1 meaning big-endian. This required runtime\nvalidation to reject invalid values and made the code less readable.\n\nReplace with a bool big_endian field that is self-documenting and\ntype-safe. The compiler now enforces valid values, eliminating the\nneed for the validation check in audio_validate_settings().\n\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\nReviewed-by: Thomas Huth <thuth@redhat.com>\nReviewed-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>\n---\n audio/dsound_template.h | 2 +-\n include/qemu/audio.h | 2 +-\n audio/alsaaudio.c | 8 ++++----\n audio/audio-mixeng-be.c | 21 ++++-----------------\n audio/jackaudio.c | 4 ++--\n audio/ossaudio.c | 22 +++++++++++-----------\n audio/paaudio.c | 22 +++++++++++-----------\n audio/pwaudio.c | 30 +++++++++++++++---------------\n audio/sdlaudio.c | 26 +++++++++++++-------------\n audio/sndioaudio.c | 2 +-\n audio/spiceaudio.c | 4 ++--\n audio/wavaudio.c | 2 +-\n audio/wavcapture.c | 2 +-\n hw/audio/ac97.c | 2 +-\n hw/audio/adlib.c | 2 +-\n hw/audio/asc.c | 2 +-\n hw/audio/cs4231a.c | 6 +++---\n hw/audio/es1370.c | 2 +-\n hw/audio/gus.c | 2 +-\n hw/audio/lm4549.c | 6 +++---\n hw/audio/sb16.c | 8 ++++----\n hw/audio/via-ac97.c | 2 +-\n hw/audio/virtio-snd.c | 2 +-\n hw/audio/wm8750.c | 4 ++--\n hw/display/xlnx_dp.c | 2 +-\n hw/usb/dev-audio.c | 2 +-\n tests/audio/test-audio.c | 2 +-\n ui/vnc.c | 2 +-\n 28 files changed, 90 insertions(+), 103 deletions(-)", "diff": "diff --git a/audio/dsound_template.h b/audio/dsound_template.h\nindex af4019bcb34..f9761120875 100644\n--- a/audio/dsound_template.h\n+++ b/audio/dsound_template.h\n@@ -244,7 +244,7 @@ static int dsound_init_out(HWVoiceOut *hw, struct audsettings *as)\n }\n \n ds->first_time = true;\n- obt_as.endianness = 0;\n+ obt_as.big_endian = false;\n audio_pcm_init_info (&hw->info, &obt_as);\n \n if (bc.dwBufferBytes % hw->info.bytes_per_frame) {\ndiff --git a/include/qemu/audio.h b/include/qemu/audio.h\nindex 9e4566d60aa..cff8a334f36 100644\n--- a/include/qemu/audio.h\n+++ b/include/qemu/audio.h\n@@ -38,7 +38,7 @@ typedef struct audsettings {\n int freq;\n int nchannels;\n AudioFormat fmt;\n- int endianness;\n+ bool big_endian;\n } audsettings;\n \n typedef struct SWVoiceOut SWVoiceOut;\ndiff --git a/audio/alsaaudio.c b/audio/alsaaudio.c\nindex 889240ad0c7..e2290ea814a 100644\n--- a/audio/alsaaudio.c\n+++ b/audio/alsaaudio.c\n@@ -666,7 +666,7 @@ static int alsa_init_out(HWVoiceOut *hw, struct audsettings *as)\n struct audsettings obt_as;\n Audiodev *dev = hw->s->dev;\n \n- req.fmt = aud_to_alsafmt (as->fmt, as->endianness);\n+ req.fmt = aud_to_alsafmt (as->fmt, as->big_endian);\n req.freq = as->freq;\n req.nchannels = as->nchannels;\n \n@@ -677,7 +677,7 @@ static int alsa_init_out(HWVoiceOut *hw, struct audsettings *as)\n obt_as.freq = obt.freq;\n obt_as.nchannels = obt.nchannels;\n obt_as.fmt = obt.fmt;\n- obt_as.endianness = obt.endianness;\n+ obt_as.big_endian = obt.endianness;\n \n audio_pcm_init_info (&hw->info, &obt_as);\n hw->samples = obt.samples;\n@@ -752,7 +752,7 @@ static int alsa_init_in(HWVoiceIn *hw, struct audsettings *as)\n struct audsettings obt_as;\n Audiodev *dev = hw->s->dev;\n \n- req.fmt = aud_to_alsafmt (as->fmt, as->endianness);\n+ req.fmt = aud_to_alsafmt (as->fmt, as->big_endian);\n req.freq = as->freq;\n req.nchannels = as->nchannels;\n \n@@ -763,7 +763,7 @@ static int alsa_init_in(HWVoiceIn *hw, struct audsettings *as)\n obt_as.freq = obt.freq;\n obt_as.nchannels = obt.nchannels;\n obt_as.fmt = obt.fmt;\n- obt_as.endianness = obt.endianness;\n+ obt_as.big_endian = obt.endianness;\n \n audio_pcm_init_info (&hw->info, &obt_as);\n hw->samples = obt.samples;\ndiff --git a/audio/audio-mixeng-be.c b/audio/audio-mixeng-be.c\nindex 931d5b206f2..d05202aabae 100644\n--- a/audio/audio-mixeng-be.c\n+++ b/audio/audio-mixeng-be.c\n@@ -135,19 +135,7 @@ static void audio_print_settings (const struct audsettings *as)\n break;\n }\n \n- AUD_log (NULL, \" endianness=\");\n- switch (as->endianness) {\n- case 0:\n- AUD_log (NULL, \"little\");\n- break;\n- case 1:\n- AUD_log (NULL, \"big\");\n- break;\n- default:\n- AUD_log (NULL, \"invalid\");\n- break;\n- }\n- AUD_log (NULL, \"\\n\");\n+ AUD_log (NULL, \" endianness=%s\\n\", as->big_endian ? \"big\" : \"little\");\n }\n \n static int audio_validate_settings (const struct audsettings *as)\n@@ -155,7 +143,6 @@ static int audio_validate_settings (const struct audsettings *as)\n int invalid;\n \n invalid = as->nchannels < 1;\n- invalid |= as->endianness != 0 && as->endianness != 1;\n \n switch (as->fmt) {\n case AUDIO_FORMAT_S8:\n@@ -180,7 +167,7 @@ static int audio_pcm_info_eq (struct audio_pcm_info *info, const struct audsetti\n return info->af == as->fmt\n && info->freq == as->freq\n && info->nchannels == as->nchannels\n- && info->swap_endianness == (as->endianness != HOST_BIG_ENDIAN);\n+ && info->swap_endianness == (as->big_endian != HOST_BIG_ENDIAN);\n }\n \n void audio_pcm_init_info (struct audio_pcm_info *info, const struct audsettings *as)\n@@ -190,7 +177,7 @@ void audio_pcm_init_info (struct audio_pcm_info *info, const struct audsettings\n info->nchannels = as->nchannels;\n info->bytes_per_frame = as->nchannels * audio_format_bits(as->fmt) / 8;\n info->bytes_per_second = info->freq * info->bytes_per_frame;\n- info->swap_endianness = (as->endianness != HOST_BIG_ENDIAN);\n+ info->swap_endianness = (as->big_endian != HOST_BIG_ENDIAN);\n }\n \n void audio_pcm_info_clear_buf(struct audio_pcm_info *info, void *buf, int len)\n@@ -1797,7 +1784,7 @@ audsettings audiodev_to_audsettings(AudiodevPerDirectionOptions *pdo)\n .freq = pdo->frequency,\n .nchannels = pdo->channels,\n .fmt = pdo->format,\n- .endianness = HOST_BIG_ENDIAN,\n+ .big_endian = HOST_BIG_ENDIAN,\n };\n }\n \ndiff --git a/audio/jackaudio.c b/audio/jackaudio.c\nindex a2f725a3232..d9ae8edc0e0 100644\n--- a/audio/jackaudio.c\n+++ b/audio/jackaudio.c\n@@ -531,7 +531,7 @@ static int qjack_init_out(HWVoiceOut *hw, struct audsettings *as)\n .freq = jo->c.freq,\n .nchannels = jo->c.nchannels,\n .fmt = AUDIO_FORMAT_F32,\n- .endianness = 0\n+ .big_endian = false\n };\n audio_pcm_init_info(&hw->info, &os);\n \n@@ -566,7 +566,7 @@ static int qjack_init_in(HWVoiceIn *hw, struct audsettings *as)\n .freq = ji->c.freq,\n .nchannels = ji->c.nchannels,\n .fmt = AUDIO_FORMAT_F32,\n- .endianness = 0\n+ .big_endian = false\n };\n audio_pcm_init_info(&hw->info, &is);\n \ndiff --git a/audio/ossaudio.c b/audio/ossaudio.c\nindex 81f49f9a7e7..157979e84b4 100644\n--- a/audio/ossaudio.c\n+++ b/audio/ossaudio.c\n@@ -160,36 +160,36 @@ static int aud_to_ossfmt(AudioFormat fmt, bool big_endian)\n }\n }\n \n-static int oss_to_audfmt (int ossfmt, AudioFormat *fmt, int *endianness)\n+static int oss_to_audfmt (int ossfmt, AudioFormat *fmt, bool *big_endian)\n {\n switch (ossfmt) {\n case AFMT_S8:\n- *endianness = 0;\n+ *big_endian = false;\n *fmt = AUDIO_FORMAT_S8;\n break;\n \n case AFMT_U8:\n- *endianness = 0;\n+ *big_endian = false;\n *fmt = AUDIO_FORMAT_U8;\n break;\n \n case AFMT_S16_LE:\n- *endianness = 0;\n+ *big_endian = false;\n *fmt = AUDIO_FORMAT_S16;\n break;\n \n case AFMT_U16_LE:\n- *endianness = 0;\n+ *big_endian = false;\n *fmt = AUDIO_FORMAT_U16;\n break;\n \n case AFMT_S16_BE:\n- *endianness = 1;\n+ *big_endian = true;\n *fmt = AUDIO_FORMAT_S16;\n break;\n \n case AFMT_U16_BE:\n- *endianness = 1;\n+ *big_endian = true;\n *fmt = AUDIO_FORMAT_U16;\n break;\n \n@@ -475,7 +475,7 @@ static int oss_init_out(HWVoiceOut *hw, struct audsettings *as)\n \n oss->fd = -1;\n \n- req.fmt = aud_to_ossfmt (as->fmt, as->endianness);\n+ req.fmt = aud_to_ossfmt (as->fmt, as->big_endian);\n req.freq = as->freq;\n req.nchannels = as->nchannels;\n \n@@ -483,7 +483,7 @@ static int oss_init_out(HWVoiceOut *hw, struct audsettings *as)\n return -1;\n }\n \n- err = oss_to_audfmt(obt.fmt, &obt_as.fmt, &obt_as.endianness);\n+ err = oss_to_audfmt(obt.fmt, &obt_as.fmt, &obt_as.big_endian);\n if (err) {\n oss_anal_close (&fd);\n return -1;\n@@ -601,14 +601,14 @@ static int oss_init_in(HWVoiceIn *hw, struct audsettings *as)\n \n oss->fd = -1;\n \n- req.fmt = aud_to_ossfmt (as->fmt, as->endianness);\n+ req.fmt = aud_to_ossfmt (as->fmt, as->big_endian);\n req.freq = as->freq;\n req.nchannels = as->nchannels;\n if (oss_open(1, &req, as, &obt, &fd, dev)) {\n return -1;\n }\n \n- err = oss_to_audfmt(obt.fmt, &obt_as.fmt, &obt_as.endianness);\n+ err = oss_to_audfmt(obt.fmt, &obt_as.fmt, &obt_as.big_endian);\n if (err) {\n oss_anal_close (&fd);\n return -1;\ndiff --git a/audio/paaudio.c b/audio/paaudio.c\nindex 1501b26386a..c9957105543 100644\n--- a/audio/paaudio.c\n+++ b/audio/paaudio.c\n@@ -352,28 +352,28 @@ static pa_sample_format_t audfmt_to_pa(AudioFormat afmt, bool big_endian)\n return format;\n }\n \n-static AudioFormat pa_to_audfmt (pa_sample_format_t fmt, int *endianness)\n+static AudioFormat pa_to_audfmt (pa_sample_format_t fmt, bool *big_endian)\n {\n switch (fmt) {\n case PA_SAMPLE_U8:\n return AUDIO_FORMAT_U8;\n case PA_SAMPLE_S16BE:\n- *endianness = 1;\n+ *big_endian = true;\n return AUDIO_FORMAT_S16;\n case PA_SAMPLE_S16LE:\n- *endianness = 0;\n+ *big_endian = false;\n return AUDIO_FORMAT_S16;\n case PA_SAMPLE_S32BE:\n- *endianness = 1;\n+ *big_endian = true;\n return AUDIO_FORMAT_S32;\n case PA_SAMPLE_S32LE:\n- *endianness = 0;\n+ *big_endian = false;\n return AUDIO_FORMAT_S32;\n case PA_SAMPLE_FLOAT32BE:\n- *endianness = 1;\n+ *big_endian = true;\n return AUDIO_FORMAT_F32;\n case PA_SAMPLE_FLOAT32LE:\n- *endianness = 0;\n+ *big_endian = false;\n return AUDIO_FORMAT_F32;\n default:\n error_report(\"pulseaudio: Internal logic error: Bad pa_sample_format %d\", fmt);\n@@ -531,7 +531,7 @@ static int qpa_init_out(HWVoiceOut *hw, struct audsettings *as)\n PAConnection *c = apa->conn;\n \n pa->g = apa;\n- ss.format = audfmt_to_pa (as->fmt, as->endianness);\n+ ss.format = audfmt_to_pa (as->fmt, as->big_endian);\n ss.channels = as->nchannels;\n ss.rate = as->freq;\n \n@@ -541,7 +541,7 @@ static int qpa_init_out(HWVoiceOut *hw, struct audsettings *as)\n ba.maxlength = -1;\n ba.prebuf = -1;\n \n- obt_as.fmt = pa_to_audfmt (ss.format, &obt_as.endianness);\n+ obt_as.fmt = pa_to_audfmt (ss.format, &obt_as.big_endian);\n \n pa->stream = qpa_simple_new (\n c,\n@@ -582,7 +582,7 @@ static int qpa_init_in(HWVoiceIn *hw, struct audsettings *as)\n PAConnection *c = apa->conn;\n \n pa->g = apa;\n- ss.format = audfmt_to_pa (as->fmt, as->endianness);\n+ ss.format = audfmt_to_pa (as->fmt, as->big_endian);\n ss.channels = as->nchannels;\n ss.rate = as->freq;\n \n@@ -592,7 +592,7 @@ static int qpa_init_in(HWVoiceIn *hw, struct audsettings *as)\n ba.minreq = -1;\n ba.prebuf = -1;\n \n- obt_as.fmt = pa_to_audfmt (ss.format, &obt_as.endianness);\n+ obt_as.fmt = pa_to_audfmt (ss.format, &obt_as.big_endian);\n \n pa->stream = qpa_simple_new (\n c,\ndiff --git a/audio/pwaudio.c b/audio/pwaudio.c\nindex 6a80e5a333e..b70bf0c1353 100644\n--- a/audio/pwaudio.c\n+++ b/audio/pwaudio.c\n@@ -365,7 +365,7 @@ audfmt_to_pw(AudioFormat fmt, bool big_endian)\n }\n \n static AudioFormat\n-pw_to_audfmt(enum spa_audio_format fmt, int *endianness,\n+pw_to_audfmt(enum spa_audio_format fmt, bool *big_endian,\n uint32_t *sample_size)\n {\n switch (fmt) {\n@@ -377,43 +377,43 @@ pw_to_audfmt(enum spa_audio_format fmt, int *endianness,\n return AUDIO_FORMAT_U8;\n case SPA_AUDIO_FORMAT_S16_BE:\n *sample_size = 2;\n- *endianness = 1;\n+ *big_endian = true;\n return AUDIO_FORMAT_S16;\n case SPA_AUDIO_FORMAT_S16_LE:\n *sample_size = 2;\n- *endianness = 0;\n+ *big_endian = false;\n return AUDIO_FORMAT_S16;\n case SPA_AUDIO_FORMAT_U16_BE:\n *sample_size = 2;\n- *endianness = 1;\n+ *big_endian = true;\n return AUDIO_FORMAT_U16;\n case SPA_AUDIO_FORMAT_U16_LE:\n *sample_size = 2;\n- *endianness = 0;\n+ *big_endian = false;\n return AUDIO_FORMAT_U16;\n case SPA_AUDIO_FORMAT_S32_BE:\n *sample_size = 4;\n- *endianness = 1;\n+ *big_endian = true;\n return AUDIO_FORMAT_S32;\n case SPA_AUDIO_FORMAT_S32_LE:\n *sample_size = 4;\n- *endianness = 0;\n+ *big_endian = false;\n return AUDIO_FORMAT_S32;\n case SPA_AUDIO_FORMAT_U32_BE:\n *sample_size = 4;\n- *endianness = 1;\n+ *big_endian = true;\n return AUDIO_FORMAT_U32;\n case SPA_AUDIO_FORMAT_U32_LE:\n *sample_size = 4;\n- *endianness = 0;\n+ *big_endian = false;\n return AUDIO_FORMAT_U32;\n case SPA_AUDIO_FORMAT_F32_BE:\n *sample_size = 4;\n- *endianness = 1;\n+ *big_endian = true;\n return AUDIO_FORMAT_F32;\n case SPA_AUDIO_FORMAT_F32_LE:\n *sample_size = 4;\n- *endianness = 0;\n+ *big_endian = false;\n return AUDIO_FORMAT_F32;\n default:\n *sample_size = 1;\n@@ -534,13 +534,13 @@ qpw_init_out(HWVoiceOut *hw, struct audsettings *as)\n \n pw_thread_loop_lock(c->thread_loop);\n \n- v->info.format = audfmt_to_pw(as->fmt, as->endianness);\n+ v->info.format = audfmt_to_pw(as->fmt, as->big_endian);\n v->info.channels = as->nchannels;\n qpw_set_position(as->nchannels, v->info.position);\n v->info.rate = as->freq;\n \n obt_as.fmt =\n- pw_to_audfmt(v->info.format, &obt_as.endianness, &v->frame_size);\n+ pw_to_audfmt(v->info.format, &obt_as.big_endian, &v->frame_size);\n v->frame_size *= as->nchannels;\n \n v->req = (uint64_t)AUDIO_MIXENG_BACKEND(c)->dev->timer_period * v->info.rate\n@@ -581,13 +581,13 @@ qpw_init_in(HWVoiceIn *hw, struct audsettings *as)\n \n pw_thread_loop_lock(c->thread_loop);\n \n- v->info.format = audfmt_to_pw(as->fmt, as->endianness);\n+ v->info.format = audfmt_to_pw(as->fmt, as->big_endian);\n v->info.channels = as->nchannels;\n qpw_set_position(as->nchannels, v->info.position);\n v->info.rate = as->freq;\n \n obt_as.fmt =\n- pw_to_audfmt(v->info.format, &obt_as.endianness, &v->frame_size);\n+ pw_to_audfmt(v->info.format, &obt_as.big_endian, &v->frame_size);\n v->frame_size *= as->nchannels;\n \n /* call the function that creates a new stream for recording */\ndiff --git a/audio/sdlaudio.c b/audio/sdlaudio.c\nindex 5f332678209..936a3ed076d 100644\n--- a/audio/sdlaudio.c\n+++ b/audio/sdlaudio.c\n@@ -96,56 +96,56 @@ static int aud_to_sdlfmt (AudioFormat fmt)\n }\n }\n \n-static int sdl_to_audfmt(int sdlfmt, AudioFormat *fmt, int *endianness)\n+static int sdl_to_audfmt(int sdlfmt, AudioFormat *fmt, bool *big_endian)\n {\n switch (sdlfmt) {\n case AUDIO_S8:\n- *endianness = 0;\n+ *big_endian = false;\n *fmt = AUDIO_FORMAT_S8;\n break;\n \n case AUDIO_U8:\n- *endianness = 0;\n+ *big_endian = false;\n *fmt = AUDIO_FORMAT_U8;\n break;\n \n case AUDIO_S16LSB:\n- *endianness = 0;\n+ *big_endian = false;\n *fmt = AUDIO_FORMAT_S16;\n break;\n \n case AUDIO_U16LSB:\n- *endianness = 0;\n+ *big_endian = false;\n *fmt = AUDIO_FORMAT_U16;\n break;\n \n case AUDIO_S16MSB:\n- *endianness = 1;\n+ *big_endian = true;\n *fmt = AUDIO_FORMAT_S16;\n break;\n \n case AUDIO_U16MSB:\n- *endianness = 1;\n+ *big_endian = true;\n *fmt = AUDIO_FORMAT_U16;\n break;\n \n case AUDIO_S32LSB:\n- *endianness = 0;\n+ *big_endian = false;\n *fmt = AUDIO_FORMAT_S32;\n break;\n \n case AUDIO_S32MSB:\n- *endianness = 1;\n+ *big_endian = true;\n *fmt = AUDIO_FORMAT_S32;\n break;\n \n case AUDIO_F32LSB:\n- *endianness = 0;\n+ *big_endian = false;\n *fmt = AUDIO_FORMAT_F32;\n break;\n \n case AUDIO_F32MSB:\n- *endianness = 1;\n+ *big_endian = true;\n *fmt = AUDIO_FORMAT_F32;\n break;\n \n@@ -350,7 +350,7 @@ static int sdl_init_out(HWVoiceOut *hw, struct audsettings *as)\n return -1;\n }\n \n- err = sdl_to_audfmt(obt.format, &obt_as.fmt, &obt_as.endianness);\n+ err = sdl_to_audfmt(obt.format, &obt_as.fmt, &obt_as.big_endian);\n if (err) {\n sdl_close_out(sdl);\n return -1;\n@@ -406,7 +406,7 @@ static int sdl_init_in(HWVoiceIn *hw, audsettings *as)\n return -1;\n }\n \n- err = sdl_to_audfmt(obt.format, &obt_as.fmt, &obt_as.endianness);\n+ err = sdl_to_audfmt(obt.format, &obt_as.fmt, &obt_as.big_endian);\n if (err) {\n sdl_close_in(sdl);\n return -1;\ndiff --git a/audio/sndioaudio.c b/audio/sndioaudio.c\nindex 766eceeeefe..761f23f8273 100644\n--- a/audio/sndioaudio.c\n+++ b/audio/sndioaudio.c\n@@ -387,7 +387,7 @@ static int sndio_init(SndioVoice *self,\n }\n \n if (req.bits > 8) {\n- req.le = as->endianness ? 0 : 1;\n+ req.le = !as->big_endian;\n }\n \n req.rate = as->freq;\ndiff --git a/audio/spiceaudio.c b/audio/spiceaudio.c\nindex 81b897e13e0..f903ef77e72 100644\n--- a/audio/spiceaudio.c\n+++ b/audio/spiceaudio.c\n@@ -106,7 +106,7 @@ static int line_out_init(HWVoiceOut *hw, struct audsettings *as)\n #endif\n settings.nchannels = SPICE_INTERFACE_PLAYBACK_CHAN;\n settings.fmt = AUDIO_FORMAT_S16;\n- settings.endianness = HOST_BIG_ENDIAN;\n+ settings.big_endian = HOST_BIG_ENDIAN;\n \n audio_pcm_init_info (&hw->info, &settings);\n hw->samples = LINE_OUT_SAMPLES;\n@@ -222,7 +222,7 @@ static int line_in_init(HWVoiceIn *hw, struct audsettings *as)\n #endif\n settings.nchannels = SPICE_INTERFACE_RECORD_CHAN;\n settings.fmt = AUDIO_FORMAT_S16;\n- settings.endianness = HOST_BIG_ENDIAN;\n+ settings.big_endian = HOST_BIG_ENDIAN;\n \n audio_pcm_init_info (&hw->info, &settings);\n hw->samples = LINE_IN_SAMPLES;\ndiff --git a/audio/wavaudio.c b/audio/wavaudio.c\nindex eed1e501af0..55d12d6cdfd 100644\n--- a/audio/wavaudio.c\n+++ b/audio/wavaudio.c\n@@ -111,7 +111,7 @@ static int wav_init_out(HWVoiceOut *hw, struct audsettings *as)\n \n hdr[34] = bits16 ? 0x10 : 0x08;\n \n- wav_as.endianness = 0;\n+ wav_as.big_endian = false;\n audio_pcm_init_info (&hw->info, &wav_as);\n \n hw->samples = 1024;\ndiff --git a/audio/wavcapture.c b/audio/wavcapture.c\nindex 69aa91e35f6..2dac9461710 100644\n--- a/audio/wavcapture.c\n+++ b/audio/wavcapture.c\n@@ -137,7 +137,7 @@ int wav_start_capture(AudioBackend *state, CaptureState *s, const char *path,\n as.freq = freq;\n as.nchannels = 1 << stereo;\n as.fmt = bits16 ? AUDIO_FORMAT_S16 : AUDIO_FORMAT_U8;\n- as.endianness = 0;\n+ as.big_endian = false;\n \n ops.notify = wav_notify;\n ops.capture = wav_capture;\ndiff --git a/hw/audio/ac97.c b/hw/audio/ac97.c\nindex 5d442b7e067..fd74c249949 100644\n--- a/hw/audio/ac97.c\n+++ b/hw/audio/ac97.c\n@@ -313,7 +313,7 @@ static void open_voice(AC97LinkState *s, int index, int freq)\n as.freq = freq;\n as.nchannels = 2;\n as.fmt = AUDIO_FORMAT_S16;\n- as.endianness = 0;\n+ as.big_endian = false;\n \n if (freq > 0) {\n s->invalid_freq[index] = 0;\ndiff --git a/hw/audio/adlib.c b/hw/audio/adlib.c\nindex ce17e21d5fd..52ee5cb6256 100644\n--- a/hw/audio/adlib.c\n+++ b/hw/audio/adlib.c\n@@ -254,7 +254,7 @@ static void adlib_realizefn (DeviceState *dev, Error **errp)\n as.freq = s->freq;\n as.nchannels = SHIFT;\n as.fmt = AUDIO_FORMAT_S16;\n- as.endianness = HOST_BIG_ENDIAN;\n+ as.big_endian = HOST_BIG_ENDIAN;\n \n s->voice = audio_be_open_out(\n s->audio_be,\ndiff --git a/hw/audio/asc.c b/hw/audio/asc.c\nindex 35c7b5750d6..ea59bdde7b8 100644\n--- a/hw/audio/asc.c\n+++ b/hw/audio/asc.c\n@@ -648,7 +648,7 @@ static void asc_realize(DeviceState *dev, Error **errp)\n as.freq = ASC_FREQ;\n as.nchannels = 2;\n as.fmt = AUDIO_FORMAT_U8;\n- as.endianness = HOST_BIG_ENDIAN;\n+ as.big_endian = HOST_BIG_ENDIAN;\n \n s->voice = audio_be_open_out(s->audio_be, s->voice, \"asc.out\", s, asc_out_cb,\n &as);\ndiff --git a/hw/audio/cs4231a.c b/hw/audio/cs4231a.c\nindex e6cae9c988e..c589670e855 100644\n--- a/hw/audio/cs4231a.c\n+++ b/hw/audio/cs4231a.c\n@@ -289,7 +289,7 @@ static void cs_reset_voices (CSState *s, uint32_t val)\n }\n \n as.nchannels = (val & (1 << 4)) ? 2 : 1;\n- as.endianness = 0;\n+ as.big_endian = false;\n s->tab = NULL;\n \n switch ((val >> 5) & ((s->dregs[MODE_And_ID] & MODE2) ? 7 : 3)) {\n@@ -305,12 +305,12 @@ static void cs_reset_voices (CSState *s, uint32_t val)\n s->tab = ALawDecompressTable;\n x_law:\n as.fmt = AUDIO_FORMAT_S16;\n- as.endianness = HOST_BIG_ENDIAN;\n+ as.big_endian = HOST_BIG_ENDIAN;\n s->shift = as.nchannels == 2;\n break;\n \n case 6:\n- as.endianness = 1;\n+ as.big_endian = true;\n /* fall through */\n case 2:\n as.fmt = AUDIO_FORMAT_S16;\ndiff --git a/hw/audio/es1370.c b/hw/audio/es1370.c\nindex e1658393c6a..ca7ad16df49 100644\n--- a/hw/audio/es1370.c\n+++ b/hw/audio/es1370.c\n@@ -407,7 +407,7 @@ static void es1370_update_voices (ES1370State *s, uint32_t ctl, uint32_t sctl)\n as.freq = new_freq;\n as.nchannels = 1 << (new_fmt & 1);\n as.fmt = (new_fmt & 2) ? AUDIO_FORMAT_S16 : AUDIO_FORMAT_U8;\n- as.endianness = 0;\n+ as.big_endian = false;\n \n if (i == ADC_CHANNEL) {\n s->adc_voice =\ndiff --git a/hw/audio/gus.c b/hw/audio/gus.c\nindex 5c2a34c09d2..196c4f72205 100644\n--- a/hw/audio/gus.c\n+++ b/hw/audio/gus.c\n@@ -256,7 +256,7 @@ static void gus_realizefn (DeviceState *dev, Error **errp)\n as.freq = s->freq;\n as.nchannels = 2;\n as.fmt = AUDIO_FORMAT_S16;\n- as.endianness = HOST_BIG_ENDIAN;\n+ as.big_endian = HOST_BIG_ENDIAN;\n \n s->voice = audio_be_open_out(\n s->audio_be,\ndiff --git a/hw/audio/lm4549.c b/hw/audio/lm4549.c\nindex 14e15a844ba..a891e975106 100644\n--- a/hw/audio/lm4549.c\n+++ b/hw/audio/lm4549.c\n@@ -202,7 +202,7 @@ void lm4549_write(lm4549_state *s,\n as.freq = value;\n as.nchannels = 2;\n as.fmt = AUDIO_FORMAT_S16;\n- as.endianness = 0;\n+ as.big_endian = false;\n \n s->voice = audio_be_open_out(\n s->audio_be,\n@@ -272,7 +272,7 @@ static int lm4549_post_load(void *opaque, int version_id)\n as.freq = freq;\n as.nchannels = 2;\n as.fmt = AUDIO_FORMAT_S16;\n- as.endianness = 0;\n+ as.big_endian = false;\n \n s->voice = audio_be_open_out(\n s->audio_be,\n@@ -312,7 +312,7 @@ void lm4549_init(lm4549_state *s, lm4549_callback data_req_cb, void* opaque,\n as.freq = 48000;\n as.nchannels = 2;\n as.fmt = AUDIO_FORMAT_S16;\n- as.endianness = 0;\n+ as.big_endian = false;\n \n s->voice = audio_be_open_out(\n s->audio_be,\ndiff --git a/hw/audio/sb16.c b/hw/audio/sb16.c\nindex c8fc7df8b44..1b5e452a29b 100644\n--- a/hw/audio/sb16.c\n+++ b/hw/audio/sb16.c\n@@ -213,7 +213,7 @@ static void continue_dma8 (SB16State *s)\n as.freq = s->freq;\n as.nchannels = 1 << s->fmt_stereo;\n as.fmt = s->fmt;\n- as.endianness = 0;\n+ as.big_endian = false;\n \n s->voice = audio_be_open_out(\n s->audio_be,\n@@ -376,7 +376,7 @@ static void dma_cmd (SB16State *s, uint8_t cmd, uint8_t d0, int dma_len)\n as.freq = s->freq;\n as.nchannels = 1 << s->fmt_stereo;\n as.fmt = s->fmt;\n- as.endianness = 0;\n+ as.big_endian = false;\n \n s->voice = audio_be_open_out(\n s->audio_be,\n@@ -877,7 +877,7 @@ static void legacy_reset (SB16State *s)\n as.freq = s->freq;\n as.nchannels = 1;\n as.fmt = AUDIO_FORMAT_U8;\n- as.endianness = 0;\n+ as.big_endian = false;\n \n s->voice = audio_be_open_out(\n s->audio_be,\n@@ -1300,7 +1300,7 @@ static int sb16_post_load (void *opaque, int version_id)\n as.freq = s->freq;\n as.nchannels = 1 << s->fmt_stereo;\n as.fmt = s->fmt;\n- as.endianness = 0;\n+ as.big_endian = false;\n \n s->voice = audio_be_open_out(\n s->audio_be,\ndiff --git a/hw/audio/via-ac97.c b/hw/audio/via-ac97.c\nindex 84d137b41a3..9d61283542a 100644\n--- a/hw/audio/via-ac97.c\n+++ b/hw/audio/via-ac97.c\n@@ -237,7 +237,7 @@ static void open_voice_out(ViaAC97State *s)\n .freq = CODEC_REG(s, AC97_PCM_Front_DAC_Rate),\n .nchannels = s->aur.type & BIT(4) ? 2 : 1,\n .fmt = s->aur.type & BIT(5) ? AUDIO_FORMAT_S16 : AUDIO_FORMAT_S8,\n- .endianness = 0,\n+ .big_endian = false,\n };\n s->vo = audio_be_open_out(s->audio_be, s->vo, \"via-ac97.out\", s, out_cb, &as);\n }\ndiff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c\nindex 89e24c0a8e0..8b949146468 100644\n--- a/hw/audio/virtio-snd.c\n+++ b/hw/audio/virtio-snd.c\n@@ -378,7 +378,7 @@ static void virtio_snd_get_qemu_audsettings(audsettings *as,\n as->nchannels = MIN(AUDIO_MAX_CHANNELS, params->channels);\n as->fmt = virtio_snd_get_qemu_format(params->format);\n as->freq = virtio_snd_get_qemu_freq(params->rate);\n- as->endianness = 0; /* Conforming to VIRTIO 1.0: always little endian. */\n+ as->big_endian = false; /* Conforming to VIRTIO 1.0: always little endian. */\n }\n \n /*\ndiff --git a/hw/audio/wm8750.c b/hw/audio/wm8750.c\nindex 2a286515b14..e2507b0269a 100644\n--- a/hw/audio/wm8750.c\n+++ b/hw/audio/wm8750.c\n@@ -202,7 +202,7 @@ static void wm8750_set_format(WM8750State *s)\n return;\n \n /* Setup input */\n- in_fmt.endianness = 0;\n+ in_fmt.big_endian = false;\n in_fmt.nchannels = 2;\n in_fmt.freq = s->adc_hz;\n in_fmt.fmt = AUDIO_FORMAT_S16;\n@@ -215,7 +215,7 @@ static void wm8750_set_format(WM8750State *s)\n CODEC \".input3\", s, wm8750_audio_in_cb, &in_fmt);\n \n /* Setup output */\n- out_fmt.endianness = 0;\n+ out_fmt.big_endian = false;\n out_fmt.nchannels = 2;\n out_fmt.freq = s->dac_hz;\n out_fmt.fmt = AUDIO_FORMAT_S16;\ndiff --git a/hw/display/xlnx_dp.c b/hw/display/xlnx_dp.c\nindex 9aa4709b411..7d037b46a35 100644\n--- a/hw/display/xlnx_dp.c\n+++ b/hw/display/xlnx_dp.c\n@@ -1393,7 +1393,7 @@ static void xlnx_dp_realize(DeviceState *dev, Error **errp)\n as.freq = 44100;\n as.nchannels = 2;\n as.fmt = AUDIO_FORMAT_S16;\n- as.endianness = 0;\n+ as.big_endian = false;\n \n s->amixer_output_stream = audio_be_open_out(s->audio_be,\n s->amixer_output_stream,\ndiff --git a/hw/usb/dev-audio.c b/hw/usb/dev-audio.c\nindex 7b758718c12..e18e0a1dfd6 100644\n--- a/hw/usb/dev-audio.c\n+++ b/hw/usb/dev-audio.c\n@@ -975,7 +975,7 @@ static void usb_audio_reinit(USBDevice *dev, unsigned channels)\n s->out.as.freq = USBAUDIO_SAMPLE_RATE;\n s->out.as.nchannels = s->out.channels;\n s->out.as.fmt = AUDIO_FORMAT_S16;\n- s->out.as.endianness = 0;\n+ s->out.as.big_endian = false;\n streambuf_init(&s->out.buf, s->buffer, s->out.channels);\n \n s->out.voice = audio_be_open_out(s->audio_be, s->out.voice, TYPE_USB_AUDIO,\ndiff --git a/tests/audio/test-audio.c b/tests/audio/test-audio.c\nindex 90d96ae0575..b87a12eb55b 100644\n--- a/tests/audio/test-audio.c\n+++ b/tests/audio/test-audio.c\n@@ -57,7 +57,7 @@ static const struct audsettings default_test_settings = {\n .freq = SAMPLE_RATE,\n .nchannels = CHANNELS,\n .fmt = AUDIO_FORMAT_S16,\n- .endianness = 0,\n+ .big_endian = false,\n };\n \n static void dummy_audio_callback(void *opaque, int avail)\ndiff --git a/ui/vnc.c b/ui/vnc.c\nindex d56fe2c180e..daf5b01d342 100644\n--- a/ui/vnc.c\n+++ b/ui/vnc.c\n@@ -3372,7 +3372,7 @@ static void vnc_connect(VncDisplay *vd, QIOChannelSocket *sioc,\n vs->as.freq = 44100;\n vs->as.nchannels = 2;\n vs->as.fmt = AUDIO_FORMAT_S16;\n- vs->as.endianness = 0;\n+ vs->as.big_endian = false;\n \n qemu_mutex_init(&vs->output_mutex);\n vs->bh = qemu_bh_new(vnc_jobs_bh, vs);\n", "prefixes": [ "73/85" ] }