Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196862/?format=api
{ "id": 2196862, "url": "http://patchwork.ozlabs.org/api/patches/2196862/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-51-e676662e4514@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260216-audio-v1-51-e676662e4514@redhat.com>", "list_archive_url": null, "date": "2026-02-16T11:15:40", "name": "[51/85] audio/jack: convert to QOM lifecycle methods", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "afb8240a0b4be70d0947a01fb9c11c222fb066e4", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-51-e676662e4514@redhat.com/mbox/", "series": [ { "id": 492294, "url": "http://patchwork.ozlabs.org/api/series/492294/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492294", "date": "2026-02-16T11:14:52", "name": "audio: cleanups & add a manual test", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492294/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196862/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196862/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=baETH920;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF0qd4xbkz1xxy\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 16 Feb 2026 22:27:25 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vrweJ-0003GR-Oj; Mon, 16 Feb 2026 06:20:19 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrwcE-0006ak-BL\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:18:13 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrwcC-0008CB-E8\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:18:09 -0500", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-187-Nf_NEw_UMeih7CYbTExd2Q-1; Mon,\n 16 Feb 2026 06:18:02 -0500", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 6ED021800454; Mon, 16 Feb 2026 11:18:00 +0000 (UTC)", "from localhost (unknown [10.45.242.26])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id E54C518003F5; Mon, 16 Feb 2026 11:17:59 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771240687;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=aSw0+nWfREHkM9D3OEgLFV+S+9mgN4B1YEV84KexTb8=;\n b=baETH920E1k/gOmzlN5QH7Nn45biI+VSwzxoKU1Ef7AJX8c9DURqFsBbTb6OnMcTOMXg8i\n mrMF4TDrJ3nx9+bJFIdeIlcnZvDOnaAp0KBUocGWm/aaFrwaYnuG1gFkjl9suwnAxQTW4B\n i7Mi0DP6j99jRdBUMvBjAd2RxoowI0A=", "X-MC-Unique": "Nf_NEw_UMeih7CYbTExd2Q-1", "X-Mimecast-MFC-AGG-ID": "Nf_NEw_UMeih7CYbTExd2Q_1771240680", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Mon, 16 Feb 2026 12:15:40 +0100", "Subject": "[PATCH 51/85] audio/jack: convert to QOM lifecycle methods", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260216-audio-v1-51-e676662e4514@redhat.com>", "References": "<20260216-audio-v1-0-e676662e4514@redhat.com>", "In-Reply-To": "<20260216-audio-v1-0-e676662e4514@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Gerd Hoffmann <kraxel@redhat.com>, Eduardo Habkost <eduardo@habkost.net>,\n Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>,\n Christian Schoenebeck <qemu_oss@crudebyte.com>,\n Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>,\n Thomas Huth <huth@tuxfamily.org>, Alexandre Ratchov <alex@caoua.org>,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Laurent Vivier <laurent@vivier.eu>, \"Michael S. Tsirkin\" <mst@redhat.com>,\n Manos Pitsidianakis <manos.pitsidianakis@linaro.org>,\n Alistair Francis <alistair@alistair23.me>,\n \"Edgar E. Iglesias\" <edgar.iglesias@gmail.com>,\n Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Mark Cave-Ayland <mark.caveayland@nutanix.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=2688;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=t0ucslZSKbGcBRFeyrKr2G8Lh/S+UoRUSUp+0FAVQBY=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvxQ5zrVbVSPL/xI25NQc7n5DQc/dYT/XBYH6\n jGtBjQPRGOJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL8UAAKCRDa6OEJdZac\n 5WzOEACqKsIXAM9F0PkZZn+jgTBQSEewvNiNgfEvoF6pvr4SPmK3rKBkBVcm2Qv1k9uGOjmOyiY\n 4Ql6Xq8Iw8lfcJa9VOz9O254OuuM4rqp9g6ydM+fQlTsv+p4pDMztk5vN+IbQlzgFIz7OKr2OBa\n nTgEpU/ymBj4ynkfbSPuze0f4O8jlPQ2FyPVO/var1rsHGiXl43Wolr0kuYx4DPLgjhobpg20Ug\n ReWFwfEdMEnJ1tmVvPGKYCv4dkLsFNkg5SJLfgmnOig2Gtkq2dgV4iK8bKAshHRK10R0BTmmx2X\n CXf8SgxL6lxpTQjTY5gsYOp1WOgImz9BqlqXqaCmwXY0gjefx1SWZX8e/p5Ys5yM7t6Ml5j1Jp2\n j2aFncipEjiEYzS7qmaneSezzThU7KP6Q0dOk29uYAp+TMV1gJML5j1Xk6OdUUDpluk8ODbJ1s+\n xBwM99P9PbDrjum5voco10gOCYfFLWbTazqO0u7JJsGoSL5uaiJEXQbu+zhQTH7jE7D9AtjQznJ\n nvqdfb3g4V0xAm4Cv2UMwTR8NeZM9fbPwswin8o6iiUagrK75YJzLjEj9iH5HluGZNLtmwDdNXS\n meGyOq9YLD0vTrxGPbmzc+Pa1U0ZprYpo9R5Vs0UW3AtDw7YQrgPHpbMW85mul0z9Y66T7x5GxL\n bQKS5h5MBYY87ow==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Remove the legacy driver init/fini callbacks from the JACK audio backend.\n\nBoth qjack_init() and qjack_fini() were no-ops that performed no real\ninitialization or cleanup work. Access to the Audiodev is now through\nhw->s->dev instead of the drv_opaque pointer.\n\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\nReviewed-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>\n---\n audio/jackaudio.c | 30 +++++++++---------------------\n 1 file changed, 9 insertions(+), 21 deletions(-)", "diff": "diff --git a/audio/jackaudio.c b/audio/jackaudio.c\nindex 972b158f023..31e3da6a7fe 100644\n--- a/audio/jackaudio.c\n+++ b/audio/jackaudio.c\n@@ -44,13 +44,6 @@ struct AudioJack {\n \n static struct audio_driver jack_driver;\n \n-static void audio_jack_class_init(ObjectClass *klass, const void *data)\n-{\n- AudioMixengBackendClass *k = AUDIO_MIXENG_BACKEND_CLASS(klass);\n-\n- k->driver = &jack_driver;\n-}\n-\n struct QJack;\n \n typedef enum QJackState {\n@@ -518,7 +511,7 @@ static int qjack_init_out(HWVoiceOut *hw, struct audsettings *as,\n void *drv_opaque)\n {\n QJackOut *jo = (QJackOut *)hw;\n- Audiodev *dev = (Audiodev *)drv_opaque;\n+ Audiodev *dev = hw->s->dev;\n \n jo->c.out = true;\n jo->c.enabled = false;\n@@ -555,7 +548,7 @@ static int qjack_init_in(HWVoiceIn *hw, struct audsettings *as,\n void *drv_opaque)\n {\n QJackIn *ji = (QJackIn *)hw;\n- Audiodev *dev = (Audiodev *)drv_opaque;\n+ Audiodev *dev = hw->s->dev;\n \n ji->c.out = false;\n ji->c.enabled = false;\n@@ -662,16 +655,6 @@ static int qjack_thread_creator(jack_native_thread_t *thread,\n }\n #endif\n \n-static void *qjack_init(Audiodev *dev, Error **errp)\n-{\n- assert(dev->driver == AUDIODEV_DRIVER_JACK);\n- return dev;\n-}\n-\n-static void qjack_fini(void *opaque)\n-{\n-}\n-\n static struct audio_pcm_ops jack_pcm_ops = {\n .init_out = qjack_init_out,\n .fini_out = qjack_fini_out,\n@@ -689,8 +672,6 @@ static struct audio_pcm_ops jack_pcm_ops = {\n \n static struct audio_driver jack_driver = {\n .name = \"jack\",\n- .init = qjack_init,\n- .fini = qjack_fini,\n .pcm_ops = &jack_pcm_ops,\n .max_voices_out = INT_MAX,\n .max_voices_in = INT_MAX,\n@@ -708,6 +689,13 @@ static void qjack_info(const char *msg)\n dolog(\"I: %s\\n\", msg);\n }\n \n+static void audio_jack_class_init(ObjectClass *klass, const void *data)\n+{\n+ AudioMixengBackendClass *k = AUDIO_MIXENG_BACKEND_CLASS(klass);\n+\n+ k->driver = &jack_driver;\n+}\n+\n static const TypeInfo audio_types[] = {\n {\n .name = TYPE_AUDIO_JACK,\n", "prefixes": [ "51/85" ] }