Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196854/?format=api
{ "id": 2196854, "url": "http://patchwork.ozlabs.org/api/patches/2196854/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-46-e676662e4514@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260216-audio-v1-46-e676662e4514@redhat.com>", "list_archive_url": null, "date": "2026-02-16T11:15:35", "name": "[46/85] audio/alsa: convert to QOM lifecycle methods", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b9b02fa0c62106806b0474a25625607023e7eac2", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-46-e676662e4514@redhat.com/mbox/", "series": [ { "id": 492294, "url": "http://patchwork.ozlabs.org/api/series/492294/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492294", "date": "2026-02-16T11:14:52", "name": "audio: cleanups & add a manual test", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492294/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196854/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196854/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=JVoczkfD;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF0pm2gwJz1xwF\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 16 Feb 2026 22:26:40 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vrwfb-0008VH-R9; Mon, 16 Feb 2026 06:21:39 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrwc5-0006Om-4a\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:18:04 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrwc1-00089G-PO\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:18:00 -0500", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-259-YWNviQL8PsSzcH4TeNd7AA-1; Mon,\n 16 Feb 2026 06:17:49 -0500", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 762891955D7F; Mon, 16 Feb 2026 11:17:47 +0000 (UTC)", "from localhost (unknown [10.45.242.26])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id C83F41800465; Mon, 16 Feb 2026 11:17:46 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771240674;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=BmWsdaoNqpVIR51QxuWz4WHbtihjGKEs2lMyJkFhJdU=;\n b=JVoczkfDMMr7puJpY57iiEwzDI4/QbBohXcGSbzbYFNm6FHlhV1v0UJrLArFutWbQrYRp+\n NKBPY9srLI1XRC5oQ9hQx/TBdIVoN3sCnYLH1mbD3fc6z76plUU1DeWU4l4BnpwpfmgnPW\n EAcivtfzN8AKxI6lZ5OwZ73tO+sb1wQ=", "X-MC-Unique": "YWNviQL8PsSzcH4TeNd7AA-1", "X-Mimecast-MFC-AGG-ID": "YWNviQL8PsSzcH4TeNd7AA_1771240667", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Mon, 16 Feb 2026 12:15:35 +0100", "Subject": "[PATCH 46/85] audio/alsa: convert to QOM lifecycle methods", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260216-audio-v1-46-e676662e4514@redhat.com>", "References": "<20260216-audio-v1-0-e676662e4514@redhat.com>", "In-Reply-To": "<20260216-audio-v1-0-e676662e4514@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Gerd Hoffmann <kraxel@redhat.com>, Eduardo Habkost <eduardo@habkost.net>,\n Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>,\n Christian Schoenebeck <qemu_oss@crudebyte.com>,\n Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>,\n Thomas Huth <huth@tuxfamily.org>, Alexandre Ratchov <alex@caoua.org>,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Laurent Vivier <laurent@vivier.eu>, \"Michael S. Tsirkin\" <mst@redhat.com>,\n Manos Pitsidianakis <manos.pitsidianakis@linaro.org>,\n Alistair Francis <alistair@alistair23.me>,\n \"Edgar E. Iglesias\" <edgar.iglesias@gmail.com>,\n Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Mark Cave-Ayland <mark.caveayland@nutanix.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=5252;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=sSRqkWRZ9hS4IFoZz7rr3+mLEDXoYfNvp3TZ0iZgY6Y=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvxQmk9b3wzN3LM3fcPoVlXSzyKcASxtAa+kr\n 2r/1mlq7USJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL8UAAKCRDa6OEJdZac\n 5auqD/46RIfQboxk82mbkTY3HCCjNGnhpRYk4hp4AjGvuho7AbzCwq7Y48DZT0iv9X/azQ7GULJ\n DEwMQ7XN6B2PrbMFu6sn8LU1L1kdLE/0AW3kPt8ILIdSiFiiSYA1Pr3r20oKwTfLq+s0vIL8XPO\n +eXyVDaKpiXzWPeIA3WKW4Da/kpGD1gFBaDaluEx/j0+Jqt1FuJ6DVZwxCFcafbn93McgBqW8xe\n HrVbJ+rcFTuZBwIFCgPJ+cOCDCtGG4DUbMDA5wZq46IK1KODWbq9BK8z4/3gnhcp0DmJzI8YieY\n ZMkunBgnukoccVIVLrb+BQxWm2Qb/mVG5EyvWQUpFDjvnodKxJBeAhigolvgNdyLt59dZGTZP/l\n IxJW1UIjhW5lfHpsy3q1modoQT0Ixo3zPQ9qx0ni0x4msnTSnFaN6yB+fYc/wXpiyopIhEKpi+E\n m4iCS0Zqh9/Zn2H3sN9YcU0d0bylS9HJLmrgL6ZEBQH9Q/9HhjWsk1/T1+56tl2wD2cUR5k3kHv\n w6ckbVKADWcwYpjLUh1Nokbo02lw7gLnVMkNVCQIGg7KXQkG4yD9jj8WVN3OMaza6KE4jeecLvq\n U6WTSfhdcqI+CY00fWMJYK+X34s87ssL79Nbb6HTb9tTRMWK6K8TH4/QeDNqIZBB/lLfkUiASXN\n vo/vXrEhP5lRMPg==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Migrate the ALSA audio backend from the legacy driver init/fini\ncallbacks to proper QOM realize method.\n\nThe alsa_audio_init() function is replaced with audio_alsa_realize(),\nwhich performs the same ALSA option initialization before delegating\nto the parent class realize method. The empty alsa_audio_fini() is\nremoved.\n\nThe Audiodev pointer stored in ALSAVoiceOut and ALSAVoiceIn is removed\nas it can now be accessed through hw->s->dev.\n\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\nReviewed-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>\n---\n audio/alsaaudio.c | 43 ++++++++++++++++++++-----------------------\n 1 file changed, 20 insertions(+), 23 deletions(-)", "diff": "diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c\nindex ae1cec6a36e..c2788606b28 100644\n--- a/audio/alsaaudio.c\n+++ b/audio/alsaaudio.c\n@@ -40,19 +40,14 @@\n #define TYPE_AUDIO_ALSA \"audio-alsa\"\n OBJECT_DECLARE_SIMPLE_TYPE(AudioALSA, AUDIO_ALSA)\n \n+static AudioBackendClass *audio_alsa_parent_class;\n+\n struct AudioALSA {\n AudioMixengBackend parent_obj;\n };\n \n static struct audio_driver alsa_audio_driver;\n \n-static void audio_alsa_class_init(ObjectClass *klass, const void *data)\n-{\n- AudioMixengBackendClass *k = AUDIO_MIXENG_BACKEND_CLASS(klass);\n-\n- k->driver = &alsa_audio_driver;\n-}\n-\n struct pollhlp {\n snd_pcm_t *handle;\n struct pollfd *pfds;\n@@ -65,14 +60,12 @@ typedef struct ALSAVoiceOut {\n HWVoiceOut hw;\n snd_pcm_t *handle;\n struct pollhlp pollhlp;\n- Audiodev *dev;\n } ALSAVoiceOut;\n \n typedef struct ALSAVoiceIn {\n HWVoiceIn hw;\n snd_pcm_t *handle;\n struct pollhlp pollhlp;\n- Audiodev *dev;\n } ALSAVoiceIn;\n \n struct alsa_params_req {\n@@ -707,7 +700,7 @@ static int alsa_init_out(HWVoiceOut *hw, struct audsettings *as,\n struct alsa_params_obt obt;\n snd_pcm_t *handle;\n struct audsettings obt_as;\n- Audiodev *dev = drv_opaque;\n+ Audiodev *dev = hw->s->dev;\n \n req.fmt = aud_to_alsafmt (as->fmt, as->endianness);\n req.freq = as->freq;\n@@ -727,7 +720,6 @@ static int alsa_init_out(HWVoiceOut *hw, struct audsettings *as,\n \n alsa->pollhlp.s = hw->s;\n alsa->handle = handle;\n- alsa->dev = dev;\n return 0;\n }\n \n@@ -766,7 +758,7 @@ static int alsa_voice_ctl (snd_pcm_t *handle, const char *typ, int ctl)\n static void alsa_enable_out(HWVoiceOut *hw, bool enable)\n {\n ALSAVoiceOut *alsa = (ALSAVoiceOut *) hw;\n- AudiodevAlsaPerDirectionOptions *apdo = alsa->dev->u.alsa.out;\n+ AudiodevAlsaPerDirectionOptions *apdo = hw->s->dev->u.alsa.out;\n \n if (enable) {\n bool poll_mode = apdo->try_poll;\n@@ -794,7 +786,7 @@ static int alsa_init_in(HWVoiceIn *hw, struct audsettings *as, void *drv_opaque)\n struct alsa_params_obt obt;\n snd_pcm_t *handle;\n struct audsettings obt_as;\n- Audiodev *dev = drv_opaque;\n+ Audiodev *dev = hw->s->dev;\n \n req.fmt = aud_to_alsafmt (as->fmt, as->endianness);\n req.freq = as->freq;\n@@ -814,7 +806,6 @@ static int alsa_init_in(HWVoiceIn *hw, struct audsettings *as, void *drv_opaque)\n \n alsa->pollhlp.s = hw->s;\n alsa->handle = handle;\n- alsa->dev = dev;\n return 0;\n }\n \n@@ -871,7 +862,7 @@ static size_t alsa_read(HWVoiceIn *hw, void *buf, size_t len)\n static void alsa_enable_in(HWVoiceIn *hw, bool enable)\n {\n ALSAVoiceIn *alsa = (ALSAVoiceIn *) hw;\n- AudiodevAlsaPerDirectionOptions *apdo = alsa->dev->u.alsa.in;\n+ AudiodevAlsaPerDirectionOptions *apdo = hw->s->dev->u.alsa.in;\n \n if (enable) {\n bool poll_mode = apdo->try_poll;\n@@ -901,7 +892,8 @@ static void alsa_init_per_direction(AudiodevAlsaPerDirectionOptions *apdo)\n }\n }\n \n-static void *alsa_audio_init(Audiodev *dev, Error **errp)\n+static bool\n+audio_alsa_realize(AudioBackend *abe, Audiodev *dev, Error **errp)\n {\n AudiodevAlsaOptions *aopts;\n assert(dev->driver == AUDIODEV_DRIVER_ALSA);\n@@ -929,11 +921,7 @@ static void *alsa_audio_init(Audiodev *dev, Error **errp)\n dev->u.alsa.in->buffer_length = 92880;\n }\n \n- return dev;\n-}\n-\n-static void alsa_audio_fini (void *opaque)\n-{\n+ return audio_alsa_parent_class->realize(abe, dev, errp);\n }\n \n static struct audio_pcm_ops alsa_pcm_ops = {\n@@ -953,8 +941,6 @@ static struct audio_pcm_ops alsa_pcm_ops = {\n \n static struct audio_driver alsa_audio_driver = {\n .name = \"alsa\",\n- .init = alsa_audio_init,\n- .fini = alsa_audio_fini,\n .pcm_ops = &alsa_pcm_ops,\n .max_voices_out = INT_MAX,\n .max_voices_in = INT_MAX,\n@@ -962,6 +948,17 @@ static struct audio_driver alsa_audio_driver = {\n .voice_size_in = sizeof (ALSAVoiceIn)\n };\n \n+static void audio_alsa_class_init(ObjectClass *klass, const void *data)\n+{\n+ AudioBackendClass *b = AUDIO_BACKEND_CLASS(klass);\n+ AudioMixengBackendClass *k = AUDIO_MIXENG_BACKEND_CLASS(klass);\n+\n+ audio_alsa_parent_class = AUDIO_BACKEND_CLASS(object_class_get_parent(klass));\n+\n+ b->realize = audio_alsa_realize;\n+ k->driver = &alsa_audio_driver;\n+}\n+\n static const TypeInfo audio_types[] = {\n {\n .name = TYPE_AUDIO_ALSA,\n", "prefixes": [ "46/85" ] }