Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196852/?format=api
{ "id": 2196852, "url": "http://patchwork.ozlabs.org/api/patches/2196852/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-53-e676662e4514@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260216-audio-v1-53-e676662e4514@redhat.com>", "list_archive_url": null, "date": "2026-02-16T11:15:42", "name": "[53/85] audio/coreaudio: convert to QOM lifecycle methods", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "98dd046d392d0c1938cec7662dda47fbcd6a4d21", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-53-e676662e4514@redhat.com/mbox/", "series": [ { "id": 492294, "url": "http://patchwork.ozlabs.org/api/series/492294/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492294", "date": "2026-02-16T11:14:52", "name": "audio: cleanups & add a manual test", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492294/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196852/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196852/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=NSaQlkto;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF0pg4STdz1xwF\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 16 Feb 2026 22:26:35 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vrwfI-0005ky-Gy; Mon, 16 Feb 2026 06:21:20 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrwcL-0006i3-Og\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:18:23 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrwcI-0008D2-PR\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:18:17 -0500", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-437-Stq9VjIlP7qh-Q1F_XVTLA-1; Mon,\n 16 Feb 2026 06:18:09 -0500", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id E956E1956058; Mon, 16 Feb 2026 11:18:06 +0000 (UTC)", "from localhost (unknown [10.45.242.26])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id EF7B230001A5; Mon, 16 Feb 2026 11:18:05 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771240692;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=uH9F5ZbfheqEuQKcQaxVN621xVlRLtEAcdHBWTCahY4=;\n b=NSaQlktooaxvaPEq+12d7y8ViY3r8GhfdpLd8YDj5ZFVziaGLYccLDAhCe1/EO0hcN00mG\n uM2sAj68lUzwv5urti74Z/+7n80N6M8glseLvrX4QgT9Jhv9i5xGzpXZts3oV4NCxgYu43\n uYatZhx8Mo0wlhXdYCYOuX5NI6QYzzQ=", "X-MC-Unique": "Stq9VjIlP7qh-Q1F_XVTLA-1", "X-Mimecast-MFC-AGG-ID": "Stq9VjIlP7qh-Q1F_XVTLA_1771240687", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Mon, 16 Feb 2026 12:15:42 +0100", "Subject": "[PATCH 53/85] audio/coreaudio: convert to QOM lifecycle methods", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260216-audio-v1-53-e676662e4514@redhat.com>", "References": "<20260216-audio-v1-0-e676662e4514@redhat.com>", "In-Reply-To": "<20260216-audio-v1-0-e676662e4514@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Gerd Hoffmann <kraxel@redhat.com>, Eduardo Habkost <eduardo@habkost.net>,\n Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>,\n Christian Schoenebeck <qemu_oss@crudebyte.com>,\n Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>,\n Thomas Huth <huth@tuxfamily.org>, Alexandre Ratchov <alex@caoua.org>,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Laurent Vivier <laurent@vivier.eu>, \"Michael S. Tsirkin\" <mst@redhat.com>,\n Manos Pitsidianakis <manos.pitsidianakis@linaro.org>,\n Alistair Francis <alistair@alistair23.me>,\n \"Edgar E. Iglesias\" <edgar.iglesias@gmail.com>,\n Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Mark Cave-Ayland <mark.caveayland@nutanix.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1859;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=vQiHwzIc9rV8//NbzAafizGFjxFI5+TEF7+H85FTPW8=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvxQsEj/x84XZ2zrVn1c7YV6t77/ljjT9YCwC\n JsYIyqPEyeJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL8UAAKCRDa6OEJdZac\n 5fVVD/4p1ZxH28XdPxkA+QQ2lt2h4PAapFFsNv7e480/s5PeKu78gV9oO7RANBomYL6Lst26reU\n xdbR4UlIHQbEHEqTUITsPBLex2EBf3g6DUbVVrZtdRkXUqD+tha5dNNfXgEBb4MU6UtcKZvQolX\n 8ZbSEbDLWmayLkwTAPwRduDr6H/hpZ0An54UC+YeKgCdgo4Q9Aikttfqd/w6fKRZX41oPoiQK5S\n J+BwO2qH3WXTG4N8ZkFIUPs26RedCggjeYa5SDAtmUY7VID0ukQBpzanZ8Yo4zl3FvB0AsFKU26\n phXYUF85kWV+6itdoGICZNBIdDi9cHqZwkU1E+1Di1mdBaxbq1m2uBx2MS45moyeBSdeeOOL+CZ\n u1k2cX3yev5qsJqpWrOWBuWZbdu6TKBxjYYRdYUOsz+6JvCHWafXDYJO6pbX+fPmFDCMnNYWkEF\n XQZnVEkaGLMANY3zujxHWa/gkmZtAwIDRsuOgBL6OEy8q9OdUHL6m7ZYvW0UCm0qrwfnaHYZ4Ju\n lUn5z6+XW1TrJvlSdeTzxD6KnsxZHoZl4VZpQAbwl6k3Wk/peSmkytAHa93a0Uef2OavU8CDLln\n 1+wIWNRvvzD+FIOps5cWQwi0nRIwxwTDsr6hS4xcVMwVcgG+cKyIEi4ugPmaIs6gRsX9PfK8+Na\n DhMIiUNRXFay7lA==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Remove the legacy driver init/fini callbacks from the CoreAudio backend.\n\nBoth coreaudio_audio_init() and coreaudio_audio_fini() were no-ops that\nperformed no real initialization or cleanup work. Access to the\nAudiodev is now through hw->s->dev instead of the drv_opaque pointer.\n\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\nReviewed-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>\nReviewed-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>\n---\n audio/coreaudio.m | 13 +------------\n 1 file changed, 1 insertion(+), 12 deletions(-)", "diff": "diff --git a/audio/coreaudio.m b/audio/coreaudio.m\nindex 862cb9dd9b0..4a0904f0073 100644\n--- a/audio/coreaudio.m\n+++ b/audio/coreaudio.m\n@@ -579,7 +579,7 @@ static int coreaudio_init_out(HWVoiceOut *hw, struct audsettings *as,\n OSStatus status;\n coreaudioVoiceOut *core = (coreaudioVoiceOut *) hw;\n int err;\n- Audiodev *dev = drv_opaque;\n+ Audiodev *dev = hw->s->dev;\n AudiodevCoreaudioPerDirectionOptions *cpdo = dev->u.coreaudio.out;\n struct audsettings obt_as;\n \n@@ -656,15 +656,6 @@ static void coreaudio_enable_out(HWVoiceOut *hw, bool enable)\n update_device_playback_state(core);\n }\n \n-static void *coreaudio_audio_init(Audiodev *dev, Error **errp)\n-{\n- return dev;\n-}\n-\n-static void coreaudio_audio_fini (void *opaque)\n-{\n-}\n-\n static struct audio_pcm_ops coreaudio_pcm_ops = {\n .init_out = coreaudio_init_out,\n .fini_out = coreaudio_fini_out,\n@@ -681,8 +672,6 @@ static void coreaudio_audio_fini (void *opaque)\n \n static struct audio_driver coreaudio_audio_driver = {\n .name = \"coreaudio\",\n- .init = coreaudio_audio_init,\n- .fini = coreaudio_audio_fini,\n .pcm_ops = &coreaudio_pcm_ops,\n .max_voices_out = 1,\n .max_voices_in = 0,\n", "prefixes": [ "53/85" ] }