Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196849/?format=api
{ "id": 2196849, "url": "http://patchwork.ozlabs.org/api/patches/2196849/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-75-e676662e4514@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260216-audio-v1-75-e676662e4514@redhat.com>", "list_archive_url": null, "date": "2026-02-16T11:16:04", "name": "[75/85] audio: rework DEBUG_POLL", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3114133b1bb6e683f41ac993d0554aa64aa780b8", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-75-e676662e4514@redhat.com/mbox/", "series": [ { "id": 492294, "url": "http://patchwork.ozlabs.org/api/series/492294/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492294", "date": "2026-02-16T11:14:52", "name": "audio: cleanups & add a manual test", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492294/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196849/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196849/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=JqOcgD0J;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF0pG1NBZz1xxp\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 16 Feb 2026 22:26:14 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vrwfa-0008Mu-ID; Mon, 16 Feb 2026 06:21:38 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrwdL-0007yI-4e\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:19:19 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrwdJ-0008TO-2x\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:19:18 -0500", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-199-4BQWyRFXM5OZuEZ7gBJIeg-1; Mon,\n 16 Feb 2026 06:19:11 -0500", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 9C51D18002C1; Mon, 16 Feb 2026 11:19:09 +0000 (UTC)", "from localhost (unknown [10.45.242.26])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 0BD8A1955F43; Mon, 16 Feb 2026 11:19:08 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771240756;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=N7c59NEfg4hmqcbZ3MZ180N2UP3aJ4ktCpkln/Wb2qE=;\n b=JqOcgD0JtQkNLMFqZ40t0jkzI+1vxDCkRnqErCEwp/D8kdoa3bm+CVZnHWwdq0WJaMx0Sr\n hZGj+UlYaPAP5CvxPka8Q3saMEzAass3eT5BTIAix57fvOPX1mz31A0XNIJDnuNGQjoIFs\n kZsuLuiWb/KZxd/fxksFvzm9+3YSqpY=", "X-MC-Unique": "4BQWyRFXM5OZuEZ7gBJIeg-1", "X-Mimecast-MFC-AGG-ID": "4BQWyRFXM5OZuEZ7gBJIeg_1771240749", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Mon, 16 Feb 2026 12:16:04 +0100", "Subject": "[PATCH 75/85] audio: rework DEBUG_POLL", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260216-audio-v1-75-e676662e4514@redhat.com>", "References": "<20260216-audio-v1-0-e676662e4514@redhat.com>", "In-Reply-To": "<20260216-audio-v1-0-e676662e4514@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Gerd Hoffmann <kraxel@redhat.com>, Eduardo Habkost <eduardo@habkost.net>,\n Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>,\n Christian Schoenebeck <qemu_oss@crudebyte.com>,\n Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>,\n Thomas Huth <huth@tuxfamily.org>, Alexandre Ratchov <alex@caoua.org>,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Laurent Vivier <laurent@vivier.eu>, \"Michael S. Tsirkin\" <mst@redhat.com>,\n Manos Pitsidianakis <manos.pitsidianakis@linaro.org>,\n Alistair Francis <alistair@alistair23.me>,\n \"Edgar E. Iglesias\" <edgar.iglesias@gmail.com>,\n Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Mark Cave-Ayland <mark.caveayland@nutanix.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=3820;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=VuHJE/OMoLF5FV66Xec/LvzCGIsN/NmdER0U65ZSEv0=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvxSC3oidMw+TYQw+bed/aGyUDri9z1ES2mfP\n mNcR+kss6KJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL8UgAKCRDa6OEJdZac\n 5c4uD/sEd++T8QohRaQ95Za6IPQRCm1KE+xDf5nA1SOKwPzmuQDDiQrozdPuMv5Vcy1FSDc0oPq\n hMyYijL0C49wC06yiwaPAjtwios2ncI6XYim21cjvauUwO/wfvXwu0MB94+nmkjhMYrXkIJq+MI\n xs7veXvlVf+ThVbDHMxp9LjWFNxRnlYrbYzfKcgOLSYqNusDtMnHmJRdlm6C+A/Er/LPMCAl0Vr\n +GSVoh5Gz81ZwuZo0hyXkkF6l8BZIvU6ECtv8YpOIQLgrnxRX9sKNRzHG5sRhu+QcjEmUbNy7H/\n ppfOeH/VQd4wnJhY9VVvvsdOi8tFnW0tcmc0ONrzKxnO4nMaKbQB1QoD6JdlPe8TOTDncUdQonJ\n MxBn0lCJMKJ9CIBR0dj49JKuelJUP6gLrphdeiyq68CSuXhXcylMFXmwwwpv43NS2RbpKzPRgPf\n Ak/YJest1iyVRLsB1w2ixFHwRXqRWIrfz1h04eRahIvgr3feZJPKOhFMIcXUoEBMysWPkXT3vGY\n We+JscZXwHlOTYrJh9JOxhR+OmoHYO27+PI0xWwCIedoP3ZCe5SmKubNKk1XoxUpSV6Ag7v/QvJ\n vlAgGhrJnAB6N2j85w8oN3e+SbsyenoPP+47zACsMUTS6W6ZyiQAiWvgRSPBJcSkYuRFFvmXAYI\n XLrX7JpFBi9H96w==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Use more correct GTimer, specific for each backend, with a trace event.\n\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\nReviewed-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>\n---\n audio/audio_int.h | 1 +\n include/qemu/timer.h | 1 +\n audio/audio-mixeng-be.c | 25 +++++++++----------------\n audio/trace-events | 1 +\n 4 files changed, 12 insertions(+), 16 deletions(-)", "diff": "diff --git a/audio/audio_int.h b/audio/audio_int.h\nindex dd5f2220d75..e0ed6af67ed 100644\n--- a/audio/audio_int.h\n+++ b/audio/audio_int.h\n@@ -224,6 +224,7 @@ struct AudioMixengBackend {\n Audiodev *dev;\n \n QEMUTimer *ts;\n+ GTimer *run_timer;\n QLIST_HEAD (hw_in_listhead, HWVoiceIn) hw_head_in;\n QLIST_HEAD (hw_out_listhead, HWVoiceOut) hw_head_out;\n QLIST_HEAD (cap_listhead, CaptureVoiceOut) cap_head;\ndiff --git a/include/qemu/timer.h b/include/qemu/timer.h\nindex 7c18da16525..b931181f53d 100644\n--- a/include/qemu/timer.h\n+++ b/include/qemu/timer.h\n@@ -6,6 +6,7 @@\n #include \"qemu/host-utils.h\"\n \n #define NANOSECONDS_PER_SECOND 1000000000LL\n+#define MICROSECONDS_PER_SECOND 1000000LL\n \n /* timers */\n \ndiff --git a/audio/audio-mixeng-be.c b/audio/audio-mixeng-be.c\nindex 84e4d136de3..2aeb05ba37e 100644\n--- a/audio/audio-mixeng-be.c\n+++ b/audio/audio-mixeng-be.c\n@@ -24,13 +24,13 @@\n #include \"system/replay.h\"\n #include \"system/runstate.h\"\n #include \"trace.h\"\n+#include \"trace/control.h\"\n \n #define AUDIO_CAP \"audio\"\n #include \"audio_int.h\"\n \n /* #define DEBUG_OUT */\n /* #define DEBUG_CAPTURE */\n-/* #define DEBUG_POLL */\n \n #define SW_NAME(sw) (sw)->name ? (sw)->name : \"unknown\"\n \n@@ -1269,22 +1269,12 @@ void audio_run(AudioMixengBackend *s, const char *msg)\n audio_run_in(s);\n audio_run_capture(s);\n \n-#ifdef DEBUG_POLL\n- {\n- static double prevtime;\n- double currtime;\n- struct timeval tv;\n-\n- if (gettimeofday (&tv, NULL)) {\n- perror (\"audio_run: gettimeofday\");\n- return;\n- }\n-\n- currtime = tv.tv_sec + tv.tv_usec * 1e-6;\n- dolog (\"Elapsed since last %s: %f\\n\", msg, currtime - prevtime);\n- prevtime = currtime;\n+ if (trace_event_get_state(TRACE_AUDIO_RUN_POLL)) {\n+ /* Convert seconds to microseconds for trace event */\n+ int64_t elapsed_us = g_timer_elapsed(s->run_timer, NULL) * MICROSECONDS_PER_SECOND;\n+ trace_audio_run_poll(msg, elapsed_us);\n+ g_timer_start(s->run_timer);\n }\n-#endif\n }\n \n void audio_generic_run_buffer_in(HWVoiceIn *hw)\n@@ -1545,6 +1535,7 @@ static void audio_mixeng_backend_init(Object *obj)\n QLIST_INIT(&s->hw_head_in);\n QLIST_INIT(&s->cap_head);\n s->ts = timer_new_ns(QEMU_CLOCK_VIRTUAL, audio_timer, s);\n+ s->run_timer = g_timer_new();\n \n s->vmse = qemu_add_vm_change_state_handler(audio_vm_change_state_handler, s);\n assert(s->vmse != NULL);\n@@ -1596,6 +1587,8 @@ static void audio_mixeng_backend_finalize(Object *obj)\n s->ts = NULL;\n }\n \n+ g_clear_pointer(&s->run_timer, g_timer_destroy);\n+\n if (s->vmse) {\n qemu_del_vm_change_state_handler(s->vmse);\n s->vmse = NULL;\ndiff --git a/audio/trace-events b/audio/trace-events\nindex 4749c54fc04..d66a712e871 100644\n--- a/audio/trace-events\n+++ b/audio/trace-events\n@@ -61,6 +61,7 @@ audio_timer_delayed(int interval) \"interval %d ms\"\n \n # audio-mixeng-be.c\n audio_get_avail(const char *name, size_t live, uint32_t frontend_frames) \"%s: get_avail live %zu frontend frames %u\"\n+audio_run_poll(const char *msg, int64_t elapsed_us) \"Elapsed since last %s: %\" PRId64 \" us\"\n \n # audio_template.h\n audio_open_out(const char *name, int freq, int nchannels, int fmt) \"open %s, freq %d, nchannels %d, fmt %d\"\n", "prefixes": [ "75/85" ] }