Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196841/?format=api
{ "id": 2196841, "url": "http://patchwork.ozlabs.org/api/patches/2196841/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-52-e676662e4514@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260216-audio-v1-52-e676662e4514@redhat.com>", "list_archive_url": null, "date": "2026-02-16T11:15:41", "name": "[52/85] audio/sndio: convert to QOM lifecycle methods", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6faba5bd15a3340c2b6fbd01e7d8054f6fd351b5", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-52-e676662e4514@redhat.com/mbox/", "series": [ { "id": 492294, "url": "http://patchwork.ozlabs.org/api/series/492294/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492294", "date": "2026-02-16T11:14:52", "name": "audio: cleanups & add a manual test", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492294/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196841/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196841/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=TwDyq/pn;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF0mM5WL3z1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 16 Feb 2026 22:24:35 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vrwfY-00082z-Pw; Mon, 16 Feb 2026 06:21:36 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrwcF-0006b1-I8\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:18:14 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrwcE-0008CQ-48\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:18:11 -0500", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-353-5O8WJ4ZdM0ysddx2svczBw-1; Mon,\n 16 Feb 2026 06:18:06 -0500", "from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id EA62D1956094; Mon, 16 Feb 2026 11:18:03 +0000 (UTC)", "from localhost (unknown [10.45.242.26])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id AD06019560A2; Mon, 16 Feb 2026 11:18:02 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771240689;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Qj7tPbVqgOlKJ+Ll6M3+6JaJu6YSwwchSgbBCeu4O1M=;\n b=TwDyq/pnlKNRYGOfBa2pvN1MkcQdjqzV69iRE6acHGPUbB+abN56aFgiZgevsHroRaJKeS\n 3jqJD5dZ76gYRWwXl25gWTv4UNkw7+8nwga7cpsQkn/MUqjrTGs+t82FZyo4URljC+1YkE\n RligsrwXuO8UnGUStkSHdUPI35r0wZM=", "X-MC-Unique": "5O8WJ4ZdM0ysddx2svczBw-1", "X-Mimecast-MFC-AGG-ID": "5O8WJ4ZdM0ysddx2svczBw_1771240684", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Mon, 16 Feb 2026 12:15:41 +0100", "Subject": "[PATCH 52/85] audio/sndio: convert to QOM lifecycle methods", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260216-audio-v1-52-e676662e4514@redhat.com>", "References": "<20260216-audio-v1-0-e676662e4514@redhat.com>", "In-Reply-To": "<20260216-audio-v1-0-e676662e4514@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Gerd Hoffmann <kraxel@redhat.com>, Eduardo Habkost <eduardo@habkost.net>,\n Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>,\n Christian Schoenebeck <qemu_oss@crudebyte.com>,\n Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>,\n Thomas Huth <huth@tuxfamily.org>, Alexandre Ratchov <alex@caoua.org>,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Laurent Vivier <laurent@vivier.eu>, \"Michael S. Tsirkin\" <mst@redhat.com>,\n Manos Pitsidianakis <manos.pitsidianakis@linaro.org>,\n Alistair Francis <alistair@alistair23.me>,\n \"Edgar E. Iglesias\" <edgar.iglesias@gmail.com>,\n Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Mark Cave-Ayland <mark.caveayland@nutanix.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=2039;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=idLQbKa19YwiU46EtQoQP2sry84lA/BHtl+BQc+SfU0=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvxQyvJ5Sp0lr4p334/waquRoLpaMl8d00Wl1\n B/yZSTqLt+JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL8UAAKCRDa6OEJdZac\n 5aooD/4geXbnZ4hfJpI2CicCN/NSOcSTacyRuSYM/YdRVob1CoJvAqrcF1lXYsioTOO1tqHXsZR\n 1ulGUnmdOK/Qb0sRVhmmZLHLuanzw4j1iUTyJCIvxQYatdyPSRn1ZR3yvQ4tIdxz5Ep8wHNP5MT\n to886YMHX5xr7bN4Gx8Gjz5/0168kf2HAKtH3ZU+8XbbcBEYx2JXHe/jYRDhFsCPxaN8f+NrBXq\n ZkepiDTjmeq2OhWw5IZxEhwf2MYH3HO/4rSajPVMBxgjHFyQvIxBN2Y3c7gPwI9zM0T8Xf1k/Vm\n ANIBUvKGBYOzR7nszGDRqjDUHndCe17oDllP66Tc9MPOVy66W+ctz7EBO4XKVaerGVNwkcme8g4\n 2SrMDK+gol5ZLu078XRYNaxoXk+zk40Iv/ZXwdZcoagOOIOdWM8hYHr6unr5Dcv5oIMtRyZLY8f\n YgsGaSHSIHZ8B0rXSe+tdwnhbg18FfKCs5i+s6InQUiaK6SNjJ/3dfkp0cbK4KGf4bK9CkF2fgx\n TDdODJNjCa6IkYwrI+kaQR6o7GUEEi5OjhaU83MVNS0o8qvjTtTxYGPZztLtVp52GBDLB/RUoIv\n 8VNcyZmljnFU/o+BihgY5jGberEpyoa3CzHtXXOOiT/Y+cwtHaAhPnxXKhns/9t3blPxSvHujZm\n gtA/0qJCHVPbFKw==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.12", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Remove the legacy driver init/fini callbacks from the sndio audio backend.\n\nBoth sndio_audio_init() and sndio_audio_fini() were no-ops that\nperformed no real initialization or cleanup work. Access to the\nAudiodev is now through hw->s->dev instead of the drv_opaque pointer.\n\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\nReviewed-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>\n---\n audio/sndioaudio.c | 16 ++--------------\n 1 file changed, 2 insertions(+), 14 deletions(-)", "diff": "diff --git a/audio/sndioaudio.c b/audio/sndioaudio.c\nindex 2a9ae42992b..c15d8b6684a 100644\n--- a/audio/sndioaudio.c\n+++ b/audio/sndioaudio.c\n@@ -499,7 +499,7 @@ static int sndio_init_out(HWVoiceOut *hw, struct audsettings *as, void *opaque)\n {\n SndioVoice *self = (SndioVoice *) hw;\n \n- if (sndio_init(self, as, SIO_PLAY, opaque) == -1) {\n+ if (sndio_init(self, as, SIO_PLAY, hw->s->dev) == -1) {\n return -1;\n }\n \n@@ -512,7 +512,7 @@ static int sndio_init_in(HWVoiceIn *hw, struct audsettings *as, void *opaque)\n {\n SndioVoice *self = (SndioVoice *) hw;\n \n- if (sndio_init(self, as, SIO_REC, opaque) == -1) {\n+ if (sndio_init(self, as, SIO_REC, hw->s->dev) == -1) {\n return -1;\n }\n \n@@ -535,16 +535,6 @@ static void sndio_fini_in(HWVoiceIn *hw)\n sndio_fini(self);\n }\n \n-static void *sndio_audio_init(Audiodev *dev, Error **errp)\n-{\n- assert(dev->driver == AUDIODEV_DRIVER_SNDIO);\n- return dev;\n-}\n-\n-static void sndio_audio_fini(void *opaque)\n-{\n-}\n-\n static struct audio_pcm_ops sndio_pcm_ops = {\n .init_out = sndio_init_out,\n .fini_out = sndio_fini_out,\n@@ -563,8 +553,6 @@ static struct audio_pcm_ops sndio_pcm_ops = {\n \n static struct audio_driver sndio_audio_driver = {\n .name = \"sndio\",\n- .init = sndio_audio_init,\n- .fini = sndio_audio_fini,\n .pcm_ops = &sndio_pcm_ops,\n .max_voices_out = INT_MAX,\n .max_voices_in = INT_MAX,\n", "prefixes": [ "52/85" ] }