Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196833/?format=api
{ "id": 2196833, "url": "http://patchwork.ozlabs.org/api/patches/2196833/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-67-e676662e4514@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260216-audio-v1-67-e676662e4514@redhat.com>", "list_archive_url": null, "date": "2026-02-16T11:15:56", "name": "[67/85] audio/pw: replace custom logging with error_report", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "7725f1ab36be850a70099399043191c17f7d18f4", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-67-e676662e4514@redhat.com/mbox/", "series": [ { "id": 492294, "url": "http://patchwork.ozlabs.org/api/series/492294/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492294", "date": "2026-02-16T11:14:52", "name": "audio: cleanups & add a manual test", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492294/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196833/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196833/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=L9Gup3PM;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF0lX5s5Xz1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 16 Feb 2026 22:23:52 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vrwfP-0006jY-F4; Mon, 16 Feb 2026 06:21:27 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrwcx-0007NK-KC\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:18:57 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrwcv-0008P2-5V\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:18:55 -0500", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-600-Mwrem7XYPm-sZi5F77Bv5g-1; Mon,\n 16 Feb 2026 06:18:48 -0500", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 575A81955D8D; Mon, 16 Feb 2026 11:18:46 +0000 (UTC)", "from localhost (unknown [10.45.242.26])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id AE32130001A5; Mon, 16 Feb 2026 11:18:45 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771240732;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=f2dXnZAb4GQ3OqunerrTarsSyOPnsFPU054yEOgQ/M0=;\n b=L9Gup3PM5j6v3YBZ3UYi8F54OY6MuOfbxRsCsJ9ACL8U0NqYJbPSyzW9eXwsrKOxvdVLu5\n uGlmdORel91I7HbKXx1iDvm004kHwjyuMjAR+qpIK6+Mo3QLdZlDEock4Km9ABramvCcHj\n 8zyLQ64uoMAacyhlw4mc45aUCm9CNOM=", "X-MC-Unique": "Mwrem7XYPm-sZi5F77Bv5g-1", "X-Mimecast-MFC-AGG-ID": "Mwrem7XYPm-sZi5F77Bv5g_1771240726", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Mon, 16 Feb 2026 12:15:56 +0100", "Subject": "[PATCH 67/85] audio/pw: replace custom logging with error_report", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260216-audio-v1-67-e676662e4514@redhat.com>", "References": "<20260216-audio-v1-0-e676662e4514@redhat.com>", "In-Reply-To": "<20260216-audio-v1-0-e676662e4514@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Gerd Hoffmann <kraxel@redhat.com>, Eduardo Habkost <eduardo@habkost.net>,\n Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>,\n Christian Schoenebeck <qemu_oss@crudebyte.com>,\n Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>,\n Thomas Huth <huth@tuxfamily.org>, Alexandre Ratchov <alex@caoua.org>,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Laurent Vivier <laurent@vivier.eu>, \"Michael S. Tsirkin\" <mst@redhat.com>,\n Manos Pitsidianakis <manos.pitsidianakis@linaro.org>,\n Alistair Francis <alistair@alistair23.me>,\n \"Edgar E. Iglesias\" <edgar.iglesias@gmail.com>,\n Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Mark Cave-Ayland <mark.caveayland@nutanix.com>,\n Thomas Huth <thuth@redhat.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=2025;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=9XNiYrTBg8/TjuL3Pf/yXDW/8WV5yurqmx3CbFtxjhs=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvxRSfLO9lhGAIAH3YGIPwWElH4Mul7Hib5HK\n 35X9PJePGqJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL8UQAKCRDa6OEJdZac\n 5UVtD/4hBQEGov6kG25Fo3wIZ4XoC+OUUtYUBYbExsdpwvRV9u6PriUD/wbSI6t7vtwZqh3YmsG\n ffVaMEHgjnq4xCRx3Ku5ohAAk7ng4PW9udOkEKoIBd4jFoHZvqTAGLuctUlrrsY/1AoOZHHFl4W\n xe8qhEZIMXLNoDYWA9cQ5LQnmTqsBmhTNgjr+3Iio43g/OyiJiyPxT64QFT0Dnw+O7Lo8m5cuwn\n k028BB6BAPqn06TbU0thagkhsN1BNrlD2gKpAXcVM0N2H1PJK5bUfFkkBpwxdl5dKiBHh6bu5PH\n mbvYSGIQQJ8LoUiGRyhet/kN80enWRypYLN6RiWW/+H5Zf+3hL2vjSccJh/CURs2sR/xfhEWKHw\n mq/WEJe8UKWT4Y0geGK4PKw4er7vqzWCKrSUrj+5bXCq0S6UYQobLXdRcI/izvP9QGop0EHtCsn\n TOEAdvFD7EjSEOq8oVCVFrjok4TIJh6DPFsMEav2WLicZk6TJXaH5Gbidmbj9F5lVStvHEThWqY\n uyPmgS8yzwBo87/sxKjIoA+vIMSt31OZ24sjeoNViXWJQjLKZNnUrlhlw4StayW9BhD2TujDGnc\n QM3RbTmANEUCzMqYBNOe6/0fan+x80MRf+V3BDaWgvbWEja41PmeMFkzK1PteYBjJZ1Ebtfm7oL\n dDYhn8YKVNLFGTA==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Replace the custom audio logging infrastructure (dolog macro) with\nstandard QEMU error reporting (error_report).\n\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\nReviewed-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>\nReviewed-by: Thomas Huth <thuth@redhat.com>\n---\n audio/pwaudio.c | 11 +++++------\n 1 file changed, 5 insertions(+), 6 deletions(-)", "diff": "diff --git a/audio/pwaudio.c b/audio/pwaudio.c\nindex 7a009a94f3a..6a80e5a333e 100644\n--- a/audio/pwaudio.c\n+++ b/audio/pwaudio.c\n@@ -20,14 +20,13 @@\n #include <spa/param/props.h>\n \n #include <pipewire/pipewire.h>\n+\n+#include \"audio_int.h\"\n #include \"trace.h\"\n \n-#define AUDIO_CAP \"pipewire\"\n #define RINGBUFFER_SIZE (1u << 22)\n #define RINGBUFFER_MASK (RINGBUFFER_SIZE - 1)\n \n-#include \"audio_int.h\"\n-\n #define TYPE_AUDIO_PW \"audio-pipewire\"\n OBJECT_DECLARE_SIMPLE_TYPE(AudioPw, AUDIO_PW)\n \n@@ -358,7 +357,7 @@ audfmt_to_pw(AudioFormat fmt, bool big_endian)\n format = big_endian ? SPA_AUDIO_FORMAT_F32_BE : SPA_AUDIO_FORMAT_F32_LE;\n break;\n default:\n- dolog(\"Internal logic error: Bad audio format %d\\n\", fmt);\n+ error_report(\"pipewire: internal logic error: bad audio format %d\", fmt);\n format = SPA_AUDIO_FORMAT_U8;\n break;\n }\n@@ -418,7 +417,7 @@ pw_to_audfmt(enum spa_audio_format fmt, int *endianness,\n return AUDIO_FORMAT_F32;\n default:\n *sample_size = 1;\n- dolog(\"Internal logic error: Bad spa_audio_format %d\\n\", fmt);\n+ error_report(\"pipewire: internal logic error: bad spa_audio_format %d\", fmt);\n return AUDIO_FORMAT_U8;\n }\n }\n@@ -518,7 +517,7 @@ qpw_set_position(uint32_t channels, uint32_t position[SPA_AUDIO_MAX_CHANNELS])\n position[0] = SPA_AUDIO_CHANNEL_MONO;\n break;\n default:\n- dolog(\"Internal error: unsupported channel count %d\\n\", channels);\n+ error_report(\"pipewire: unsupported channel count %d\", channels);\n }\n }\n \n", "prefixes": [ "67/85" ] }