Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196826/?format=api
{ "id": 2196826, "url": "http://patchwork.ozlabs.org/api/patches/2196826/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-82-e676662e4514@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260216-audio-v1-82-e676662e4514@redhat.com>", "list_archive_url": null, "date": "2026-02-16T11:16:11", "name": "[82/85] audio: replace remaining dolog() and AUD_log", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "939f9d7c500c4010d922a6dc84a3aae775239de3", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-82-e676662e4514@redhat.com/mbox/", "series": [ { "id": 492294, "url": "http://patchwork.ozlabs.org/api/series/492294/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492294", "date": "2026-02-16T11:14:52", "name": "audio: cleanups & add a manual test", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492294/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196826/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196826/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=BiNGh4Gs;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF0kP6cYXz1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 16 Feb 2026 22:22:53 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vrwfV-0007c0-Gr; Mon, 16 Feb 2026 06:21:33 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrwdd-00014w-QN\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:19:38 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrwdc-00008p-1J\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:19:37 -0500", "from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-eZ5vn84fMCuPDEEuy7Dqdw-1; Mon,\n 16 Feb 2026 06:19:32 -0500", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 13585180061C; Mon, 16 Feb 2026 11:19:30 +0000 (UTC)", "from localhost (unknown [10.45.242.26])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 366AE18003F5; Mon, 16 Feb 2026 11:19:28 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771240775;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=FAUf6ISAZflTDjhXPD3ercX88fY0ngZoOrqUS7o23nE=;\n b=BiNGh4GsUVsrI5ErVCxb8+jKAeQqGg3HFPbaZJuHHNkqgnY0WFJGZ0MMJvo5Fjq34mxh3w\n dw4kcueH2vJPqJEBNz+mOHHU+3d7eayh1MjIRI842JEjtCt+KApmllSUybD0RtmTxPOtyX\n fhb5yDyj+1HoVP95Aqk5Ve+L+2vMiSY=", "X-MC-Unique": "eZ5vn84fMCuPDEEuy7Dqdw-1", "X-Mimecast-MFC-AGG-ID": "eZ5vn84fMCuPDEEuy7Dqdw_1771240770", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Mon, 16 Feb 2026 12:16:11 +0100", "Subject": "[PATCH 82/85] audio: replace remaining dolog() and AUD_log", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260216-audio-v1-82-e676662e4514@redhat.com>", "References": "<20260216-audio-v1-0-e676662e4514@redhat.com>", "In-Reply-To": "<20260216-audio-v1-0-e676662e4514@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Gerd Hoffmann <kraxel@redhat.com>, Eduardo Habkost <eduardo@habkost.net>,\n Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>,\n Christian Schoenebeck <qemu_oss@crudebyte.com>,\n Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>,\n Thomas Huth <huth@tuxfamily.org>, Alexandre Ratchov <alex@caoua.org>,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Laurent Vivier <laurent@vivier.eu>, \"Michael S. Tsirkin\" <mst@redhat.com>,\n Manos Pitsidianakis <manos.pitsidianakis@linaro.org>,\n Alistair Francis <alistair@alistair23.me>,\n \"Edgar E. Iglesias\" <edgar.iglesias@gmail.com>,\n Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Mark Cave-Ayland <mark.caveayland@nutanix.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=5295;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=mOUp9eC9vpEhRWm1F10PNR55828CsJNREo9Q5TCNNvM=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvxS8OVVpkPOKm5cUtP04sCqyOLFsyNqaNIl+\n zQ23O2L4S2JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL8UgAKCRDa6OEJdZac\n 5Tn9EACsUwLAH8MeYZjy+V08nmhf4+TbU/JZDkFGl+cx5bR8Lz114WS2shcfs0dbnzJVobZNqqw\n BLjBA/96RW2g3aPpaGlfYwKnJsZtK2dUhV8OSPzmyRN8t65kjIqdZic3epkDw12BdgSnVlkmPxl\n WYMJKRFfk6suDuXwGdvrCuvNKQOfmg6Z6Xl114MSZKSVbfR7Yoac7yrR09nW8+GPFhKqzSk3p61\n vpyAiAy+ClkBHyM97svUVRfNYXjSo4Ma7GH/TZzjGFaCqW5iADljBc7/9QWX+DPLad/6Hk2CRzA\n cWdxVZoDXXJYc6Z5DMTLiDyQCGgufr452FPMlI+SpplDo3u1082HdxghrBbmbqpd69tXJaFG7Pi\n TUYRX5dLEkAKEShuPBXu2QtbLV45sIKjwkDSERI+srdBFXNETo1W43TVkPlLVDNn2P0roHZ1gT5\n p6Pdvlog/oH8okWj/Gtieze1O9P5KgFvFCb1TzbrAeOTge9ekBx/YBnl4z/SMrrqQwYgVZrEJqi\n kst01pGscF9tnPcmgfT+6tdFtdI9tkvKS5Wgnx9H0Dgy+zP1+PtGKk4BaB0XHrE5Ij+7lLmtjhp\n cRpvpQGCJvMr9IWWFGAfC1KzXvlE1hlkkJRDxA4TcmiSstDMBcmjbzTpf0nF2/OL0aGL6bPRr7M\n vOVYUq6gDhnHJtQ==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Use warn_report/error_report and trace instead.\n\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\nReviewed-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>\n---\n audio/audio_template.h | 19 ++++++++-----------\n audio/audio-mixeng-be.c | 14 ++++++--------\n audio/trace-events | 1 +\n 3 files changed, 15 insertions(+), 19 deletions(-)", "diff": "diff --git a/audio/audio_template.h b/audio/audio_template.h\nindex 9dde36738bc..760aaf5f31f 100644\n--- a/audio/audio_template.h\n+++ b/audio/audio_template.h\n@@ -47,21 +47,19 @@ static void glue(audio_init_nb_voices_, TYPE)(AudioMixengBackend *s,\n if (glue(s->nb_hw_voices_, TYPE) > max_voices) {\n if (!max_voices) {\n #ifdef DAC\n- dolog(\"Driver `%s' does not support \" NAME \"\\n\", k->name);\n+ warn_report(\"audio: Driver '%s' does not support \" NAME, k->name);\n #endif\n } else {\n- dolog(\"Driver `%s' does not support %d \" NAME \" voices, max %d\\n\",\n- k->name,\n- glue(s->nb_hw_voices_, TYPE),\n- max_voices);\n+ warn_report(\"audio: Driver '%s' does not support %d \" NAME \" voices, max %d\",\n+ k->name, glue(s->nb_hw_voices_, TYPE), max_voices);\n }\n glue(s->nb_hw_voices_, TYPE) = max_voices;\n }\n \n if (glue(s->nb_hw_voices_, TYPE) < min_voices) {\n- dolog(\"Bogus number of \" NAME \" voices %d, setting to %d\\n\",\n- glue(s->nb_hw_voices_, TYPE),\n- min_voices);\n+ warn_report(\"audio: Bogus number of \" NAME \" voices %d, setting to %d\",\n+ glue(s->nb_hw_voices_, TYPE),\n+ min_voices);\n }\n \n if (!voice_size && max_voices) {\n@@ -443,7 +441,7 @@ static SW *glue(audio_pcm_create_voice_pair_, TYPE)(\n \n hw = glue(audio_pcm_hw_add_, TYPE)(s, &hw_as);\n if (!hw) {\n- dolog(\"Could not create a backend for voice `%s'\\n\", sw_name);\n+ error_report(\"audio: Could not create a backend for voice '%s'\", sw_name);\n goto err1;\n }\n \n@@ -537,8 +535,7 @@ static SW *glue(audio_mixeng_backend_open_, TYPE) (\n HW *hw = sw->hw;\n \n if (!hw) {\n- dolog(\"Internal logic error: voice `%s' has no backend\\n\",\n- SW_NAME(sw));\n+ audio_bug(\"Internal logic error: voice '%s' has no backend\", SW_NAME(sw));\n goto fail;\n }\n \ndiff --git a/audio/audio-mixeng-be.c b/audio/audio-mixeng-be.c\nindex 45bcfb74338..87e5a2fc3af 100644\n--- a/audio/audio-mixeng-be.c\n+++ b/audio/audio-mixeng-be.c\n@@ -654,7 +654,7 @@ static size_t audio_mixeng_backend_write(AudioBackend *be, SWVoiceOut *sw,\n hw = sw->hw;\n \n if (!hw->enabled) {\n- dolog(\"Writing to disabled voice %s\\n\", SW_NAME(sw));\n+ warn_report(\"audio: Writing to disabled voice %s\", SW_NAME(sw));\n return 0;\n }\n \n@@ -677,7 +677,7 @@ static size_t audio_mixeng_backend_read(AudioBackend *be,\n hw = sw->hw;\n \n if (!hw->enabled) {\n- dolog(\"Reading from disabled voice %s\\n\", SW_NAME(sw));\n+ warn_report(\"audio: Reading from disabled voice %s\", SW_NAME(sw));\n return 0;\n }\n \n@@ -874,9 +874,8 @@ static void audio_capture_mix_and_clear(HWVoiceOut *hw, size_t rpos,\n sw->empty = sw->total_hw_samples_mixed == 0;\n \n if (to_read - frames_in) {\n- dolog(\"Could not mix %zu frames into a capture \"\n- \"buffer, mixed %zu\\n\",\n- to_read, frames_in);\n+ audio_bug(\"Could not mix %zu frames into a capture \"\n+ \"buffer, mixed %zu\", to_read, frames_in);\n break;\n }\n n -= to_read;\n@@ -1561,7 +1560,7 @@ static CaptureVoiceOut *audio_mixeng_backend_add_capture(\n }\n \n if (!audio_get_pdo_out(s->dev)->mixing_engine) {\n- dolog(\"Can't capture with mixeng disabled\\n\");\n+ error_report(\"audio: Can't capture with mixeng disabled\");\n return NULL;\n }\n \n@@ -1754,8 +1753,7 @@ size_t audio_rate_peek_bytes(RateCtl *rate, struct audio_pcm_info *info)\n void audio_rate_add_bytes(RateCtl *rate, size_t bytes_used)\n {\n if (rate->peeked_frames < 0 || rate->peeked_frames > 65536) {\n- AUD_log(NULL, \"Resetting rate control (%\" PRId64 \" frames)\\n\",\n- rate->peeked_frames);\n+ trace_audio_rate_reset(rate->peeked_frames);\n audio_rate_start(rate);\n }\n \ndiff --git a/audio/trace-events b/audio/trace-events\nindex ed04792d508..222e73c7e88 100644\n--- a/audio/trace-events\n+++ b/audio/trace-events\n@@ -70,6 +70,7 @@ audio_sw_write(const char *name, size_t size, size_t written, size_t total_mixed\n audio_get_free(const char *name, size_t live, size_t dead, uint32_t frontend_frames) \"%s: get_free live %zu dead %zu frontend frames %u\"\n audio_out_disable(void) \"Disabling voice\"\n audio_out_played(size_t played) \"played=%zu\"\n+audio_rate_reset(int64_t frames) \"Resetting rate control (%\" PRId64 \" frames)\"\n \n # audio_template.h\n audio_open_out(const char *name, int freq, int nchannels, int fmt) \"open %s, freq %d, nchannels %d, fmt %d\"\n", "prefixes": [ "82/85" ] }