Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196817/?format=api
{ "id": 2196817, "url": "http://patchwork.ozlabs.org/api/patches/2196817/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-63-e676662e4514@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260216-audio-v1-63-e676662e4514@redhat.com>", "list_archive_url": null, "date": "2026-02-16T11:15:52", "name": "[63/85] audio/jack: replace custom logging with report & trace", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b2957e2c58b068ac8bffe81db6bbefeb48f79ec8", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-63-e676662e4514@redhat.com/mbox/", "series": [ { "id": 492294, "url": "http://patchwork.ozlabs.org/api/series/492294/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492294", "date": "2026-02-16T11:14:52", "name": "audio: cleanups & add a manual test", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492294/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196817/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196817/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=beahFPMw;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF0hx1CdSz1xxp\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 16 Feb 2026 22:21:37 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vrwfU-0007SM-7O; Mon, 16 Feb 2026 06:21:32 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrwcm-00075b-Gx\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:18:46 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrwck-0008Hs-5X\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:18:43 -0500", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-517-PmmclhK9MPSHztIgP2OG1w-1; Mon,\n 16 Feb 2026 06:18:38 -0500", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 623F21955D42; Mon, 16 Feb 2026 11:18:36 +0000 (UTC)", "from localhost (unknown [10.45.242.26])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 5A7A130001A5; Mon, 16 Feb 2026 11:18:35 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771240721;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=3OeZeYhTauS7VhsUmiT8lNq2q4uk8o3wKup878n2xcg=;\n b=beahFPMwQM38f1SoyNOCT7c3yWYTatlShPsWEXVm37Wu0fzV0P0zkOOEVrB/Y7W+HNLZIU\n cS8099rHCEyRAqFwwEU0m9d8b0+sAWY8ax6pTRRgI/uAA6VmPknLBXYicxAz9WfCLYd/47\n h8PimbdXyrkKyZJpY7oECrHwLc5a5TY=", "X-MC-Unique": "PmmclhK9MPSHztIgP2OG1w-1", "X-Mimecast-MFC-AGG-ID": "PmmclhK9MPSHztIgP2OG1w_1771240716", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Mon, 16 Feb 2026 12:15:52 +0100", "Subject": "[PATCH 63/85] audio/jack: replace custom logging with report & trace", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260216-audio-v1-63-e676662e4514@redhat.com>", "References": "<20260216-audio-v1-0-e676662e4514@redhat.com>", "In-Reply-To": "<20260216-audio-v1-0-e676662e4514@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Gerd Hoffmann <kraxel@redhat.com>, Eduardo Habkost <eduardo@habkost.net>,\n Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>,\n Christian Schoenebeck <qemu_oss@crudebyte.com>,\n Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>,\n Thomas Huth <huth@tuxfamily.org>, Alexandre Ratchov <alex@caoua.org>,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Laurent Vivier <laurent@vivier.eu>, \"Michael S. Tsirkin\" <mst@redhat.com>,\n Manos Pitsidianakis <manos.pitsidianakis@linaro.org>,\n Alistair Francis <alistair@alistair23.me>,\n \"Edgar E. Iglesias\" <edgar.iglesias@gmail.com>,\n Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Mark Cave-Ayland <mark.caveayland@nutanix.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=4967;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=tnMUAuR9ZZnzXMT3/4hZtykb2+KAGrajZYT1JRkA5GQ=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvxRdKQiHLFBtMKklXyT0ri2mogrf0CRJLN2W\n MtWyA9Y4MuJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL8UQAKCRDa6OEJdZac\n 5V2HD/43Ec0BC88USxdOBEGpbxPp/j+PvXsJBpkzTzKxTT01rEjMcaT33FYv/9NRx/W1U0V9UNI\n H0FIA4Z8fIUAjBUk7WV13p1wnQhRuVzYW+lB2iQpni6FpLTyU8p23DWC0+5fsfIBU0srgEDib5N\n CWSK0iGPTjbiFYoO2VkNAxt5qaElmU1iECoutYY+KNs36H1/78T5ZqNROW220BRGbBV+VF2aNmd\n tejOz6ssTlRuKl9L5kHFTtTETkCnEIcD6NzsiHCIllCsPQ4sU3Ov2oFlDBxi9j9AJR1h46wy/Sb\n VEsxddNnITSLiikrdeFYwWZSmB8sqbWrWSvzKjr2fNNhJrV3tYuU1wK77ASkxASJOHFhba9bXiN\n S8QA0Xqnc6rqYqE+93SVgiXHGV0FdtIwqU506kFadYnEOnlaKs6pr80kcDhxZS9Mk/ZIrhUrG8s\n hAyWl8a1shMsMBZpxeRAoCM5N22V220gxtN56KIOcGyHOMsU/oaxYO3tl6BEb+u8N5XQsga94L1\n bvZX4EzCjjRXR0pdG5B/cvqiWgFCJGwxbYn2YaE+m4XJCDWdpXWvJmK7NYNdP24j/NZGg6MsHEQ\n JDEKo9lniDw/gnnye9Trki/q94XhhNofhJ7z8UPGxi6+Ys6Jnt7SugrXguxxZGDNpU9g/Ede4p5\n M/sLAwbQG8oQtBg==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Replace the custom audio logging infrastructure with standard QEMU\nerror reporting and tracing.\n\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\nReviewed-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>\n---\n audio/jackaudio.c | 29 +++++++++++++----------------\n audio/trace-events | 9 +++++++++\n 2 files changed, 22 insertions(+), 16 deletions(-)", "diff": "diff --git a/audio/jackaudio.c b/audio/jackaudio.c\nindex e415e94e6e6..a2f725a3232 100644\n--- a/audio/jackaudio.c\n+++ b/audio/jackaudio.c\n@@ -26,11 +26,11 @@\n #include \"qemu/module.h\"\n #include \"qemu/atomic.h\"\n #include \"qemu/main-loop.h\"\n+#include \"qemu/error-report.h\"\n #include \"qemu/audio.h\"\n #include \"qom/object.h\"\n-\n-#define AUDIO_CAP \"jack\"\n #include \"audio_int.h\"\n+#include \"trace.h\"\n \n #include <jack/jack.h>\n #include <jack/thread.h>\n@@ -343,7 +343,7 @@ static void qjack_client_recover(QJackClient *c)\n \n /* if enabled then attempt to recover */\n if (c->enabled) {\n- dolog(\"attempting to reconnect to server\\n\");\n+ trace_jack_client_recover();\n qjack_client_init(c);\n }\n }\n@@ -399,10 +399,10 @@ static void qjack_client_connect_ports(QJackClient *c)\n }\n \n if (c->out) {\n- dolog(\"connect %s -> %s\\n\", p, ports[i]);\n+ trace_jack_connect(p, ports[i]);\n jack_connect(c->client, p, ports[i]);\n } else {\n- dolog(\"connect %s -> %s\\n\", ports[i], p);\n+ trace_jack_connect(ports[i], p);\n jack_connect(c->client, ports[i], p);\n }\n }\n@@ -441,9 +441,9 @@ static int qjack_client_init(QJackClient *c)\n c->opt->server_name);\n \n if (c->client == NULL) {\n- dolog(\"jack_client_open failed: status = 0x%2.0x\\n\", status);\n+ error_report(\"jack: jack_client_open failed: status = 0x%2.0x\", status);\n if (status & JackServerFailed) {\n- dolog(\"unable to connect to JACK server\\n\");\n+ error_report(\"jack: unable to connect to JACK server\");\n }\n return -1;\n }\n@@ -451,12 +451,11 @@ static int qjack_client_init(QJackClient *c)\n c->freq = jack_get_sample_rate(c->client);\n \n if (status & JackServerStarted) {\n- dolog(\"JACK server started\\n\");\n+ trace_jack_server_started();\n }\n \n if (status & JackNameNotUnique) {\n- dolog(\"JACK unique name assigned %s\\n\",\n- jack_get_client_name(c->client));\n+ trace_jack_unique_name(jack_get_client_name(c->client));\n }\n \n /* Allocate working buffer for process callback */\n@@ -536,8 +535,7 @@ static int qjack_init_out(HWVoiceOut *hw, struct audsettings *as)\n };\n audio_pcm_init_info(&hw->info, &os);\n \n- dolog(\"JACK output configured for %dHz (%d samples)\\n\",\n- jo->c.freq, jo->c.buffersize);\n+ trace_jack_out_init(jo->c.freq, jo->c.buffersize);\n \n return 0;\n }\n@@ -572,8 +570,7 @@ static int qjack_init_in(HWVoiceIn *hw, struct audsettings *as)\n };\n audio_pcm_init_info(&hw->info, &is);\n \n- dolog(\"JACK input configured for %dHz (%d samples)\\n\",\n- ji->c.freq, ji->c.buffersize);\n+ trace_jack_in_init(ji->c.freq, ji->c.buffersize);\n \n return 0;\n }\n@@ -654,12 +651,12 @@ static int qjack_thread_creator(jack_native_thread_t *thread,\n \n static void qjack_error(const char *msg)\n {\n- dolog(\"E: %s\\n\", msg);\n+ error_report(\"jack: %s\", msg);\n }\n \n static void qjack_info(const char *msg)\n {\n- dolog(\"I: %s\\n\", msg);\n+ trace_jack_info(msg);\n }\n \n static void audio_jack_class_init(ObjectClass *klass, const void *data)\ndiff --git a/audio/trace-events b/audio/trace-events\nindex b2f29666700..79744456cec 100644\n--- a/audio/trace-events\n+++ b/audio/trace-events\n@@ -28,6 +28,15 @@ dsound_clear_sample(void *p1, uint32_t blen1, uint32_t len1, void *p2, uint32_t\n dsound_wave_format(uint16_t wFormatTag, uint16_t nChannels, uint32_t nSamplesPerSec, uint32_t nAvgBytesPerSec, uint16_t nBlockAlign, uint16_t wBitsPerSample, uint16_t cbSize) \"wFormatTag=%u, nChannels=%u, nSamplesPerSec=%u, nAvgBytesPerSec=%u, nBlockAlign=%u, wBitsPerSample=%u, cbSize=%u\"\n dsound_buffer_bytes(uint32_t caps_bytes, uint32_t desc_bytes) \"caps_bytes=%u, desc_bytes=%u\"\n \n+# jackaudio.c\n+jack_client_recover(void) \"attempting to reconnect to server\"\n+jack_connect(const char *src, const char *dst) \"connect %s -> %s\"\n+jack_server_started(void) \"server started\"\n+jack_unique_name(const char *name) \"unique name assigned %s\"\n+jack_out_init(uint32_t freq, int buffersize) \"output configured for %uHz (%d samples)\"\n+jack_in_init(uint32_t freq, int buffersize) \"input configured for %uHz (%d samples)\"\n+jack_info(const char *msg) \"%s\"\n+\n # pwaudio.c\n pw_state_changed(int nodeid, const char *s) \"node id: %d stream state: %s\"\n pw_read(int32_t avail, uint32_t index, size_t len) \"avail=%d index=%u len=%zu\"\n", "prefixes": [ "63/85" ] }