Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196812/?format=api
{ "id": 2196812, "url": "http://patchwork.ozlabs.org/api/patches/2196812/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-38-e676662e4514@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260216-audio-v1-38-e676662e4514@redhat.com>", "list_archive_url": null, "date": "2026-02-16T11:15:27", "name": "[38/85] audio-be: add common pre-conditions", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6581d4fc62e88212890bc70d38753581763a240a", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-38-e676662e4514@redhat.com/mbox/", "series": [ { "id": 492294, "url": "http://patchwork.ozlabs.org/api/series/492294/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492294", "date": "2026-02-16T11:14:52", "name": "audio: cleanups & add a manual test", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492294/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196812/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196812/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=BAj+uHrC;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF0hf3SkKz1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 16 Feb 2026 22:21:22 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vrweQ-0004LD-LP; Mon, 16 Feb 2026 06:20:27 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrwbb-0005ki-61\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:17:35 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrwbZ-0007zb-Et\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:17:30 -0500", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-423-9uq7PT2NMZmkYNLkkLBUlQ-1; Mon,\n 16 Feb 2026 06:17:26 -0500", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 8791F1956058; Mon, 16 Feb 2026 11:17:24 +0000 (UTC)", "from localhost (unknown [10.45.242.26])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 8F3671800464; Mon, 16 Feb 2026 11:17:23 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771240648;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=14KtznUlIjxeUhZQ3HJFjn608eAk9OXV5ZTi/HQfe2w=;\n b=BAj+uHrClYAJ+ZmOfuCWgYg2SMrWNHDiHXw1KiQ6o8/Usapkjn392xNwN1vdMKgFoEsxLK\n 4+1Xtu+5s1yuqMKAIwgW6nGAmn7eyJltWPbUCvUzndqBIsUm/DQkPVnwm9LFPBqPnyQ1l3\n 3D2+YBMOYzdvRnZKJA+2QjhLZVLXVcE=", "X-MC-Unique": "9uq7PT2NMZmkYNLkkLBUlQ-1", "X-Mimecast-MFC-AGG-ID": "9uq7PT2NMZmkYNLkkLBUlQ_1771240644", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Mon, 16 Feb 2026 12:15:27 +0100", "Subject": "[PATCH 38/85] audio-be: add common pre-conditions", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260216-audio-v1-38-e676662e4514@redhat.com>", "References": "<20260216-audio-v1-0-e676662e4514@redhat.com>", "In-Reply-To": "<20260216-audio-v1-0-e676662e4514@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Gerd Hoffmann <kraxel@redhat.com>, Eduardo Habkost <eduardo@habkost.net>,\n Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>,\n Christian Schoenebeck <qemu_oss@crudebyte.com>,\n Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>,\n Thomas Huth <huth@tuxfamily.org>, Alexandre Ratchov <alex@caoua.org>,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Laurent Vivier <laurent@vivier.eu>, \"Michael S. Tsirkin\" <mst@redhat.com>,\n Manos Pitsidianakis <manos.pitsidianakis@linaro.org>,\n Alistair Francis <alistair@alistair23.me>,\n \"Edgar E. Iglesias\" <edgar.iglesias@gmail.com>,\n Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Mark Cave-Ayland <mark.caveayland@nutanix.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=6032;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=zXuDMfkjGAD2e+OunENZs2O7GncbAFbykUUyFo44jys=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvxQfwdZmV+cpyVDheiWV5K7XQjwx6FCLGFQC\n ngi9xRbxFeJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL8UAAKCRDa6OEJdZac\n 5XQMD/9v89KN9GZbrcrzh/XCa9j3+bB/YHhyc1rytSaKDjw/9NGnAfu2vKs1T9J4AeFR3k+CbK7\n ZnvyKqL/1i0VxFQJtcqU22rw7hb77VVmLG1KLRghlneMYUohOsnVgQ7iSic5WbHViL84g+/GCc7\n QkhwiAadUNhTmWCqjRJG/zCKlDWcDop1wxuDPoODEjyi8OAQsIL/7kszvpXahKHrPVJ0eyo41Sv\n 2EHUSC6nEyjsBAudwJB8OQ26x4OTaLl+suBuA2xVhQBVNrHfd8Tl1AOjHGCmXZM/i0qWwudR9Bv\n b8wmkpVOO874YP0rZDJlBPAvcMf9XJLtOucDTiVdI7N+ySroCv3eLfS98dDb88Kvn/a5IUeQWi6\n Hh/U9Y/Ts3XyekcJVnUJwVfpSbeDI4UG2DkCIGhWFIF7D0ieN8DYFB/HzVwRqbuVSlhR0JSLRtc\n AHVAow7SR0j0VILmj5lXCYDC8805xpRfl8uJsr0UfiPvvMr7m05k+UO3qzg5I35cSOaC8zIf9Yn\n 76l1QJ4a/fbKg1PNzNYUGJBpMrlx/+Q2V/q2do/OF0tSkG7x6ppADgb9ZCePJgUugoua/KedDbw\n jdX6eNSNcdQmOZ66omCUyaZJnGRDxQouXQT4Sy5CuYjCnpRO/ZQsCkEYyZcmEpB1E7mCTyNd9AO\n gHRmv1iBh/OhCcg==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "assert() on valid values, and handle acceptable NULL arguments\ngracefully.\n\nNote audio_driver_write() and audio_driver_read() used to return\nsize (with a \"XXX: Consider options\") when sw was NULL. Imho, it is more\ncorrect to not pretend to have read/written anything by default in the\nAudioBackend base abstract class.\n\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\nReviewed-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>\n---\n audio/audio-be.c | 61 ++++++++++++++++++++++++++++++++++++++++++++++++\n tests/audio/test-audio.c | 8 +++----\n 2 files changed, 64 insertions(+), 5 deletions(-)", "diff": "diff --git a/audio/audio-be.c b/audio/audio-be.c\nindex 4d3b1e2bafd..719dd8cac12 100644\n--- a/audio/audio-be.c\n+++ b/audio/audio-be.c\n@@ -29,6 +29,10 @@ SWVoiceIn *audio_be_open_in(\n {\n AudioBackendClass *klass = AUDIO_BACKEND_GET_CLASS(be);\n \n+ assert(name != NULL);\n+ assert(callback_fn != NULL);\n+ assert(as != NULL);\n+\n return klass->open_in(be, sw, name, callback_opaque, callback_fn, as);\n }\n \n@@ -42,6 +46,10 @@ SWVoiceOut *audio_be_open_out(\n {\n AudioBackendClass *klass = AUDIO_BACKEND_GET_CLASS(be);\n \n+ assert(name != NULL);\n+ assert(callback_fn != NULL);\n+ assert(as != NULL);\n+\n return klass->open_out(be, sw, name, callback_opaque, callback_fn, as);\n }\n \n@@ -49,6 +57,10 @@ void audio_be_close_out(AudioBackend *be, SWVoiceOut *sw)\n {\n AudioBackendClass *klass = AUDIO_BACKEND_GET_CLASS(be);\n \n+ if (!sw) {\n+ return;\n+ }\n+\n return klass->close_out(be, sw);\n }\n \n@@ -56,6 +68,10 @@ void audio_be_close_in(AudioBackend *be, SWVoiceIn *sw)\n {\n AudioBackendClass *klass = AUDIO_BACKEND_GET_CLASS(be);\n \n+ if (!sw) {\n+ return;\n+ }\n+\n return klass->close_in(be, sw);\n }\n \n@@ -63,6 +79,10 @@ bool audio_be_is_active_out(AudioBackend *be, SWVoiceOut *sw)\n {\n AudioBackendClass *klass = AUDIO_BACKEND_GET_CLASS(be);\n \n+ if (!sw) {\n+ return false;\n+ }\n+\n return klass->is_active_out(be, sw);\n }\n \n@@ -70,6 +90,10 @@ bool audio_be_is_active_in(AudioBackend *be, SWVoiceIn *sw)\n {\n AudioBackendClass *klass = AUDIO_BACKEND_GET_CLASS(be);\n \n+ if (!sw) {\n+ return false;\n+ }\n+\n return klass->is_active_in(be, sw);\n }\n \n@@ -77,6 +101,10 @@ size_t audio_be_write(AudioBackend *be, SWVoiceOut *sw, void *buf, size_t size)\n {\n AudioBackendClass *klass = AUDIO_BACKEND_GET_CLASS(be);\n \n+ if (!sw) {\n+ return 0;\n+ }\n+\n return klass->write(be, sw, buf, size);\n }\n \n@@ -84,6 +112,10 @@ size_t audio_be_read(AudioBackend *be, SWVoiceIn *sw, void *buf, size_t size)\n {\n AudioBackendClass *klass = AUDIO_BACKEND_GET_CLASS(be);\n \n+ if (!sw) {\n+ return 0;\n+ }\n+\n return klass->read(be, sw, buf, size);\n }\n \n@@ -91,6 +123,10 @@ int audio_be_get_buffer_size_out(AudioBackend *be, SWVoiceOut *sw)\n {\n AudioBackendClass *klass = AUDIO_BACKEND_GET_CLASS(be);\n \n+ if (!sw) {\n+ return 0;\n+ }\n+\n return klass->get_buffer_size_out(be, sw);\n }\n \n@@ -98,6 +134,10 @@ void audio_be_set_active_out(AudioBackend *be, SWVoiceOut *sw, bool on)\n {\n AudioBackendClass *klass = AUDIO_BACKEND_GET_CLASS(be);\n \n+ if (!sw) {\n+ return;\n+ }\n+\n return klass->set_active_out(be, sw, on);\n }\n \n@@ -105,6 +145,10 @@ void audio_be_set_active_in(AudioBackend *be, SWVoiceIn *sw, bool on)\n {\n AudioBackendClass *klass = AUDIO_BACKEND_GET_CLASS(be);\n \n+ if (!sw) {\n+ return;\n+ }\n+\n return klass->set_active_in(be, sw, on);\n }\n \n@@ -112,6 +156,10 @@ void audio_be_set_volume_out(AudioBackend *be, SWVoiceOut *sw, Volume *vol)\n {\n AudioBackendClass *klass = AUDIO_BACKEND_GET_CLASS(be);\n \n+ if (!sw) {\n+ return;\n+ }\n+\n klass->set_volume_out(be, sw, vol);\n }\n \n@@ -119,6 +167,10 @@ void audio_be_set_volume_in(AudioBackend *be, SWVoiceIn *sw, Volume *vol)\n {\n AudioBackendClass *klass = AUDIO_BACKEND_GET_CLASS(be);\n \n+ if (!sw) {\n+ return;\n+ }\n+\n klass->set_volume_in(be, sw, vol);\n }\n \n@@ -130,6 +182,9 @@ CaptureVoiceOut *audio_be_add_capture(\n {\n AudioBackendClass *klass = AUDIO_BACKEND_GET_CLASS(be);\n \n+ assert(as != NULL);\n+ assert(ops != NULL);\n+\n return klass->add_capture(be, as, ops, cb_opaque);\n }\n \n@@ -137,6 +192,10 @@ void audio_be_del_capture(AudioBackend *be, CaptureVoiceOut *cap, void *cb_opaqu\n {\n AudioBackendClass *klass = AUDIO_BACKEND_GET_CLASS(be);\n \n+ if (!cap) {\n+ return;\n+ }\n+\n klass->del_capture(be, cap, cb_opaque);\n }\n \n@@ -155,6 +214,8 @@ bool audio_be_set_dbus_server(AudioBackend *be,\n {\n AudioBackendClass *klass = AUDIO_BACKEND_GET_CLASS(be);\n \n+ assert(server != NULL);\n+\n if (!audio_be_can_set_dbus_server(be)) {\n error_setg(errp, \"Audiodev '%s' is not compatible with DBus\",\n audio_be_get_id(be));\ndiff --git a/tests/audio/test-audio.c b/tests/audio/test-audio.c\nindex 1827c084ac8..90d96ae0575 100644\n--- a/tests/audio/test-audio.c\n+++ b/tests/audio/test-audio.c\n@@ -493,11 +493,9 @@ static void test_audio_null_handling(void)\n /* audio_be_get_buffer_size_out(NULL) should return 0 */\n g_assert_cmpint(audio_be_get_buffer_size_out(be, NULL), ==, 0);\n \n- /* audio_be_write/read(NULL, ...) should return size (no-op) */\n- g_assert_cmpuint(audio_be_write(be, NULL, buffer, sizeof(buffer)), ==,\n- sizeof(buffer));\n- g_assert_cmpuint(audio_be_read(be, NULL, buffer, sizeof(buffer)), ==,\n- sizeof(buffer));\n+ /* audio_be_write/read(NULL, ...) should return 0 */\n+ g_assert_cmpuint(audio_be_write(be, NULL, buffer, sizeof(buffer)), ==, 0);\n+ g_assert_cmpuint(audio_be_read(be, NULL, buffer, sizeof(buffer)), ==, 0);\n \n /* These should not crash */\n audio_be_set_active_out(be, NULL, true);\n", "prefixes": [ "38/85" ] }