Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196801/?format=api
{ "id": 2196801, "url": "http://patchwork.ozlabs.org/api/patches/2196801/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-16-e676662e4514@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260216-audio-v1-16-e676662e4514@redhat.com>", "list_archive_url": null, "date": "2026-02-16T11:15:05", "name": "[16/85] scripts/modinfo: add --skip-missing-deps", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "73d04d810c6a50237b101558f08dfa51a4d1e673", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-16-e676662e4514@redhat.com/mbox/", "series": [ { "id": 492294, "url": "http://patchwork.ozlabs.org/api/series/492294/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492294", "date": "2026-02-16T11:14:52", "name": "audio: cleanups & add a manual test", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492294/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196801/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196801/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Ca+erjM2;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF0fg0HSMz1xtN\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 16 Feb 2026 22:19:39 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vrwdW-0000GO-QR; Mon, 16 Feb 2026 06:19:30 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrwaj-0005Hs-Tx\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:17:05 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrwad-0007RW-Gb\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:16:32 -0500", "from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-112-mWSuph5cO9-5d6ohy55CpQ-1; Mon,\n 16 Feb 2026 06:16:25 -0500", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id AE85B1800365; Mon, 16 Feb 2026 11:16:23 +0000 (UTC)", "from localhost (unknown [10.45.242.26])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 1262A30001B9; Mon, 16 Feb 2026 11:16:22 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771240590;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=KCugop36CLelcrOMKIrKRT8HBbv47hNoq//wkZ62yVs=;\n b=Ca+erjM2yp/PiFS1jEuPyWh/BVf/FN4SSJ8HNfho1ZukNCvE+RMK7s4Mfa1gkZsNKlB8J5\n jFLWuUlZW1o9hXxUG3t0pGowrA4fmUrlp+Do5YEhzG2G4oQQ01HnjzzM0j1dwXEYlErWT0\n 6Gr2ArKuuB5CzZZYfk6sYevHSlM16Ik=", "X-MC-Unique": "mWSuph5cO9-5d6ohy55CpQ-1", "X-Mimecast-MFC-AGG-ID": "mWSuph5cO9-5d6ohy55CpQ_1771240583", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Mon, 16 Feb 2026 12:15:05 +0100", "Subject": "[PATCH 16/85] scripts/modinfo: add --skip-missing-deps", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260216-audio-v1-16-e676662e4514@redhat.com>", "References": "<20260216-audio-v1-0-e676662e4514@redhat.com>", "In-Reply-To": "<20260216-audio-v1-0-e676662e4514@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Gerd Hoffmann <kraxel@redhat.com>, Eduardo Habkost <eduardo@habkost.net>,\n Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>,\n Christian Schoenebeck <qemu_oss@crudebyte.com>,\n Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>,\n Thomas Huth <huth@tuxfamily.org>, Alexandre Ratchov <alex@caoua.org>,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Laurent Vivier <laurent@vivier.eu>, \"Michael S. Tsirkin\" <mst@redhat.com>,\n Manos Pitsidianakis <manos.pitsidianakis@linaro.org>,\n Alistair Francis <alistair@alistair23.me>,\n \"Edgar E. Iglesias\" <edgar.iglesias@gmail.com>,\n Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Mark Cave-Ayland <mark.caveayland@nutanix.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=5639;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=ygcT/EP4LKFFbInc5HK8ho4Iw+AmP0MuGXSJiZYYmoc=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvxOHXNZrYPKLzyeQ8z6X6VU5BDpOUyVsw41/\n lYzr9uHeLKJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL8TgAKCRDa6OEJdZac\n 5fOoEACgLqwVa2Yp4SD81nT3uP6DNRwMv/bm+MDEtr03Tx3ZpY+cbGI9AqrnKs+PZXvncHYc/2X\n xNBAGp0uSQjaqqtYp5aG2QySNKk4rzm2woekbwTAyxZqqGd4uyVoA9hy7nhdbhqd0KlDojH5nEZ\n 3XlgBUTReQXcu2FS9gfwWuyl3KAMl2yBNvbMPjy5wpKDTe1qXdeKMEz1awemtRfR6ZL9xQlllSm\n HvpJVmhoxBrAmyCt/6ai4HAKMsev/TLAdahGsDnUgWssGt+ClYyUU2emrZjJIBPwVIKYOgG/yiH\n bvhaTZSK9eNORZ4SdBrxQEG4b0kna1P3qBUXb7B81fJl+5CsfgloftTDPC7+eLYPyIlWdHchKpt\n z1UyQMNMbzXorpK/UJWzVs5hFX+lKBrnWAX0Myi2L95391uDWc8/FMTE7/QNgYvInnZU3KkJjy+\n k6vRD+Uii4YLWW1dgD0nwxilI+B6+1/H2sC3GsDHHZWUYyb2vlQZg2ToxoprAn/+2zeeq9GcTnV\n lNi+UPlD4IXv+bKk/Qb7D5PpKiSOvphPjkez9Yd4VQl7BNJ8dTJOeIv/cxJHBaZKjXmw40rEvOn\n OH9eWKy2JU7tMetm4ZjB4L5S/FflfJblgGv0s9b5o/ttsF8nw39j6x4AuFoDFz31CUZviLJAzw+\n JHQyglWo+elR1bg==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Add --skip-missing-deps flag that prints warnings for missing\ndependencies but continues without exiting with error code 1.\n\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\nAcked-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>\n---\n scripts/modinfo-generate.py | 94 ++++++++++++++++++++++++++++++++++-----------\n 1 file changed, 71 insertions(+), 23 deletions(-)", "diff": "diff --git a/scripts/modinfo-generate.py b/scripts/modinfo-generate.py\nindex e7d35242414..e231c129196 100644\n--- a/scripts/modinfo-generate.py\n+++ b/scripts/modinfo-generate.py\n@@ -34,7 +34,8 @@ def parse_line(line: str) -> tuple[str, str]:\n continue\n return (kind, data)\n \n-def generate(name: str, lines: list[str], enabled: set[str]) -> Optional[set[str]]:\n+def parse_modinfo(name: str, lines: list[str], enabled: set[str]) -> Optional[dict]:\n+ \"\"\"Parse a modinfo file and return module metadata, or None if disabled.\"\"\"\n arch = \"\"\n objs = []\n deps = []\n@@ -54,21 +55,39 @@ def generate(name: str, lines: list[str], enabled: set[str]) -> Optional[set[str\n # don't add a module which dependency is not enabled\n # in kconfig\n if data.strip() not in enabled:\n- print(f\" /* module {data.strip()} isn't enabled in Kconfig. */\")\n- print(\"/* },{ */\")\n return None\n else:\n print(\"unknown:\", kind)\n exit(1)\n \n- print(f' .name = \"{name}\",')\n- if arch != \"\":\n- print(f\" .arch = {arch},\")\n- print_array(\"objs\", objs)\n- print_array(\"deps\", deps)\n- print_array(\"opts\", opts)\n+ return {\n+ 'name': name,\n+ 'arch': arch,\n+ 'objs': objs,\n+ 'deps': deps,\n+ 'opts': opts,\n+ 'dep_names': {dep.strip('\" ') for dep in deps}\n+ }\n+\n+def generate(modinfo: str, mod: Optional[dict],\n+ skip_reason: Optional[str]) -> None:\n+ \"\"\"Generate C code for a module.\"\"\"\n+ print(f\" /* {modinfo} */\")\n+ if mod is None:\n+ if skip_reason == \"missing_deps\":\n+ print(\" /* module has missing dependencies. */\")\n+ else:\n+ print(\" /* module isn't enabled in Kconfig. */\")\n+ print(\"/* },{ */\")\n+ return\n+\n+ print(f' .name = \"{mod[\"name\"]}\",')\n+ if mod['arch'] != \"\":\n+ print(f\" .arch = {mod['arch']},\")\n+ print_array(\"objs\", mod['objs'])\n+ print_array(\"deps\", mod['deps'])\n+ print_array(\"opts\", mod['opts'])\n print(\"},{\")\n- return {dep.strip('\" ') for dep in deps}\n \n def print_pre() -> None:\n print(\"/* generated by scripts/modinfo-generate.py */\")\n@@ -86,6 +105,8 @@ def main() -> None:\n )\n parser.add_argument('--devices',\n help='path to config-device.mak')\n+ parser.add_argument('--skip-missing-deps', action='store_true',\n+ help='warn if a dependency is missing and continue')\n parser.add_argument('modinfo', nargs='+',\n help='modinfo files to process')\n args = parser.parse_args()\n@@ -99,27 +120,54 @@ def main() -> None:\n if config[1].rstrip() == 'y':\n enabled.add(config[0][7:]) # remove CONFIG_\n \n- deps = set()\n- modules = set()\n- print_pre()\n+ # all_modules: modinfo path -> (basename, parsed module or None, skip_reason)\n+ all_modules = {}\n for modinfo in args.modinfo:\n with open(modinfo) as f:\n lines = f.readlines()\n- print(f\" /* {modinfo} */\")\n (basename, _) = os.path.splitext(modinfo)\n- moddeps = generate(basename, lines, enabled)\n- if moddeps is not None:\n- modules.add(basename)\n- deps.update(moddeps)\n- print_post()\n+ mod = parse_modinfo(basename, lines, enabled)\n+ skip_reason = \"kconfig\" if mod is None else None\n+ all_modules[modinfo] = (basename, mod, skip_reason)\n+\n+ # Collect all available module names\n+ available = {basename for basename, mod, _ in all_modules.values()\n+ if mod is not None}\n \n- error = False\n- for dep in deps.difference(modules):\n+ # Collect all dependencies\n+ all_deps = set()\n+ for basename, mod, _ in all_modules.values():\n+ if mod is not None:\n+ all_deps.update(mod['dep_names'])\n+\n+ # Check for missing dependencies\n+ missing = all_deps.difference(available)\n+ for dep in missing:\n print(f\"Dependency {dep} cannot be satisfied\", file=sys.stderr)\n- error = True\n \n- if error:\n+ if missing and not args.skip_missing_deps:\n exit(1)\n \n+ # When skipping missing deps, iteratively remove modules with\n+ # unsatisfiable dependencies\n+ if args.skip_missing_deps and missing:\n+ changed = True\n+ while changed:\n+ changed = False\n+ for modinfo, (basename, mod, skip_reason) in list(all_modules.items()):\n+ if mod is None:\n+ continue\n+ if not mod['dep_names'].issubset(available):\n+ available.discard(basename)\n+ all_modules[modinfo] = (basename, None, \"missing_deps\")\n+ changed = True\n+\n+ # generate output\n+ print_pre()\n+ for modinfo in args.modinfo:\n+ (basename, mod, skip_reason) = all_modules[modinfo]\n+ generate(modinfo, mod, skip_reason)\n+ print_post()\n+\n if __name__ == \"__main__\":\n main()\n", "prefixes": [ "16/85" ] }