Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196798/?format=api
{ "id": 2196798, "url": "http://patchwork.ozlabs.org/api/patches/2196798/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-4-e676662e4514@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260216-audio-v1-4-e676662e4514@redhat.com>", "list_archive_url": null, "date": "2026-02-16T11:14:53", "name": "[04/85] audio/dbus: make \"dbus\" the default backend when using -display dbus", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b1baabaf73c85991404b69e61d99c2b0bfbe5406", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-4-e676662e4514@redhat.com/mbox/", "series": [ { "id": 492294, "url": "http://patchwork.ozlabs.org/api/series/492294/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492294", "date": "2026-02-16T11:14:52", "name": "audio: cleanups & add a manual test", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492294/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196798/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196798/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=AIz/btq0;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF0f804dhz1xtN\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 16 Feb 2026 22:19:12 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vrwa6-0004ma-PT; Mon, 16 Feb 2026 06:15:58 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrwa4-0004lb-DT\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:15:56 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrwa2-0007Ji-AI\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:15:56 -0500", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-452-WlHKukHPNKiwgDbFuE7VgQ-1; Mon,\n 16 Feb 2026 06:15:50 -0500", "from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 4409719560B2; Mon, 16 Feb 2026 11:15:48 +0000 (UTC)", "from localhost (unknown [10.45.242.26])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 9BDD019560A2; Mon, 16 Feb 2026 11:15:47 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771240553;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=TQTKsJe+H0JmAEbmIdQJvVw5lqnUUPR6AFifO+6umuY=;\n b=AIz/btq0KIH9fBPBxN7ONXn+va/nUrALzVPPN4sOc9V/pZ8OcCR1WbQudLC7e+L20tuWtE\n lJGx8pjH1fX62PfUiPYWWV0hFG2wsG53P7JWegzC59IEcH9OcX5GAnU6QI+zWJJdxOHpzJ\n T928Fs0cbZMd6stc88Ruzp/6WsJHqp0=", "X-MC-Unique": "WlHKukHPNKiwgDbFuE7VgQ-1", "X-Mimecast-MFC-AGG-ID": "WlHKukHPNKiwgDbFuE7VgQ_1771240548", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Mon, 16 Feb 2026 12:14:53 +0100", "Subject": "[PATCH 04/85] audio/dbus: make \"dbus\" the default backend when\n using -display dbus", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260216-audio-v1-4-e676662e4514@redhat.com>", "References": "<20260216-audio-v1-0-e676662e4514@redhat.com>", "In-Reply-To": "<20260216-audio-v1-0-e676662e4514@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Gerd Hoffmann <kraxel@redhat.com>, Eduardo Habkost <eduardo@habkost.net>,\n Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>,\n Christian Schoenebeck <qemu_oss@crudebyte.com>,\n Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>,\n Thomas Huth <huth@tuxfamily.org>, Alexandre Ratchov <alex@caoua.org>,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Laurent Vivier <laurent@vivier.eu>, \"Michael S. Tsirkin\" <mst@redhat.com>,\n Manos Pitsidianakis <manos.pitsidianakis@linaro.org>,\n Alistair Francis <alistair@alistair23.me>,\n \"Edgar E. Iglesias\" <edgar.iglesias@gmail.com>,\n Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Mark Cave-Ayland <mark.caveayland@nutanix.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=3368;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=i0hZV7AIfgA8SuFqO30DlmD20T1D7KstDiHR2TRDsyg=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvxOjI4h00rSui2Rb0WXtwvFdNIDvuQWGaEkY\n Dk/2hw+feaJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL8TgAKCRDa6OEJdZac\n 5XPyEACk3jplro9UmB+SMonTa5N8UUYgLik3j3qZoeg8vDsKCsCksav3E995HKv41rj/FcTkydl\n edVc022hab9KCZmexplrB3uZ2GtGzNAhTieFPzeRENWBfgppc+0ngp4KT2f5npPVnBJfBn9wzPX\n e50DMTOmSFA+iO4WVzrFPWHeZS8aodZeu/KZkPzAk/j9GLsUg3Ep02EJfaTTkfAnzr3GoOtRHN4\n a3BlijkBRWQdWt7Ia5a7rgEuhXT7jpIIHbDqPpqperJxlG641+RvSgt+jUJ4oEhuA74dq4MNXIf\n OroHkt2VWw5I6iyeV0NNEgo5gnsInGPxCCP+yO6iDOSrQ8inCCgF2CxHHxyxaEn6HBg4iLUnJki\n D0xgHTsTTUTm5Mx0nM8lbcz6ZRPOrxiO2HrpiMZw/9QrLRpoOWQaCgmHnJciam/gltxcyPxVr+6\n af7A4wfFwrv2EvPAvcAMqdxiXM15g2KzHhZWOd4qSWIpdgrs6pOpZmqVuSX4TqD2x011JyEmEtX\n Loj8pdWMz7BadQSTzxYnZ9EzX1NwTUp96QYywcj7wrnFIBFNHcrIeygMPgh7DMeNq1YMYIIKzP5\n UaL8mZrdXHxotWOcVGQV7MEqWq32QI10d7d+y/muzHJmv2R4AeYLsoEWQGUW09ZBd3OX025rySs\n v2Tc9NYJTyHijtg==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.12", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Set \"using_dbus_display\" during early_dbus_init(), so that we can try to\ncreate the \"dbus\" audio backend by default from audio_prio_list.\n\nThis makes dbus audio work by default when using an audio device,\nwithout having to setup and wire up the -audiodev manually.\n\nThe added FIXME is addressed in the following commits.\n\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\nReviewed-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>\n---\n audio/audio.c | 3 +++\n audio/dbusaudio.c | 8 +++++++-\n ui/dbus.c | 22 +++++++++++++++++-----\n 3 files changed, 27 insertions(+), 6 deletions(-)", "diff": "diff --git a/audio/audio.c b/audio/audio.c\nindex a218570a4f4..9563583cd1e 100644\n--- a/audio/audio.c\n+++ b/audio/audio.c\n@@ -58,6 +58,9 @@\n that we generate the list.\n */\n const char *audio_prio_list[] = {\n+#ifdef CONFIG_GIO\n+ \"dbus\",\n+#endif\n \"spice\",\n CONFIG_AUDIO_DRIVERS\n \"none\",\ndiff --git a/audio/dbusaudio.c b/audio/dbusaudio.c\nindex d729a810aa6..1fe7c4ed647 100644\n--- a/audio/dbusaudio.c\n+++ b/audio/dbusaudio.c\n@@ -32,6 +32,7 @@\n #endif\n \n #include \"ui/dbus.h\"\n+#include \"ui/dbus-display.h\"\n #include \"ui/dbus-display1.h\"\n \n #define AUDIO_CAP \"dbus\"\n@@ -408,8 +409,13 @@ dbus_enable_in(HWVoiceIn *hw, bool enable)\n static void *\n dbus_audio_init(Audiodev *dev, Error **errp)\n {\n- DBusAudio *da = g_new0(DBusAudio, 1);\n+ DBusAudio *da;\n \n+ if (!qemu_using_dbus_display(errp)) {\n+ return NULL;\n+ }\n+\n+ da = g_new0(DBusAudio, 1);\n da->dev = dev;\n da->out_listeners = g_hash_table_new_full(g_str_hash, g_str_equal,\n g_free, g_object_unref);\ndiff --git a/ui/dbus.c b/ui/dbus.c\nindex 31f6eb1189f..0be1931d208 100644\n--- a/ui/dbus.c\n+++ b/ui/dbus.c\n@@ -35,6 +35,7 @@\n #include \"ui/egl-context.h\"\n #endif\n #include \"qemu/audio.h\"\n+#include \"audio/audio_int.h\" /* FIXME: use QOM dynamic cast instead of drv->name */\n #include \"qapi/error.h\"\n #include \"trace.h\"\n \n@@ -218,9 +219,20 @@ dbus_display_complete(UserCreatable *uc, Error **errp)\n return;\n }\n \n- if (dd->audiodev && *dd->audiodev) {\n- AudioBackend *audio_be = audio_be_by_name(dd->audiodev, errp);\n- if (!audio_be || !audio_be_set_dbus_server(audio_be, dd->server, dd->p2p, errp)) {\n+ {\n+ AudioBackend *audio_be = audio_get_default_audio_be(NULL);\n+\n+ if (audio_be && !g_str_equal(audio_be->drv->name, \"dbus\")) {\n+ audio_be = NULL;\n+ }\n+ if (dd->audiodev && *dd->audiodev) {\n+ audio_be = audio_be_by_name(dd->audiodev, errp);\n+ if (!audio_be) {\n+ return;\n+ }\n+ }\n+ if (audio_be &&\n+ !audio_be_set_dbus_server(audio_be, dd->server, dd->p2p, errp)) {\n return;\n }\n }\n@@ -475,6 +487,8 @@ early_dbus_init(DisplayOptions *opts)\n #endif\n }\n \n+ using_dbus_display = 1;\n+\n type_register_static(&dbus_vc_type_info);\n }\n \n@@ -488,8 +502,6 @@ dbus_init(DisplayState *ds, DisplayOptions *opts)\n exit(1);\n }\n \n- using_dbus_display = 1;\n-\n object_new_with_props(TYPE_DBUS_DISPLAY,\n object_get_objects_root(),\n \"dbus-display\", &error_fatal,\n", "prefixes": [ "04/85" ] }