Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196773/?format=api
{ "id": 2196773, "url": "http://patchwork.ozlabs.org/api/patches/2196773/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-1-edcb25699381@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260216-audio-v1-1-edcb25699381@redhat.com>", "list_archive_url": null, "date": "2026-02-16T10:42:13", "name": "[01/85] audio: remove obsolete/obscure functions", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "8cca52fa01bee4a5ff9b7d8a83c1248afbe96ea9", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-1-edcb25699381@redhat.com/mbox/", "series": [ { "id": 492288, "url": "http://patchwork.ozlabs.org/api/series/492288/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492288", "date": "2026-02-16T10:42:12", "name": "audio: cleanups & add a manual test", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492288/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196773/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196773/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=LhMF5Oey;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fDzsh1mGhz1xwF\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 16 Feb 2026 21:44:08 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vrw4N-0001sl-Jz; Mon, 16 Feb 2026 05:43:13 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrw40-0001pM-8Z\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 05:42:49 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrw3y-0000y7-Fl\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 05:42:47 -0500", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-470-9TXNNgeLMJaY5VQgo5FWBQ-1; Mon,\n 16 Feb 2026 05:42:41 -0500", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id E23E6195DE50; Mon, 16 Feb 2026 10:42:38 +0000 (UTC)", "from localhost (unknown [10.45.242.26])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id A0A3E1955F43; Mon, 16 Feb 2026 10:42:37 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771238565;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=a+cxlaNFYy99fV6iC6NoJX8UA3JXNvcFW8aev589keg=;\n b=LhMF5OeycUcLyQ6XJzWz4yOsZ0s6ptmylL4s+TAcuXCAgcBO1QxO28hW/UEas8b0wM7h54\n Ny71jiu0XdCP2DN9JkHPR0cGoTxtTz6raZ6s4530eCd+838+PXfzxrw8uR0Y5uREuC5JTx\n hJIDVG49WKXEyOXQJvNNvvjCs1AjgPI=", "X-MC-Unique": "9TXNNgeLMJaY5VQgo5FWBQ-1", "X-Mimecast-MFC-AGG-ID": "9TXNNgeLMJaY5VQgo5FWBQ_1771238559", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Mon, 16 Feb 2026 11:42:13 +0100", "Subject": "[PATCH 01/85] audio: remove obsolete/obscure functions", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260216-audio-v1-1-edcb25699381@redhat.com>", "References": "<20260216-audio-v1-0-edcb25699381@redhat.com>", "In-Reply-To": "<20260216-audio-v1-0-edcb25699381@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Gerd Hoffmann <kraxel@redhat.com>, Eduardo Habkost <eduardo@habkost.net>,\n Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>,\n Christian Schoenebeck <qemu_oss@crudebyte.com>,\n Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>,\n Thomas Huth <huth@tuxfamily.org>, Alexandre Ratchov <alex@caoua.org>,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Laurent Vivier <laurent@vivier.eu>, \"Michael S. Tsirkin\" <mst@redhat.com>,\n Manos Pitsidianakis <manos.pitsidianakis@linaro.org>,\n Alistair Francis <alistair@alistair23.me>,\n \"Edgar E. Iglesias\" <edgar.iglesias@gmail.com>,\n Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Mark Cave-Ayland <mark.caveayland@nutanix.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=4945;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=uYrPkyR2tbIVOyryH+czFSaxcbDkF6UtkEqgWhCJ+H4=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvSSpgr3KXvBW/Uuue5UDXDuIDk3G1LZmXvF6\n jtx43sDOSmJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL0kgAKCRDa6OEJdZac\n 5UybD/0R3v2fVDEOAX71TfgWzEMJ+BVr9MMlF36LnZwNCbPefK58Bj4FQdun3h6bymu8pieS/fp\n fpy5Slj0xQhOOvWGwR7JoYwpyY0TLXgdHg4OK+E99El+BEo+963I+wRMTL0VzjZJWhs8YX5CAp2\n dNIo+ZUqEocIc8NopNbvxDMORMQfVeT2DmP+ff7KwYeBSg0wAjjBCFK1NIQVNZBxPSv4ThzbAXy\n PRvppcgq0oLVAlrEpaQnXXCt3BXkhD5/9xe7OMdNeo9WU5oynJhkLGSz6ZYpf3ZeblAU81viu/9\n yxwZ7kbkC3ei6w9d9TWIQwf9PMHEtEDV0CW+pA9nri7AQPup/Gh0tb4uzBi6ryHnT0yafz2ACYB\n nZoUgL88AFFlsKNDWM6Ha02+Bx8wIoAFdTb2OHTyymIVWcDbJY4uW2f9hwBmf8uO/MJGHTlMl1o\n MJoybXI7arZEIZaiMqIjRjxXYjJS4MZF9e+3q7vuQ8/JJcz5bIazhoS+W9efrz2EoyvI7dG7s+q\n nLqcgmldCHRIv+wHq9eO3ISWBRnX46Aal++Th07bixJpd9KCfDOotht0FokG3J7qf1ugQ3ovtPc\n YBD9BCKFU2o9AdsPc7UrYRw7MsspVfxlIdJ6n0JevDVLeNNv8pjwPqpKnOVitW6gt0UTx8k+QfG\n p5JOFa7fjlHZX3w==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "AUD_init_time_stamp_{in,out} and AUD_get_elapsed_usec_{in,out} are only\nused by the adlib device. The result isn't actually being used since\nADLIB_KILL_TIMERS was set some 20y ago. Let's drop this dead code now.\n\nDrop QEMUAudioTimeStamp as well as reported by Akihiko Odaki.\n\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\nReviewed-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>\n---\n audio/audio_template.h | 34 ----------------------\n include/qemu/audio.h | 10 -------\n hw/audio/adlib.c | 18 +-----------\n .../codeconverter/codeconverter/test_regexps.py | 1 -\n 4 files changed, 1 insertion(+), 62 deletions(-)", "diff": "diff --git a/audio/audio_template.h b/audio/audio_template.h\nindex 7a8c431f2d7..1ab3c47fd76 100644\n--- a/audio/audio_template.h\n+++ b/audio/audio_template.h\n@@ -569,40 +569,6 @@ bool glue(AUD_is_active_, TYPE)(SW *sw)\n return sw ? sw->active : 0;\n }\n \n-void glue (AUD_init_time_stamp_, TYPE) (SW *sw, QEMUAudioTimeStamp *ts)\n-{\n- if (!sw) {\n- return;\n- }\n-\n- ts->old_ts = sw->hw->ts_helper;\n-}\n-\n-uint64_t glue (AUD_get_elapsed_usec_, TYPE) (SW *sw, QEMUAudioTimeStamp *ts)\n-{\n- uint64_t delta, cur_ts, old_ts;\n-\n- if (!sw) {\n- return 0;\n- }\n-\n- cur_ts = sw->hw->ts_helper;\n- old_ts = ts->old_ts;\n- /* dolog (\"cur %\" PRId64 \" old %\" PRId64 \"\\n\", cur_ts, old_ts); */\n-\n- if (cur_ts >= old_ts) {\n- delta = cur_ts - old_ts;\n- } else {\n- delta = UINT64_MAX - old_ts + cur_ts;\n- }\n-\n- if (!delta) {\n- return 0;\n- }\n-\n- return muldiv64 (delta, sw->hw->info.freq, 1000000);\n-}\n-\n #undef TYPE\n #undef HW\n #undef SW\ndiff --git a/include/qemu/audio.h b/include/qemu/audio.h\nindex a92e0b70ef0..a1a64ad340d 100644\n--- a/include/qemu/audio.h\n+++ b/include/qemu/audio.h\n@@ -50,10 +50,6 @@ struct AudioBackendClass {\n \n typedef struct AudioBackend AudioBackend;\n \n-typedef struct QEMUAudioTimeStamp {\n- uint64_t old_ts;\n-} QEMUAudioTimeStamp;\n-\n bool AUD_backend_check(AudioBackend **be, Error **errp);\n \n SWVoiceOut *AUD_open_out (\n@@ -71,9 +67,6 @@ int AUD_get_buffer_size_out (SWVoiceOut *sw);\n void AUD_set_active_out(SWVoiceOut *sw, bool on);\n bool AUD_is_active_out(SWVoiceOut *sw);\n \n-void AUD_init_time_stamp_out (SWVoiceOut *sw, QEMUAudioTimeStamp *ts);\n-uint64_t AUD_get_elapsed_usec_out (SWVoiceOut *sw, QEMUAudioTimeStamp *ts);\n-\n #define AUDIO_MAX_CHANNELS 16\n typedef struct Volume {\n bool mute;\n@@ -112,9 +105,6 @@ size_t AUD_read (SWVoiceIn *sw, void *pcm_buf, size_t size);\n void AUD_set_active_in(SWVoiceIn *sw, bool on);\n bool AUD_is_active_in(SWVoiceIn *sw);\n \n-void AUD_init_time_stamp_in (SWVoiceIn *sw, QEMUAudioTimeStamp *ts);\n-uint64_t AUD_get_elapsed_usec_in (SWVoiceIn *sw, QEMUAudioTimeStamp *ts);\n-\n void audio_cleanup(void);\n \n typedef struct st_sample st_sample;\ndiff --git a/hw/audio/adlib.c b/hw/audio/adlib.c\nindex 8b9fe53e17b..efab5107a4c 100644\n--- a/hw/audio/adlib.c\n+++ b/hw/audio/adlib.c\n@@ -34,8 +34,6 @@\n \n #define DEBUG 0\n \n-#define ADLIB_KILL_TIMERS 1\n-\n #define ADLIB_DESC \"Yamaha YM3812 (OPL2)\"\n \n #if DEBUG\n@@ -71,7 +69,6 @@ struct AdlibState {\n uint64_t dexp[2];\n SWVoiceOut *voice;\n int left, pos, samples;\n- QEMUAudioTimeStamp ats;\n FM_OPL *opl;\n PortioList port_list;\n };\n@@ -88,19 +85,7 @@ static void adlib_kill_timers (AdlibState *s)\n \n for (i = 0; i < 2; ++i) {\n if (s->ticking[i]) {\n- uint64_t delta;\n-\n- delta = AUD_get_elapsed_usec_out (s->voice, &s->ats);\n- ldebug (\n- \"delta = %f dexp = %f expired => %d\",\n- delta / 1000000.0,\n- s->dexp[i] / 1000000.0,\n- delta >= s->dexp[i]\n- );\n- if (ADLIB_KILL_TIMERS || delta >= s->dexp[i]) {\n- adlib_stop_opl_timer (s, i);\n- AUD_init_time_stamp_out (s->voice, &s->ats);\n- }\n+ adlib_stop_opl_timer(s, i);\n }\n }\n }\n@@ -149,7 +134,6 @@ static void timer_handler (void *opaque, int c, double interval_Sec)\n #endif\n \n s->dexp[n] = interval_Sec * 1000000.0;\n- AUD_init_time_stamp_out (s->voice, &s->ats);\n }\n \n static int write_audio (AdlibState *s, int samples)\ndiff --git a/scripts/codeconverter/codeconverter/test_regexps.py b/scripts/codeconverter/codeconverter/test_regexps.py\nindex 2b9f5b80111..f92389e9618 100644\n--- a/scripts/codeconverter/codeconverter/test_regexps.py\n+++ b/scripts/codeconverter/codeconverter/test_regexps.py\n@@ -202,7 +202,6 @@ def test_struct_re():\n uint64_t dexp[2];\n SWVoiceOut *voice;\n int left, pos, samples;\n- QEMUAudioTimeStamp ats;\n FM_OPL *opl;\n PortioList port_list;\n } AdlibState;\n", "prefixes": [ "01/85" ] }