Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196769/?format=api
{ "id": 2196769, "url": "http://patchwork.ozlabs.org/api/patches/2196769/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-3-edcb25699381@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260216-audio-v1-3-edcb25699381@redhat.com>", "list_archive_url": null, "date": "2026-02-16T10:42:15", "name": "[03/85] audio/adlib: drop ts_helper HWVoice field", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "2756206ffa821ae8d5ca7c65f06b04f6fb68eaa9", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-3-edcb25699381@redhat.com/mbox/", "series": [ { "id": 492288, "url": "http://patchwork.ozlabs.org/api/series/492288/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492288", "date": "2026-02-16T10:42:12", "name": "audio: cleanups & add a manual test", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492288/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196769/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196769/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=etFBudC8;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fDzsB5jFDz1xwF\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 16 Feb 2026 21:43:42 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vrw4U-0001vB-DJ; Mon, 16 Feb 2026 05:43:18 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrw47-0001qm-LQ\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 05:42:59 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vrw44-0000z2-4l\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 05:42:54 -0500", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-547-I8kpWs3NOQSmNHtSG_9e0Q-1; Mon,\n 16 Feb 2026 05:42:47 -0500", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id A340F195FDD1; Mon, 16 Feb 2026 10:42:45 +0000 (UTC)", "from localhost (unknown [10.45.242.26])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 36DE71800464; Mon, 16 Feb 2026 10:42:43 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771238571;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=03yR22OPWyv4xOgsTRflUVZkTa9pLbZJpc7QOwE/YKQ=;\n b=etFBudC8mVVsHoesepiTXmC3nnXj3bJT5vNwtubyRP5idWFRzpSQXBCE3o0dVDJL2h/UIF\n m0FxCf8NMQP2IYFOKD8uHbjSJyJ+0EPMpShibMhjkaD7Dk4lTZl4Oevyr772MMyfe1FaMl\n LqD2Au9wJUMR9lk0ZlxFR6JAWBzROt4=", "X-MC-Unique": "I8kpWs3NOQSmNHtSG_9e0Q-1", "X-Mimecast-MFC-AGG-ID": "I8kpWs3NOQSmNHtSG_9e0Q_1771238565", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Mon, 16 Feb 2026 11:42:15 +0100", "Subject": "[PATCH 03/85] audio/adlib: drop ts_helper HWVoice field", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260216-audio-v1-3-edcb25699381@redhat.com>", "References": "<20260216-audio-v1-0-edcb25699381@redhat.com>", "In-Reply-To": "<20260216-audio-v1-0-edcb25699381@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Gerd Hoffmann <kraxel@redhat.com>, Eduardo Habkost <eduardo@habkost.net>,\n Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>,\n Christian Schoenebeck <qemu_oss@crudebyte.com>,\n Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>,\n Thomas Huth <huth@tuxfamily.org>, Alexandre Ratchov <alex@caoua.org>,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Laurent Vivier <laurent@vivier.eu>, \"Michael S. Tsirkin\" <mst@redhat.com>,\n Manos Pitsidianakis <manos.pitsidianakis@linaro.org>,\n Alistair Francis <alistair@alistair23.me>,\n \"Edgar E. Iglesias\" <edgar.iglesias@gmail.com>,\n Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Mark Cave-Ayland <mark.caveayland@nutanix.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1480;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=/79pMsmTucvlzgY5FBqKNb003r8HB/EPhG2j1zf1dS8=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvST/BaDjCpM0KcZ7tv+5/YjKDVVrzmszahPu\n 6R2+wqSMb+JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL0kwAKCRDa6OEJdZac\n 5XuCD/4wlO/cqLvuvC05xPsUFW9Kz6h/qDKLhrlPIYoABA+qEm6LQ5nTvh+CdHhxQMd4hSJt0iD\n 8y0pgQaMSqRRctueH2PoigCwkvqJrG7MvDcJe/2I9aojrzxHSkhrwUAqn4QdUf9WCtuQTRsIZgq\n EecwYvSC9ZYdXUwTGiVqjRMRt2hxCDpn2Bz49xM32CDQLnr1gzNOWvn23rOE3ITuv3+wPUPOaJp\n 7h3h+TXlJfNlQcAqPlvWZ1Om7MVaSVQEu7GOWEA69RGqxfEpCtdovRsHPRau/2zK0hT9RNIX7mP\n 4DkRtyroVdv24aDdheAvYxakBo7jpifHfzl5jdLDesplZdnRRPaESMpI2PBaqfvmjtt7lxRMHm3\n slwOgDFsl1P9f/9SRLnPFMJMN6aH7d55BP652xxmCRdMpw2TXcQhO2HpI1HRkCS/GiacqHW46OJ\n VHg4A+T7H3xx4xuPAEaDaU8q/qah22DfhCGcGccdHLTJBm8EHv4IwuCv9UBkSxZt40IogC8j+GJ\n Bb9pxegqX35BQZE0jlcjlPM7SioxA7cN8Xoa7QRPhEqy3t51swJuJCM2qaUCwbcdzCorciuWJ9V\n yp237fY2MfHamuD4GDCbLLoAR4ZbuMH0l4Xg+j94b/FGuJ4Tg9Cya6fpVmjeQ5EbnU9UL7u+DqZ\n b3ck143I665ddSg==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Previous commits made this dead code.\n\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\nReviewed-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>\n---\n audio/audio_int.h | 2 --\n audio/audio.c | 2 --\n 2 files changed, 4 deletions(-)", "diff": "diff --git a/audio/audio_int.h b/audio/audio_int.h\nindex b2b8002477c..20b4c87b0b6 100644\n--- a/audio/audio_int.h\n+++ b/audio/audio_int.h\n@@ -77,7 +77,6 @@ typedef struct HWVoiceOut {\n struct audio_pcm_info info;\n \n f_sample *clip;\n- uint64_t ts_helper;\n \n STSampleBuffer mix_buf;\n void *buf_emul;\n@@ -99,7 +98,6 @@ typedef struct HWVoiceIn {\n t_sample *conv;\n \n size_t total_samples_captured;\n- uint64_t ts_helper;\n \n STSampleBuffer conv_buf;\n void *buf_emul;\ndiff --git a/audio/audio.c b/audio/audio.c\nindex b7a28f79d4f..a218570a4f4 100644\n--- a/audio/audio.c\n+++ b/audio/audio.c\n@@ -1240,7 +1240,6 @@ static void audio_run_out(AudioBackend *s)\n #endif\n \n if (played) {\n- hw->ts_helper += played;\n audio_capture_mix_and_clear (hw, prev_rpos, played);\n }\n \n@@ -1320,7 +1319,6 @@ static void audio_run_in(AudioBackend *s)\n \n min = audio_pcm_hw_find_min_in (hw);\n hw->total_samples_captured += captured - min;\n- hw->ts_helper += captured;\n \n for (sw = hw->sw_head.lh_first; sw; sw = sw->entries.le_next) {\n sw->total_hw_samples_acquired -= min;\n", "prefixes": [ "03/85" ] }