Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196760/?format=api
{ "id": 2196760, "url": "http://patchwork.ozlabs.org/api/patches/2196760/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216102951.150381-2-kkostiuk@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260216102951.150381-2-kkostiuk@redhat.com>", "list_archive_url": null, "date": "2026-02-16T10:29:47", "name": "[PULL,1/5] qga/vss-win32: Fix ConvertStringToBSTR redefinition with newer MinGW", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "66bbafcc5052cc5c22386774d43873e7ec613320", "submitter": { "id": 83198, "url": "http://patchwork.ozlabs.org/api/people/83198/?format=api", "name": "Kostiantyn Kostiuk", "email": "kkostiuk@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216102951.150381-2-kkostiuk@redhat.com/mbox/", "series": [ { "id": 492282, "url": "http://patchwork.ozlabs.org/api/series/492282/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492282", "date": "2026-02-16T10:29:46", "name": "[PULL,1/5] qga/vss-win32: Fix ConvertStringToBSTR redefinition with newer MinGW", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492282/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196760/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196760/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=bYxmzcVl;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fDzbh5zWYz1xtN\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 16 Feb 2026 21:32:00 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vrvrs-0005xU-4l; Mon, 16 Feb 2026 05:30:16 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <kkostiuk@redhat.com>)\n id 1vrvrj-0005wQ-Rp\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 05:30:09 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <kkostiuk@redhat.com>)\n id 1vrvrf-0006hB-Rh\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 05:30:06 -0500", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-426-2KfgfwZ5Mt2p6a2K1rirQQ-1; Mon,\n 16 Feb 2026 05:29:58 -0500", "from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 465F518004AD; Mon, 16 Feb 2026 10:29:57 +0000 (UTC)", "from srv1.redhat.com (unknown [10.44.32.156])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id F2DFC1800669; Mon, 16 Feb 2026 10:29:55 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771237802;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=hQ5tRuWYImee0j/eSuZeoovu/KfdCpgO6d8EXV9epJA=;\n b=bYxmzcVleyqEtyQ9Izoc8fxlmJrOaW4bOmwHmYTMmOHrk7+T4YinL2FK66/amUU/4ojeRN\n XSpPGtpdLMLR4wnQ8kNq3C7CxjO/wMKWP5YgJ+ieAUS6cUKnp7yk3SeqvM+3ppVbJoyF37\n dnndSRLxirMBD7P6hOOmalCfKfO2MBE=", "X-MC-Unique": "2KfgfwZ5Mt2p6a2K1rirQQ-1", "X-Mimecast-MFC-AGG-ID": "2KfgfwZ5Mt2p6a2K1rirQQ_1771237797", "From": "Kostiantyn Kostiuk <kkostiuk@redhat.com>", "To": "qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,\n Richard Henderson <richard.henderson@linaro.org>", "Subject": "[PULL 1/5] qga/vss-win32: Fix ConvertStringToBSTR redefinition with\n newer MinGW", "Date": "Mon, 16 Feb 2026 12:29:47 +0200", "Message-ID": "<20260216102951.150381-2-kkostiuk@redhat.com>", "In-Reply-To": "<20260216102951.150381-1-kkostiuk@redhat.com>", "References": "<20260216102951.150381-1-kkostiuk@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.93", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=kkostiuk@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Nguyen Dinh Phi <phind.uet@gmail.com>\n\nNewer versions of MinGW-w64 provide ConvertStringToBSTR() in the\n_com_util namespace via <comutil.h>. This causes a redefinition\nerror when building qemu-ga on Windows with these toolchains.\n\nAdd a meson check to detect whether ConvertStringToBSTR is already\navailable, and conditionally compile our fallback implementation\nonly when the system does not provide one.\n\nSigned-off-by: Nguyen Dinh Phi <phind.uet@gmail.com>\nSuggested-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>\nReviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>\nReviewed-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>\nLink: https://lore.kernel.org/qemu-devel/20251218085446.462827-2-phind.uet@gmail.com\nSigned-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>\n---\n meson.build | 12 ++++++++++++\n qga/vss-win32/install.cpp | 2 ++\n 2 files changed, 14 insertions(+)", "diff": "diff --git a/meson.build b/meson.build\nindex 8ad37c992b..47e46c1d9f 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -3299,6 +3299,18 @@ endif\n # Detect host pointer size for the target configuration loop.\n host_long_bits = cc.sizeof('void *') * 8\n \n+# Detect if ConvertStringToBSTR has been defined in _com_util namespace\n+if host_os == 'windows'\n+ has_convert_string_to_bstr = cxx.links('''\n+ #include <comutil.h>\n+ int main() {\n+ BSTR b = _com_util::ConvertStringToBSTR(\"test\");\n+ return b ? 0 : 1;\n+ }\n+ ''')\n+ config_host_data.set('CONFIG_CONVERT_STRING_TO_BSTR', has_convert_string_to_bstr)\n+endif\n+\n ########################\n # Target configuration #\n ########################\ndiff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp\nindex 7b25d9098b..5b7a8e9bc5 100644\n--- a/qga/vss-win32/install.cpp\n+++ b/qga/vss-win32/install.cpp\n@@ -549,6 +549,7 @@ STDAPI DllUnregisterServer(void)\n \n \n /* Support function to convert ASCII string into BSTR (used in _bstr_t) */\n+#ifndef CONFIG_CONVERT_STRING_TO_BSTR\n namespace _com_util\n {\n BSTR WINAPI ConvertStringToBSTR(const char *ascii) {\n@@ -566,6 +567,7 @@ namespace _com_util\n return bstr;\n }\n }\n+#endif\n \n /* Stop QGA VSS provider service using Winsvc API */\n STDAPI StopService(void)\n", "prefixes": [ "PULL", "1/5" ] }