Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196758/?format=api
{ "id": 2196758, "url": "http://patchwork.ozlabs.org/api/patches/2196758/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216102951.150381-5-kkostiuk@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260216102951.150381-5-kkostiuk@redhat.com>", "list_archive_url": null, "date": "2026-02-16T10:29:50", "name": "[PULL,4/5] qga: Move CoInitialize/CoInitializeSecurity to main process thread", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "a3eff267ddc39ca150981b212b1f6b3955dbba10", "submitter": { "id": 83198, "url": "http://patchwork.ozlabs.org/api/people/83198/?format=api", "name": "Kostiantyn Kostiuk", "email": "kkostiuk@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216102951.150381-5-kkostiuk@redhat.com/mbox/", "series": [ { "id": 492282, "url": "http://patchwork.ozlabs.org/api/series/492282/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492282", "date": "2026-02-16T10:29:46", "name": "[PULL,1/5] qga/vss-win32: Fix ConvertStringToBSTR redefinition with newer MinGW", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492282/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196758/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196758/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Cr7pj1Vm;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fDzZj43JBz1xtN\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 16 Feb 2026 21:31:09 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vrvrt-0005xZ-3l; Mon, 16 Feb 2026 05:30:17 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <kkostiuk@redhat.com>)\n id 1vrvrp-0005wz-D5\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 05:30:14 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <kkostiuk@redhat.com>)\n id 1vrvrj-0006tK-7N\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 05:30:09 -0500", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-503-0eOSy0isOOeg5D-Nk9onkQ-1; Mon,\n 16 Feb 2026 05:30:03 -0500", "from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 53DFC1955D7A; Mon, 16 Feb 2026 10:30:02 +0000 (UTC)", "from srv1.redhat.com (unknown [10.44.32.156])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id 2009F1800465; Mon, 16 Feb 2026 10:30:00 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771237805;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=rrHCY5KX91VDIK/7DELWtkdibSPQHxJxeU1/Q0fsMT0=;\n b=Cr7pj1VmvsJPAc9VWxbeW6sB1oNexqUBddcqqEX8/5y7ne2lOHySpb1XEJr6+Ab+rTVROB\n pSRl3ja8roHJDABZ+7NBZRnwCB3m3LvKrWbFEFBalsV8m6KEQfV6ArB+Hm84l5AmRe7BVf\n pxiN+hzrWzLO3izchRuJSSpYoSmEzBg=", "X-MC-Unique": "0eOSy0isOOeg5D-Nk9onkQ-1", "X-Mimecast-MFC-AGG-ID": "0eOSy0isOOeg5D-Nk9onkQ_1771237802", "From": "Kostiantyn Kostiuk <kkostiuk@redhat.com>", "To": "qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,\n Richard Henderson <richard.henderson@linaro.org>", "Subject": "[PULL 4/5] qga: Move CoInitialize/CoInitializeSecurity to main\n process thread", "Date": "Mon, 16 Feb 2026 12:29:50 +0200", "Message-ID": "<20260216102951.150381-5-kkostiuk@redhat.com>", "In-Reply-To": "<20260216102951.150381-1-kkostiuk@redhat.com>", "References": "<20260216102951.150381-1-kkostiuk@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.93", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=kkostiuk@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Elizabeth Ashurov <eashurov@redhat.com>\n\nProblem:\nTwo issues with COM initialization:\n\nIssue #1: Incorrect call order\n- requester_init() called CoInitializeSecurity first\n- Per Microsoft documentation, CoInitialize() must be called BEFORE\n CoInitializeSecurity()\n\nIssue #2: Incorrect call location\n- CoInitializeSecurity was called from dll instead of the main process\n- Per Microsoft documentation, CoInitializeSecurity() must be called exactly once per process from\n the main executable, not from a DLL\n\nReference:\nhttps://learn.microsoft.com/en-us/windows/win32/api/combaseapi/nf-combaseapi-coinitializesecurity\nhttps://learn.microsoft.com/en-us/windows/win32/api/objbase/nf-objbase-coinitialize\n\nThis caused incorrect COM initialization, preventing VSS Writers from\ncalling back via IVssWriterCallback (hr = 0x80070005, Access denied,\nEvent ID 8194).\n\nFix:\n- Initialize COM in main.c for both service and CLI modes\n- Call CoInitialize() followed by CoInitializeSecurity() in correct order\n in the main thread before any VSS operations\n- Add proper CoUninitialize() cleanup\n\nResult:\nVSS Writers can now successfully call back to the agent. Event ID 8194\nerror is resolved.\n\nSigned-off-by: Elizabeth Ashurov <eashurov@redhat.com>\nReviewed-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>\nTested-by: Dehan Meng <demeng@redhat.com>\nLink: https://lore.kernel.org/qemu-devel/20260211101744.757548-1-eashurov@redhat.com\nSigned-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>\n---\n qga/main.c | 42 +++++++++++++++++++++++++++++++++++++\n qga/vss-win32/requester.cpp | 13 ------------\n 2 files changed, 42 insertions(+), 13 deletions(-)", "diff": "diff --git a/qga/main.c b/qga/main.c\nindex dd1c216f9a..fd19c7037d 100644\n--- a/qga/main.c\n+++ b/qga/main.c\n@@ -32,6 +32,8 @@\n #include \"qemu/systemd.h\"\n #include \"qemu-version.h\"\n #ifdef _WIN32\n+#include <windows.h>\n+#include <objbase.h>\n #include <dbt.h>\n #include <pdh.h>\n #include \"qga/service-win32.h\"\n@@ -830,6 +832,29 @@ DWORD WINAPI service_ctrl_handler(DWORD ctrl, DWORD type, LPVOID data,\n return ret;\n }\n \n+/* Initialize COM for VSS operations */\n+static HRESULT init_com(void)\n+{\n+ HRESULT hr;\n+\n+ hr = CoInitialize(NULL);\n+ if (FAILED(hr)) {\n+ return hr;\n+ }\n+\n+ hr = CoInitializeSecurity(\n+ NULL, -1, NULL, NULL,\n+ RPC_C_AUTHN_LEVEL_PKT_PRIVACY,\n+ RPC_C_IMP_LEVEL_IDENTIFY,\n+ NULL, EOAC_NONE, NULL);\n+ if (FAILED(hr)) {\n+ CoUninitialize();\n+ return hr;\n+ }\n+\n+ return S_OK;\n+}\n+\n VOID WINAPI service_main(DWORD argc, TCHAR *argv[])\n {\n GAService *service = &ga_state->service;\n@@ -842,6 +867,13 @@ VOID WINAPI service_main(DWORD argc, TCHAR *argv[])\n return;\n }\n \n+ /* Initialize COM for VSS operations in the service thread */\n+ HRESULT hr_com = init_com();\n+ if (FAILED(hr_com)) {\n+ g_critical(\"Failed to initialize COM in service thread: 0x%lx\", hr_com);\n+ return;\n+ }\n+\n service->status.dwServiceType = SERVICE_WIN32;\n service->status.dwCurrentState = SERVICE_RUNNING;\n service->status.dwControlsAccepted = SERVICE_ACCEPT_STOP | SERVICE_ACCEPT_SHUTDOWN;\n@@ -866,6 +898,8 @@ VOID WINAPI service_main(DWORD argc, TCHAR *argv[])\n \n run_agent(ga_state);\n \n+ CoUninitialize();\n+\n UnregisterDeviceNotification(service->device_notification_handle);\n service->status.dwCurrentState = SERVICE_STOPPED;\n SetServiceStatus(service->status_handle, &service->status);\n@@ -1719,7 +1753,15 @@ int main(int argc, char **argv)\n StartServiceCtrlDispatcher(service_table);\n ret = EXIT_SUCCESS;\n } else {\n+ HRESULT hr_com = init_com();\n+ if (FAILED(hr_com)) {\n+ g_critical(\"Failed to initialize COM: 0x%lx\", hr_com);\n+ ret = EXIT_FAILURE;\n+ goto end;\n+ }\n+\n ret = run_agent(s);\n+ CoUninitialize();\n }\n #else\n ret = run_agent(s);\ndiff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp\nindex 5615955b6f..2ebfabf45d 100644\n--- a/qga/vss-win32/requester.cpp\n+++ b/qga/vss-win32/requester.cpp\n@@ -60,15 +60,6 @@ STDAPI requester_init(void)\n {\n qga_debug_begin;\n \n- COMInitializer initializer; /* to call CoInitializeSecurity */\n- HRESULT hr = CoInitializeSecurity(\n- NULL, -1, NULL, NULL, RPC_C_AUTHN_LEVEL_PKT_PRIVACY,\n- RPC_C_IMP_LEVEL_IDENTIFY, NULL, EOAC_NONE, NULL);\n- if (FAILED(hr)) {\n- qga_debug(\"failed to CoInitializeSecurity (error %lx)\", hr);\n- return hr;\n- }\n-\n hLib = LoadLibraryA(\"VSSAPI.DLL\");\n if (!hLib) {\n qga_debug(\"failed to load VSSAPI.DLL\");\n@@ -320,8 +311,6 @@ void requester_freeze(int *num_vols, void *mountpoints, ErrorSet *errset)\n return;\n }\n \n- CoInitialize(NULL);\n-\n /* Allow unrestricted access to events */\n InitializeSecurityDescriptor(&sd, SECURITY_DESCRIPTOR_REVISION);\n SetSecurityDescriptorDacl(&sd, TRUE, NULL, FALSE);\n@@ -560,7 +549,6 @@ out:\n \n out1:\n requester_cleanup();\n- CoUninitialize();\n \n qga_debug_end;\n }\n@@ -641,7 +629,6 @@ void requester_thaw(int *num_vols, void *mountpints, ErrorSet *errset)\n *num_vols = vss_ctx.cFrozenVols;\n requester_cleanup();\n \n- CoUninitialize();\n StopService();\n \n qga_debug_end;\n", "prefixes": [ "PULL", "4/5" ] }