Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196643/?format=api
{ "id": 2196643, "url": "http://patchwork.ozlabs.org/api/patches/2196643/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-gpio/patch/20260215120555.v2.1.I77c3eb563271c21870379eefd16ebbc4e09635bb@changeid/", "project": { "id": 42, "url": "http://patchwork.ozlabs.org/api/projects/42/?format=api", "name": "Linux GPIO development", "link_name": "linux-gpio", "list_id": "linux-gpio.vger.kernel.org", "list_email": "linux-gpio@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260215120555.v2.1.I77c3eb563271c21870379eefd16ebbc4e09635bb@changeid>", "list_archive_url": null, "date": "2026-02-15T20:05:55", "name": "[v2] gpio: Avoid NULL dereference in linehandle_create()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0377b5c3bf45d214172dbba264304b26ff7d7123", "submitter": { "id": 9763, "url": "http://patchwork.ozlabs.org/api/people/9763/?format=api", "name": "Douglas Anderson", "email": "dianders@chromium.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-gpio/patch/20260215120555.v2.1.I77c3eb563271c21870379eefd16ebbc4e09635bb@changeid/mbox/", "series": [ { "id": 492231, "url": "http://patchwork.ozlabs.org/api/series/492231/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-gpio/list/?series=492231", "date": "2026-02-15T20:05:55", "name": "[v2] gpio: Avoid NULL dereference in linehandle_create()", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/492231/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196643/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196643/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-gpio+bounces-31693-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-gpio@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=XJ4Mrc3T;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-31693-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org\n header.b=\"XJ4Mrc3T\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=74.125.82.50", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=chromium.org" ], "Received": [ "from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fDcPJ5sJfz1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 16 Feb 2026 07:06:44 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 603AD301412E\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 15 Feb 2026 20:06:40 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 4C3C02690C0;\n\tSun, 15 Feb 2026 20:06:39 +0000 (UTC)", "from mail-dl1-f50.google.com (mail-dl1-f50.google.com\n [74.125.82.50])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id EBBD1246774\n\tfor <linux-gpio@vger.kernel.org>; Sun, 15 Feb 2026 20:06:37 +0000 (UTC)", "by mail-dl1-f50.google.com with SMTP id\n a92af1059eb24-1271257ae53so2540960c88.1\n for <linux-gpio@vger.kernel.org>;\n Sun, 15 Feb 2026 12:06:37 -0800 (PST)", "from dianders.sjc.corp.google.com\n ([2a00:79e0:2e7c:8:6d1b:eb8c:16f:1964])\n by smtp.gmail.com with ESMTPSA id\n a92af1059eb24-12742cad9desm6896092c88.11.2026.02.15.12.06.35\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 15 Feb 2026 12:06:35 -0800 (PST)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1771185999; cv=none;\n b=OzU1/3atViOpA+WLsfbG8GCwDJjHS8QLoxfE4T5YICHh/OFiGLievlu8+9AySlgHWnLkJTrlFyP5CUYfH9DlSkO+VxNdOv3WUY+6sSgSqisFD65c42kyrZLpisTNd1JnK8j2ZdrGQKz5VErfO1T2nX8CJeB1OXIG/feQXOzKiJs=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1771185999; c=relaxed/simple;\n\tbh=DZxBctGHQ8YK2uZhVlc5yIy9LV6Le4CnXmSL/0tvMfg=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=OBJDvi/MILXKmLuex4x9wYLPGMkJA0rTGYX45D9TsEeq3/BaBu88jktPYpdVjFXe4AyPmX70xuwv0sq79mpHTpS2HM21+MMnxXgmtowvUfloDlFfmQcePuQO45C8b1etb64AZdE/DehnHnzl+sM0cKjn+jMBDuVvdptMvmKJK34=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=chromium.org;\n spf=pass smtp.mailfrom=chromium.org;\n dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org\n header.b=XJ4Mrc3T; arc=none smtp.client-ip=74.125.82.50", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1771185997; x=1771790797;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=16om0dKffWd/jiAsOCQqAqNAh+Z+U1swvD/OzEUaow4=;\n b=XJ4Mrc3TT2gRLKkB8y9LicHhoTVGqCYVhFusBjKcikmnCuV+52KIB25jph+tKQw29V\n i5qN/fGoH1geIEtKPmnPvqNBx4vt6d87OBuuq0LvVn9arbZnh27YI15wgfbM0UmX/Y4U\n bG5mLeaFu4kj8LrVcBpHUEe9u0Zlp/CT5QotM=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771185997; x=1771790797;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=16om0dKffWd/jiAsOCQqAqNAh+Z+U1swvD/OzEUaow4=;\n b=an7kDDDbnRAvXVyJ1Waw+CEBVRPOILgJegKT42bWqh/LebV5jAMEy67Y5WKQB9MDtV\n UQv9Wl9RYI7s/X1wrqI4/MRmMvj9S0z6n7qr5flkh5+HdcZRYV4RJEwqmb+4sQIt3Tqz\n BRblt1X6EUNILN1LkIxjjS8T+1SSvDKhXeffK7R4iDfXjuf3sJCD5228b2WPwBTF/a1q\n MmJ78mDXZt6uCp1skNHJ5QCH6xUqPp523QfA/ZuoBnpCmjrPuHvG6/1TdVqaz1zT8now\n CuOA+jaxKtOCr1pEhMPqZ9Xg/DMy6VD0nkiit8Ym6iEVsttA0js0COOWOXBVzfmo8eBu\n eQug==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCXnuuOIgBT2bQ0nvsPLSaCQkaziS2Zn3whqZiuQ8Os45BVaLH9hvHXwcdK1z4aJ8kMI0843ukwTYWjP@vger.kernel.org", "X-Gm-Message-State": "AOJu0YwYd68bJds3qbaXOXufs8u6r9DTtfZQWwvaLhycSh5QEFLMsYY6\n\tljmrP45pABt1YZrl7n0egges4OEyYcsGwyIiXVnliTOZ0c4b9cTUXt5dxexxzhLA0A==", "X-Gm-Gg": "AZuq6aJS0lkzjlW19r7qZEZhopFvlvusp0FU44bcKPSVul/uuTtq/LuHW/uPCmvsOsc\n\t3Zp4a/09o5Bx2E9puMG2Hr3M6AMbmLiw+SqvUr9IZA03XNwFs5HMxayjmVsdErS9BqmtNBkQ997\n\tbHtJRmIvLEBr9Gm93E0QezSVC+8ZF6v83Tbwt9LVs3OjeB2LCHHHDFkdGzxlx6g7hGYhF7kMvX8\n\tVyeWfmBAcGSSK2pnU5768b0aJVcrF1rQKeVdeuMhSFPo+a3NSqEBcRT5B7P5g3y3XAS00yUzEZ4\n\tUOD3OFQZxniui5hcVmojSisFyMDr2eyU9fmQBIuieZ484TMVLEyNpbq24uiMRvoLvvUTHQX33Di\n\ta1HZvlOPjVbg7YNxzn6GggBtjcQq2k+c2Txe0sVcJhYxWXhOa2cp8OwwLKOpRj9SWF4TMtXxO++\n\tZ0knWpjYIvwbv1NbfIyGlxA76oCaBLO/LNL9KDuAtpMPmfX6mgQXcVCQT8CbOoPaR4g3hIues6a\n\t96CYATsjw==", "X-Received": "by 2002:a05:7022:f102:b0:11b:9386:a38d with SMTP id\n a92af1059eb24-1273ae81364mr3683409c88.48.1771185997008;\n Sun, 15 Feb 2026 12:06:37 -0800 (PST)", "From": "Douglas Anderson <dianders@chromium.org>", "To": "Linus Walleij <linusw@kernel.org>,\n\tChristian Brauner <brauner@kernel.org>,\n\tBartosz Golaszewski <brgl@kernel.org>,\n\tKent Gibson <warthog618@gmail.com>", "Cc": "Douglas Anderson <dianders@chromium.org>,\n\tlinux-gpio@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org", "Subject": "[PATCH v2] gpio: Avoid NULL dereference in linehandle_create()", "Date": "Sun, 15 Feb 2026 12:05:55 -0800", "Message-ID": "\n <20260215120555.v2.1.I77c3eb563271c21870379eefd16ebbc4e09635bb@changeid>", "X-Mailer": "git-send-email 2.53.0.273.g2a3d683680-goog", "Precedence": "bulk", "X-Mailing-List": "linux-gpio@vger.kernel.org", "List-Id": "<linux-gpio.vger.kernel.org>", "List-Subscribe": "<mailto:linux-gpio+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-gpio+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "In linehandle_create(), there is a statement like this:\n retain_and_null_ptr(lh);\n\nSoon after, there is a debug printout that dereferences \"lh\", which\nwill crash things.\n\nAvoid the crash by using handlereq.lines, which is the same value.\n\nFixes: da7e394bf58f (\"gpio: convert linehandle_create() to FD_PREPARE()\")\nSigned-off-by: Douglas Anderson <dianders@chromium.org>\n---\n\nChanges in v2:\n- Use handlereq.lines rather than creating another local shadow.\n\n drivers/gpio/gpiolib-cdev.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c\nindex 2adc3c070908..189127721e38 100644\n--- a/drivers/gpio/gpiolib-cdev.c\n+++ b/drivers/gpio/gpiolib-cdev.c\n@@ -388,7 +388,7 @@ static int linehandle_create(struct gpio_device *gdev, void __user *ip)\n \tfd_publish(fdf);\n \n \tdev_dbg(&gdev->dev, \"registered chardev handle for %d lines\\n\",\n-\t\tlh->num_descs);\n+\t\thandlereq.lines);\n \n \treturn 0;\n }\n", "prefixes": [ "v2" ] }