Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196604/?format=api
{ "id": 2196604, "url": "http://patchwork.ozlabs.org/api/patches/2196604/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260215123514.2288422-1-s-vadapalli@ti.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260215123514.2288422-1-s-vadapalli@ti.com>", "list_archive_url": null, "date": "2026-02-15T12:35:12", "name": "[v3] usb: cdns3: use VBUS Valid to determine role for dr_mode OTG", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "841d4cabdb17a8e86ddb98418fb37e55df9979e0", "submitter": { "id": 84157, "url": "http://patchwork.ozlabs.org/api/people/84157/?format=api", "name": "Siddharth Vadapalli", "email": "s-vadapalli@ti.com" }, "delegate": { "id": 1699, "url": "http://patchwork.ozlabs.org/api/users/1699/?format=api", "username": "marex", "first_name": "Marek", "last_name": "Vasut", "email": "marek.vasut@gmail.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260215123514.2288422-1-s-vadapalli@ti.com/mbox/", "series": [ { "id": 492213, "url": "http://patchwork.ozlabs.org/api/series/492213/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=492213", "date": "2026-02-15T12:35:12", "name": "[v3] usb: cdns3: use VBUS Valid to determine role for dr_mode OTG", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/492213/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196604/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196604/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=ti.com header.i=@ti.com header.a=rsa-sha256\n header.s=selector1 header.b=OvmicrwI;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=ti.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=ti.com header.i=@ti.com header.b=\"OvmicrwI\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=ti.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=s-vadapalli@ti.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fDQLz590qz1xpl\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 15 Feb 2026 23:34:03 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id EB51980B98;\n\tSun, 15 Feb 2026 13:33:57 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id EE3858309A; Sun, 15 Feb 2026 13:33:55 +0100 (CET)", "from BN1PR04CU002.outbound.protection.outlook.com\n (mail-eastus2azlp170100001.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c110::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 2039280325\n for <u-boot@lists.denx.de>; Sun, 15 Feb 2026 13:33:52 +0100 (CET)", "from BL1PR13CA0248.namprd13.prod.outlook.com (2603:10b6:208:2ba::13)\n by BN0PR10MB4823.namprd10.prod.outlook.com (2603:10b6:408:12d::19)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.16; Sun, 15 Feb\n 2026 12:33:50 +0000", "from BL6PEPF0001AB58.namprd02.prod.outlook.com\n (2603:10b6:208:2ba:cafe::5c) by BL1PR13CA0248.outlook.office365.com\n (2603:10b6:208:2ba::13) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9632.12 via Frontend Transport; Sun,\n 15 Feb 2026 12:33:50 +0000", "from lewvzet200.ext.ti.com (198.47.23.194) by\n BL6PEPF0001AB58.mail.protection.outlook.com (10.167.241.10) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9611.8 via Frontend Transport; Sun, 15 Feb 2026 12:33:50 +0000", "from DLEE202.ent.ti.com (157.170.170.77) by lewvzet200.ext.ti.com\n (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 15 Feb\n 2026 06:33:49 -0600", "from DLEE200.ent.ti.com (157.170.170.75) by DLEE202.ent.ti.com\n (157.170.170.77) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 15 Feb\n 2026 06:33:49 -0600", "from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE200.ent.ti.com\n (157.170.170.75) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend\n Transport; Sun, 15 Feb 2026 06:33:49 -0600", "from toolbox.dhcp.ti.com (uda0492258.dhcp.ti.com [10.24.73.74])\n by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 61FCXk6P3916028;\n Sun, 15 Feb 2026 06:33:47 -0600" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,T_SPF_PERMERROR autolearn=no\n autolearn_force=no version=3.4.2", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=UtRvRodvqvsRK64y2DUdbMW2udSBbRHdLDkFNUONQVTGA1I/oVYJqHOPSfvSKrPB4EekA5RzETmEkWq/gGuiCN1vC5TI9w9S3S2LM8IYR4J1z89fWY5CBJgbkyp62S6It3DcnJ+X3My0Eu9BJLiHiKWVhh83/yBfKa1aWIQNq0H6PYR0l7eN/+M5aKIpWqpN3TQEcEM3JSMzIhsus3b44gB92XYs/5/1AMnbPCL80XQ/X6hUnDKDmUEFNPbexpePHHH3wG7DdjAfte5f1hxh3k5vz45SZyDrfOchX/8WYRvFNemKcHk1Ny9Pp/fzhiGWrC6FGw+n7tVCplySwvtQDA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=WyOlW1E3GkGOpz46GB+zms1StPE1FZuiRFDeDEKg7t0=;\n b=xT+ewOoGEiT73NUEZwJqdKWsPyahs2QAY5zI5/Z2tJ2V5kAAK6C+yahDF6qa6qFQbj+QUD0PCPni+CeDjcexIBmNMV8K2+jUqjIb6cXwzT5WLo7lrsU7UmbEbKioK/LugKE5AR5PyV95R+8aOTzWesQ/yQaTy7rqasBugzh2DCfg37NkDrytJ1zu4Y4DP4hF3P9s5WuIFJEGxbuaOgoKyYfiaB1ijZEBNVxUwK9b9e6vxAv/yUntocGKAFU/9kpPFlX13tYdcpiwNgawEkcNOLT2d1UAbqi6YT8PoSe0K5HI2LhbpJ2px9hZwlnUhitfObmqRY7Jv5WczfHS31qvlQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 198.47.23.194) smtp.rcpttodomain=lists.denx.de smtp.mailfrom=ti.com;\n dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=WyOlW1E3GkGOpz46GB+zms1StPE1FZuiRFDeDEKg7t0=;\n b=OvmicrwI6QP3ALZbmmN8kYribmyCWg6JWPTxGJWKbkkChZGwah+b0zLNIigdmDCKpmK0h/yOTUBkNlEkJDXcIOKbGSfVdZXautlZ0CVzL3epNIkuIek3dlUMmyj6KS46KeHlxcPCIPMb505d1xoUbhEsrB2GAS+7zjgGVq9KxPk=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 198.47.23.194)\n smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;\n dmarc=pass\n action=none header.from=ti.com;", "Received-SPF": "Pass (protection.outlook.com: domain of ti.com designates\n 198.47.23.194 as permitted sender) receiver=protection.outlook.com;\n client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C", "From": "Siddharth Vadapalli <s-vadapalli@ti.com>", "To": "<marex@denx.de>, <trini@konsulko.com>, <minda.chen@starfivetech.com>", "CC": "<marek.vasut@mailbox.org>, <u-boot@lists.denx.de>, <srk@ti.com>,\n <s-vadapalli@ti.com>", "Subject": "[PATCH v3] usb: cdns3: use VBUS Valid to determine role for dr_mode\n OTG", "Date": "Sun, 15 Feb 2026 18:05:12 +0530", "Message-ID": "<20260215123514.2288422-1-s-vadapalli@ti.com>", "X-Mailer": "git-send-email 2.51.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-C2ProcessedOrg": "333ef613-75bf-4e12-a4b1-8e3623f5dcea", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "BL6PEPF0001AB58:EE_|BN0PR10MB4823:EE_", "X-MS-Office365-Filtering-Correlation-Id": "5a426906-491c-4775-320e-08de6c8e78e9", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n ARA:13230040|82310400026|1800799024|376014|36860700013;", "X-Microsoft-Antispam-Message-Info": "\n RZsK0l5s0yXSjSKx3GJpwSdYUC3TD9duwNqkVQabfl+CXjlDndfmTIGJk3WVlWrJJ/Apm6oeoTtQHKz+kg71yZCNP329ffZT5c82cZ5Mh58z8q8ySf0ob+fRBqR/0LMCk2tQwCBjdMtD7kVaCbS0O/rjESSYy61/aUXE0HDkLd9cvZs+/A0or/Wn8gxmgFbEYuxcyaQ164wv1gqazhMbMYUCvLQ/lRx1gw7CM0gEn1d5S+TezIWEl1EgJH+bacgqo2Wv0H5bqpx87FowI+Cxs44M24TsHIcCMsD8LeE4Hs8S7xfFY9dXM68c47cdEQ1xGz7Yg/2VZQ+NwXG4b0WvUeqilgOtTLjF3ZNs478kytdObewFOsVDjONdRpJiFVtsW7SnuKCHUUSYekrYV9mXGkqssNcNhDrg+BhrinCtJMe2okP7E8/DAXxkmirVz5oTukVK9+hc7/kBX5rRJfpnyBH4qv5exg597WzOr3zpOe94KwhFXneJMQnRgliiENHf9dtYXGcqEE80hu7306x0hHH3rNTxqzFeSTHtb4Nov2yqj9QIIpvqmmgCx6HZ/5pOZS2wMAeIcxWvq+iyPtRfOm0DXZMa5ahTEYHKkjtJK4zd9G16DM7o7fbzkS2Yp3+RFWmV2WtWPLZ9ml2uJu5W6KEqZssTnkKiZxoEfotj/dAbusk0Eg1/UiSTxehBDitxXJujzDdVZ0mv9o5vVao0rQAVQDiJXlVXSZXvzmNNJRrz86zrXvK75LkUqbYup26Gv+Gs3FC4ct8oPFNqkLigqfUmrtw/Bm2KGBDODC/fRbMvCHmxG+kQ0eMSAr1TyTYgP26+XoywDJGqlNYAPTw723LI1LA5FlCzyVI1ys77jDp5bzs5YETaWeBoPEkwDUi6WE2EZfZPo+H6GU/FJs2d7kR6z2CWlX/bMp9pUYsaqFKsbFkSiyQzs3PXRnX6AIHgU12xV1T86CmvHykX87pZSgbO5S6S5uv+YZLfAQOpWZwzaqVX+X2/y4YoFKS75B5qUuIK5XJPwMsYRWPt0Y0rz2TyH+3zHNa69ChhFM3i1xDhKiQcA34NJQpcKW1ZCXw52I2DZcZSX5LeYAJmpUaWSI1j9A/qkwrvalLpcY0bBy9IKK3awYh2S2mEOFON2kCvvIncqruwt0Lw/yb1CcQgIcx+9g6l/cMIayALnSbUIH44346HhH11P7xJc3E4/6N75Y+8GD2IP7toG3a94RujzM40KTVRmkk8y/vn5xHlf5Xwd6eT7G4tPOLFwcek7qXvXx/ITd0SW3eB4rlpIPyzGcnSgsTbKoDg7L1aqcm0sQica+SUXFqpnP8rxiRQZMHHFWNgd7l83Q/MKtSSfWXdZsAyg+b7RnNo96p8hDPznedBCPQPFDFwBKyC1p2I4es9TIjIqU4BCpj8MEzh8YPyVf508PqSM2XgkG55OUpuUkmz59bAcKHhmQY86YQnTe0RmXNRDUc4bwiaUgimCdC+KcTLkgmljQEFOCeYDFTCDquNJy6AqHSDULLB1VVuaSIb2/5S4ulL9pQOC4k761Hp9GO3+50Y5CQlennNGhUy965TduAAa6J1x+cXAw6aA67G2E8jngURKX3AZmLLzi1bUCDNgpYtAXp3at7uIrEAZqc=", "X-Forefront-Antispam-Report": "CIP:198.47.23.194; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:lewvzet200.ext.ti.com; PTR:InfoDomainNonexistent;\n CAT:NONE; SFS:(13230040)(82310400026)(1800799024)(376014)(36860700013);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n +EhC4i0Jp88YxIs+0lTAKr8B8Jcn5LBi3M4j7TexQOSyyFpUSRPZk/ixLCgsBleESOV1TSbx0RB1WPKTNVinMZwJ7oRhlodxnYDWtbE7dQRa81WmrWW/NRd38cHb80oBipETHnUmO5fgG1bU0LxnncKOlKjKCRGwqzKRLX5RXTiDk0AgOIYlqNEvKZQI93QOdcv4Z4OnPz87ZaXWkEkL16MSOyrSMymsDJLbRvSgzXJ1/4sGIrS8z4Wo/NXE+VlRzh7uamlEJ0NIhHhyjKGfm08gii5gUQaUPuWe5RqcFS4W4OdmWNrCGO5uK6CUlNhJKZTJ1D9DdaMBh0OBkfJq2ZpVkfazdY8zbNnmy/vxRaAia75BvTks4diruenVVqqoAwgbUla9YQgso5aEJgSyT9/rdzquMWVocgKhBUF2G/HKV+Z+Wi+/QaKzQEHGmSpV", "X-OriginatorOrg": "ti.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "15 Feb 2026 12:33:50.1609 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 5a426906-491c-4775-320e-08de6c8e78e9", "X-MS-Exchange-CrossTenant-Id": "e5b49634-450b-4709-8abb-1e2b19b982b7", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7; Ip=[198.47.23.194];\n Helo=[lewvzet200.ext.ti.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BL6PEPF0001AB58.namprd02.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BN0PR10MB4823", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "The cdns3_bind() function is responsible for identifying the appropriate\ndriver to bind to the USB Controller's device-tree node. If the device-tree\nnode has the 'dr_mode' property set to 'otg', the existing approach fails\nto bind a driver, leading to loss of functionality.\n\nTo address this, use the VBUS Valid field of the OTG Status register to\ndetermine the role as follows:\n- If VBUS Valid field is set, it indicates that a USB Host is supplying\n power and the Controller should assume the Peripheral role.\n- If VBUS Valid field is clear, it indicates the absence of a USB Host and\n the Controller should assume the Host role.\n\nAdditionally, when 'dr_mode' happens to be 'otg' and the STRAP settings\nare not specified, use VBUS Valid to determine the role in cdns3_drd_init()\nand assign it to cdns->dr_mode.\n\nSigned-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>\n---\n\nHello,\n\nThis patch is based on commit\nf9ffeec4bdc board: toradex: Make A53 get RAM size from DT in K3 boards\nof the master branch of U-Boot.\n\nv2 of this patch is at:\nhttps://lore.kernel.org/r/20260213051556.1247716-1-s-vadapalli@ti.com/\nChanges since v2:\n- Based on feedback from Marek, a temporary child udevice has been\n created in cdns3_get_otg_mode() to use devfdt_remap_addr_name(),\n instead of implementing custom equivalent of devfdt_remap_addr_name().\n\nTest logs on J784S4 EVM:\nhttps://gist.github.com/Siddharth-Vadapalli-at-TI/5f55c14a061a797e266f086ea18ef3e0\n\nRegards,\nSiddharth.\n\n drivers/usb/cdns3/core.c | 55 ++++++++++++++++++++++++++++++++++++++++\n drivers/usb/cdns3/drd.c | 11 ++++++++\n 2 files changed, 66 insertions(+)", "diff": "diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c\nindex 4434dc15bec..6eacbce7714 100644\n--- a/drivers/usb/cdns3/core.c\n+++ b/drivers/usb/cdns3/core.c\n@@ -392,6 +392,54 @@ static const struct udevice_id cdns3_ids[] = {\n \t{ },\n };\n \n+/*\n+ * The VBUS Valid Bit in the OTG Status register can be used to determine\n+ * the role. When VBUS Valid is set, it indicates that a USB Host is supplying\n+ * power, so the Controller should assume the PERIPHERAL role. If it isn't set,\n+ * it indicates the absence of a USB Host, so the Controller should assume the\n+ * HOST role. If the OTG Status register is inaccessible, return an error.\n+ */\n+static int cdns3_get_otg_mode(struct udevice *parent, enum usb_dr_mode *mode)\n+{\n+\t/* Create a temporary child device for using devfdt_remap_addr_name() */\n+\tstruct udevice child = {\n+\t\t.parent = parent,\n+\t};\n+\tstruct cdns3 cdns, *cdnsp;\n+\tvoid __iomem *otg_regs;\n+\tint vbus;\n+\n+\tdev_set_ofnode(&child, ofnode_first_subnode(dev_ofnode(parent)));\n+\totg_regs = devfdt_remap_addr_name(&child, \"otg\");\n+\tif (!otg_regs) {\n+\t\tdev_err(parent, \"failed to get otg registers for child node\\n\");\n+\t\treturn -ENXIO;\n+\t}\n+\n+\t/*\n+\t * As mentioned in drivers/usb/cdns3/drd.c, there are two versions\n+\t * of the Controller. The following logic detects the version of the\n+\t * Controller and interprets the register layout accordingly.\n+\t */\n+\tcdnsp = &cdns;\n+\tcdnsp->otg_v0_regs = otg_regs;\n+\tif (!readl(&cdnsp->otg_v0_regs->cmd)) {\n+\t\tcdnsp->otg_regs = otg_regs;\n+\t} else {\n+\t\tcdnsp->otg_v1_regs = otg_regs;\n+\t\tcdnsp->otg_regs = (void *)&cdnsp->otg_v1_regs->cmd;\n+\t}\n+\n+\t/* Use VBUS Valid to determine role */\n+\tvbus = !!(readl(&cdnsp->otg_regs->sts) & OTGSTS_VBUS_VALID);\n+\tif (vbus)\n+\t\t*mode = USB_DR_MODE_PERIPHERAL;\n+\telse\n+\t\t*mode = USB_DR_MODE_HOST;\n+\n+\treturn 0;\n+}\n+\n int cdns3_bind(struct udevice *parent)\n {\n \tenum usb_dr_mode dr_mode;\n@@ -413,6 +461,13 @@ int cdns3_bind(struct udevice *parent)\n \tif (dr_mode == USB_DR_MODE_UNKNOWN)\n \t\tdr_mode = usb_get_dr_mode(dev_ofnode(parent));\n \n+\t/* Use VBUS Valid to determine role */\n+\tif (dr_mode == USB_DR_MODE_OTG) {\n+\t\tret = cdns3_get_otg_mode(parent, &dr_mode);\n+\t\tif (ret < 0)\n+\t\t\treturn ret;\n+\t}\n+\n \tswitch (dr_mode) {\n #if defined(CONFIG_SPL_USB_HOST) || \\\n \t(!defined(CONFIG_XPL_BUILD) && defined(CONFIG_USB_HOST))\ndiff --git a/drivers/usb/cdns3/drd.c b/drivers/usb/cdns3/drd.c\nindex cbb13342343..0ca40a5cc8d 100644\n--- a/drivers/usb/cdns3/drd.c\n+++ b/drivers/usb/cdns3/drd.c\n@@ -301,6 +301,17 @@ int cdns3_drd_init(struct cdns3 *cdns)\n \t\tcdns->dr_mode = USB_DR_MODE_PERIPHERAL;\n \t}\n \n+\t/*\n+\t * In the absence of STRAP configuration, use VBUS Valid to\n+\t * determine the appropriate role to be assigned to dr_mode.\n+\t */\n+\tif (cdns->dr_mode == USB_DR_MODE_OTG) {\n+\t\tif (cdns3_get_vbus(cdns))\n+\t\t\tcdns->dr_mode = USB_DR_MODE_PERIPHERAL;\n+\t\telse\n+\t\t\tcdns->dr_mode = USB_DR_MODE_HOST;\n+\t}\n+\n \tstate = readl(&cdns->otg_regs->sts);\n \tif (OTGSTS_OTG_NRDY(state) != 0) {\n \t\tdev_err(cdns->dev, \"Cadence USB3 OTG device not ready\\n\");\n", "prefixes": [ "v3" ] }