Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196566/?format=api
{ "id": 2196566, "url": "http://patchwork.ozlabs.org/api/patches/2196566/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260215052225.22513-11-mohamed@unpredictable.fr/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260215052225.22513-11-mohamed@unpredictable.fr>", "list_archive_url": null, "date": "2026-02-15T05:22:21", "name": "[v3,10/14] whpx: i386: remove remaining winhvemulation support code", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "5ed7f9d6cc47e5ffe941a571b0e4ce669e0834c4", "submitter": { "id": 91318, "url": "http://patchwork.ozlabs.org/api/people/91318/?format=api", "name": "Mohamed Mediouni", "email": "mohamed@unpredictable.fr" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260215052225.22513-11-mohamed@unpredictable.fr/mbox/", "series": [ { "id": 492201, "url": "http://patchwork.ozlabs.org/api/series/492201/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492201", "date": "2026-02-15T05:22:12", "name": "whpx: x86 updates (2026-02)", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/492201/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196566/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196566/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=unpredictable.fr header.i=@unpredictable.fr\n header.a=rsa-sha256 header.s=sig1 header.b=YYfhpvCh;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fDDq61FJyz1xwj\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 15 Feb 2026 16:24:18 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vrUbH-0000R5-LI; Sun, 15 Feb 2026 00:23:19 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1vrUb9-0000Pl-4l\n for qemu-devel@nongnu.org; Sun, 15 Feb 2026 00:23:11 -0500", "from p-west2-cluster1-host11-snip4-10.eps.apple.com ([57.103.68.33]\n helo=outbound.mr.icloud.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1vrUb7-0004u5-EH\n for qemu-devel@nongnu.org; Sun, 15 Feb 2026 00:23:10 -0500", "from outbound.mr.icloud.com (unknown [127.0.0.2])\n by p00-icloudmta-asmtp-us-west-2a-60-percent-1 (Postfix) with ESMTPS id\n 4CFA618006AA; Sun, 15 Feb 2026 05:23:07 +0000 (UTC)", "from localhost.localdomain (unknown [17.57.152.38])\n by p00-icloudmta-asmtp-us-west-2a-60-percent-1 (Postfix) with ESMTPSA id\n CE0CC1800103; Sun, 15 Feb 2026 05:23:03 +0000 (UTC)" ], "Dkim-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr;\n s=sig1; t=1771132988; x=1773724988;\n bh=bIb2USwKqldYX6wHKR7h+SU/ZoexRDb/MQYEkd5ZjcI=;\n h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme;\n b=YYfhpvChqZ7aML0lmom7XVtMP+JvYL+/5YPUUxvgC+qTe12aBRvhFY/fX+Q1c7F1aaWf+yViwWMnsid+AxljCBT/Pv0fUZxJBsC8x6DmOURNH12p/7HAyohJb9leeOUXWG/5qvlNxeB8ibE/f7azX2H0/5FVM4LRLy2bptNzzGnKCHo0bGHt83K/D4Blx6ESNHP+aJfdq5XXgLRHnTlNGsprsw7Z8XQYxf0ibFrqIDiZKs0XAHAnm4zY4pRu+N4TWGlmzsUJSde4WUmESFVDbadvkxJ96JRxq7HxJqrVg668VkMs0waOr7eH2otfnJ9SMvLjeMtdfjtjZjtzYZfV9w==", "mail-alias-created-date": "1752046281608", "From": "Mohamed Mediouni <mohamed@unpredictable.fr>", "To": "qemu-devel@nongnu.org", "Cc": "Phil Dennis-Jordan <phil@philjordan.eu>,\n Bernhard Beschow <shentey@gmail.com>, Cameron Esfahani <dirty@apple.com>,\n Magnus Kulke <magnuskulke@linux.microsoft.com>, qemu-arm@nongnu.org,\n Peter Maydell <peter.maydell@linaro.org>,\n Roman Bolshakov <rbolshakov@ddn.com>, Paolo Bonzini <pbonzini@redhat.com>,\n Mohamed Mediouni <mohamed@unpredictable.fr>,\n Pedro Barbuda <pbarbuda@microsoft.com>,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, =?utf-8?q?Marc?=\n\t=?utf-8?q?-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Magnus Kulke <magnus.kulke@linux.microsoft.com>, =?utf-8?q?Philippe_Mathieu?=\n\t=?utf-8?q?-Daud=C3=A9?= <philmd@linaro.org>, Wei Liu <wei.liu@kernel.org>,\n Zhao Liu <zhao1.liu@intel.com>", "Subject": "[PATCH v3 10/14] whpx: i386: remove remaining winhvemulation support\n code", "Date": "Sun, 15 Feb 2026 06:22:21 +0100", "Message-ID": "<20260215052225.22513-11-mohamed@unpredictable.fr>", "X-Mailer": "git-send-email 2.50.1", "In-Reply-To": "<20260215052225.22513-1-mohamed@unpredictable.fr>", "References": "<20260215052225.22513-1-mohamed@unpredictable.fr>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Authority-Info-Out": "v=2.4 cv=eurSD4pX c=1 sm=1 tr=0 ts=6991583c\n cx=c_apl:c_apl_out:c_pps a=9OgfyREA4BUYbbCgc0Y0oA==:117\n a=9OgfyREA4BUYbbCgc0Y0oA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22\n a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=UBzWkQmmy9v7-gCQCgEA:9", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMjE1MDAzNiBTYWx0ZWRfX/3Anl09FbqaP\n hiKWLP+CZynOd8TDdaFhRRbASyajAOLtNZsNvhK/SZWCLsOVEKyz4hzRFdiDA145ovCsGXjVTQT\n pUQBmRrmhnSAcBDd3nCjC9B9Hlei8s8C2ET+4xNqay/0h18TKrtna9olYY8SKzOT3JrwcHrYlIo\n 750RGAZ2eJBlwgzMuMJzbfZdAZN27AXbjTGWzaiWRS6wbTW56gS39UXp2MVGKXRpl0Q1vxT2IZp\n H6HgPDHbJ6cD3daLCXcm1Yx0oECt/3NyvdjgoWhcr73WGyg5IyTfqRhVQnY8FQuj+X7Ivln0BJ0\n Iqf7VnC7uVoLDe9Inya50ftKjYgFXbUcuYDULTS6HX/oWjo+nFMsOnfryanuY4=", "X-Proofpoint-GUID": "tP7qtZw-iqdUbFhDN-FEcdEz6YizJh6d", "X-Proofpoint-ORIG-GUID": "tP7qtZw-iqdUbFhDN-FEcdEz6YizJh6d", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-02-15_02,2026-02-13_01,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=notspam policy=default score=0 suspectscore=0\n malwarescore=0 mlxscore=0 mlxlogscore=999\n bulkscore=0 clxscore=1030\n spamscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 classifier=spam\n authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2602150036", "X-JNJ": "\n AAAAAAABeE7R4N3+f5FgO1KgxJIeF8dk4dA2NWw2UGidy4kY4h17K7eFSPaALrQxlmxe89Tj0iK7yL3sC4LMyMtLmVzVwjRdu14qD8LRrXbsnu+pwCY0ZWDtAg1z4d8qjd49+t2NhEF15/YEq1WD8K9KbhxSUEsxLapusr2tbM0LowUtw2DjkvIl/JSSNnGTm+O8kcpZT4wDIt83HjcHOMAHekSq2rrVa3yEADZ+yYDG2R21BBSmVR8uub39FM2R5ER1rq7gYpb6bGLOhLA7x6i+VSzq3wkXpBEwkZhlMLCF9nw+wl/BSurk1HEL7j9GrhMal+j0FHUyVuPKAHUkDrqQ3TkG6DuyC8izU82TMrSNoEdNOgyvkk72RCBmYalw7gvP0B6uw83G93r7RuPtHvOt9NYpyWQ8RszSGX9k+dGW6+O5wzmWALlC76bWxobAi7dAszEc82uXq+CGZDHPmoK+D2FkmhZZ7La5mgiNzx7k2EBjZAkHz9xGGY1fQgiXZhwQI7kJaNsptScNqMOPENcxqE1c8jgQwWg5QrGB3mpFwW08CmLaJKkNwYGzWs9jej+gIcwCn0p87KkmdsdDgj0dAEVC05wsYjHY5FsgLuV0PoP2JAsqWBa79VmFxu6n1sN4fCQk7w2W4mJSvo0Zn9Jxj5g1QDf2L/+VvgtZhHzeihW4qu0xj1uXUlSGioUemm72IvsHW+w8rpa0mMYlalhY1z/pm4BZ2lm8dL1imeKt3y7OmOK6OkzHu90RHzqXsy7bYZSxK4eOGU46N6CXmR3q4U0HN1cZ3eFRkuc4hwSVl4RfIxMNCWIzfren", "Received-SPF": "pass client-ip=57.103.68.33;\n envelope-from=mohamed@unpredictable.fr; helo=outbound.mr.icloud.com", "X-Spam_score_int": "-27", "X-Spam_score": "-2.8", "X-Spam_bar": "--", "X-Spam_report": "(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "After moving away to target/i386/emulate, this is no longer necessary.\n\nSigned-off-by: Mohamed Mediouni <mohamed@unpredictable.fr>\n---\n accel/whpx/whpx-common.c | 22 ----------------------\n include/system/whpx-common.h | 3 ---\n include/system/whpx-internal.h | 16 ----------------\n meson.build | 3 +--\n 4 files changed, 1 insertion(+), 43 deletions(-)", "diff": "diff --git a/accel/whpx/whpx-common.c b/accel/whpx/whpx-common.c\nindex c2263c2496..245e64a12f 100644\n--- a/accel/whpx/whpx-common.c\n+++ b/accel/whpx/whpx-common.c\n@@ -39,9 +39,6 @@ bool whpx_allowed;\n bool whpx_irqchip_in_kernel;\n static bool whp_dispatch_initialized;\n static HMODULE hWinHvPlatform;\n-#ifdef HOST_X86_64\n-static HMODULE hWinHvEmulation;\n-#endif\n \n struct whpx_state whpx_global;\n struct WHPDispatch whp_dispatch;\n@@ -393,7 +390,6 @@ static bool load_whp_dispatch_fns(HMODULE *handle,\n HMODULE hLib = *handle;\n \n #define WINHV_PLATFORM_DLL \"WinHvPlatform.dll\"\n- #define WINHV_EMULATION_DLL \"WinHvEmulation.dll\"\n #define WHP_LOAD_FIELD_OPTIONAL(return_type, function_name, signature) \\\n whp_dispatch.function_name = \\\n (function_name ## _t)GetProcAddress(hLib, #function_name); \\\n@@ -420,14 +416,6 @@ static bool load_whp_dispatch_fns(HMODULE *handle,\n WHP_LOAD_LIB(WINHV_PLATFORM_DLL, hLib)\n LIST_WINHVPLATFORM_FUNCTIONS(WHP_LOAD_FIELD)\n break;\n- case WINHV_EMULATION_FNS_DEFAULT:\n-#ifdef HOST_X86_64\n- WHP_LOAD_LIB(WINHV_EMULATION_DLL, hLib)\n- LIST_WINHVEMULATION_FUNCTIONS(WHP_LOAD_FIELD)\n-#else\n- g_assert_not_reached();\n-#endif\n- break;\n case WINHV_PLATFORM_FNS_SUPPLEMENTAL:\n WHP_LOAD_LIB(WINHV_PLATFORM_DLL, hLib)\n LIST_WINHVPLATFORM_FUNCTIONS_SUPPLEMENTAL(WHP_LOAD_FIELD_OPTIONAL)\n@@ -543,11 +531,6 @@ bool init_whp_dispatch(void)\n if (!load_whp_dispatch_fns(&hWinHvPlatform, WINHV_PLATFORM_FNS_DEFAULT)) {\n goto error;\n }\n-#ifdef HOST_X86_64\n- if (!load_whp_dispatch_fns(&hWinHvEmulation, WINHV_EMULATION_FNS_DEFAULT)) {\n- goto error;\n- }\n-#endif\n assert(load_whp_dispatch_fns(&hWinHvPlatform,\n WINHV_PLATFORM_FNS_SUPPLEMENTAL));\n whp_dispatch_initialized = true;\n@@ -557,11 +540,6 @@ error:\n if (hWinHvPlatform) {\n FreeLibrary(hWinHvPlatform);\n }\n-#ifdef HOST_X86_64\n- if (hWinHvEmulation) {\n- FreeLibrary(hWinHvEmulation);\n- }\n-#endif\n return false;\n }\n \ndiff --git a/include/system/whpx-common.h b/include/system/whpx-common.h\nindex 5bce33e336..fa2cc9a2ce 100644\n--- a/include/system/whpx-common.h\n+++ b/include/system/whpx-common.h\n@@ -3,9 +3,6 @@\n #define SYSTEM_WHPX_COMMON_H\n \n struct AccelCPUState {\n-#ifdef HOST_X86_64\n- WHV_EMULATOR_HANDLE emulator;\n-#endif\n bool window_registered;\n bool interruptable;\n bool ready_for_pic_interrupt;\ndiff --git a/include/system/whpx-internal.h b/include/system/whpx-internal.h\nindex ad6ade223e..7a1c9871f1 100644\n--- a/include/system/whpx-internal.h\n+++ b/include/system/whpx-internal.h\n@@ -4,9 +4,6 @@\n \n #include <windows.h>\n #include <winhvplatform.h>\n-#ifdef HOST_X86_64\n-#include <winhvemulation.h>\n-#endif\n #include \"hw/i386/apic.h\"\n #include \"exec/vaddr.h\"\n \n@@ -89,12 +86,6 @@ void whpx_apic_get(APICCommonState *s);\n X(HRESULT, WHvResetPartition, \\\n (WHV_PARTITION_HANDLE Partition)) \\\n \n-#define LIST_WINHVEMULATION_FUNCTIONS(X) \\\n- X(HRESULT, WHvEmulatorCreateEmulator, (const WHV_EMULATOR_CALLBACKS* Callbacks, WHV_EMULATOR_HANDLE* Emulator)) \\\n- X(HRESULT, WHvEmulatorDestroyEmulator, (WHV_EMULATOR_HANDLE Emulator)) \\\n- X(HRESULT, WHvEmulatorTryIoEmulation, (WHV_EMULATOR_HANDLE Emulator, VOID* Context, const WHV_VP_EXIT_CONTEXT* VpContext, const WHV_X64_IO_PORT_ACCESS_CONTEXT* IoInstructionContext, WHV_EMULATOR_STATUS* EmulatorReturnStatus)) \\\n- X(HRESULT, WHvEmulatorTryMmioEmulation, (WHV_EMULATOR_HANDLE Emulator, VOID* Context, const WHV_VP_EXIT_CONTEXT* VpContext, const WHV_MEMORY_ACCESS_CONTEXT* MmioInstructionContext, WHV_EMULATOR_STATUS* EmulatorReturnStatus)) \\\n-\n #define WHP_DEFINE_TYPE(return_type, function_name, signature) \\\n typedef return_type (WINAPI *function_name ## _t) signature;\n \n@@ -103,16 +94,10 @@ void whpx_apic_get(APICCommonState *s);\n \n /* Define function typedef */\n LIST_WINHVPLATFORM_FUNCTIONS(WHP_DEFINE_TYPE)\n-#ifdef HOST_X86_64\n-LIST_WINHVEMULATION_FUNCTIONS(WHP_DEFINE_TYPE)\n-#endif\n LIST_WINHVPLATFORM_FUNCTIONS_SUPPLEMENTAL(WHP_DEFINE_TYPE)\n \n struct WHPDispatch {\n LIST_WINHVPLATFORM_FUNCTIONS(WHP_DECLARE_MEMBER)\n-#ifdef HOST_X86_64\n- LIST_WINHVEMULATION_FUNCTIONS(WHP_DECLARE_MEMBER)\n-#endif\n LIST_WINHVPLATFORM_FUNCTIONS_SUPPLEMENTAL(WHP_DECLARE_MEMBER)\n };\n \n@@ -122,7 +107,6 @@ bool init_whp_dispatch(void);\n \n typedef enum WHPFunctionList {\n WINHV_PLATFORM_FNS_DEFAULT,\n- WINHV_EMULATION_FNS_DEFAULT,\n WINHV_PLATFORM_FNS_SUPPLEMENTAL\n } WHPFunctionList;\n \ndiff --git a/meson.build b/meson.build\nindex 4af32c3e1f..86bc807e56 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -865,8 +865,7 @@ if get_option('whpx').allowed() and host_os == 'windows'\n endif\n # Leave CONFIG_WHPX disabled\n else\n- if cc.has_header('winhvplatform.h', required: get_option('whpx')) and \\\n- cc.has_header('winhvemulation.h', required: get_option('whpx'))\n+ if cc.has_header('winhvplatform.h', required: get_option('whpx'))\n accelerators += 'CONFIG_WHPX'\n endif\n endif\n", "prefixes": [ "v3", "10/14" ] }