Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196510/?format=api
{ "id": 2196510, "url": "http://patchwork.ozlabs.org/api/patches/2196510/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/20260214114821.2414121-1-daniel.barboza@oss.qualcomm.com/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260214114821.2414121-1-daniel.barboza@oss.qualcomm.com>", "list_archive_url": null, "date": "2026-02-14T11:48:21", "name": "tree-ssa-phiopt: remove mispredicted AND->(OR|AND) bitop [PR64567]", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "74a9c8c7896b16d866665ec726b68d2b8ee69e8e", "submitter": { "id": 92288, "url": "http://patchwork.ozlabs.org/api/people/92288/?format=api", "name": "Daniel Barboza", "email": "daniel.barboza@oss.qualcomm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/20260214114821.2414121-1-daniel.barboza@oss.qualcomm.com/mbox/", "series": [ { "id": 492170, "url": "http://patchwork.ozlabs.org/api/series/492170/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=492170", "date": "2026-02-14T11:48:21", "name": "tree-ssa-phiopt: remove mispredicted AND->(OR|AND) bitop [PR64567]", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492170/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196510/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196510/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=miQXAIC/;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=FdTAG2Yy;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=miQXAIC/;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=FdTAG2Yy", "sourceware.org; dmarc=none (p=none dis=none)\n header.from=oss.qualcomm.com", "sourceware.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com", "server2.sourceware.org;\n arc=none smtp.remote-ip=205.220.180.131" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fCnPZ3vqDz1xwj\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 14 Feb 2026 22:49:04 +1100 (AEDT)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 549754BAD14A\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 14 Feb 2026 11:49:02 +0000 (GMT)", "from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com\n [205.220.180.131])\n by sourceware.org (Postfix) with ESMTPS id BC80B4B9DB7A\n for <gcc-patches@gcc.gnu.org>; Sat, 14 Feb 2026 11:48:28 +0000 (GMT)", "from pps.filterd (m0279872.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 61EBTnHZ2440609\n for <gcc-patches@gcc.gnu.org>; Sat, 14 Feb 2026 11:48:28 GMT", "from mail-dy1-f199.google.com (mail-dy1-f199.google.com\n [74.125.82.199])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cahe60mef-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for <gcc-patches@gcc.gnu.org>; Sat, 14 Feb 2026 11:48:28 +0000 (GMT)", "by mail-dy1-f199.google.com with SMTP id\n 5a478bee46e88-2ba8a461dd9so16792654eec.1\n for <gcc-patches@gcc.gnu.org>; Sat, 14 Feb 2026 03:48:27 -0800 (PST)", "from grind.dc1.ventanamicro.com ([179.193.9.245])\n by smtp.gmail.com with ESMTPSA id\n a92af1059eb24-12742c6ce01sm1882822c88.7.2026.02.14.03.48.24\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 14 Feb 2026 03:48:25 -0800 (PST)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org 549754BAD14A", "OpenDKIM Filter v2.11.0 sourceware.org BC80B4B9DB7A" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org BC80B4B9DB7A", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org BC80B4B9DB7A", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771069708; cv=none;\n b=BDXcMtxMZHpFwMlye7sgbiHYl4kPylRwiSTEAu/dpl22Vp/fEvsoFxktdFnSj0mzjl92oQwo8glmXyV7MLfNt6UL2Bm/OMseC8Epe6Hbm2juBvmuWVrmnPhaqchb87FVPp2QBLGis2Je1ikXzRVcYayiGb1FV1/OHv4tuRWCnts=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1771069708; c=relaxed/simple;\n bh=ALKBwVxy6U3+Xp0azpanWrBqbp/h3tT5iaVaItQYVeg=;\n h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID:\n MIME-Version;\n b=NGvqUYQQ5ofMcYZSrSlZNkr2MfkKn7KxJHhRCm9IDFx2xLHwTMLjO0PFC+zKgu2REyQl2Mtt9bCNkMCkSulAfcrAU3RpS5q9TqGUpgI7D6MoNR23j+TEoNffwff17jOiKS7QxrlUlv9+vBAZevCxbUwEr+6pklvej0gx0f0Cy1c=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:date:from:message-id:mime-version\n :subject:to; s=qcppdkim1; bh=YD90ESjH3TBWaMt4SOcMLk+7CITLoKDa4iL\n lrbg6PS0=; b=miQXAIC/eaP/BZLZGIP9r5J7v7yTDQ2k/10RrvbydYAg/Er55rM\n aFq/20o19j1pvOKKAzV0w/H4dkHfZpiOK4T4xqk/qnw69iDoG7blOEtV8Oinnr/B\n aXcfMtb5XaAASOU54l39NjGHNcMeiHgDnH12XeS2PZzaPJgEffPfYLlPU20qfYfI\n /Xg+GnFaslkN9eGisM+J3rurx9qPBrhBTC9+CjiWeHvKFw2xyQx04hrSCgGl3eIe\n aG+WBtFgHL7FEf+74pjgD7GXcEtmff7ZOXPxgFXyq/Z7jHfyqmlFS1spuORhfpAA\n C43TEnLCJE3oQzTLRFG/+Ktmrq6XRMObEfQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1771069707; x=1771674507; darn=gcc.gnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=YD90ESjH3TBWaMt4SOcMLk+7CITLoKDa4iLlrbg6PS0=;\n b=FdTAG2Yym1wCX1NmRZkdxzyuqCKsiJE05jEsee0Xq+z2djrKq+7eG1D24jx96+qIpQ\n /sCyBkhObY87zMWq1xdLtSi4M6WydROM5goNHO+7oUyPGRMZ9cwj1aIPwWE1Fhcrddft\n 8e39jldXUpUNunLJ8Q7sy/66bDcDfG/MBqhfX7Yx6sMKIQ9k+89HkTLppekw/4tP96Tw\n kQD0IKCiB+oYE4yTYPM2dtgsA0XDmiUXSNonPq7YGKP3GgonnrTJrweyDXWAxbZrU3oy\n hMuTRc5LkP5NloeqqyS3ki2s+qxqPrGnLdKwr+QZbNyw1b9dqMsPnzGAwUL85v2tbTZT\n 1H8w==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771069707; x=1771674507;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=YD90ESjH3TBWaMt4SOcMLk+7CITLoKDa4iLlrbg6PS0=;\n b=Xu4kp7V05ceSoDpti/GXUsIdx9i1jPxJZ0TX501ZMNjDq6Uu079xj144/UCWckdVL+\n zlTxx6gUKxRN2bFxbhlMziSo3LBK/TchmJn7LIucZcP8a29Sm10VcBjYrr9QSJE7qy17\n XPDH/gadL859gHT4Se42IIs4o2SiMBdAlGUS98g7u9R3ko8xHL4NSAtFFyhGAaCzI04+\n 4onbdij2VXbjh09Hj2jlBvsGHbktU0eK22oVi+iitDKQ0nPEC9o11o1/rEi3W/T9VHcR\n dbhu0dJxy/SI/6IfPYpYYuvfAT/ziXgFr/64kCknwCzwuhOUYfLmG0SHuW6c3RqyiSQJ\n oneg==", "X-Gm-Message-State": "AOJu0YwJQJA3Ex8iuygQj1EJ5PXsAScwnUc/D1MGoKio1h9u24xcScAs\n amWmNpEMwu6wMKD0s8eKyqQp6WmoUzz9Y+1ZJkLVV035D7ohgtaygwQslkd9hyakIATjxxHoM6l\n HTdZdTSIBTn4zMEYqUH4mkuttrlGg8Fh7k9+EzsM237u8uoF9+vfuCQIskHIcBiU+2gI6", "X-Gm-Gg": "AZuq6aJEQEe91QzUwzAbEU5mP9Lh14ZJKqZQ0sXjGIr/+k+VBf/tvzjG7tyzMW/vYQj\n XItAkszI+pticG8BCCvPYx3l459RA13w1q4jFlfHZEPQ6z3SSWqNs7AcE+dZ/GM+rRU2TPC17Qy\n UXPVgbE2biPpQmUFKZIpiiza4t3Pd4ln7b1YEZwk696naTxg5qANx1ndkgsH0nwyQ8PpO/Tt17Z\n CtslK7A3tOYcRFQN7KDqDrq3R6eIptXksb7w8BJQlCLKEjLV/MZ4syUvkY0F/CwZeZTPIRgJCm2\n 2GQbjht2QXwrUdlKR5QbVScsRchBdBlp0aERWLXUu0WLTUwrSHklvaqBPn8KCK6ShXaGGRZkOti\n QJMtv3A9eAoKlJZS1KfFGbBlMK6Ewn21lmM17liJZN4SoEHX99KwnyCFS", "X-Received": [ "by 2002:a05:7300:e619:b0:2ba:7f26:d863 with SMTP id\n 5a478bee46e88-2babc3d924bmr2053325eec.16.1771069706604;\n Sat, 14 Feb 2026 03:48:26 -0800 (PST)", "by 2002:a05:7300:e619:b0:2ba:7f26:d863 with SMTP id\n 5a478bee46e88-2babc3d924bmr2053293eec.16.1771069705890;\n Sat, 14 Feb 2026 03:48:25 -0800 (PST)" ], "From": "Daniel Barboza <daniel.barboza@oss.qualcomm.com>", "To": "gcc-patches@gcc.gnu.org", "Cc": "jeffrey.law@oss.qualcomm.com, andrew.pinski@oss.qualcomm.com,\n Daniel Barboza <daniel.barboza@oss.qualcomm.com>", "Subject": "[PATCH] tree-ssa-phiopt: remove mispredicted AND->(OR|AND) bitop\n [PR64567]", "Date": "Sat, 14 Feb 2026 08:48:21 -0300", "Message-ID": "<20260214114821.2414121-1-daniel.barboza@oss.qualcomm.com>", "X-Mailer": "git-send-email 2.51.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Authority-Analysis": "v=2.4 cv=c5WmgB9l c=1 sm=1 tr=0 ts=6990610c cx=c_pps\n a=cFYjgdjTJScbgFmBucgdfQ==:117 a=li3dXIDAslFm3Zus54lMNg==:17\n a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=rZXkxLWsO1O0eVZT8NAA:9\n a=scEy_gLbYbu1JhEsrz4S:22", "X-Proofpoint-GUID": "2dwUalu_dUTnMHZnn6slw9LBzPxMyANp", "X-Proofpoint-ORIG-GUID": "2dwUalu_dUTnMHZnn6slw9LBzPxMyANp", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMjE0MDA5NSBTYWx0ZWRfXwbxP8x7ji8sO\n BEQ1y7K8/moxMpmlRBqnroVvgfnYv6uTBK4PXtT7PFs7mNebf4Hb4R7Wpw8rtrwuEzmAtWWZppd\n VHmmDlOznudB/bndQGydikvZI0uk4wIkfVIIzCjobZVkOxnYHAayByhi6N1snSeMuoNiin3uh5q\n AmPpALEHg3Or351+jTaY+prfpA1s+k9gwJTa5P8WkDpdto1ZMUbmOEZmboK1IsbtA5IOTc251tr\n 83paHrcq9r6xkVYGTuED646uQYYcbpANtgG+9qv648G24FxgnnoVlPIWpLKGTJwWAL8iPiZxzGB\n X8Se2OMBb5gz8wkz+iGj7CNO/NlrBhVSbAXq3fjP1VgP1kYxZnSk0DPsk1DhIrDVBYGENFIFMkT\n AxkbAfjRUOlLkNOODgIBxbIkQgEswmT5aNz4taxXMVygckgWlaiH6SbAUZGIohPTE+aKmoVCYrh\n w8/Si32Cak29xjS0Y6Q==", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-02-13_05,2026-02-13_01,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n impostorscore=0 suspectscore=0 phishscore=0 clxscore=1015 malwarescore=0\n bulkscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602140095", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "Add a new helper that handles mispredicts in the following bit ops\nscenarios:\n\n- checking if a bitmask is not set, and in this case set it: always set\n the bitmask;\n- checking if a bitmask is set, and in this case clear it: always clear\n the bitmask.\n\nBootstrapped and tested with x86_64-pc-linux-gnu.\n\n\tPR tree-optimization/64567\n\ngcc/ChangeLog:\n\n\t* tree-ssa-phiopt.cc (block_has_single_assignment): simple\n\thelper that verifies in a block has a single statement.\n\t(cond_removal_mispredict_bitop): helper that verifies if we have\n\ta bitmask check that leads to the same bitmask being\n\tset/cleared, and make the set/clear unconditional.\n\t(pass_phiopt::execute): use the new helper.\n\ngcc/testsuite/ChangeLog:\n\n\t* gcc.dg/tree-ssa/PR64567.c: New test.\n---\n gcc/testsuite/gcc.dg/tree-ssa/PR64567.c | 23 ++++\n gcc/tree-ssa-phiopt.cc | 170 ++++++++++++++++++++++++\n 2 files changed, 193 insertions(+)\n create mode 100644 gcc/testsuite/gcc.dg/tree-ssa/PR64567.c", "diff": "diff --git a/gcc/testsuite/gcc.dg/tree-ssa/PR64567.c b/gcc/testsuite/gcc.dg/tree-ssa/PR64567.c\nnew file mode 100644\nindex 00000000000..09e8cee62ee\n--- /dev/null\n+++ b/gcc/testsuite/gcc.dg/tree-ssa/PR64567.c\n@@ -0,0 +1,23 @@\n+/* { dg-additional-options -O2 } */\n+/* { dg-additional-options -fdump-tree-phiopt } */\n+\n+#define F1 0x04\n+#define F2 0x08\n+\n+int bar(unsigned flags);\n+\n+int foo(unsigned flags)\n+{\n+ if (flags & (F1 | F2))\n+ flags &= ~(F1 | F2);\n+ return bar(flags);\n+}\n+\n+int baz(unsigned flags)\n+{\n+ if (!(flags & F1))\n+ flags |= F1;\n+ return bar(flags);\n+}\n+\n+/* { dg-final { scan-tree-dump-times \" PHI \" 0 phiopt2 } } */\ndiff --git a/gcc/tree-ssa-phiopt.cc b/gcc/tree-ssa-phiopt.cc\nindex fcf44136d0a..ef1c9eb8b19 100644\n--- a/gcc/tree-ssa-phiopt.cc\n+++ b/gcc/tree-ssa-phiopt.cc\n@@ -2703,6 +2703,172 @@ cond_removal_in_builtin_zero_pattern (basic_block cond_bb,\n return true;\n }\n \n+/* Check if a BB has a single assignment or a single assignment\n+ and a GOTO. Return the gimple assignment or NULL if\n+ the BB does not match the criteria. */\n+\n+static gimple*\n+block_has_single_assignment (basic_block bb)\n+{\n+ gimple_stmt_iterator gsi = gsi_start_nondebug_after_labels_bb (bb);\n+ gimple *stmt = gsi_stmt (gsi);\n+\n+ if (!stmt || !is_gimple_assign (stmt))\n+ return NULL;\n+\n+ gsi = gsi_last_nondebug_bb (bb);\n+ gimple *last_stmt = gsi_stmt (gsi);\n+\n+ if (!last_stmt)\n+ return NULL;\n+\n+ if (gimple_code (last_stmt) == GIMPLE_GOTO)\n+ {\n+ gsi_prev (&gsi);\n+ last_stmt = gsi_stmt (gsi);\n+ }\n+\n+ if (last_stmt != stmt)\n+ return NULL;\n+\n+ return stmt;\n+}\n+\n+/* Optimize the case where we have a bitmask check and\n+ a bitmask set/clear of the same mask, making the\n+ set/clear unconditional. E.g for a bitmask set case:\n+\n+ _1 = flags_3 & bitmask;\n+ if (_1 == 0)\n+ goto <bb 3>; [INV]\n+ else\n+ goto <bb 4>; [INV]\n+\n+ ;; basic block 3, loop depth 0, maybe hot\n+ flags_4 = flags_3 | bitmask;\n+ ;; succ: 4 (FALLTHRU,EXECUTABLE)\n+\n+ ;; basic block 4, loop depth 0, maybe hot\n+ # flags_2 = PHI <flags_3, flags_4>\n+\n+ We'll make the gcond always true, always setting the\n+ bitmask. The gcond disappears, and the BIT_AND op\n+ used by it also goes away if it's not being used elsewhere.\n+\n+ Likewise for the bitmask clear case. */\n+\n+static bool\n+cond_removal_mispredict_bitop (basic_block cond_bb,\n+\t\t\t basic_block middle_bb,\n+\t\t\t tree arg0, tree arg1)\n+{\n+ /* Check if the middle_bb has a single stmt or a\n+ single stmt + a goto. */\n+ gimple *mid_stmt = block_has_single_assignment (middle_bb);\n+ if (!mid_stmt)\n+ return false;\n+\n+ /* mid_stmt constraints:\n+ - Must be either an IOR or an AND;\n+ - RHS1 is a SSA_NAME with integral type. */\n+ if (gimple_assign_rhs_class (mid_stmt) != GIMPLE_BINARY_RHS)\n+ return false;\n+\n+ tree rhs1 = gimple_assign_rhs1 (mid_stmt);\n+ if (TREE_CODE (rhs1) != SSA_NAME\n+ || !INTEGRAL_TYPE_P (TREE_TYPE (rhs1)))\n+ return false;\n+\n+ tree_code mid_code = gimple_assign_rhs_code (mid_stmt);\n+ if (mid_code != BIT_AND_EXPR && mid_code != BIT_IOR_EXPR)\n+ return false;\n+\n+ if (arg0 != gimple_assign_lhs (mid_stmt)\n+ || arg1 != gimple_assign_rhs1 (mid_stmt))\n+ return false;\n+\n+ /* 'cond' must be the format: SSA_NAME EQ|NE integer_zerop,\n+ where cond_code varies with mid_stmt OP:\n+\n+ - SSA_NAME == 0 and mid_stmt = BIT_AND;\n+ - SSA_NAME != 0 and mid_stmt = BIT_IOR.\n+\n+ We're assuming that SSA_NAME is a suitable BIT_AND\n+ for now. */\n+ gcond *cond = safe_dyn_cast <gcond *> (*gsi_last_bb (cond_bb));\n+ if (!cond)\n+ return false;\n+\n+ if (TREE_CODE (gimple_cond_lhs (cond)) != SSA_NAME\n+ || !integer_zerop (gimple_cond_rhs (cond)))\n+ return false;\n+\n+ tree_code cond_code = gimple_cond_code (cond);\n+ if (cond_code != EQ_EXPR && cond_code != NE_EXPR)\n+ return false;\n+\n+ if ((cond_code == NE_EXPR && mid_code != BIT_AND_EXPR)\n+ || (cond_code == EQ_EXPR && mid_code != BIT_IOR_EXPR))\n+ return false;\n+\n+ gimple *cond_stmt = SSA_NAME_DEF_STMT (gimple_cond_lhs (cond));\n+ if (!cond_stmt || !is_gimple_assign (cond_stmt)\n+ || gimple_assign_rhs_class (cond_stmt) != GIMPLE_BINARY_RHS\n+ || gimple_assign_rhs_code (cond_stmt) != BIT_AND_EXPR)\n+ return false;\n+\n+ /* RHS1 for both cond_stmt and mid_stmt must be the same.\n+ RHS2 will depend of what we're trying to map. For a\n+ \"check if set, if not set it\":\n+\n+ _1 = SSA_NAME & imm\n+ if (_1 == 0) goto 3 else goto 4\n+ 3: _4 = SSA_NAME | imm\n+\t(fallthrough to 4)\n+\n+ RHS2 must be the same for both. However for a \"if set, clear it\"\n+ case:\n+\n+ _1 = SSA_NAME & imm\n+ if (_1 != 0) goto 3 else goto 4\n+ 3: _4 = SSA_NAME & (mask ~imm)\n+\t(fallthrough to 4)\n+\n+ mid_stmt RHS2 must clear 'imm', meaning that it must be a\n+ mask format. Both RHS2 must also be INTEGER_CST. */\n+ if (gimple_assign_rhs1 (cond_stmt) != gimple_assign_rhs1 (mid_stmt))\n+ return false;\n+\n+ if (mid_code == BIT_IOR_EXPR\n+ && gimple_assign_rhs2 (cond_stmt) != gimple_assign_rhs2 (mid_stmt))\n+ return false;\n+ else if (mid_code == BIT_AND_EXPR)\n+ {\n+ tree cond_stmt_imm = gimple_assign_rhs2 (cond_stmt);\n+ tree mid_stmt_imm = gimple_assign_rhs2 (mid_stmt);\n+\n+ if (TREE_CODE (cond_stmt_imm) != INTEGER_CST\n+\t || TREE_CODE (mid_stmt_imm) != INTEGER_CST)\n+\treturn false;\n+\n+ wide_int cond_imm = wi::to_wide (cond_stmt_imm);\n+ wide_int mid_imm = wi::to_wide (mid_stmt_imm);\n+\n+ if (!wi::ltu_p (cond_imm, mid_imm)\n+\t || wi::ne_p (mid_imm, wi::bit_not (cond_imm)))\n+\treturn false;\n+ }\n+\n+ /* Finally set 'cond' to always execute mid_stmt. */\n+ edge e = single_pred_edge (middle_bb);\n+ if (e->flags & EDGE_TRUE_VALUE)\n+ gimple_cond_make_true (cond);\n+ else\n+ gimple_cond_make_false (cond);\n+\n+ return true;\n+}\n+\n /* Auxiliary functions to determine the set of memory accesses which\n can't trap because they are preceded by accesses to the same memory\n portion. We do that for MEM_REFs, so we only need to track\n@@ -4073,6 +4239,10 @@ pass_phiopt::execute (function *)\n \t && !diamond_p\n \t && spaceship_replacement (bb, bb1, e1, e2, phi, arg0, arg1))\n \tcfgchanged = true;\n+ else if (single_pred_p (bb1)\n+\t && !diamond_p\n+\t && cond_removal_mispredict_bitop (bb, bb1, arg0, arg1))\n+\tcfgchanged = true;\n };\n \n execute_over_cond_phis (phiopt_exec);\n", "prefixes": [] }