Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196509/?format=api
{ "id": 2196509, "url": "http://patchwork.ozlabs.org/api/patches/2196509/?format=api", "web_url": "http://patchwork.ozlabs.org/project/buildroot/patch/20260214-libxmlsec_fix-v1-1-0512d1cd6e06@bootlin.com/", "project": { "id": 27, "url": "http://patchwork.ozlabs.org/api/projects/27/?format=api", "name": "Buildroot development", "link_name": "buildroot", "list_id": "buildroot.buildroot.org", "list_email": "buildroot@buildroot.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260214-libxmlsec_fix-v1-1-0512d1cd6e06@bootlin.com>", "list_archive_url": null, "date": "2026-02-14T11:25:14", "name": "package/libxmlsec1: disable des support", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "516c7eade78f0142bdce323d766d703416b17468", "submitter": { "id": 85775, "url": "http://patchwork.ozlabs.org/api/people/85775/?format=api", "name": "Alexis Lothoré", "email": "alexis.lothore@bootlin.com" }, "delegate": { "id": 89618, "url": "http://patchwork.ozlabs.org/api/users/89618/?format=api", "username": "juju", "first_name": "Julien", "last_name": "Olivain", "email": "juju@cotds.org" }, "mbox": "http://patchwork.ozlabs.org/project/buildroot/patch/20260214-libxmlsec_fix-v1-1-0512d1cd6e06@bootlin.com/mbox/", "series": [ { "id": 492169, "url": "http://patchwork.ozlabs.org/api/series/492169/?format=api", "web_url": "http://patchwork.ozlabs.org/project/buildroot/list/?series=492169", "date": "2026-02-14T11:25:14", "name": "package/libxmlsec1: disable des support", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492169/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196509/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196509/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<buildroot-bounces@buildroot.org>", "X-Original-To": [ "incoming-buildroot@patchwork.ozlabs.org", "buildroot@buildroot.org" ], "Delivered-To": [ "patchwork-incoming-buildroot@legolas.ozlabs.org", "buildroot@buildroot.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=buildroot.org header.i=@buildroot.org\n header.a=rsa-sha256 header.s=default header.b=ZvFoGbYU;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=buildroot.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=buildroot-bounces@buildroot.org; receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fCmvK3GSMz1xpl\n\tfor <incoming-buildroot@patchwork.ozlabs.org>;\n Sat, 14 Feb 2026 22:26:21 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id DF254406B3;\n\tSat, 14 Feb 2026 11:26:13 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 6jkEHnZxGJkD; Sat, 14 Feb 2026 11:26:11 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 18F7740553;\n\tSat, 14 Feb 2026 11:26:11 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists1.osuosl.org (Postfix) with ESMTP id 0514D270\n for <buildroot@buildroot.org>; Sat, 14 Feb 2026 11:26:09 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id DE1FD82201\n for <buildroot@buildroot.org>; Sat, 14 Feb 2026 11:26:08 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id S_vsTo61C30h for <buildroot@buildroot.org>;\n Sat, 14 Feb 2026 11:26:08 +0000 (UTC)", "from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4])\n by smtp1.osuosl.org (Postfix) with ESMTPS id AF593821EF\n for <buildroot@buildroot.org>; Sat, 14 Feb 2026 11:26:06 +0000 (UTC)", "from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233])\n by smtpout-03.galae.net (Postfix) with ESMTPS id 6E0AD4E40D8A\n for <buildroot@buildroot.org>; Sat, 14 Feb 2026 11:26:04 +0000 (UTC)", "from mail.galae.net (mail.galae.net [212.83.136.155])\n by smtpout-01.galae.net (Postfix) with ESMTPS id 45550606CB\n for <buildroot@buildroot.org>; Sat, 14 Feb 2026 11:26:04 +0000 (UTC)", "from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon)\n with ESMTPSA id 64F5A10368FFD; Sat, 14 Feb 2026 12:26:03 +0100 (CET)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=buildroot-bounces@buildroot.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 18F7740553", "OpenDKIM Filter v2.11.0 smtp1.osuosl.org AF593821EF" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=buildroot.org;\n\ts=default; t=1771068371;\n\tbh=NUeUp0SQWISyFn4145TdNrAO6g5RXpatr0bgX8BULQI=;\n\th=Date:To:Cc:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From:Reply-To:From;\n\tb=ZvFoGbYUlaqEzAg0XeSr0rmiCcGdFKmtYTKl9Sfz25gSTqPH8YxZ0ITuVhtQRJ5cd\n\t Ssku5Bxb3DxLqwkMSImlSY5Xse9nhn+wtWgh407SbxbbV41UtNlPX4zFtoa60j39J+\n\t +VIYzWKtDD+U8GMzb4b16PB3Fza4PQbFUhOsHIA+PrQf33YH6YOdL6dZ2l+4J0GV7M\n\t ABFLgdYOoK9LCoFdjf+eXocAFBHCy++E8zOzWADHLCd92qvYdEahQlsjsuEovKquUw\n\t fFT+icFAbBCLQKsU5AAyeHpOgc+Hh7truS69PFkE5hDrT3eblgHFOAP8ATMbzKJIur\n\t rUJC+/HyLkHcw==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=185.246.85.4;\n helo=smtpout-03.galae.net; envelope-from=alexis.lothore@bootlin.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp1.osuosl.org AF593821EF", "Date": "Sat, 14 Feb 2026 12:25:14 +0100", "MIME-Version": "1.0", "Message-Id": "<20260214-libxmlsec_fix-v1-1-0512d1cd6e06@bootlin.com>", "X-B4-Tracking": "v=1; b=H4sIAAAAAAAC/x2MQQqAIBAAvyJ7TlgXEuorEZG21YJZKEQQ/j3pO\n AMzL2ROwhl69ULiW7KcsYJpFPh9jhtrWSoDIVkkQzqIe46Q2U+rPJoQO+ccoW0t1OZKXPX/G8Z\n SPnwtAhRfAAAA", "X-Change-ID": "20260212-libxmlsec_fix-2009bbb20656", "To": "buildroot@buildroot.org", "Cc": "Thomas Petazzoni <thomas.petazzoni@bootlin.com>, =?utf-8?q?Alexis_Lothor?=\n\t=?utf-8?q?=C3=A9?= <alexis.lothore@bootlin.com>", "X-Mailer": "b4 0.14.3", "X-Last-TLS-Session-Version": "TLSv1.3", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=bootlin.com; s=dkim;\n t=1771068363; h=from:subject:date:message-id:to:cc:mime-version:content-type:\n content-transfer-encoding; bh=cBcoPyDX8jPn3EdLRNmHUKDGgTKkAzNhH+nljezbl64=;\n b=xKxT2VWPHLqdU13v/R7drlqzpiPmHRQMQgak7XhJ3E9WqGjSLWdcZhHP0Bo+kmtYEI48Dd\n kgqGjHrrqJ9iRFldEljE3+Af9TP5jesw3RKXB5H8VNJmEHQH+tVeNJuxYytOabWEZIjVzT\n aYt9TliaGEDOuevmKwTJHg+ehITqTBodCunL7Hq6GvVFRaJ7YGSd+v3lp5ui1v7U0kwEDU\n zKx8KB+2Q96lpfcPIxRtHjCAi0LNdpuwZj2djdnUOSukidILv0C4IOg62H71c2vfeAjnM1\n 60mBCdZ4JrjtFBT9XeJCMzw7QVNCbES1X4bVx5O6pyk2k3kE6rWPHeicKCGayw==", "X-Mailman-Original-Authentication-Results": [ "smtp1.osuosl.org;\n dmarc=pass (p=reject dis=none)\n header.from=bootlin.com", "smtp1.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256\n header.s=dkim header.b=xKxT2VWP" ], "Subject": "[Buildroot] [PATCH] package/libxmlsec1: disable des support", "X-BeenThere": "buildroot@buildroot.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Discussion and development of buildroot <buildroot.buildroot.org>", "List-Unsubscribe": "<https://lists.buildroot.org/mailman/options/buildroot>,\n <mailto:buildroot-request@buildroot.org?subject=unsubscribe>", "List-Archive": "<http://lists.buildroot.org/pipermail/buildroot/>", "List-Post": "<mailto:buildroot@buildroot.org>", "List-Help": "<mailto:buildroot-request@buildroot.org?subject=help>", "List-Subscribe": "<https://lists.buildroot.org/mailman/listinfo/buildroot>,\n <mailto:buildroot-request@buildroot.org?subject=subscribe>", "From": "=?utf-8?q?Alexis_Lothor=C3=A9_via_buildroot?= <buildroot@buildroot.org>", "Reply-To": "=?utf-8?q?Alexis_Lothor=C3=A9?= <alexis.lothore@bootlin.com>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "buildroot-bounces@buildroot.org", "Sender": "\"buildroot\" <buildroot-bounces@buildroot.org>" }, "content": "libxmslec1 build fails on some configurations with the following build\nlogs:\n\n CC libxmlsec1_openssl_la-kw_des.lo\n kw_des.c:75:8: error: unknown type name 'xmlSecKWDes3Klass'; did you mean 'xmlSecKWAesKlass'?\n 75 | static xmlSecKWDes3Klass xmlSecOpenSSLKWDes3ImplKlass = {\n | ^~~~~~~~~~~~~~~~~\n | xmlSecKWAesKlass\n kw_des.c:77:5: error: initialization of 'int' from 'int (*)(struct _xmlSecTransform *, xmlSecByte *, size_t, size_t *)' {aka 'int (*)(struct _xmlSecTransform *, unsigned char *, long unsigned int, long unsigned int *)'} makes integer from pointer without a cast [-Wint-conversion]\n 77 | xmlSecOpenSSLKWDes3GenerateRandom, /* xmlSecKWDes3GenerateRandomMethod generateRandom; */\n | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n kw_des.c:77:5: note: (near initialization for 'xmlSecOpenSSLKWDes3ImplKlass')\n kw_des.c:77:5: error: initializer element is not computable at load time\n kw_des.c:77:5: note: (near initialization for 'xmlSecOpenSSLKWDes3ImplKlass')\n kw_des.c:78:5: error: excess elements in scalar initializer\n 78 | xmlSecOpenSSLKWDes3Sha1, /* xmlSecKWDes3Sha1Method sha1; */\n | ^~~~~~~~~~~~~~~~~~~~~~~\n kw_des.c:78:5: note: (near initialization for 'xmlSecOpenSSLKWDes3ImplKlass')\n kw_des.c:79:5: error: excess elements in scalar initializer\n 79 | xmlSecOpenSSLKWDes3BlockEncrypt, /* xmlSecKWDes3BlockEncryptMethod encrypt; */\n | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n kw_des.c:79:5: note: (near initialization for 'xmlSecOpenSSLKWDes3ImplKlass')\n kw_des.c:80:5: error: excess elements in scalar initializer\n 80 | xmlSecOpenSSLKWDes3BlockDecrypt, /* xmlSecKWDes3BlockDecryptMethod decrypt; */\n | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n [...]\n\nThis build failure is due to those struct definitions being set\nconditionally in src/kw_aes_des.h behind a XMLSEC_NO_DES define, and\nthis define ending up being 1 on some builds. We could assume that the\nmakefiles in libxmlsec should just not try to build any DES related file\nwhen XMLSEC_NO_DES is set to 1 (and so, in this specific case, not try\nto build src/openssl/kw_des.c), but the autotools tooling in the project\nis not the one setting XMLSEC_NO_DES: there is a mismatch between\ndetected features at configure time and build time.\n- at build time, the tooling just checks if user has passed\n `--enable-des=no`. If so, it sets XMLSEC_NO_DES, otherwise it assumes\n that DES support is available.\n- at build time, libxmlsec tries to build openssl backend. This backend\n checks OpenSSL features, especially whether OPENSSL_NO_DES is set (and\n if so, it enforces XMLSEC_NO_DES to 1 as well)\n- This OPENSSL_NO_DES comes from libopenssl configuration headers\n installed in sysroot. Its presence is driven by the `no-des` option\n passed at libopenssl configure time\n- This `no-des` flag is driven by buildroot option\n BR2_PACKAGE_LIBOPENSSL_ENABLE_DES\n\nThere are multiple options to fix this package here:\n1. fixing upstream package to make the features detection more robust (eg\n check openssl headers at configure time to ensure that DES is\n supported)\n2. enforce XMLSEC_NO_DES if BR2_PACKAGE_LIBOPENSSL_ENABLE_DES is not set\n3. systematically enforce XMLSEC_NO_DES=1\n\nNow:\n- 1 may take time, and would then need a temporary patch to live in\n buildroot while the fix is accepted upstream and released\n- 2 works only for libopenssl, what if libressl is used ?\n- DES usage is discouraged anyway, as stated by configure logs:\n [...]\n checking for DES support... yes (use discouraged)\n [...]\nAs the package has been introduced very recently, there's a very low\nchance to break any user use case by completely disabling DES support.\n\nSystematically disable DES support in libxmlsec1 to discourage usage and\nfix build failure when the corresponding SSL library does not expose DES\nsupport.\n\nFixes: https://autobuild.buildroot.org/results/3e15f03dc0211c622125ebb69ff7230ce900029a/\nSigned-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>\n---\n package/libxmlsec1/libxmlsec1.mk | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)\n\n\n---\nbase-commit: e728d3506b0bb0c3169b5beccdf6eb523bdda3f7\nchange-id: 20260212-libxmlsec_fix-2009bbb20656\n\nBest regards,", "diff": "diff --git a/package/libxmlsec1/libxmlsec1.mk b/package/libxmlsec1/libxmlsec1.mk\nindex d0d553c48c65..29222bc16ffd 100644\n--- a/package/libxmlsec1/libxmlsec1.mk\n+++ b/package/libxmlsec1/libxmlsec1.mk\n@@ -19,7 +19,8 @@ LIBXMLSEC1_CONF_OPTS = \\\n \t--with-openssl \\\n \t--without-gnutls \\\n \t--without-gcrypt \\\n-\t--without-nss\n+\t--without-nss \\\n+\t--disable-des\n \n HOST_LIBXMLSEC1_CONF_OPTS = \\\n \t--enable-crypto-dl=no \\\n@@ -27,7 +28,8 @@ HOST_LIBXMLSEC1_CONF_OPTS = \\\n \t--without-gnutls \\\n \t--without-gcrypt \\\n \t--without-nss \\\n-\t--without-libxslt\n+\t--without-libxslt \\\n+\t--disable-des\n \n ifeq ($(BR2_PACKAGE_LIBXSLT),y)\n LIBXMLSEC1_DEPENDENCIES += libxslt\n", "prefixes": [] }