Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196470/?format=api
{ "id": 2196470, "url": "http://patchwork.ozlabs.org/api/patches/2196470/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260214024736.3726811-1-simon.glass@canonical.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260214024736.3726811-1-simon.glass@canonical.com>", "list_archive_url": null, "date": "2026-02-14T02:47:34", "name": "kbuild: unexport sub_make_done to fix child make invocations", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "a98ca4166622754816826592c77727d3f956909a", "submitter": { "id": 6170, "url": "http://patchwork.ozlabs.org/api/people/6170/?format=api", "name": "Simon Glass", "email": "sjg@chromium.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260214024736.3726811-1-simon.glass@canonical.com/mbox/", "series": [ { "id": 492155, "url": "http://patchwork.ozlabs.org/api/series/492155/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=492155", "date": "2026-02-14T02:47:34", "name": "kbuild: unexport sub_make_done to fix child make invocations", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492155/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196470/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196470/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=Tz4gsYO7;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"Tz4gsYO7\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fCYPG4Cqdz1xr1\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 14 Feb 2026 13:48:02 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 0CE8383015;\n\tSat, 14 Feb 2026 03:47:53 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 2FD9A83642; Sat, 14 Feb 2026 03:47:50 +0100 (CET)", "from mail-oo1-xc34.google.com (mail-oo1-xc34.google.com\n [IPv6:2607:f8b0:4864:20::c34])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 8084980B98\n for <u-boot@lists.denx.de>; Sat, 14 Feb 2026 03:47:47 +0100 (CET)", "by mail-oo1-xc34.google.com with SMTP id\n 006d021491bc7-662f91bba0fso2615602eaf.0\n for <u-boot@lists.denx.de>; Fri, 13 Feb 2026 18:47:47 -0800 (PST)", "from chromium.org ([73.34.74.121]) by smtp.gmail.com with ESMTPSA id\n 586e51a60fabf-40ee06756easm4886948fac.13.2026.02.13.18.47.43\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 13 Feb 2026 18:47:44 -0800 (PST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1771037265; x=1771642065; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=KfMJHxth4U29GJsSiRSYU/lA3HZuUckLJxmV2+cxv7s=;\n b=Tz4gsYO7ZWF24m5PqinX35r+bvAGdHCLbfFR6Kq4+yelMGJokj2k1rKgbT75tAIwry\n +v9yJk1E8a7ZSrz9op2aJGCIXtFGE5AgFXti/DCkv8qBBByOHFV2xkekwQ3DrxZWVToE\n /tZG7ViIvFPQmNfJSiZ2m4LFyKcTUIzL+LEMA=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771037265; x=1771642065;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=KfMJHxth4U29GJsSiRSYU/lA3HZuUckLJxmV2+cxv7s=;\n b=mQ7Kw+P7YWwoo1NR/GiChsfmBGQkJcoDg3ceIbFl23nO4RyM230/u8l+JG05RMbwxG\n Wkf2NQSguSdMifWlx318Mk4tY1mLLEvhFfHvQQ/UJFEcTgFTFGrwdTWlciI//QAAHm8A\n M4AjJlEeEAIAGfS8dcEmu/y3n7/CfDesov5VS37S1hwsU0PdWFjJ2/66+3LvWuj4Tl6v\n UYLF65Kr6VVKwr2wk0rtm5aXt/D9Q3jbFQu5z2j31ZFxY4Z2TGzDdlBtMTwAyunXZPbZ\n 78gXghs7QnJlM2BZ4k60sMrFt2zS0ZjEsW8bgxc8dtzMOH7R/WdeDMeoJyj+3rsm4Qt0\n FoBA==", "X-Gm-Message-State": "AOJu0YyJRujRPV5i4lqGCgzhoZ+LOFUXHu12XWWTImpDTwmoIjiiUYAh\n GTHI0wo3sLGjQgUiMa/Lo2TI8Eii6kFFRUwpAx8/wddhzg1h/kA8K1a3N7+7emrABRC6rboJTX4\n JLJY=", "X-Gm-Gg": "AZuq6aK0gHh3F1wmjWBm/TcBIRLDH0GuqumTaVLxcWleJAOx6HXCb0lh5eG/JhqXIRY\n 2lAwxSGg8EDvYKN/M9a0c9vhXmj0O7wsC9955F0nnFXbv6HL9ymixkptVVpKoQS9fFokTQTEWd7\n FegVPxXHc4iEVnI4emkKwCyTVQBE6dj3umtz281O3oqk7aGnLYwMEoWIdephN4C7OhxZ2xM7w9I\n Le4w4HFgdvav9Sy6a1dkKEsaxfhK1Kwug9yKrYYFdbyDosDfWACJgN3Hw+Jx0Nt3DsWaiF/FEEG\n X33K8WPc0ka3y0z6WviaVbAaESXYKpWeaUZHLgOLaVIzT7SmmTNBqEdsIogHSyKWklCh+zvYs40\n e/seEWo11/YVrqVvh8rGDlOO0fHGEHad6KDEHQnOnu3W+9FIW3IO6erz7L/P5bkUFbTzHkjdt0F\n Enaknfp8sD9Lj+29uoEH5FwNuagz9n", "X-Received": "by 2002:a05:6820:807:b0:677:f82a:6258 with SMTP id\n 006d021491bc7-678208a4ecdmr1128729eaf.14.1771037265554;\n Fri, 13 Feb 2026 18:47:45 -0800 (PST)", "From": "Simon Glass <sjg@chromium.org>", "X-Google-Original-From": "Simon Glass <simon.glass@canonical.com>", "To": "u-boot@lists.denx.de", "Cc": "Ilias Apalodimas <ilias.apalodimas@linaro.org>,\n Simon Glass <simon.glass@canonical.com>,\n Sughosh Ganu <sughosh.ganu@arm.com>, Tom Rini <trini@konsulko.com>", "Subject": "[PATCH] kbuild: unexport sub_make_done to fix child make invocations", "Date": "Fri, 13 Feb 2026 19:47:34 -0700", "Message-ID": "<20260214024736.3726811-1-simon.glass@canonical.com>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "The exported sub_make_done variable leaks into the environment of all\nchild processes. When make targets like tcheck spawn independent make\ninvocations with O=, those child makes inherit sub_make_done=1, skip\nthe KBUILD_OUTPUT setup and try to build in the source tree.\n\nThere is a workaround that resets sub_make_done to 0 for specific test\ntargets, but this isn't great since it has tolist every target that\nspawns independent make invocations.\n\nInstead, unexport sub_make_done once we are in the final make\ninvocation. The direct sub-make already has the value in its\nenvironment from the export, and no further propagation is needed.\nThis also allows the per-target workaround to be removed.\n\nFixes: 27529f1cb02d (\"kbuild: skip parsing pre sub-make code for recursion\")\nSigned-off-by: Simon Glass <simon.glass@canonical.com>\n---\n\n Makefile | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/Makefile b/Makefile\nindex d38fa5d6aca..f539c6f82f3 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -194,6 +194,10 @@ endif # sub_make_done\n # We process the rest of the Makefile if this is the final invocation of make\n ifeq ($(need-sub-make),)\n \n+# Do not propagate sub_make_done to non-submake children (e.g. test scripts\n+# that invoke make separately with O= need to process the KBUILD_OUTPUT block)\n+unexport sub_make_done\n+\n # Do not print \"Entering directory ...\",\n # but we want to display it when entering to the output directory\n # so that IDEs/editors are able to understand relative filenames.\n@@ -2738,10 +2742,6 @@ help:\n \t@echo 'Execute \"make\" or \"make all\" to build all targets marked with [*] '\n \t@echo 'For further info see the ./README file'\n \n-ifneq ($(filter tests pcheck qcheck tcheck,$(MAKECMDGOALS)),)\n-export sub_make_done := 0\n-endif\n-\n tests check:\n \t$(srctree)/test/run\n \n", "prefixes": [] }