Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196466/?format=api
{ "id": 2196466, "url": "http://patchwork.ozlabs.org/api/patches/2196466/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260214021240.58657-9-philmd@linaro.org/", "project": { "id": 69, "url": "http://patchwork.ozlabs.org/api/projects/69/?format=api", "name": "QEMU powerpc development", "link_name": "qemu-ppc", "list_id": "qemu-ppc.nongnu.org", "list_email": "qemu-ppc@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260214021240.58657-9-philmd@linaro.org>", "list_archive_url": null, "date": "2026-02-14T02:12:39", "name": "[8/8] system/globals: Build as common code", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "2051c05fb7e22fb456616a00b468a11d92411d72", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260214021240.58657-9-philmd@linaro.org/mbox/", "series": [ { "id": 492153, "url": "http://patchwork.ozlabs.org/api/series/492153/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-ppc/list/?series=492153", "date": "2026-02-14T02:12:32", "name": "system: Absorb globals-target.c within common globals.c", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492153/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196466/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196466/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=SEZtf8XF;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fCXfQ50y5z1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 14 Feb 2026 13:14:22 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-ppc-bounces@nongnu.org>)\n\tid 1vr5AL-0004NV-4j; Fri, 13 Feb 2026 21:13:49 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1vr5AJ-00048g-7l\n for qemu-ppc@nongnu.org; Fri, 13 Feb 2026 21:13:47 -0500", "from mail-wm1-x331.google.com ([2a00:1450:4864:20::331])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1vr5AH-0004do-L5\n for qemu-ppc@nongnu.org; Fri, 13 Feb 2026 21:13:46 -0500", "by mail-wm1-x331.google.com with SMTP id\n 5b1f17b1804b1-48379a42f76so2885245e9.0\n for <qemu-ppc@nongnu.org>; Fri, 13 Feb 2026 18:13:45 -0800 (PST)", "from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43796ac8209sm9885016f8f.30.2026.02.13.18.13.42\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 13 Feb 2026 18:13:43 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1771035224; x=1771640024; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=IBfS1gwelZ2mj2qarZUPVGv4uT0cGemLv8DXYJc3eqg=;\n b=SEZtf8XFVgVTmh310w4BaWz+InFg8ztedq/p+g/dRvSrlfGmDzSCMymnq13jInehMR\n Lcm3wSQ/7khSNh+BixvAlrEz3PqFJfSgPH5gk9jVtWqV3fFmaqLGxxnCxcE7yJZQ9tCy\n Sw1qacHAcZWFSk4S3/y+5Wz1o9ys5+FfwYqZNNJTrZyC0KtZ64RVCQXs7+K4XL/tZdUA\n CpqOavz2K7LNG9GIYSbE+/pYzaFkdIQA4NiK+YKbStczH6+6Xsu9iflTnzBGqj8FE4Ts\n m1pHpq4DHwMzUS63m0Xbf7xw0BSInCrtGbkF9lBvoJPmgqUHOfR1zmTRUuCaYyCK23bp\n ktzQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771035224; x=1771640024;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=IBfS1gwelZ2mj2qarZUPVGv4uT0cGemLv8DXYJc3eqg=;\n b=Ao+x4iyQp2cNH3pyPDRh/vh9rBZSC5DZ0SMR2LUCLWaqYQvjCcMZGIlG76xc7xi8m4\n v88ycuwPxI8ZP5gNbgBbYI/w+JiafHm0c3yrzdrK2CgQa4WY6lDgOqKP3Gz8wpi1Zbzh\n b0ZVpdxgXXDGbe46AbTg/HOY1kMxQEX2Uz38d5PullXEr5IWRJDRX773n7cN8g+mt+Lw\n 4F24Uni101k+ZegLnbogqaszROUP5AYIxhfbA4Fkdd3e/cFDvPRQy5DaDJg7RZWgbUib\n eBDnotSMeHpHCMHseAtxiUa3vtEt35yA2gWr5FAkd0FZF8Km/5OM1UNEqpr5+AHuztto\n hstQ==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCV1Cq++DweSKl4yR6ZH2QUod8RXJKq4SvhQnDICqjC9L2Omuhhk91RTAyCCnceaO5dhD5tPrVfWLw==@nongnu.org", "X-Gm-Message-State": "AOJu0YzXLr5sT4qZWYNdGyG7T43NxYC9aICN9H7j64723b8m9BMO5Be/\n 2gY71cK6ecKbbINP1haYGqg0B9sDKXlQYtq0cKKtVyjlLIFWEU7zaQ5iMCCeV6ONCIo=", "X-Gm-Gg": "AZuq6aJghO+7vFC0MqQwL3OV4mkj1n/juAiHzBTdcK07wwkMJsowyq1vhAZGMdGoBuz\n bYkh0yOUj/XkjlqaZkhtdhPUga3wpbCWEgbNrs5hGf7tbPpdTfV7qbVBaJ2HxqytliRd7+oeXHv\n e668qCEfISz+IP9ZtZIWDS/BgGf0zIPsZqhEY9A9r7/fC+FsIxhkhUWL4WOIrS1RAk6HXI+VRq8\n tH140HlVmgQyuurfmKKNw6xDlMXwu7BVuF2PnCNW93RR/xKoiYnZWKxbIfFI5OSOiaMOzhKeMEV\n qNb6yzCmWHu0bZ5ksNy3/beP73Yx0hzChMtMROTm2FRDVXLRkxcu04xW0LhPOBcGyu7MApUO0cP\n 0R6YwO6UhGGuSdMQOY5R7T5aFAvTL2yZJ5pPAv2BEs8io0qDSD/KfTfbQ8RvL6urVsSPsHLI0Ql\n idL+fZjWZ4ZbjdWu/iNxoq3Sx7SYzxJADzAvBYvGiQJRFMcnlMvT7gEtNKG21ujIZwHS9B/hPL", "X-Received": "by 2002:a05:600c:83c6:b0:480:6941:d38b with SMTP id\n 5b1f17b1804b1-48379c1cde5mr13980735e9.30.1771035223809;\n Fri, 13 Feb 2026 18:13:43 -0800 (PST)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "Chinmay Rath <rathc@linux.ibm.com>,\n =?utf-8?q?Herv=C3=A9_Poussineau?= <hpoussin@reactos.org>,\n Harsh Prateek Bora <harshpb@linux.ibm.com>,\n Nicholas Piggin <npiggin@gmail.com>, Artyom Tarasenko <atar4qemu@gmail.com>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>, qemu-ppc@nongnu.org,\n Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,\n Laurent Vivier <laurent@vivier.eu>,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "Subject": "[PATCH 8/8] system/globals: Build as common code", "Date": "Sat, 14 Feb 2026 03:12:39 +0100", "Message-ID": "<20260214021240.58657-9-philmd@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260214021240.58657-1-philmd@linaro.org>", "References": "<20260214021240.58657-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::331;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-ppc@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-ppc.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-ppc>,\n <mailto:qemu-ppc-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-ppc>", "List-Post": "<mailto:qemu-ppc@nongnu.org>", "List-Help": "<mailto:qemu-ppc-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-ppc>,\n <mailto:qemu-ppc-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Now than all targets have the graphic dimension variables\ninitialized the same way, we can move them to the common\nfile unit, having them built once. Remove the now empty\nglobals-target.c file.\n\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n---\n system/globals-target.c | 14 --------------\n system/globals.c | 3 +++\n system/meson.build | 4 ----\n 3 files changed, 3 insertions(+), 18 deletions(-)\n delete mode 100644 system/globals-target.c", "diff": "diff --git a/system/globals-target.c b/system/globals-target.c\ndeleted file mode 100644\nindex ffa6c308b59..00000000000\n--- a/system/globals-target.c\n+++ /dev/null\n@@ -1,14 +0,0 @@\n-/*\n- * Global variables that should not exist (target specific)\n- *\n- * Copyright (c) 2003-2008 Fabrice Bellard\n- *\n- * SPDX-License-Identifier: MIT\n- */\n-\n-#include \"qemu/osdep.h\"\n-#include \"system/system.h\"\n-\n-int graphic_width;\n-int graphic_height;\n-int graphic_depth;\ndiff --git a/system/globals.c b/system/globals.c\nindex c33f6ed3902..34fd3ce9c72 100644\n--- a/system/globals.c\n+++ b/system/globals.c\n@@ -49,6 +49,9 @@ bool enable_cpu_pm;\n int autostart = 1;\n int vga_interface_type = VGA_NONE;\n bool vga_interface_created;\n+int graphic_width;\n+int graphic_height;\n+int graphic_depth;\n Chardev *parallel_hds[MAX_PARALLEL_PORTS];\n QEMUOptionRom option_rom[MAX_OPTION_ROMS];\n int nb_option_roms;\ndiff --git a/system/meson.build b/system/meson.build\nindex d91703d3dcc..579e8353d53 100644\n--- a/system/meson.build\n+++ b/system/meson.build\n@@ -1,7 +1,3 @@\n-specific_ss.add(when: 'CONFIG_SYSTEM_ONLY', if_true: [files(\n- 'globals-target.c',\n-)])\n-\n system_ss.add(files(\n 'vl.c',\n ), sdl, libpmem, libdaxctl)\n", "prefixes": [ "8/8" ] }