Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196453/?format=api
{ "id": 2196453, "url": "http://patchwork.ozlabs.org/api/patches/2196453/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260214021240.58657-3-philmd@linaro.org/", "project": { "id": 69, "url": "http://patchwork.ozlabs.org/api/projects/69/?format=api", "name": "QEMU powerpc development", "link_name": "qemu-ppc", "list_id": "qemu-ppc.nongnu.org", "list_email": "qemu-ppc@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260214021240.58657-3-philmd@linaro.org>", "list_archive_url": null, "date": "2026-02-14T02:12:33", "name": "[2/8] hw/display/macfb: Constify macfb_mode_table[] array", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "2567bd0ec018b87cada49b44b551f6de7a81a747", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260214021240.58657-3-philmd@linaro.org/mbox/", "series": [ { "id": 492153, "url": "http://patchwork.ozlabs.org/api/series/492153/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-ppc/list/?series=492153", "date": "2026-02-14T02:12:32", "name": "system: Absorb globals-target.c within common globals.c", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492153/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196453/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196453/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=sCDmB2Zt;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fCXd96ypDz1xwj\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 14 Feb 2026 13:13:17 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-ppc-bounces@nongnu.org>)\n\tid 1vr59b-0003eP-7W; Fri, 13 Feb 2026 21:13:03 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1vr59Z-0003e1-Ip\n for qemu-ppc@nongnu.org; Fri, 13 Feb 2026 21:13:01 -0500", "from mail-wm1-x332.google.com ([2a00:1450:4864:20::332])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1vr59Y-0004WF-0L\n for qemu-ppc@nongnu.org; Fri, 13 Feb 2026 21:13:01 -0500", "by mail-wm1-x332.google.com with SMTP id\n 5b1f17b1804b1-4836f363d0dso12335815e9.3\n for <qemu-ppc@nongnu.org>; Fri, 13 Feb 2026 18:12:59 -0800 (PST)", "from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4834d482480sm328085395e9.0.2026.02.13.18.12.56\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 13 Feb 2026 18:12:57 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1771035178; x=1771639978; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=nmUxv3UTE6ZdlIHSSW1HHJoRu03dAklDGcxZsp/sqZ4=;\n b=sCDmB2ZtC83l38Z/GIYPm6uldV+ni2oCbixbye9fC/oiGTDhsN2CEQ4UDl2YI82X36\n m7nI9kaFEzz7ZhhSoEyE9+CPBdqBzEvci7d/o+Y9NLf82mLOUaHNxQsArG9NUvQld5YO\n TpMWiQUomEqt7N4AkvdV+ZqEB87M2vM2G0DpvzjMb/Nu9jXPj1PNCg0Sf16ZBjCSbsnA\n lIW7GL1Lh6dUHShgAaLy/qd4rSsNo+tDmtrFjQVA0idBKP/1otKi0rnagkTr020kHGh3\n oKORZyG5r2ewEs/ZASCKnBr99qefyU+FjMYkQYrZmoiVIlo/QEhlzGWtTXd2FRkWo1RZ\n NM1w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771035178; x=1771639978;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=nmUxv3UTE6ZdlIHSSW1HHJoRu03dAklDGcxZsp/sqZ4=;\n b=bbhqbwH5woH40XrKUyA6/bt1dyTyc3bmp1u1QcUI0iJ0X8K8gQYoDiO1JxUwN3JrRL\n l9ewIgWjmVukPFFY8huAjKUZ7YblKbwAKJ6HypVb9hJLmvS+G96ZHnOCIyO/51/k7sDi\n 4E+7nQ3GSpSOoAQt3swUf9md7NiKvrgWXrocOcxdukI45WdPW6Es1XZYBwLtER+Qs7hB\n 1fXgm9B5UX85aRhh1qV1gO9P4xLkdFKqNndWLFHi6yxPTzfSIDtnHJqpggEM7n5h56Xy\n 3HnMNdOl26WoJE16OZvZgFL2MnbAAyjkDL7W1TCjdoWXYFJpkzqMaTyTMeXzp1Hc+HOu\n z2hg==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCWHbhUaWgaba0c9ZxA2k6sDAEwRy48OwElyVN7o3hFhYYcDF9Rna9Hnuu13l37ggmX2IwHzgyz/Cw==@nongnu.org", "X-Gm-Message-State": "AOJu0YwQou53bdq0hM5dVDGsx2hq1ZrphhhlFDaUtpfQVvyM4c++CUrB\n S89JcDf0+iEyumefMbZgfWG9sD0LntICv1rVY5hDH1NLK16RSOwdmvqR0ths6OF7du4=", "X-Gm-Gg": "AZuq6aLG3Lw1gbCTdChyBYdItTDk/ZJu5TESVNT4J2/nryxT2iY4YPEzHvhC9TTbfdf\n dtMJd5hZjCDxetM9oZfO50Q21WX0nmJ1tfle58vvliDhNStNCHX402jRGrijwFKDO7+c6+KAWoB\n bUae14xTXpwisV3tppCgndG5z38VX6OQYmrN9txp18d/rWdw8eLWh1sLzlJ0RXIq3Oo5hKxzDWp\n jbyZUJYzhgMkRXGE/onFxgHvRXO4a9BQNVJd9moRbUyjMfiCL2ZC+ZsnWSap2M6CqAU7C81FNnP\n kPtgOBwtRf/pP1XmwgH6C472RA37T7Bmzs5Oovglrt0bvpDWknSHjCNXGrSJPtWZE2kVEVRiWuo\n r0MCSj9hiu6mdvnhKe3QICXShhxnB/Vuewk+bvbEV76M6i9f70r6HeOyvv2h7G5BFKdZ2NnQWoD\n UJs0+yDEaqJFAnjXwotTx32qgPJ3Q9i3CAgJeHpwdqDt64p9htNRZ8TiyCTmGbVEhoIqXl9PNVa\n wOsV8QqZPs=", "X-Received": "by 2002:a05:600c:4443:b0:47e:e952:86c9 with SMTP id\n 5b1f17b1804b1-48379b318bamr18979695e9.0.1771035178495;\n Fri, 13 Feb 2026 18:12:58 -0800 (PST)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "Chinmay Rath <rathc@linux.ibm.com>,\n =?utf-8?q?Herv=C3=A9_Poussineau?= <hpoussin@reactos.org>,\n Harsh Prateek Bora <harshpb@linux.ibm.com>,\n Nicholas Piggin <npiggin@gmail.com>, Artyom Tarasenko <atar4qemu@gmail.com>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>, qemu-ppc@nongnu.org,\n Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,\n Laurent Vivier <laurent@vivier.eu>,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "Subject": "[PATCH 2/8] hw/display/macfb: Constify macfb_mode_table[] array", "Date": "Sat, 14 Feb 2026 03:12:33 +0100", "Message-ID": "<20260214021240.58657-3-philmd@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260214021240.58657-1-philmd@linaro.org>", "References": "<20260214021240.58657-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::332;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-ppc@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-ppc.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-ppc>,\n <mailto:qemu-ppc-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-ppc>", "List-Post": "<mailto:qemu-ppc@nongnu.org>", "List-Help": "<mailto:qemu-ppc-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-ppc>,\n <mailto:qemu-ppc-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "macfb_mode_table[] is only read, never updated, so can be const.\n\nUpdate the call sites accordingly.\nMake the MacfbState::mode pointer to const.\n\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n---\n include/hw/display/macfb.h | 2 +-\n hw/display/macfb.c | 10 +++++-----\n hw/m68k/q800.c | 2 +-\n 3 files changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/include/hw/display/macfb.h b/include/hw/display/macfb.h\nindex 495dead44b5..cb7aac7a4dd 100644\n--- a/include/hw/display/macfb.h\n+++ b/include/hw/display/macfb.h\n@@ -66,7 +66,7 @@ typedef struct MacfbState {\n uint8_t type;\n \n uint32_t regs[MACFB_NUM_REGS];\n- MacFbMode *mode;\n+ const MacFbMode *mode;\n \n QEMUTimer *vbl_timer;\n qemu_irq irq;\ndiff --git a/hw/display/macfb.c b/hw/display/macfb.c\nindex 57ad8ad5587..8ef174dc6df 100644\n--- a/hw/display/macfb.c\n+++ b/hw/display/macfb.c\n@@ -100,7 +100,7 @@ static const MacFbSense macfb_sense_table[] = {\n { MACFB_DISPLAY_SVGA, 0x7, 0x5 },\n };\n \n-static MacFbMode macfb_mode_table[] = {\n+static const MacFbMode macfb_mode_table[] = {\n { MACFB_DISPLAY_VGA, 1, 0x100, 0x71e, 640, 480, 0x400, 0x1000 },\n { MACFB_DISPLAY_VGA, 2, 0x100, 0x70e, 640, 480, 0x400, 0x1000 },\n { MACFB_DISPLAY_VGA, 4, 0x100, 0x706, 640, 480, 0x400, 0x1000 },\n@@ -397,7 +397,7 @@ static void macfb_update_mode(MacfbState *s)\n \n static void macfb_mode_write(MacfbState *s)\n {\n- MacFbMode *macfb_mode;\n+ const MacFbMode *macfb_mode;\n int i;\n \n for (i = 0; i < ARRAY_SIZE(macfb_mode_table); i++) {\n@@ -418,11 +418,11 @@ static void macfb_mode_write(MacfbState *s)\n }\n }\n \n-static MacFbMode *macfb_find_mode(MacfbDisplayType display_type,\n+static const MacFbMode *macfb_find_mode(MacfbDisplayType display_type,\n uint16_t width, uint16_t height,\n uint8_t depth)\n {\n- MacFbMode *macfb_mode;\n+ const MacFbMode *macfb_mode;\n int i;\n \n for (i = 0; i < ARRAY_SIZE(macfb_mode_table); i++) {\n@@ -440,7 +440,7 @@ static MacFbMode *macfb_find_mode(MacfbDisplayType display_type,\n static gchar *macfb_mode_list(void)\n {\n GString *list = g_string_new(\"\");\n- MacFbMode *macfb_mode;\n+ const MacFbMode *macfb_mode;\n int i;\n \n for (i = 0; i < ARRAY_SIZE(macfb_mode_table); i++) {\ndiff --git a/hw/m68k/q800.c b/hw/m68k/q800.c\nindex 25ddddb5d9f..4767eb4298f 100644\n--- a/hw/m68k/q800.c\n+++ b/hw/m68k/q800.c\n@@ -255,7 +255,7 @@ static void q800_machine_init(MachineState *machine)\n int32_t initrd_size;\n uint8_t *prom;\n int i, checksum;\n- MacFbMode *macfb_mode;\n+ const MacFbMode *macfb_mode;\n ram_addr_t ram_size = machine->ram_size;\n const char *kernel_filename = machine->kernel_filename;\n const char *initrd_filename = machine->initrd_filename;\n", "prefixes": [ "2/8" ] }