Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196408/?format=api
{ "id": 2196408, "url": "http://patchwork.ozlabs.org/api/patches/2196408/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260213182713.44924-6-philmd@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260213182713.44924-6-philmd@linaro.org>", "list_archive_url": null, "date": "2026-02-13T18:27:13", "name": "[5/5] page-vary: Inline set_preferred_target_page_bits_common()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "322b1bb19c50a72025544f217d44fe8c7399e642", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260213182713.44924-6-philmd@linaro.org/mbox/", "series": [ { "id": 492130, "url": "http://patchwork.ozlabs.org/api/series/492130/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492130", "date": "2026-02-13T18:27:09", "name": "page-vary: Build set_preferred_target_page_bits() as common code", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492130/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196408/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196408/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=Su6PigSq;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fCLJd69Qwz1xr1\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 14 Feb 2026 05:28:17 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vqxtT-0007Ff-8R; Fri, 13 Feb 2026 13:27:55 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1vqxtR-0007FW-AW\n for qemu-devel@nongnu.org; Fri, 13 Feb 2026 13:27:53 -0500", "from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1vqxtP-00064C-S0\n for qemu-devel@nongnu.org; Fri, 13 Feb 2026 13:27:53 -0500", "by mail-wr1-x42d.google.com with SMTP id\n ffacd0b85a97d-436356740e6so1360269f8f.2\n for <qemu-devel@nongnu.org>; Fri, 13 Feb 2026 10:27:51 -0800 (PST)", "from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43796a5acaasm7209327f8f.6.2026.02.13.10.27.48\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 13 Feb 2026 10:27:49 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1771007270; x=1771612070; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=tsrTVhXyENyB3MoHInBSDRjS9vH5n3zQs9EUXUebqfk=;\n b=Su6PigSqiklNvdXEVIJNGJzbQfENSIfsoQeKi3RdqxklON0tvJwCnDf+RIWHCD/hbn\n XTz0VMiv8FKgVcVlJVPchd771am08D4Z8XRihOC3ZZP50VzGDYGKO63PuDqOko8acI6P\n qwTHcTvj6d7T/ZrBU9k+dYgB3rabdz8f6L1vgfC6HwJ2njuat8oD6D52h7BYxmSAI54l\n 4iQWswQT7sMNV7Gd/g6Ue0l8RidUgyGW/SbPFpfoK0DOvOjokF8GOL1YTRxqrLPTAyTu\n czaPJYHc+vqqonlgFlrDAl9BQIsYIjOTz2Kzk21OBuKYKuRKRDVF6s0TwbHMbsPlmw9H\n d+Mg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771007270; x=1771612070;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=tsrTVhXyENyB3MoHInBSDRjS9vH5n3zQs9EUXUebqfk=;\n b=NwhLX40US2kGzFiM2ZsdHUB4nABIICX2dOwsL+7UVduR5Wff1dtDHnRbbv1BI9bFmm\n VsI31ShHG92ZuQAp92zxyufgrySbomIxGhHA6GM+uAx3xdTcP2uVCk8hgTdZVJG7W+N/\n fp/Fb0kFJ40c3Lih3nYRNfpBCGa50TvYjqFZW+2DCXtKx5Lk8ZDsKOqa0wPbtQwS3o+Z\n jZCYesnPzUVQs/URfUc8CyKIu4QwLQtB6d/bjZh+2H6zvEdvQJBQvOtzadQbWCcu0iwk\n o2F9FfQDjjm3/kxkAUaJJmeZMnLyQ7l2gzDY07413q7x+kAbQ+UfbBKAlWvkNr9NqQ8T\n +dig==", "X-Gm-Message-State": "AOJu0YyqMFzJQYqhsWUw6t5DRAtABTBxtnZOMZMrpfKvMKV+W7YAbT9S\n Lld3yPMnbAYlGWn++PgrLMhhuHApHxrHjwNXCc8TpL1/0eLA34rrravVf4xS8/qd2KIBxFOb3Lf\n uJys0eok=", "X-Gm-Gg": "AZuq6aKb/v/VxdYr3Hip1shse1WIWbfv6tDfCkxRUpzqnp3/wotWTMfkyOKd151ZXME\n gtv778CmgYLhswaCQn8Axolcf5YCRURHLqLkMJaFHFIwPjxmsOJSqmS17NvVMITdIrv1e6tkEMs\n Dn2DD1GxYzvJkRB60L6a/DpSfgwg9clTpUtqZ0I/ldjFFhIpm7QCEk9Hzu5tHH+VhIykhCMVd7z\n c/abbAkybuYCumsNIIhgdvEAQvzB4/GmjIEGUmKB/ARqEt7rfbRoCI5fhjo+r1Dr0pSpUYhU9FF\n T7LJ0Q4vXGrXJh9h5mogvgqm0LHPmxRL+hSA4E5UsryT4az/TJMC8WqGO4mV6Hmlxv3x2w06CZ3\n w7BzJKCPWacXhpHLNWYYGLOQ4UY6WhJUx8ZzuN/fsiaIzyttzEqBYMEHbYMezzPIfgX7NjNetmr\n wmbMndtKkaMOFbOHkvU4tlkyHmknBDf6hvlKe/+LbOLJPOUNtZ3/YxoBeSaU0L7LsemlLmsFAu", "X-Received": "by 2002:a05:6000:2203:b0:436:173c:b8e3 with SMTP id\n ffacd0b85a97d-4379db93b3amr793442f8f.29.1771007270053;\n Fri, 13 Feb 2026 10:27:50 -0800 (PST)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "Richard Henderson <richard.henderson@linaro.org>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>, =?utf-8?q?Philippe_Mathieu-?=\n\t=?utf-8?q?Daud=C3=A9?= <philmd@linaro.org>,\n Paolo Bonzini <pbonzini@redhat.com>", "Subject": "[PATCH 5/5] page-vary: Inline set_preferred_target_page_bits_common()", "Date": "Fri, 13 Feb 2026 19:27:13 +0100", "Message-ID": "<20260213182713.44924-6-philmd@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260213182713.44924-1-philmd@linaro.org>", "References": "<20260213182713.44924-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::42d;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x42d.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "set_preferred_target_page_bits_common() is only used once\nin set_preferred_target_page_bits(): inline it there and\nremove its prototype.\n\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n---\n include/exec/page-vary.h | 1 -\n page-vary-common.c | 33 +++++++++++++++------------------\n 2 files changed, 15 insertions(+), 19 deletions(-)", "diff": "diff --git a/include/exec/page-vary.h b/include/exec/page-vary.h\nindex 3c77689ca52..c4dc56634bc 100644\n--- a/include/exec/page-vary.h\n+++ b/include/exec/page-vary.h\n@@ -41,7 +41,6 @@ typedef struct {\n } TargetPageBits;\n \n #ifdef IN_PAGE_VARY\n-bool set_preferred_target_page_bits_common(int bits);\n void finalize_target_page_bits_common(int min);\n #endif\n \ndiff --git a/page-vary-common.c b/page-vary-common.c\nindex a2417354cc5..e2ccc7b0ead 100644\n--- a/page-vary-common.c\n+++ b/page-vary-common.c\n@@ -27,29 +27,26 @@\n \n TargetPageBits target_page;\n \n-bool set_preferred_target_page_bits_common(int bits)\n-{\n- /*\n- * The target page size is the lowest common denominator for all\n- * the CPUs in the system, so we can only make it smaller, never\n- * larger. And we can't make it smaller once we've committed to\n- * a particular size.\n- */\n- if (target_page.bits == 0 || target_page.bits > bits) {\n- if (target_page.decided) {\n- return false;\n- }\n- target_page.bits = bits;\n- }\n- return true;\n-}\n-\n bool set_preferred_target_page_bits(int bits)\n {\n assert(bits >= TARGET_PAGE_BITS_MIN);\n+\n if (target_page_bits_vary()) {\n- return set_preferred_target_page_bits_common(bits);\n+ /*\n+ * The target page size is the lowest common denominator for all\n+ * the CPUs in the system, so we can only make it smaller, never\n+ * larger. And we can't make it smaller once we've committed to\n+ * a particular size.\n+ */\n+ if (target_page.bits == 0 || target_page.bits > bits) {\n+ if (target_page.decided) {\n+ return false;\n+ }\n+ target_page.bits = bits;\n+ }\n+ return true;\n }\n+\n return true;\n }\n \n", "prefixes": [ "5/5" ] }