Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196343/?format=api
{ "id": 2196343, "url": "http://patchwork.ozlabs.org/api/patches/2196343/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260213133922.1431006-1-simon.glass@canonical.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260213133922.1431006-1-simon.glass@canonical.com>", "list_archive_url": null, "date": "2026-02-13T13:39:09", "name": "menu: Move shortcut-key handling to bootmenu_loop()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "19be8dea507affeef768999a4ebccfc2fce42987", "submitter": { "id": 6170, "url": "http://patchwork.ozlabs.org/api/people/6170/?format=api", "name": "Simon Glass", "email": "sjg@chromium.org" }, "delegate": { "id": 3651, "url": "http://patchwork.ozlabs.org/api/users/3651/?format=api", "username": "trini", "first_name": "Tom", "last_name": "Rini", "email": "trini@ti.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260213133922.1431006-1-simon.glass@canonical.com/mbox/", "series": [ { "id": 492099, "url": "http://patchwork.ozlabs.org/api/series/492099/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=492099", "date": "2026-02-13T13:39:09", "name": "menu: Move shortcut-key handling to bootmenu_loop()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492099/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196343/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196343/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=KVnsjBm8;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"KVnsjBm8\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fCCvm1Fhsz1xvQ\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 14 Feb 2026 00:39:47 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 1BA3483AA9;\n\tFri, 13 Feb 2026 14:39:40 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 86B2783B9D; Fri, 13 Feb 2026 14:39:38 +0100 (CET)", "from mail-ot1-x335.google.com (mail-ot1-x335.google.com\n [IPv6:2607:f8b0:4864:20::335])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id D226183015\n for <u-boot@lists.denx.de>; Fri, 13 Feb 2026 14:39:34 +0100 (CET)", "by mail-ot1-x335.google.com with SMTP id\n 46e09a7af769-7d4c85307b2so181167a34.0\n for <u-boot@lists.denx.de>; Fri, 13 Feb 2026 05:39:34 -0800 (PST)", "from chromium.org ([73.34.74.121]) by smtp.gmail.com with ESMTPSA id\n 46e09a7af769-7d4a75309a6sm6274212a34.3.2026.02.13.05.39.31\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 13 Feb 2026 05:39:31 -0800 (PST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1770989973; x=1771594773; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=gIKR0OlXEvsQCeviATeZ23i1n8mDOhQHRskPstcn2MQ=;\n b=KVnsjBm8iFHh6jJOiyazkyRvacQyovj3cubXtvwGoEBvqrcXwrDEDnZoyAWTa850yW\n mulGRLmchrBRyN0bwRd3geKwHJ1cAtidEUuAbJZoCbwG8xQ1UfFUCJMQFMF2LFEoWCAK\n cuf3WaRDPd4c0ZpLSDurtd4CZ5zhniLJkIGMU=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1770989973; x=1771594773;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=gIKR0OlXEvsQCeviATeZ23i1n8mDOhQHRskPstcn2MQ=;\n b=JhgEvlH+7OYy6tuNBq2lNnY/WJUgyiiqD4iWVIJxO41ADzpwKY0UQWv2JBxS7bq9wk\n W1qVlaJ4gy6OkRfGlRRQx//rLTITwEk0FOEXpj1gXjJ8CZdTOYuy87sWg6MSyWCBcgSG\n req13CMndOFmbtS4hD9N71KoJ0ioynOfN+wOXlIdten2uNjbc05nINYDoqgGHVb0g9Kz\n mwHOL6Wb9AO3AHKx8rJ0XT+qYoxQRcqyULvip2U7EOJY2EAdRLKwcd79YhNsmhEyWGFO\n XtTnAmOOBUqZ400Dfw8B0FD1M0zWhr112SgH9/HSAjvSinYjoAf5XNxu6BbPRz/QqJZt\n c4fQ==", "X-Gm-Message-State": "AOJu0Yzfl2AqRC1pgTPq2YkEKtVn4OfMwaj63f44BS/eEsnxj3tNq4iW\n bT+W2On5P3/8YDXxZRRP/7UIuLk2KFvDLR5h56scFeJOMb1fDpYmvaizepTK8U9iopqt7jPwcrK\n GFMQ=", "X-Gm-Gg": "AZuq6aIZ1VOOz/6EMSICSswlurtDJ5j4Uku8R5IjzdB2mM/UKTy5S2Hb/+JqKSh6TCV\n Hkb3l2Oyfhr/e5QT+5MKFu7A2+Sr9nbHHQ+rjzMLo4ZRyUJolXx20YcrfcjRFNIb2ckwvWuCTPC\n HeAJBd6Mnojls1ZH72KVubyxrE3hiYnSdO1ReKzwKQlgkz00OeMJPq2zEvpZYMLhe1y5u3XFWtz\n SpmSEaD7Lt2Wh4wzjxbOdMq9zTkplBLLBcnENFUPm9v9ikmBNys9FYwVkZtVzm7B5DMhcZqsZ3f\n wlxaBQpMXtBXa1p5idpnENlQ7iSnBElbQ2N0riIwFmEW3nX4F0egzqaUvsM1IANEpWyzZt9eXS2\n nETO3O0+mRgQXU/NmzoujecYaf0vUMK45Fg2/B2GOu7APwLaWyQsgAYQpEBGWNwwDUxauoaD0FT\n 0grt7qKlGpv1qo76wFCB2zhDhJSIb1", "X-Received": "by 2002:a05:6830:2aa7:b0:7c7:69c8:2ce with SMTP id\n 46e09a7af769-7d4c4b31df0mr1034529a34.27.1770989972782;\n Fri, 13 Feb 2026 05:39:32 -0800 (PST)", "From": "Simon Glass <sjg@chromium.org>", "X-Google-Original-From": "Simon Glass <simon.glass@canonical.com>", "To": "u-boot@lists.denx.de", "Cc": "Christian Marangi <ansuelsmth@gmail.com>,\n Simon Glass <simon.glass@canonical.com>, Tom Rini <trini@konsulko.com>", "Subject": "[PATCH] menu: Move shortcut-key handling to bootmenu_loop()", "Date": "Fri, 13 Feb 2026 06:39:09 -0700", "Message-ID": "<20260213133922.1431006-1-simon.glass@canonical.com>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "The bootmenu_conv_key() function is shared with expo subsystem for key\ninput. Adding alphanumeric-to-BKEY_SHORTCUT conversion there causes expo\nto swallow typed characters instead of inserting them as text, since\nBKEY_SHORTCUT falls in the range that expo treats as a command key\nrather than passing through.\n\nMove the shortcut-key detection into bootmenu_loop() where it is\nonly used in the bootmenu context.\n\nFixes: 8c986521c3c9 (\"cmd: bootmenu: permit to select bootmenu entry with a shortcut\")\nSigned-off-by: Simon Glass <simon.glass@canonical.com>\n---\n\n common/menu.c | 9 +++------\n 1 file changed, 3 insertions(+), 6 deletions(-)", "diff": "diff --git a/common/menu.c b/common/menu.c\nindex ae5afa14766..02df3b8f133 100644\n--- a/common/menu.c\n+++ b/common/menu.c\n@@ -556,11 +556,6 @@ enum bootmenu_key bootmenu_conv_key(int ichar)\n \tcase ' ':\n \t\tkey = BKEY_SPACE;\n \t\tbreak;\n-\tcase 'A' ... 'Z':\n-\tcase 'a' ... 'z':\n-\tcase '0' ... '9':\n-\t\tkey = BKEY_SHORTCUT;\n-\t\tbreak;\n \tdefault:\n \t\tkey = BKEY_NONE;\n \t\tbreak;\n@@ -591,8 +586,10 @@ enum bootmenu_key bootmenu_loop(struct bootmenu_data *menu,\n \n \tkey = bootmenu_conv_key(c);\n \n-\tif (key == BKEY_SHORTCUT)\n+\tif (key == BKEY_NONE && isalnum(c)) {\n+\t\tkey = BKEY_SHORTCUT;\n \t\tcch->shortcut_key = bootmenu_conv_shortcut_key(menu, c);\n+\t}\n \n \treturn key;\n }\n", "prefixes": [] }