Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196308/?format=api
{ "id": 2196308, "url": "http://patchwork.ozlabs.org/api/patches/2196308/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260213112717.1256823-2-aswin.murugan@oss.qualcomm.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260213112717.1256823-2-aswin.murugan@oss.qualcomm.com>", "list_archive_url": null, "date": "2026-02-13T11:27:12", "name": "[v2,1/6] reboot-mode: Use actual cell size instead of sizeof(u32)", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0432f616f2cbecad3573a5353225aa55be5d9cbf", "submitter": { "id": 90811, "url": "http://patchwork.ozlabs.org/api/people/90811/?format=api", "name": "Aswin Murugan", "email": "aswin.murugan@oss.qualcomm.com" }, "delegate": { "id": 151538, "url": "http://patchwork.ozlabs.org/api/users/151538/?format=api", "username": "kcxt", "first_name": "Casey", "last_name": "Connolly", "email": "casey.connolly@linaro.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260213112717.1256823-2-aswin.murugan@oss.qualcomm.com/mbox/", "series": [ { "id": 492084, "url": "http://patchwork.ozlabs.org/api/series/492084/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=492084", "date": "2026-02-13T11:27:11", "name": "qcom: Add NVMEM bitfield support and reboot‑mode integration", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/492084/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196308/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196308/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=op8BRi10;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=cs84S2pO;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=oss.qualcomm.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=\"op8BRi10\";\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=\"cs84S2pO\";\n\tdkim-atps=neutral", "phobos.denx.de; dmarc=none (p=none dis=none)\n header.from=oss.qualcomm.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=aswin.murugan@oss.qualcomm.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fC8zW49Z6z1xr1\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 13 Feb 2026 22:27:51 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 0F48783D71;\n\tFri, 13 Feb 2026 12:27:49 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 5C16F83CEE; Fri, 13 Feb 2026 12:27:46 +0100 (CET)", "from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com\n [205.220.180.131])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 34A9D80B98\n for <u-boot@lists.denx.de>; Fri, 13 Feb 2026 12:27:44 +0100 (CET)", "from pps.filterd (m0279871.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 61D5KIAc454948\n for <u-boot@lists.denx.de>; Fri, 13 Feb 2026 11:27:42 GMT", "from mail-pj1-f70.google.com (mail-pj1-f70.google.com\n [209.85.216.70])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c9mev36nj-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for <u-boot@lists.denx.de>; Fri, 13 Feb 2026 11:27:42 +0000 (GMT)", "by mail-pj1-f70.google.com with SMTP id\n 98e67ed59e1d1-354c0eb08ceso3190979a91.1\n for <u-boot@lists.denx.de>; Fri, 13 Feb 2026 03:27:42 -0800 (PST)", "from hu-aswinm-blr.qualcomm.com\n (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19])\n by smtp.gmail.com with ESMTPSA id\n 41be03b00d2f7-c6e1969f314sm7996939a12.8.2026.02.13.03.27.34\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 13 Feb 2026 03:27:40 -0800 (PST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=qcppdkim1; bh=jo7U6bY8FVt\n CHQQXv4Uo+kCfOL35EfCFepM5/ovJ738=; b=op8BRi10WR2xShLTRmY0I3E0Hrf\n pQoLZeZQiEytCGajwhqDbAds5VYoZj45BLmtgOBNh3j0C13XRbpVUP2C5XYZbipR\n FiF6e2v1bbVmJjYxmYsemJ+ymMjbMnpa0C8YzdmiLMNxPwVAlp0IibNjU03B2f3w\n CF3Cf48v8+NItlwygmN+O0WrTu/vHHS2kucpEAELXZ2qIk9W1PDECPkV5kJQE8i9\n vinJmOWWZ89fDegLI8tXi9GbnJ+TGA4UMpkFV0wHC/mEeloS8ajYbYvZTCe4gj86\n DcaTvRGz0UZO1V0wWKtRsOTpl9jfrWWhjS9lNk6eDJZ3VZzoUWS47TMfd4g==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1770982061; x=1771586861; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=jo7U6bY8FVtCHQQXv4Uo+kCfOL35EfCFepM5/ovJ738=;\n b=cs84S2pOduymGNishNb5qnHk4u98Fn3VUtQMyRKHCuLV4QOSUFQOS4J5/aNqlQl6vx\n 7r3S2xbFrq+rIpWMK3Esnds06TRLsyOK/s5/EnVkYperIL51+RCz/TYicw/+pbFhr8CD\n HMeUXQPTgH5sRtfvs+OXI0HlExPZDIxbCsZZFTX4ablw0U59QveG8vQUk4RuSTpwn/K/\n oOqFShgCaCq+50L0wULtpvFPjFecsxwSL20zgzZoSahmdPqy8qN95jzOs6TW8Y1LVa92\n Q3CCVJedtR1aa+QNO+7otVIboF2UUPzKDoc1sUoMNAi3yx3phAyahsvUK04ba6+QGe7F\n WwXQ==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1770982061; x=1771586861;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=jo7U6bY8FVtCHQQXv4Uo+kCfOL35EfCFepM5/ovJ738=;\n b=iVc5PyolaFgU8+ojqs3z8A0rO2xNoGEqc0mj6E0SqGvrQd6NjLFo4ubjydUxdeJBe4\n TxevogL96e4X45A4Rh6/KeScGA5XkeUYLhlZzuwDNfUBCnoHH50PHZo/c6ocL5x2VRww\n TW8RqJ/LYGjp5rm+x38ZEo4c1WBskmIYCo9ZfTM9k09KDlBASjHseOAc0qHmwJx1TQRK\n JQ73twq74C2Ag2DScnBT1vJQJJbu6FWU0w03fX0izTLmvGUM2ubY0nXuUH3xOEa97MK0\n j+YOZW4pB0w5h8w7YBLGXwjAxqyASyL8uXXYXluA9IB0s3eQFnoSbwhD4FEy7Z2MFIF6\n xooQ==", "X-Gm-Message-State": "AOJu0YwlGezaHbofgxa8ELRFLe2NHj66jze/71BYxmu918DCbhvG8ba6\n 2fuae51grPQ4DupKRXLs/6oInv3kgWywmYn61/ffQYJ9fZ3zwjNiKIfIEXis3Iele5OM+NNwJU8\n SAfLSKkgHWTU4/Nesycz8CDgaQJk0ONm531fiZyJj/MZlAseYunhjPC9Z/P9dz2mG", "X-Gm-Gg": "AZuq6aJjregYSykR9KUuSINtpN397ISLJnlrD/o3ZHtWHq+vrlvH5jiT/FPFSkcjQEV\n W13zWs4f8f3RaYcDrBT0ej1q+SkmXuxnCQfreGZnCA0oAld3yElmGORoRCYTe2pCMFg8hoqpp2t\n jCJx3rJS/nAMhp6YvcrTGVjnbrc81kQdYyWyXw23VCb6QQelXE8BQXkCGVanDF2330XZh6kwSd7\n T2K6xkU3iDLm8cy3vBtX/S/rtNy+LGA+pFmlRZuSBLNGi8YdYd2pE4d4O2pSuBGUZVnUeGOA+0k\n OCXEn1pREe7MZUs+hTqYwXKnk3wP+9EIs3DVxOTGzFAyKn8FADPvRzxAYiNn90+gVSOmPyEQv9m\n HlL7DXynRhgb6B3HfycUGsonO6qGBJz2G63vbzBkUjSJeA6wBM85KUaVWW9GW4v7DAv8hIXGPir\n IWBnvjqmjRFOwKCiRQqzlqsqMliuxid+9Y8osIJpRZ", "X-Received": [ "by 2002:a05:6a20:3944:b0:34d:d030:6739 with SMTP id\n adf61e73a8af0-3946c797043mr1657472637.31.1770982061158;\n Fri, 13 Feb 2026 03:27:41 -0800 (PST)", "by 2002:a05:6a20:3944:b0:34d:d030:6739 with SMTP id\n adf61e73a8af0-3946c797043mr1657448637.31.1770982060705;\n Fri, 13 Feb 2026 03:27:40 -0800 (PST)" ], "From": "Aswin Murugan <aswin.murugan@oss.qualcomm.com>", "To": "u-boot@lists.denx.de, sumit.garg@kernel.org, casey.connolly@linaro.org,\n u-boot-qcom@groups.io", "Cc": "seanga2@gmail.com, trini@konsulko.com, marek.vasut+renesas@mailbox.org,\n neil.armstrong@linaro.org, peng.fan@nxp.com, quentin.schulz@cherry.de,\n n-francis@ti.com, xypron.glpk@gmx.de, h-vm@ti.com, justin@tidylabs.net,\n jamie.gibbons@microchip.com, ycliang@andestech.com, me@samcday.com,\n sughosh.ganu@arm.com, gchan9527@gmail.com, ilias.apalodimas@linaro.org,\n Aswin Murugan <aswin.murugan@oss.qualcomm.com>", "Subject": "[PATCH v2 1/6] reboot-mode: Use actual cell size instead of\n sizeof(u32)", "Date": "Fri, 13 Feb 2026 16:57:12 +0530", "Message-Id": "<20260213112717.1256823-2-aswin.murugan@oss.qualcomm.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20260213112717.1256823-1-aswin.murugan@oss.qualcomm.com>", "References": "<20260213112717.1256823-1-aswin.murugan@oss.qualcomm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Authority-Analysis": "v=2.4 cv=Zq7g6t7G c=1 sm=1 tr=0 ts=698f0aae cx=c_pps\n a=0uOsjrqzRL749jD1oC5vDA==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17\n a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8\n a=5QhIOPboivaRtBlMk4QA:9 a=mQ_c8vxmzFEMiUWkPHU9:22", "X-Proofpoint-ORIG-GUID": "tXjYEibwNuo0LTMTYceVXJk5z-Ia8A0M", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMjEzMDA4NyBTYWx0ZWRfX3gwCBwJv9ctx\n pNUzjX4lsMHekfWybPn+fZaiiTGj1bG1klqa9Fn31svQXhyF7DS1Zua/C5iAX01YU7CcmjbQ6fa\n pKfcxbcvpgZLwYfwmwKCiBymWlTTbF+RGIfutUOtSm6Oi07G23KG996CkcEvjFeoQ92fFHq01AM\n +FU6tp8i8182/Ks/5ZGaXjbUlvoTJi3CH3xvbIcF/vvCmFMWd8Cg0uNIif52LajY33C2i6fKxvT\n /0qXiMZF0FBR5W6pWEuqDaaiwb3COUaJV9vZ2NvQF1AQIBEOdmPnxs0YnXi1SH7KRM4mhHwKR8W\n MQnncOveddwvhUN+DI9lniWtQu4H0HbWRa6q3yGOPHCwlnNxjJyohnk31LoftMV44kvb4XI5pEE\n z23z2HhLrZBjyuzDlsb39UswWOAKcqV2tdo7Ukmfq7FD9zkDRM/qmPp26qSzn9E0HQZ/yoMfHYs\n DHeMcFlg1WjOJh/s3yA==", "X-Proofpoint-GUID": "tXjYEibwNuo0LTMTYceVXJk5z-Ia8A0M", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-02-13_01,2026-02-12_03,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n clxscore=1015 lowpriorityscore=0 adultscore=0 priorityscore=1501\n impostorscore=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0\n spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound\n adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2602130087", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "The nvmem reboot-mode driver hardcodes sizeof(u32) for NVMEM read/write\noperations. This fails on platforms where the reboot reason storage is\nsmaller than 4 bytes.\n\nOn Qualcomm platforms with single-byte PMIC register storage, attempting\nto read 4 bytes from a 1-byte cell causes the NVMEM subsystem to return\n-EINVAL, breaking reboot-mode functionality.\n\nReplace sizeof(*mode) and sizeof(mode) with priv->cell.size to use the\nactual NVMEM cell size. Also initialize *mode to 0 in reboot_mode_get()\nto ensure a clean state for cells smaller than u32.\n\nThis allows the driver to work with cells of any size, from single bytes\nto multi-byte words.\n\nSigned-off-by: Aswin Murugan <aswin.murugan@oss.qualcomm.com>\n---\n drivers/reboot-mode/reboot-mode-nvmem.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/reboot-mode/reboot-mode-nvmem.c b/drivers/reboot-mode/reboot-mode-nvmem.c\nindex b9af242520a..60307cce49f 100644\n--- a/drivers/reboot-mode/reboot-mode-nvmem.c\n+++ b/drivers/reboot-mode/reboot-mode-nvmem.c\n@@ -18,15 +18,16 @@ struct nvmem_reboot_mode_priv {\n static int reboot_mode_get(struct udevice *dev, u32 *mode)\n {\n \tstruct nvmem_reboot_mode_priv *priv = dev_get_priv(dev);\n+\t*mode = 0;\n \n-\treturn nvmem_cell_read(&priv->cell, mode, sizeof(*mode));\n+\treturn nvmem_cell_read(&priv->cell, mode, priv->cell.size);\n }\n \n static int reboot_mode_set(struct udevice *dev, u32 mode)\n {\n \tstruct nvmem_reboot_mode_priv *priv = dev_get_priv(dev);\n \n-\treturn nvmem_cell_write(&priv->cell, &mode, sizeof(mode));\n+\treturn nvmem_cell_write(&priv->cell, &mode, priv->cell.size);\n }\n \n static const struct reboot_mode_ops nvmem_reboot_mode_ops = {\n", "prefixes": [ "v2", "1/6" ] }