Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196270/?format=api
{ "id": 2196270, "url": "http://patchwork.ozlabs.org/api/patches/2196270/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260213094938.4074478-9-marcandre.lureau@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260213094938.4074478-9-marcandre.lureau@redhat.com>", "list_archive_url": null, "date": "2026-02-13T09:49:27", "name": "[PULL,v2,08/15] chardev/char-pty: store pty_name into PtyChardev state", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "85421c2790ef2a639a4cd480cbf3025bcca35efd", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260213094938.4074478-9-marcandre.lureau@redhat.com/mbox/", "series": [ { "id": 492070, "url": "http://patchwork.ozlabs.org/api/series/492070/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492070", "date": "2026-02-13T09:49:19", "name": "[PULL,v2,01/15] char-udp: Fix initial backend open status", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/492070/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196270/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196270/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=aa+EvjJg;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fC6rt1kfxz1xpl\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 13 Feb 2026 20:51:58 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vqpon-0007Hf-Rb; Fri, 13 Feb 2026 04:50:33 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vqpoh-000778-Oo\n for qemu-devel@nongnu.org; Fri, 13 Feb 2026 04:50:31 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vqpoa-0007Jk-QU\n for qemu-devel@nongnu.org; Fri, 13 Feb 2026 04:50:24 -0500", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-36-txG-vcI2NLC0ek1FXKCV6A-1; Fri,\n 13 Feb 2026 04:50:15 -0500", "from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 4D33B18ADBC0; Fri, 13 Feb 2026 09:50:10 +0000 (UTC)", "from localhost (unknown [10.44.22.41])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 51E2419560B9; Fri, 13 Feb 2026 09:50:09 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1770976218;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=47+h7KsUk4pIeVRSrl5x3R/+mYPfTcUJPXIJdzZh/Nw=;\n b=aa+EvjJgK72yvHS/IfReGs5UMsxA4xfmmGi3+PH+w3iaQ64WWd+OF87QB33x0rzBLDYSE+\n hMY2i2F8DzAM5Bvq4A2LveB6cXYRhq/17+XQxL3wO2EvUguMFBPblgOyfGx6wJ/b2+rU6E\n SPl3ftO0R04O0SNbNXW+IaRW6jJsepU=", "X-MC-Unique": "txG-vcI2NLC0ek1FXKCV6A-1", "X-Mimecast-MFC-AGG-ID": "txG-vcI2NLC0ek1FXKCV6A_1770976213", "From": "marcandre.lureau@redhat.com", "To": "qemu-devel@nongnu.org", "Cc": "=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n \"Edgar E. Iglesias\" <edgar.iglesias@gmail.com>, =?utf-8?q?Daniel_P=2E_Berra?=\n\t=?utf-8?q?ng=C3=A9?= <berrange@redhat.com>, Eric Blake <eblake@redhat.com>,\n Markus Armbruster <armbru@redhat.com>, Paul Durrant <paul@xen.org>,\n Anthony PERARD <anthony@xenproject.org>, =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= <philmd@linaro.org>,\n Eduardo Habkost <eduardo@habkost.net>, Paolo Bonzini <pbonzini@redhat.com>,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org,\n Samuel Thibault <samuel.thibault@ens-lyon.org>,\n Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>", "Subject": "[PULL v2 08/15] chardev/char-pty: store pty_name into PtyChardev\n state", "Date": "Fri, 13 Feb 2026 10:49:27 +0100", "Message-ID": "<20260213094938.4074478-9-marcandre.lureau@redhat.com>", "In-Reply-To": "<20260213094938.4074478-1-marcandre.lureau@redhat.com>", "References": "<20260213094938.4074478-1-marcandre.lureau@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.12", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>\n\nWe'll use it in following commit.\n\nNote the bonus: stop use blind strcpy().\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>\nReviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>\nMessage-Id: <20260115144606.233252-8-vsementsov@yandex-team.ru>\n---\n chardev/char-pty.c | 19 +++++++++----------\n 1 file changed, 9 insertions(+), 10 deletions(-)", "diff": "diff --git a/chardev/char-pty.c b/chardev/char-pty.c\nindex 9e26e97baf5..a582aa7bc73 100644\n--- a/chardev/char-pty.c\n+++ b/chardev/char-pty.c\n@@ -43,6 +43,7 @@ struct PtyChardev {\n int connected;\n GSource *timer_src;\n char *path;\n+ char *pty_name;\n };\n typedef struct PtyChardev PtyChardev;\n \n@@ -303,7 +304,7 @@ static void cfmakeraw (struct termios *termios_p)\n #endif\n \n /* like openpty() but also makes it raw; return master fd */\n-static int qemu_openpty_raw(int *aslave, char *pty_name)\n+static int qemu_openpty_raw(int *aslave, char **pty_name)\n {\n int amaster;\n struct termios tty;\n@@ -324,9 +325,7 @@ static int qemu_openpty_raw(int *aslave, char *pty_name)\n cfmakeraw(&tty);\n tcsetattr(*aslave, TCSAFLUSH, &tty);\n \n- if (pty_name) {\n- strcpy(pty_name, q_ptsname(amaster));\n- }\n+ *pty_name = g_strdup(q_ptsname(amaster));\n \n return amaster;\n }\n@@ -335,11 +334,12 @@ static bool pty_chr_open(Chardev *chr, ChardevBackend *backend, Error **errp)\n {\n PtyChardev *s;\n int master_fd, slave_fd;\n- char pty_name[PATH_MAX];\n char *name;\n char *path = backend->u.pty.data->path;\n \n- master_fd = qemu_openpty_raw(&slave_fd, pty_name);\n+ s = PTY_CHARDEV(chr);\n+\n+ master_fd = qemu_openpty_raw(&slave_fd, &s->pty_name);\n if (master_fd < 0) {\n error_setg_errno(errp, errno, \"Failed to create PTY\");\n return false;\n@@ -351,11 +351,10 @@ static bool pty_chr_open(Chardev *chr, ChardevBackend *backend, Error **errp)\n return false;\n }\n \n- chr->filename = g_strdup_printf(\"pty:%s\", pty_name);\n+ chr->filename = g_strdup_printf(\"pty:%s\", s->pty_name);\n qemu_printf(\"char device redirected to %s (label %s)\\n\",\n- pty_name, chr->label);\n+ s->pty_name, chr->label);\n \n- s = PTY_CHARDEV(chr);\n s->ioc = QIO_CHANNEL(qio_channel_file_new_fd(master_fd));\n name = g_strdup_printf(\"chardev-pty-%s\", chr->label);\n qio_channel_set_name(s->ioc, name);\n@@ -364,7 +363,7 @@ static bool pty_chr_open(Chardev *chr, ChardevBackend *backend, Error **errp)\n \n /* create symbolic link */\n if (path) {\n- int res = symlink(pty_name, path);\n+ int res = symlink(s->pty_name, path);\n \n if (res != 0) {\n error_setg_errno(errp, errno, \"Failed to create PTY symlink\");\n", "prefixes": [ "PULL", "v2", "08/15" ] }