Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196267/?format=api
{ "id": 2196267, "url": "http://patchwork.ozlabs.org/api/patches/2196267/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260213094938.4074478-15-marcandre.lureau@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260213094938.4074478-15-marcandre.lureau@redhat.com>", "list_archive_url": null, "date": "2026-02-13T09:49:33", "name": "[PULL,v2,14/15] chardev: add logtimestamp option", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "cff838e0257f5ea5af934db9a3de2a64f686ce9d", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260213094938.4074478-15-marcandre.lureau@redhat.com/mbox/", "series": [ { "id": 492070, "url": "http://patchwork.ozlabs.org/api/series/492070/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492070", "date": "2026-02-13T09:49:19", "name": "[PULL,v2,01/15] char-udp: Fix initial backend open status", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/492070/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196267/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196267/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Wh06V/ZW;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fC6qy2h6rz1xpl\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 13 Feb 2026 20:51:10 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vqpos-0007er-NI; Fri, 13 Feb 2026 04:50:38 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vqpop-0007NN-4V\n for qemu-devel@nongnu.org; Fri, 13 Feb 2026 04:50:35 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vqpon-0007NV-9V\n for qemu-devel@nongnu.org; Fri, 13 Feb 2026 04:50:34 -0500", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-653-kDbAhiIkMMOtDe9wMvjVCw-1; Fri,\n 13 Feb 2026 04:50:28 -0500", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 8A2571956060; Fri, 13 Feb 2026 09:50:26 +0000 (UTC)", "from localhost (unknown [10.44.22.41])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id E61FC1955D85; Fri, 13 Feb 2026 09:50:25 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1770976232;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=oafPsMhhX2LYktt1mZytvPrd7reHuMI6cpisN3UVjHk=;\n b=Wh06V/ZWl47/9N57Dp+91HM7A/Ay9e/HIvYHTJiE1RvPy939yBeFJGHBgTrbjr0pNC60Xs\n EkE/E5VzVMPdqkJPjh/WSnzI0gfHcvI+VhR7OE8Q3zrLaP7vscR9gl37gmo/9bB9Ur5x8a\n i58hWjs79d4SEdGJmjxCTpj/7YPdwu0=", "X-MC-Unique": "kDbAhiIkMMOtDe9wMvjVCw-1", "X-Mimecast-MFC-AGG-ID": "kDbAhiIkMMOtDe9wMvjVCw_1770976227", "From": "marcandre.lureau@redhat.com", "To": "qemu-devel@nongnu.org", "Cc": "=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n \"Edgar E. Iglesias\" <edgar.iglesias@gmail.com>, =?utf-8?q?Daniel_P=2E_Berra?=\n\t=?utf-8?q?ng=C3=A9?= <berrange@redhat.com>, Eric Blake <eblake@redhat.com>,\n Markus Armbruster <armbru@redhat.com>, Paul Durrant <paul@xen.org>,\n Anthony PERARD <anthony@xenproject.org>, =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= <philmd@linaro.org>,\n Eduardo Habkost <eduardo@habkost.net>, Paolo Bonzini <pbonzini@redhat.com>,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org,\n Samuel Thibault <samuel.thibault@ens-lyon.org>,\n Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>", "Subject": "[PULL v2 14/15] chardev: add logtimestamp option", "Date": "Fri, 13 Feb 2026 10:49:33 +0100", "Message-ID": "<20260213094938.4074478-15-marcandre.lureau@redhat.com>", "In-Reply-To": "<20260213094938.4074478-1-marcandre.lureau@redhat.com>", "References": "<20260213094938.4074478-1-marcandre.lureau@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>\n\nAdd an option to inject timestamps into serial log file.\nThat simplifies debugging a lot, when you can simply compare\nQEMU logs with guest console logs.\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>\nAcked-by: Markus Armbruster <armbru@redhat.com>\nReviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>\nMessage-ID: <20260201173633.413934-4-vsementsov@yandex-team.ru>\n---\n qapi/char.json | 6 +++-\n include/chardev/char.h | 2 ++\n chardev/char.c | 63 ++++++++++++++++++++++++++++++++++++++----\n 3 files changed, 65 insertions(+), 6 deletions(-)", "diff": "diff --git a/qapi/char.json b/qapi/char.json\nindex 140614f82c3..a4abafa6803 100644\n--- a/qapi/char.json\n+++ b/qapi/char.json\n@@ -197,11 +197,15 @@\n # @logappend: true to append instead of truncate (default to false to\n # truncate)\n #\n+# @logtimestamp: true to insert timestamps into logfile\n+# (default false) (since 11.0)\n+#\n # Since: 2.6\n ##\n { 'struct': 'ChardevCommon',\n 'data': { '*logfile': 'str',\n- '*logappend': 'bool' } }\n+ '*logappend': 'bool',\n+ '*logtimestamp': 'bool' } }\n \n ##\n # @ChardevFile:\ndiff --git a/include/chardev/char.h b/include/chardev/char.h\nindex 81bc0cbdf2a..c2c42e4b7a3 100644\n--- a/include/chardev/char.h\n+++ b/include/chardev/char.h\n@@ -63,6 +63,8 @@ struct Chardev {\n CharFrontend *fe;\n char *label;\n int logfd;\n+ bool logtimestamp;\n+ bool log_line_start;\n int be_open;\n /* used to coordinate the chardev-change special-case: */\n bool handover_yank_instance;\ndiff --git a/chardev/char.c b/chardev/char.c\nindex 4b285baf029..48b326d57b9 100644\n--- a/chardev/char.c\n+++ b/chardev/char.c\n@@ -82,12 +82,8 @@ void qemu_chr_be_event(Chardev *s, QEMUChrEvent event)\n CHARDEV_GET_CLASS(s)->chr_be_event(s, event);\n }\n \n-static void qemu_chr_write_log(Chardev *s, const uint8_t *buf, size_t len)\n+static void do_write_log(Chardev *s, const uint8_t *buf, size_t len)\n {\n- if (s->logfd < 0) {\n- return;\n- }\n-\n if (qemu_write_full(s->logfd, buf, len) < len) {\n /*\n * qemu_write_full() is defined with G_GNUC_WARN_UNUSED_RESULT,\n@@ -96,6 +92,55 @@ static void qemu_chr_write_log(Chardev *s, const uint8_t *buf, size_t len)\n }\n }\n \n+static void do_write_log_timestamps(Chardev *s, const uint8_t *buf, size_t len)\n+{\n+ g_autofree char *timestr = NULL;\n+\n+ while (len) {\n+ size_t i;\n+\n+ if (s->log_line_start) {\n+ if (!timestr) {\n+ timestr = real_time_iso8601();\n+ }\n+ do_write_log(s, (const uint8_t *)timestr, strlen(timestr));\n+ do_write_log(s, (const uint8_t *)\" \", 1);\n+ s->log_line_start = false;\n+ }\n+\n+ for (i = 0; i < len; i++) {\n+ if (buf[i] == '\\n') {\n+ break;\n+ }\n+ }\n+\n+ if (i == len) {\n+ /* not found \\n */\n+ do_write_log(s, buf, len);\n+ return;\n+ }\n+\n+ i += 1;\n+ do_write_log(s, buf, i);\n+ buf += i;\n+ len -= i;\n+ s->log_line_start = true;\n+ }\n+}\n+\n+static void qemu_chr_write_log(Chardev *s, const uint8_t *buf, size_t len)\n+{\n+ if (s->logfd < 0) {\n+ return;\n+ }\n+\n+ if (s->logtimestamp) {\n+ do_write_log_timestamps(s, buf, len);\n+ } else {\n+ do_write_log(s, buf, len);\n+ }\n+}\n+\n static int qemu_chr_write_buffer(Chardev *s,\n const uint8_t *buf, int len,\n int *offset, bool write_all)\n@@ -248,6 +293,7 @@ static bool qemu_char_open(Chardev *chr, ChardevBackend *backend, Error **errp)\n } else {\n flags |= O_TRUNC;\n }\n+ chr->logtimestamp = common->has_logtimestamp && common->logtimestamp;\n chr->logfd = qemu_create(common->logfile, flags, 0666, errp);\n if (chr->logfd < 0) {\n return false;\n@@ -267,6 +313,7 @@ static void char_init(Object *obj)\n \n chr->handover_yank_instance = false;\n chr->logfd = -1;\n+ chr->log_line_start = true;\n qemu_mutex_init(&chr->chr_write_lock);\n \n /*\n@@ -505,6 +552,9 @@ void qemu_chr_parse_common(QemuOpts *opts, ChardevCommon *backend)\n backend->logfile = g_strdup(logfile);\n backend->has_logappend = true;\n backend->logappend = qemu_opt_get_bool(opts, \"logappend\", false);\n+\n+ backend->has_logtimestamp = true;\n+ backend->logtimestamp = qemu_opt_get_bool(opts, \"logtimestamp\", false);\n }\n \n static const ChardevClass *char_get_class(const char *driver, Error **errp)\n@@ -956,6 +1006,9 @@ QemuOptsList qemu_chardev_opts = {\n },{\n .name = \"logappend\",\n .type = QEMU_OPT_BOOL,\n+ },{\n+ .name = \"logtimestamp\",\n+ .type = QEMU_OPT_BOOL,\n },{\n .name = \"mouse\",\n .type = QEMU_OPT_BOOL,\n", "prefixes": [ "PULL", "v2", "14/15" ] }