Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196264/?format=api
{ "id": 2196264, "url": "http://patchwork.ozlabs.org/api/patches/2196264/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260213094938.4074478-10-marcandre.lureau@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260213094938.4074478-10-marcandre.lureau@redhat.com>", "list_archive_url": null, "date": "2026-02-13T09:49:28", "name": "[PULL,v2,09/15] chardev: introduce .chr_get_pty_name() handler", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "cc3ded82e20ef3e7e97923bc110feb883b49d4b1", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260213094938.4074478-10-marcandre.lureau@redhat.com/mbox/", "series": [ { "id": 492070, "url": "http://patchwork.ozlabs.org/api/series/492070/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492070", "date": "2026-02-13T09:49:19", "name": "[PULL,v2,01/15] char-udp: Fix initial backend open status", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/492070/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196264/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196264/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=cokcXWVY;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fC6qn08FVz1xxM\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 13 Feb 2026 20:51:00 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vqpon-0007H8-LN; Fri, 13 Feb 2026 04:50:33 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vqpod-00073S-Cz\n for qemu-devel@nongnu.org; Fri, 13 Feb 2026 04:50:23 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vqpoY-0007IG-SP\n for qemu-devel@nongnu.org; Fri, 13 Feb 2026 04:50:22 -0500", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-6-E-7BdYCROJiGwt4vzl-fbA-1; Fri,\n 13 Feb 2026 04:50:14 -0500", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 2FB631800464; Fri, 13 Feb 2026 09:50:13 +0000 (UTC)", "from localhost (unknown [10.44.22.41])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 6388D1955D85; Fri, 13 Feb 2026 09:50:12 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1770976217;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=F4BORkMGuDDVLyTEyiaLb3JWHa0y/2ix01bD3RCQTgw=;\n b=cokcXWVYSa3hLdPdu0lSUyu8zQzjjofJH1wB/SwwVtyNLzFMC6T9zJJKvJn132sKiM7DeO\n n3FMcOHB/ihW8B+/efx/D3OUhQ5eusjP5ZlYgQ0pgK6EXbRfHa0Bdq1GF4q+dFNkeP1h0J\n ESoxIQMO/jLdSGn+BFjCKCcifr1hkTE=", "X-MC-Unique": "E-7BdYCROJiGwt4vzl-fbA-1", "X-Mimecast-MFC-AGG-ID": "E-7BdYCROJiGwt4vzl-fbA_1770976213", "From": "marcandre.lureau@redhat.com", "To": "qemu-devel@nongnu.org", "Cc": "=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n \"Edgar E. Iglesias\" <edgar.iglesias@gmail.com>, =?utf-8?q?Daniel_P=2E_Berra?=\n\t=?utf-8?q?ng=C3=A9?= <berrange@redhat.com>, Eric Blake <eblake@redhat.com>,\n Markus Armbruster <armbru@redhat.com>, Paul Durrant <paul@xen.org>,\n Anthony PERARD <anthony@xenproject.org>, =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= <philmd@linaro.org>,\n Eduardo Habkost <eduardo@habkost.net>, Paolo Bonzini <pbonzini@redhat.com>,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org,\n Samuel Thibault <samuel.thibault@ens-lyon.org>,\n Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>", "Subject": "[PULL v2 09/15] chardev: introduce .chr_get_pty_name() handler", "Date": "Fri, 13 Feb 2026 10:49:28 +0100", "Message-ID": "<20260213094938.4074478-10-marcandre.lureau@redhat.com>", "In-Reply-To": "<20260213094938.4074478-1-marcandre.lureau@redhat.com>", "References": "<20260213094938.4074478-1-marcandre.lureau@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>\n\nCurrently we do two wrong things:\n\n1. Abuse s->filename to get pty_name from it\n\n2. Violate layering with help of CHARDEV_IS_PTY()\n\nLet's get rid of both, and introduce correct way to get pty name in\ngeneric code, if available.\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>\nReviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>\nMessage-Id: <20260115144606.233252-9-vsementsov@yandex-team.ru>\n---\n include/chardev/char.h | 7 +++++--\n chardev/char-pty.c | 7 +++++++\n chardev/char.c | 19 +++++++++++++------\n hw/char/xen_console.c | 7 ++++---\n 4 files changed, 29 insertions(+), 11 deletions(-)", "diff": "diff --git a/include/chardev/char.h b/include/chardev/char.h\nindex e1bf97222b8..ada5529fa6c 100644\n--- a/include/chardev/char.h\n+++ b/include/chardev/char.h\n@@ -247,8 +247,6 @@ OBJECT_DECLARE_TYPE(Chardev, ChardevClass, CHARDEV)\n \n #define CHARDEV_IS_RINGBUF(chr) \\\n object_dynamic_cast(OBJECT(chr), TYPE_CHARDEV_RINGBUF)\n-#define CHARDEV_IS_PTY(chr) \\\n- object_dynamic_cast(OBJECT(chr), TYPE_CHARDEV_PTY)\n \n struct ChardevClass {\n ObjectClass parent_class;\n@@ -308,6 +306,9 @@ struct ChardevClass {\n void (*chr_be_event)(Chardev *s, QEMUChrEvent event);\n \n void (*chr_listener_cleanup)(Chardev *chr);\n+\n+ /* return PTY name if available */\n+ char *(*chr_get_pty_name)(Chardev *s);\n };\n \n Chardev *qemu_chardev_new(const char *id, const char *typename,\n@@ -322,4 +323,6 @@ GSource *qemu_chr_timeout_add_ms(Chardev *chr, guint ms,\n void suspend_mux_open(void);\n void resume_mux_open(void);\n \n+char *qemu_chr_get_pty_name(Chardev *chr);\n+\n #endif\ndiff --git a/chardev/char-pty.c b/chardev/char-pty.c\nindex a582aa7bc73..047aade09e5 100644\n--- a/chardev/char-pty.c\n+++ b/chardev/char-pty.c\n@@ -387,6 +387,12 @@ static void pty_chr_parse(QemuOpts *opts, ChardevBackend *backend, Error **errp)\n pty->path = g_strdup(path);\n }\n \n+static char *pty_chr_get_pty_name(Chardev *chr)\n+{\n+ PtyChardev *s = PTY_CHARDEV(chr);\n+ return g_strdup(s->pty_name);\n+}\n+\n static void char_pty_class_init(ObjectClass *oc, const void *data)\n {\n ChardevClass *cc = CHARDEV_CLASS(oc);\n@@ -396,6 +402,7 @@ static void char_pty_class_init(ObjectClass *oc, const void *data)\n cc->chr_write = pty_chr_write;\n cc->chr_update_read_handler = pty_chr_update_read_handler;\n cc->chr_add_watch = pty_chr_add_watch;\n+ cc->chr_get_pty_name = pty_chr_get_pty_name;\n }\n \n static const TypeInfo char_pty_type_info = {\ndiff --git a/chardev/char.c b/chardev/char.c\nindex 44bfed36272..0dc792b88f7 100644\n--- a/chardev/char.c\n+++ b/chardev/char.c\n@@ -1090,9 +1090,7 @@ ChardevReturn *qmp_chardev_add(const char *id, ChardevBackend *backend,\n }\n \n ret = g_new0(ChardevReturn, 1);\n- if (CHARDEV_IS_PTY(chr)) {\n- ret->pty = g_strdup(chr->filename + 4);\n- }\n+ ret->pty = qemu_chr_get_pty_name(chr);\n \n return ret;\n \n@@ -1101,6 +1099,17 @@ err:\n return NULL;\n }\n \n+char *qemu_chr_get_pty_name(Chardev *chr)\n+{\n+ ChardevClass *cc = CHARDEV_GET_CLASS(chr);\n+\n+ if (cc->chr_get_pty_name) {\n+ return cc->chr_get_pty_name(chr);\n+ }\n+\n+ return NULL;\n+}\n+\n ChardevReturn *qmp_chardev_change(const char *id, ChardevBackend *backend,\n Error **errp)\n {\n@@ -1192,9 +1201,7 @@ ChardevReturn *qmp_chardev_change(const char *id, ChardevBackend *backend,\n object_unref(OBJECT(chr_new));\n \n ret = g_new0(ChardevReturn, 1);\n- if (CHARDEV_IS_PTY(chr_new)) {\n- ret->pty = g_strdup(chr_new->filename + 4);\n- }\n+ ret->pty = qemu_chr_get_pty_name(chr_new);\n \n return ret;\n }\ndiff --git a/hw/char/xen_console.c b/hw/char/xen_console.c\nindex 8ee098d9ad4..bdeb76dc870 100644\n--- a/hw/char/xen_console.c\n+++ b/hw/char/xen_console.c\n@@ -418,6 +418,7 @@ static void xen_console_realize(XenDevice *xendev, Error **errp)\n XenConsole *con = XEN_CONSOLE_DEVICE(xendev);\n Chardev *cs = qemu_chr_fe_get_driver(&con->chr);\n unsigned int u;\n+ g_autofree char *pty_name = NULL;\n \n if (!cs) {\n error_setg(errp, \"no backing character device\");\n@@ -450,9 +451,9 @@ static void xen_console_realize(XenDevice *xendev, Error **errp)\n \n trace_xen_console_realize(con->dev, object_get_typename(OBJECT(cs)));\n \n- if (CHARDEV_IS_PTY(cs)) {\n- /* Strip the leading 'pty:' */\n- xen_device_frontend_printf(xendev, \"tty\", \"%s\", cs->filename + 4);\n+ pty_name = qemu_chr_get_pty_name(cs);\n+ if (pty_name) {\n+ xen_device_frontend_printf(xendev, \"tty\", \"%s\", pty_name);\n }\n \n /* No normal PV driver initialization for the primary console under Xen */\n", "prefixes": [ "PULL", "v2", "09/15" ] }