Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196262/?format=api
{ "id": 2196262, "url": "http://patchwork.ozlabs.org/api/patches/2196262/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260213094938.4074478-11-marcandre.lureau@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260213094938.4074478-11-marcandre.lureau@redhat.com>", "list_archive_url": null, "date": "2026-02-13T09:49:29", "name": "[PULL,v2,10/15] chardev: rework filename handling", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f6332e48bb2448a02c346bc6fd6a4e64d6baf8f5", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260213094938.4074478-11-marcandre.lureau@redhat.com/mbox/", "series": [ { "id": 492070, "url": "http://patchwork.ozlabs.org/api/series/492070/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492070", "date": "2026-02-13T09:49:19", "name": "[PULL,v2,01/15] char-udp: Fix initial backend open status", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/492070/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196262/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196262/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=hMOvy3uy;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fC6qW4rM9z1xpl\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 13 Feb 2026 20:50:47 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vqpoq-0007TT-L6; Fri, 13 Feb 2026 04:50:36 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vqpoh-00077A-Oq\n for qemu-devel@nongnu.org; Fri, 13 Feb 2026 04:50:31 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vqpob-0007KM-Up\n for qemu-devel@nongnu.org; Fri, 13 Feb 2026 04:50:25 -0500", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-433--Y17YsGYPkOtZeaIxLcQjw-1; Fri,\n 13 Feb 2026 04:50:17 -0500", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id DFF8419560AA; Fri, 13 Feb 2026 09:50:15 +0000 (UTC)", "from localhost (unknown [10.44.22.41])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 435E71955D85; Fri, 13 Feb 2026 09:50:14 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1770976221;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=NawPSV0+R7Z6iBTNYDG41PH3COFdnG/VW+iZ15ECL/g=;\n b=hMOvy3uyQGFRNGiO0tP2eqVKtTfPFsvxr6cTbleSYm0UVAn82IdM+70MBfa8h8hbbPqKnf\n IAvYBqvcAk1o6ptKHBrlFa2lFDMgoPGme3q2CEDbZ+uxfPzORJrXDFVNmf00YCehdJxdd5\n nGUeLO5EIfW4Uyk8qJOI14bCGS9wVBc=", "X-MC-Unique": "-Y17YsGYPkOtZeaIxLcQjw-1", "X-Mimecast-MFC-AGG-ID": "-Y17YsGYPkOtZeaIxLcQjw_1770976216", "From": "marcandre.lureau@redhat.com", "To": "qemu-devel@nongnu.org", "Cc": "=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n \"Edgar E. Iglesias\" <edgar.iglesias@gmail.com>, =?utf-8?q?Daniel_P=2E_Berra?=\n\t=?utf-8?q?ng=C3=A9?= <berrange@redhat.com>, Eric Blake <eblake@redhat.com>,\n Markus Armbruster <armbru@redhat.com>, Paul Durrant <paul@xen.org>,\n Anthony PERARD <anthony@xenproject.org>, =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= <philmd@linaro.org>,\n Eduardo Habkost <eduardo@habkost.net>, Paolo Bonzini <pbonzini@redhat.com>,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org,\n Samuel Thibault <samuel.thibault@ens-lyon.org>,\n Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>", "Subject": "[PULL v2 10/15] chardev: rework filename handling", "Date": "Fri, 13 Feb 2026 10:49:29 +0100", "Message-ID": "<20260213094938.4074478-11-marcandre.lureau@redhat.com>", "In-Reply-To": "<20260213094938.4074478-1-marcandre.lureau@redhat.com>", "References": "<20260213094938.4074478-1-marcandre.lureau@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>\n\nInstead of checking, did backend set the filename state or not, let's\nbe stateless: filename is needed rarely, so, let's just have a generic\nfunction (with optional implementation by backends) to get it.\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>\n[ Marc-André - fix leak in ivshmem-pci.c ]\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\nMessage-Id: <20260115144606.233252-10-vsementsov@yandex-team.ru>\n---\n include/chardev/char.h | 5 ++++-\n chardev/char-pty.c | 8 +++++++-\n chardev/char-socket.c | 31 ++++++++++++-------------------\n chardev/char.c | 21 +++++++++++++++------\n hw/misc/ivshmem-pci.c | 7 ++++---\n 5 files changed, 42 insertions(+), 30 deletions(-)", "diff": "diff --git a/include/chardev/char.h b/include/chardev/char.h\nindex ada5529fa6c..81bc0cbdf2a 100644\n--- a/include/chardev/char.h\n+++ b/include/chardev/char.h\n@@ -62,7 +62,6 @@ struct Chardev {\n QemuMutex chr_write_lock;\n CharFrontend *fe;\n char *label;\n- char *filename;\n int logfd;\n int be_open;\n /* used to coordinate the chardev-change special-case: */\n@@ -309,6 +308,9 @@ struct ChardevClass {\n \n /* return PTY name if available */\n char *(*chr_get_pty_name)(Chardev *s);\n+\n+ /* get filename for reporting */\n+ char *(*chr_get_filename)(Chardev *s);\n };\n \n Chardev *qemu_chardev_new(const char *id, const char *typename,\n@@ -324,5 +326,6 @@ void suspend_mux_open(void);\n void resume_mux_open(void);\n \n char *qemu_chr_get_pty_name(Chardev *chr);\n+char *qemu_chr_get_filename(Chardev *chr);\n \n #endif\ndiff --git a/chardev/char-pty.c b/chardev/char-pty.c\nindex 047aade09e5..7e95132cdbb 100644\n--- a/chardev/char-pty.c\n+++ b/chardev/char-pty.c\n@@ -351,7 +351,6 @@ static bool pty_chr_open(Chardev *chr, ChardevBackend *backend, Error **errp)\n return false;\n }\n \n- chr->filename = g_strdup_printf(\"pty:%s\", s->pty_name);\n qemu_printf(\"char device redirected to %s (label %s)\\n\",\n s->pty_name, chr->label);\n \n@@ -393,6 +392,12 @@ static char *pty_chr_get_pty_name(Chardev *chr)\n return g_strdup(s->pty_name);\n }\n \n+static char *pty_chr_get_filename(Chardev *chr)\n+{\n+ PtyChardev *s = PTY_CHARDEV(chr);\n+ return g_strdup_printf(\"pty:%s\", s->pty_name);\n+}\n+\n static void char_pty_class_init(ObjectClass *oc, const void *data)\n {\n ChardevClass *cc = CHARDEV_CLASS(oc);\n@@ -403,6 +408,7 @@ static void char_pty_class_init(ObjectClass *oc, const void *data)\n cc->chr_update_read_handler = pty_chr_update_read_handler;\n cc->chr_add_watch = pty_chr_add_watch;\n cc->chr_get_pty_name = pty_chr_get_pty_name;\n+ cc->chr_get_filename = pty_chr_get_filename;\n }\n \n static const TypeInfo char_pty_type_info = {\ndiff --git a/chardev/char-socket.c b/chardev/char-socket.c\nindex 908bbdbc124..5adeb908659 100644\n--- a/chardev/char-socket.c\n+++ b/chardev/char-socket.c\n@@ -40,6 +40,7 @@\n \n static gboolean socket_reconnect_timeout(gpointer opaque);\n static void tcp_chr_telnet_init(Chardev *chr);\n+static char *qemu_chr_compute_filename(SocketChardev *s);\n \n static void tcp_chr_change_state(SocketChardev *s, TCPChardevState state)\n {\n@@ -384,8 +385,6 @@ static void tcp_chr_free_connection(Chardev *chr)\n s->sioc = NULL;\n object_unref(OBJECT(s->ioc));\n s->ioc = NULL;\n- g_free(chr->filename);\n- chr->filename = NULL;\n tcp_chr_change_state(s, TCP_CHARDEV_STATE_DISCONNECTED);\n }\n \n@@ -439,16 +438,17 @@ static char *qemu_chr_socket_address(SocketChardev *s, const char *prefix)\n }\n }\n \n-static void update_disconnected_filename(SocketChardev *s)\n+static char *tcp_chr_get_filename(Chardev *chr)\n {\n- Chardev *chr = CHARDEV(s);\n+ SocketChardev *s = SOCKET_CHARDEV(chr);\n \n- g_free(chr->filename);\n- if (s->addr) {\n- chr->filename = qemu_chr_socket_address(s, \"disconnected:\");\n- } else {\n- chr->filename = g_strdup(\"disconnected:socket\");\n+ if (s->state == TCP_CHARDEV_STATE_CONNECTED) {\n+ return qemu_chr_compute_filename(s);\n+ } else if (s->addr) {\n+ return qemu_chr_socket_address(s, \"disconnected:\");\n }\n+\n+ return g_strdup(\"disconnected:socket\");\n }\n \n /* NB may be called even if tcp_chr_connect has not been\n@@ -468,7 +468,6 @@ static void tcp_chr_disconnect_locked(Chardev *chr)\n qio_net_listener_set_client_func_full(s->listener, tcp_chr_accept,\n chr, NULL, chr->gcontext);\n }\n- update_disconnected_filename(s);\n if (emit_close) {\n qemu_chr_be_event(chr, CHR_EVENT_CLOSED);\n }\n@@ -639,9 +638,6 @@ static void tcp_chr_connect(void *opaque)\n Chardev *chr = CHARDEV(opaque);\n SocketChardev *s = SOCKET_CHARDEV(opaque);\n \n- g_free(chr->filename);\n- chr->filename = qemu_chr_compute_filename(s);\n-\n tcp_chr_change_state(s, TCP_CHARDEV_STATE_CONNECTED);\n update_ioc_handlers(s);\n qemu_chr_be_event(chr, CHR_EVENT_OPENED);\n@@ -1000,8 +996,8 @@ static void tcp_chr_accept_server_sync(Chardev *chr)\n {\n SocketChardev *s = SOCKET_CHARDEV(chr);\n QIOChannelSocket *sioc;\n- info_report(\"QEMU waiting for connection on: %s\",\n- chr->filename);\n+ g_autofree char *filename = qemu_chr_get_filename(chr);\n+ info_report(\"QEMU waiting for connection on: %s\", filename);\n tcp_chr_change_state(s, TCP_CHARDEV_STATE_CONNECTING);\n sioc = qio_net_listener_wait_client(s->listener);\n tcp_chr_set_client_ioc_name(chr, sioc);\n@@ -1258,8 +1254,6 @@ static int qmp_chardev_open_socket_server(Chardev *chr,\n s->addr = qio_net_listener_get_local_address(s->listener, 0, errp);\n \n skip_listen:\n- update_disconnected_filename(s);\n-\n if (is_waitconnect) {\n tcp_chr_accept_server_sync(chr);\n } else {\n@@ -1436,8 +1430,6 @@ static bool tcp_chr_open(Chardev *chr, ChardevBackend *backend, Error **errp)\n }\n s->registered_yank = true;\n \n- update_disconnected_filename(s);\n-\n if (s->is_listen) {\n if (qmp_chardev_open_socket_server(chr, is_telnet || is_tn3270,\n is_waitconnect, errp) < 0) {\n@@ -1593,6 +1585,7 @@ static void char_socket_class_init(ObjectClass *oc, const void *data)\n cc->chr_add_watch = tcp_chr_add_watch;\n cc->chr_update_read_handler = tcp_chr_update_read_handler;\n cc->chr_listener_cleanup = tcp_chr_listener_cleanup;\n+ cc->chr_get_filename = tcp_chr_get_filename;\n \n object_class_property_add(oc, \"addr\", \"SocketAddress\",\n char_socket_get_addr, NULL,\ndiff --git a/chardev/char.c b/chardev/char.c\nindex 0dc792b88f7..3373c9b61f8 100644\n--- a/chardev/char.c\n+++ b/chardev/char.c\n@@ -309,7 +309,6 @@ static void char_finalize(Object *obj)\n if (chr->fe) {\n chr->fe->chr = NULL;\n }\n- g_free(chr->filename);\n g_free(chr->label);\n if (chr->logfd != -1) {\n close(chr->logfd);\n@@ -796,7 +795,7 @@ static int qmp_query_chardev_foreach(Object *obj, void *data)\n ChardevInfo *value = g_malloc0(sizeof(*value));\n \n value->label = g_strdup(chr->label);\n- value->filename = g_strdup(chr->filename);\n+ value->filename = qemu_chr_get_filename(chr);\n value->frontend_open = chr->fe && chr->fe->fe_is_open;\n \n QAPI_LIST_PREPEND(*list, value);\n@@ -1025,10 +1024,6 @@ static Chardev *chardev_new(const char *id, const char *typename,\n return NULL;\n }\n \n- if (!chr->filename) {\n- chr->filename = g_strdup(typename + 8);\n- }\n-\n return chr;\n }\n \n@@ -1110,6 +1105,20 @@ char *qemu_chr_get_pty_name(Chardev *chr)\n return NULL;\n }\n \n+char *qemu_chr_get_filename(Chardev *chr)\n+{\n+ ChardevClass *cc = CHARDEV_GET_CLASS(chr);\n+ const char *typename;\n+\n+ if (cc->chr_get_filename) {\n+ return cc->chr_get_filename(chr);\n+ }\n+\n+ typename = object_get_typename(OBJECT(chr));\n+ assert(g_str_has_prefix(typename, \"chardev-\"));\n+ return g_strdup(typename + 8);\n+}\n+\n ChardevReturn *qmp_chardev_change(const char *id, ChardevBackend *backend,\n Error **errp)\n {\ndiff --git a/hw/misc/ivshmem-pci.c b/hw/misc/ivshmem-pci.c\nindex b9162589a02..a3a43f53bd1 100644\n--- a/hw/misc/ivshmem-pci.c\n+++ b/hw/misc/ivshmem-pci.c\n@@ -873,10 +873,11 @@ static void ivshmem_common_realize(PCIDevice *dev, Error **errp)\n host_memory_backend_set_mapped(s->hostmem, true);\n } else {\n Chardev *chr = qemu_chr_fe_get_driver(&s->server_chr);\n- assert(chr);\n+ g_autofree char *filename = NULL;\n \n- IVSHMEM_DPRINTF(\"using shared memory server (socket = %s)\\n\",\n- chr->filename);\n+ assert(chr);\n+ filename = qemu_chr_get_filename(chr);\n+ IVSHMEM_DPRINTF(\"using shared memory server (socket = %s)\\n\", filename);\n \n /* we allocate enough space for 16 peers and grow as needed */\n resize_peers(s, 16);\n", "prefixes": [ "PULL", "v2", "10/15" ] }