Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196261/?format=api
{ "id": 2196261, "url": "http://patchwork.ozlabs.org/api/patches/2196261/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260213094938.4074478-5-marcandre.lureau@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260213094938.4074478-5-marcandre.lureau@redhat.com>", "list_archive_url": null, "date": "2026-02-13T09:49:23", "name": "[PULL,v2,04/15] chardev: ChardevClass: consistent naming for handlers", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "373aea6530dbb49a3e74813b0e63b5b64683f54a", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260213094938.4074478-5-marcandre.lureau@redhat.com/mbox/", "series": [ { "id": 492070, "url": "http://patchwork.ozlabs.org/api/series/492070/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492070", "date": "2026-02-13T09:49:19", "name": "[PULL,v2,01/15] char-udp: Fix initial backend open status", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/492070/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196261/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196261/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=iXaS3dtB;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fC6qP5BnPz1xpl\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 13 Feb 2026 20:50:41 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vqpoa-0006yw-VT; Fri, 13 Feb 2026 04:50:21 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vqpoS-0006wr-J5\n for qemu-devel@nongnu.org; Fri, 13 Feb 2026 04:50:12 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vqpoP-0007Gn-IZ\n for qemu-devel@nongnu.org; Fri, 13 Feb 2026 04:50:11 -0500", "from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-136-Bh-00Ep0N_SO-0gTINRxQA-1; Fri,\n 13 Feb 2026 04:50:06 -0500", "from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 81A0B1884EDC; Fri, 13 Feb 2026 09:49:56 +0000 (UTC)", "from localhost (unknown [10.44.22.41])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 5DA40180066E; Fri, 13 Feb 2026 09:49:54 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1770976209;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=K/EYv/wOL3z8Ia2Topl38iZZVA139L2JWNE4O9fOHA4=;\n b=iXaS3dtBmjD6xUhDe21nqAZYJxNltQVg1Ld3sdZnfU8aGh4E9UaZf5/aS2MhNuZi34yufO\n c43/hLeid9AggPR0NcWZzjOH4hDWOG2H/C7zKWAk0fnQUXhQ0N0GfzBzto/hw/qKbw/V2p\n Ea7HZAG3VPMbASPPgaPWyHzga/5FdR0=", "X-MC-Unique": "Bh-00Ep0N_SO-0gTINRxQA-1", "X-Mimecast-MFC-AGG-ID": "Bh-00Ep0N_SO-0gTINRxQA_1770976205", "From": "marcandre.lureau@redhat.com", "To": "qemu-devel@nongnu.org", "Cc": "=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n \"Edgar E. Iglesias\" <edgar.iglesias@gmail.com>, =?utf-8?q?Daniel_P=2E_Berra?=\n\t=?utf-8?q?ng=C3=A9?= <berrange@redhat.com>, Eric Blake <eblake@redhat.com>,\n Markus Armbruster <armbru@redhat.com>, Paul Durrant <paul@xen.org>,\n Anthony PERARD <anthony@xenproject.org>, =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= <philmd@linaro.org>,\n Eduardo Habkost <eduardo@habkost.net>, Paolo Bonzini <pbonzini@redhat.com>,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org,\n Samuel Thibault <samuel.thibault@ens-lyon.org>,\n Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>", "Subject": "[PULL v2 04/15] chardev: ChardevClass: consistent naming for handlers", "Date": "Fri, 13 Feb 2026 10:49:23 +0100", "Message-ID": "<20260213094938.4074478-5-marcandre.lureau@redhat.com>", "In-Reply-To": "<20260213094938.4074478-1-marcandre.lureau@redhat.com>", "References": "<20260213094938.4074478-1-marcandre.lureau@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.93", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>\n\nMost handlers have name prefixed with \"chr_\". That's a good practice\nwhich helps to grep them. Convert the rest: .parse, .open,\nget/set_msgfds.\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>\nReviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>\nMessage-Id: <20260115144606.233252-4-vsementsov@yandex-team.ru>\n---\n include/chardev/char.h | 8 ++++----\n chardev/baum.c | 2 +-\n chardev/char-console.c | 2 +-\n chardev/char-fe.c | 8 ++++----\n chardev/char-file.c | 4 ++--\n chardev/char-hub.c | 4 ++--\n chardev/char-mux.c | 4 ++--\n chardev/char-null.c | 2 +-\n chardev/char-parallel.c | 4 ++--\n chardev/char-pipe.c | 4 ++--\n chardev/char-pty.c | 4 ++--\n chardev/char-ringbuf.c | 4 ++--\n chardev/char-serial.c | 4 ++--\n chardev/char-socket.c | 8 ++++----\n chardev/char-stdio.c | 4 ++--\n chardev/char-udp.c | 4 ++--\n chardev/char-win-stdio.c | 2 +-\n chardev/char.c | 8 ++++----\n chardev/msmouse.c | 2 +-\n chardev/spice.c | 8 ++++----\n chardev/wctablet.c | 2 +-\n gdbstub/system.c | 2 +-\n ui/console-vc.c | 4 ++--\n ui/dbus-chardev.c | 8 ++++----\n ui/dbus.c | 4 ++--\n ui/gtk.c | 2 +-\n ui/spice-app.c | 6 +++---\n ui/vdagent.c | 4 ++--\n scripts/codeconverter/codeconverter/test_regexps.py | 2 +-\n 29 files changed, 62 insertions(+), 62 deletions(-)", "diff": "diff --git a/include/chardev/char.h b/include/chardev/char.h\nindex 192cad67d41..d33833b6c02 100644\n--- a/include/chardev/char.h\n+++ b/include/chardev/char.h\n@@ -257,10 +257,10 @@ struct ChardevClass {\n bool supports_yank;\n \n /* parse command line options and populate QAPI @backend */\n- void (*parse)(QemuOpts *opts, ChardevBackend *backend, Error **errp);\n+ void (*chr_parse)(QemuOpts *opts, ChardevBackend *backend, Error **errp);\n \n /* called after construction, open/starts the backend */\n- void (*open)(Chardev *chr, ChardevBackend *backend,\n+ void (*chr_open)(Chardev *chr, ChardevBackend *backend,\n bool *be_opened, Error **errp);\n \n /* write buf to the backend */\n@@ -282,10 +282,10 @@ struct ChardevClass {\n int (*chr_ioctl)(Chardev *s, int cmd, void *arg);\n \n /* get ancillary-received fds during last read */\n- int (*get_msgfds)(Chardev *s, int* fds, int num);\n+ int (*chr_get_msgfds)(Chardev *s, int* fds, int num);\n \n /* set ancillary fds to be sent with next write */\n- int (*set_msgfds)(Chardev *s, int *fds, int num);\n+ int (*chr_set_msgfds)(Chardev *s, int *fds, int num);\n \n /* accept the given fd */\n int (*chr_add_client)(Chardev *chr, int fd);\ndiff --git a/chardev/baum.c b/chardev/baum.c\nindex 157f8b95195..75e41965c11 100644\n--- a/chardev/baum.c\n+++ b/chardev/baum.c\n@@ -676,7 +676,7 @@ static void char_braille_class_init(ObjectClass *oc, const void *data)\n {\n ChardevClass *cc = CHARDEV_CLASS(oc);\n \n- cc->open = baum_chr_open;\n+ cc->chr_open = baum_chr_open;\n cc->chr_write = baum_chr_write;\n cc->chr_accept_input = baum_chr_accept_input;\n }\ndiff --git a/chardev/char-console.c b/chardev/char-console.c\nindex 7e1bf642ebd..9a2e012d53f 100644\n--- a/chardev/char-console.c\n+++ b/chardev/char-console.c\n@@ -38,7 +38,7 @@ static void char_console_class_init(ObjectClass *oc, const void *data)\n {\n ChardevClass *cc = CHARDEV_CLASS(oc);\n \n- cc->open = qemu_chr_open_win_con;\n+ cc->chr_open = qemu_chr_open_win_con;\n }\n \n static const TypeInfo char_console_type_info = {\ndiff --git a/chardev/char-fe.c b/chardev/char-fe.c\nindex 34b83fc1c4a..a44f2673731 100644\n--- a/chardev/char-fe.c\n+++ b/chardev/char-fe.c\n@@ -130,8 +130,8 @@ int qemu_chr_fe_get_msgfds(CharFrontend *c, int *fds, int len)\n return -1;\n }\n \n- return CHARDEV_GET_CLASS(s)->get_msgfds ?\n- CHARDEV_GET_CLASS(s)->get_msgfds(s, fds, len) : -1;\n+ return CHARDEV_GET_CLASS(s)->chr_get_msgfds ?\n+ CHARDEV_GET_CLASS(s)->chr_get_msgfds(s, fds, len) : -1;\n }\n \n int qemu_chr_fe_set_msgfds(CharFrontend *c, int *fds, int num)\n@@ -142,8 +142,8 @@ int qemu_chr_fe_set_msgfds(CharFrontend *c, int *fds, int num)\n return -1;\n }\n \n- return CHARDEV_GET_CLASS(s)->set_msgfds ?\n- CHARDEV_GET_CLASS(s)->set_msgfds(s, fds, num) : -1;\n+ return CHARDEV_GET_CLASS(s)->chr_set_msgfds ?\n+ CHARDEV_GET_CLASS(s)->chr_set_msgfds(s, fds, num) : -1;\n }\n \n void qemu_chr_fe_accept_input(CharFrontend *c)\ndiff --git a/chardev/char-file.c b/chardev/char-file.c\nindex 1f7adf592ff..1e293e7054a 100644\n--- a/chardev/char-file.c\n+++ b/chardev/char-file.c\n@@ -133,8 +133,8 @@ static void char_file_class_init(ObjectClass *oc, const void *data)\n {\n ChardevClass *cc = CHARDEV_CLASS(oc);\n \n- cc->parse = qemu_chr_parse_file_out;\n- cc->open = qmp_chardev_open_file;\n+ cc->chr_parse = qemu_chr_parse_file_out;\n+ cc->chr_open = qmp_chardev_open_file;\n }\n \n static const TypeInfo char_file_type_info = {\ndiff --git a/chardev/char-hub.c b/chardev/char-hub.c\nindex d0967c22336..082baa84ab8 100644\n--- a/chardev/char-hub.c\n+++ b/chardev/char-hub.c\n@@ -276,8 +276,8 @@ static void char_hub_class_init(ObjectClass *oc, const void *data)\n {\n ChardevClass *cc = CHARDEV_CLASS(oc);\n \n- cc->parse = qemu_chr_parse_hub;\n- cc->open = qemu_chr_open_hub;\n+ cc->chr_parse = qemu_chr_parse_hub;\n+ cc->chr_open = qemu_chr_open_hub;\n cc->chr_write = hub_chr_write;\n cc->chr_add_watch = hub_chr_add_watch;\n /* We handle events from backends only */\ndiff --git a/chardev/char-mux.c b/chardev/char-mux.c\nindex db9e89f441d..c82c2da56dd 100644\n--- a/chardev/char-mux.c\n+++ b/chardev/char-mux.c\n@@ -451,8 +451,8 @@ static void char_mux_class_init(ObjectClass *oc, const void *data)\n {\n ChardevClass *cc = CHARDEV_CLASS(oc);\n \n- cc->parse = qemu_chr_parse_mux;\n- cc->open = qemu_chr_open_mux;\n+ cc->chr_parse = qemu_chr_parse_mux;\n+ cc->chr_open = qemu_chr_open_mux;\n cc->chr_write = mux_chr_write;\n cc->chr_accept_input = mux_chr_accept_input;\n cc->chr_add_watch = mux_chr_add_watch;\ndiff --git a/chardev/char-null.c b/chardev/char-null.c\nindex 89cb85da792..674603b3807 100644\n--- a/chardev/char-null.c\n+++ b/chardev/char-null.c\n@@ -38,7 +38,7 @@ static void char_null_class_init(ObjectClass *oc, const void *data)\n {\n ChardevClass *cc = CHARDEV_CLASS(oc);\n \n- cc->open = null_chr_open;\n+ cc->chr_open = null_chr_open;\n }\n \n static const TypeInfo char_null_type_info = {\ndiff --git a/chardev/char-parallel.c b/chardev/char-parallel.c\nindex 62a44b2f969..a0839b784b8 100644\n--- a/chardev/char-parallel.c\n+++ b/chardev/char-parallel.c\n@@ -274,8 +274,8 @@ static void char_parallel_class_init(ObjectClass *oc, const void *data)\n {\n ChardevClass *cc = CHARDEV_CLASS(oc);\n \n- cc->parse = qemu_chr_parse_parallel;\n- cc->open = qmp_chardev_open_parallel;\n+ cc->chr_parse = qemu_chr_parse_parallel;\n+ cc->chr_open = qmp_chardev_open_parallel;\n cc->chr_ioctl = pp_ioctl;\n }\n \ndiff --git a/chardev/char-pipe.c b/chardev/char-pipe.c\nindex e9f3bb82904..a2cd322efe6 100644\n--- a/chardev/char-pipe.c\n+++ b/chardev/char-pipe.c\n@@ -182,8 +182,8 @@ static void char_pipe_class_init(ObjectClass *oc, const void *data)\n {\n ChardevClass *cc = CHARDEV_CLASS(oc);\n \n- cc->parse = qemu_chr_parse_pipe;\n- cc->open = qemu_chr_open_pipe;\n+ cc->chr_parse = qemu_chr_parse_pipe;\n+ cc->chr_open = qemu_chr_open_pipe;\n }\n \n static const TypeInfo char_pipe_type_info = {\ndiff --git a/chardev/char-pty.c b/chardev/char-pty.c\nindex 652b0bd9e73..1a15082b025 100644\n--- a/chardev/char-pty.c\n+++ b/chardev/char-pty.c\n@@ -394,8 +394,8 @@ static void char_pty_class_init(ObjectClass *oc, const void *data)\n {\n ChardevClass *cc = CHARDEV_CLASS(oc);\n \n- cc->parse = char_pty_parse;\n- cc->open = char_pty_open;\n+ cc->chr_parse = char_pty_parse;\n+ cc->chr_open = char_pty_open;\n cc->chr_write = char_pty_chr_write;\n cc->chr_update_read_handler = pty_chr_update_read_handler;\n cc->chr_add_watch = pty_chr_add_watch;\ndiff --git a/chardev/char-ringbuf.c b/chardev/char-ringbuf.c\nindex 98aadb6acfb..6d5ba667bb4 100644\n--- a/chardev/char-ringbuf.c\n+++ b/chardev/char-ringbuf.c\n@@ -227,8 +227,8 @@ static void char_ringbuf_class_init(ObjectClass *oc, const void *data)\n {\n ChardevClass *cc = CHARDEV_CLASS(oc);\n \n- cc->parse = qemu_chr_parse_ringbuf;\n- cc->open = qemu_chr_open_ringbuf;\n+ cc->chr_parse = qemu_chr_parse_ringbuf;\n+ cc->chr_open = qemu_chr_open_ringbuf;\n cc->chr_write = ringbuf_chr_write;\n }\n \ndiff --git a/chardev/char-serial.c b/chardev/char-serial.c\nindex 4c6ca713eb1..97ed7adf736 100644\n--- a/chardev/char-serial.c\n+++ b/chardev/char-serial.c\n@@ -305,8 +305,8 @@ static void char_serial_class_init(ObjectClass *oc, const void *data)\n {\n ChardevClass *cc = CHARDEV_CLASS(oc);\n \n- cc->parse = qemu_chr_parse_serial;\n- cc->open = qmp_chardev_open_serial;\n+ cc->chr_parse = qemu_chr_parse_serial;\n+ cc->chr_open = qmp_chardev_open_serial;\n #ifndef _WIN32\n cc->chr_ioctl = tty_serial_ioctl;\n #endif\ndiff --git a/chardev/char-socket.c b/chardev/char-socket.c\nindex 3f45dd2ecdc..149a6d8cc15 100644\n--- a/chardev/char-socket.c\n+++ b/chardev/char-socket.c\n@@ -1585,14 +1585,14 @@ static void char_socket_class_init(ObjectClass *oc, const void *data)\n \n cc->supports_yank = true;\n \n- cc->parse = qemu_chr_parse_socket;\n- cc->open = qmp_chardev_open_socket;\n+ cc->chr_parse = qemu_chr_parse_socket;\n+ cc->chr_open = qmp_chardev_open_socket;\n cc->chr_wait_connected = tcp_chr_wait_connected;\n cc->chr_write = tcp_chr_write;\n cc->chr_sync_read = tcp_chr_sync_read;\n cc->chr_disconnect = tcp_chr_disconnect;\n- cc->get_msgfds = tcp_get_msgfds;\n- cc->set_msgfds = tcp_set_msgfds;\n+ cc->chr_get_msgfds = tcp_get_msgfds;\n+ cc->chr_set_msgfds = tcp_set_msgfds;\n cc->chr_add_client = tcp_chr_add_client;\n cc->chr_add_watch = tcp_chr_add_watch;\n cc->chr_update_read_handler = tcp_chr_update_read_handler;\ndiff --git a/chardev/char-stdio.c b/chardev/char-stdio.c\nindex 2568164a108..b7e9af1388f 100644\n--- a/chardev/char-stdio.c\n+++ b/chardev/char-stdio.c\n@@ -142,9 +142,9 @@ static void char_stdio_class_init(ObjectClass *oc, const void *data)\n {\n ChardevClass *cc = CHARDEV_CLASS(oc);\n \n- cc->parse = qemu_chr_parse_stdio;\n+ cc->chr_parse = qemu_chr_parse_stdio;\n #ifndef _WIN32\n- cc->open = qemu_chr_open_stdio;\n+ cc->chr_open = qemu_chr_open_stdio;\n cc->chr_set_echo = qemu_chr_set_echo_stdio;\n #endif\n }\ndiff --git a/chardev/char-udp.c b/chardev/char-udp.c\nindex 1025f577a0d..71b8d8b37df 100644\n--- a/chardev/char-udp.c\n+++ b/chardev/char-udp.c\n@@ -221,8 +221,8 @@ static void char_udp_class_init(ObjectClass *oc, const void *data)\n {\n ChardevClass *cc = CHARDEV_CLASS(oc);\n \n- cc->parse = qemu_chr_parse_udp;\n- cc->open = qmp_chardev_open_udp;\n+ cc->chr_parse = qemu_chr_parse_udp;\n+ cc->chr_open = qmp_chardev_open_udp;\n cc->chr_write = udp_chr_write;\n cc->chr_update_read_handler = udp_chr_update_read_handler;\n }\ndiff --git a/chardev/char-win-stdio.c b/chardev/char-win-stdio.c\nindex fb802a00b13..26e67aef1ca 100644\n--- a/chardev/char-win-stdio.c\n+++ b/chardev/char-win-stdio.c\n@@ -260,7 +260,7 @@ static void char_win_stdio_class_init(ObjectClass *oc, const void *data)\n {\n ChardevClass *cc = CHARDEV_CLASS(oc);\n \n- cc->open = qemu_chr_open_stdio;\n+ cc->chr_open = qemu_chr_open_stdio;\n cc->chr_write = win_stdio_write;\n cc->chr_set_echo = qemu_chr_set_echo_win_stdio;\n }\ndiff --git a/chardev/char.c b/chardev/char.c\nindex 3e432195a5a..df37d1df161 100644\n--- a/chardev/char.c\n+++ b/chardev/char.c\n@@ -267,8 +267,8 @@ static void qemu_char_open(Chardev *chr, ChardevBackend *backend,\n }\n }\n \n- if (cc->open) {\n- cc->open(chr, backend, be_opened, errp);\n+ if (cc->chr_open) {\n+ cc->chr_open(chr, backend, be_opened, errp);\n }\n }\n \n@@ -604,8 +604,8 @@ ChardevBackend *qemu_chr_parse_opts(QemuOpts *opts, Error **errp)\n backend = g_new0(ChardevBackend, 1);\n backend->type = CHARDEV_BACKEND_KIND_NULL;\n \n- if (cc->parse) {\n- cc->parse(opts, backend, &local_err);\n+ if (cc->chr_parse) {\n+ cc->chr_parse(opts, backend, &local_err);\n if (local_err) {\n error_propagate(errp, local_err);\n qapi_free_ChardevBackend(backend);\ndiff --git a/chardev/msmouse.c b/chardev/msmouse.c\nindex 1a55755d397..84050164893 100644\n--- a/chardev/msmouse.c\n+++ b/chardev/msmouse.c\n@@ -271,7 +271,7 @@ static void char_msmouse_class_init(ObjectClass *oc, const void *data)\n {\n ChardevClass *cc = CHARDEV_CLASS(oc);\n \n- cc->open = msmouse_chr_open;\n+ cc->chr_open = msmouse_chr_open;\n cc->chr_write = msmouse_chr_write;\n cc->chr_accept_input = msmouse_chr_accept_input;\n cc->chr_ioctl = msmouse_ioctl;\ndiff --git a/chardev/spice.c b/chardev/spice.c\nindex 39b79d60fb4..61caa6d0efe 100644\n--- a/chardev/spice.c\n+++ b/chardev/spice.c\n@@ -364,8 +364,8 @@ static void char_spicevmc_class_init(ObjectClass *oc, const void *data)\n {\n ChardevClass *cc = CHARDEV_CLASS(oc);\n \n- cc->parse = qemu_chr_parse_spice_vmc;\n- cc->open = qemu_chr_open_spice_vmc;\n+ cc->chr_parse = qemu_chr_parse_spice_vmc;\n+ cc->chr_open = qemu_chr_open_spice_vmc;\n cc->chr_set_fe_open = spice_vmc_set_fe_open;\n }\n \n@@ -380,8 +380,8 @@ static void char_spiceport_class_init(ObjectClass *oc, const void *data)\n {\n ChardevClass *cc = CHARDEV_CLASS(oc);\n \n- cc->parse = qemu_chr_parse_spice_port;\n- cc->open = qemu_chr_open_spice_port;\n+ cc->chr_parse = qemu_chr_parse_spice_port;\n+ cc->chr_open = qemu_chr_open_spice_port;\n cc->chr_set_fe_open = spice_port_set_fe_open;\n }\n \ndiff --git a/chardev/wctablet.c b/chardev/wctablet.c\nindex 0dc6ef08f59..8285a56e7bc 100644\n--- a/chardev/wctablet.c\n+++ b/chardev/wctablet.c\n@@ -346,7 +346,7 @@ static void wctablet_chr_class_init(ObjectClass *oc, const void *data)\n {\n ChardevClass *cc = CHARDEV_CLASS(oc);\n \n- cc->open = wctablet_chr_open;\n+ cc->chr_open = wctablet_chr_open;\n cc->chr_write = wctablet_chr_write;\n cc->chr_ioctl = wctablet_chr_ioctl;\n cc->chr_accept_input = wctablet_chr_accept_input;\ndiff --git a/gdbstub/system.c b/gdbstub/system.c\nindex 8ec8b7ea336..29b9e16a908 100644\n--- a/gdbstub/system.c\n+++ b/gdbstub/system.c\n@@ -244,7 +244,7 @@ static void char_gdb_class_init(ObjectClass *oc, const void *data)\n ChardevClass *cc = CHARDEV_CLASS(oc);\n \n cc->internal = true;\n- cc->open = gdb_monitor_open;\n+ cc->chr_open = gdb_monitor_open;\n cc->chr_write = gdb_monitor_write;\n }\n \ndiff --git a/ui/console-vc.c b/ui/console-vc.c\nindex 830842064d6..931068d43ab 100644\n--- a/ui/console-vc.c\n+++ b/ui/console-vc.c\n@@ -1185,8 +1185,8 @@ static void char_vc_class_init(ObjectClass *oc, const void *data)\n {\n ChardevClass *cc = CHARDEV_CLASS(oc);\n \n- cc->parse = vc_chr_parse;\n- cc->open = vc_chr_open;\n+ cc->chr_parse = vc_chr_parse;\n+ cc->chr_open = vc_chr_open;\n cc->chr_write = vc_chr_write;\n cc->chr_accept_input = vc_chr_accept_input;\n cc->chr_set_echo = vc_chr_set_echo;\ndiff --git a/ui/dbus-chardev.c b/ui/dbus-chardev.c\nindex d05dddaf81b..f6c426e2209 100644\n--- a/ui/dbus-chardev.c\n+++ b/ui/dbus-chardev.c\n@@ -205,12 +205,12 @@ dbus_chr_open(Chardev *chr, ChardevBackend *backend,\n opts = qemu_opts_create(qemu_find_opts(\"chardev\"), NULL, 0, &error_abort);\n qemu_opt_set(opts, \"server\", \"on\", &error_abort);\n qemu_opt_set(opts, \"wait\", \"off\", &error_abort);\n- CHARDEV_CLASS(object_class_by_name(TYPE_CHARDEV_SOCKET))->parse(\n+ CHARDEV_CLASS(object_class_by_name(TYPE_CHARDEV_SOCKET))->chr_parse(\n opts, be, errp);\n if (*errp) {\n return;\n }\n- CHARDEV_CLASS(object_class_by_name(TYPE_CHARDEV_SOCKET))->open(\n+ CHARDEV_CLASS(object_class_by_name(TYPE_CHARDEV_SOCKET))->chr_open(\n chr, be, be_opened, errp);\n }\n \n@@ -274,8 +274,8 @@ char_dbus_class_init(ObjectClass *oc, const void *data)\n DBusChardevClass *klass = DBUS_CHARDEV_CLASS(oc);\n ChardevClass *cc = CHARDEV_CLASS(oc);\n \n- cc->parse = dbus_chr_parse;\n- cc->open = dbus_chr_open;\n+ cc->chr_parse = dbus_chr_parse;\n+ cc->chr_open = dbus_chr_open;\n cc->chr_set_fe_open = dbus_chr_set_fe_open;\n cc->chr_set_echo = dbus_chr_set_echo;\n klass->parent_chr_be_event = cc->chr_be_event;\ndiff --git a/ui/dbus.c b/ui/dbus.c\nindex d2dff332585..31f6eb1189f 100644\n--- a/ui/dbus.c\n+++ b/ui/dbus.c\n@@ -451,8 +451,8 @@ dbus_vc_class_init(ObjectClass *oc, const void *data)\n DBusVCClass *klass = DBUS_VC_CLASS(oc);\n ChardevClass *cc = CHARDEV_CLASS(oc);\n \n- klass->parent_parse = cc->parse;\n- cc->parse = dbus_vc_parse;\n+ klass->parent_parse = cc->chr_parse;\n+ cc->chr_parse = dbus_vc_parse;\n }\n \n static const TypeInfo dbus_vc_type_info = {\ndiff --git a/ui/gtk.c b/ui/gtk.c\nindex e83a3666258..6217e9552e3 100644\n--- a/ui/gtk.c\n+++ b/ui/gtk.c\n@@ -1985,7 +1985,7 @@ static void char_gd_vc_class_init(ObjectClass *oc, const void *data)\n {\n ChardevClass *cc = CHARDEV_CLASS(oc);\n \n- cc->open = gd_vc_open;\n+ cc->chr_open = gd_vc_open;\n cc->chr_write = gd_vc_chr_write;\n cc->chr_accept_input = gd_vc_chr_accept_input;\n cc->chr_set_echo = gd_vc_chr_set_echo;\ndiff --git a/ui/spice-app.c b/ui/spice-app.c\nindex 24f78f305c4..ea0b62a22b7 100644\n--- a/ui/spice-app.c\n+++ b/ui/spice-app.c\n@@ -106,10 +106,10 @@ static void char_vc_class_init(ObjectClass *oc, const void *data)\n VCChardevClass *vc = CHARDEV_VC_CLASS(oc);\n ChardevClass *cc = CHARDEV_CLASS(oc);\n \n- vc->parent_open = cc->open;\n+ vc->parent_open = cc->chr_open;\n \n- cc->parse = vc_chr_parse;\n- cc->open = vc_chr_open;\n+ cc->chr_parse = vc_chr_parse;\n+ cc->chr_open = vc_chr_open;\n cc->chr_set_echo = vc_chr_set_echo;\n }\n \ndiff --git a/ui/vdagent.c b/ui/vdagent.c\nindex 142a3691ac9..090771ab171 100644\n--- a/ui/vdagent.c\n+++ b/ui/vdagent.c\n@@ -924,8 +924,8 @@ static void vdagent_chr_class_init(ObjectClass *oc, const void *data)\n {\n ChardevClass *cc = CHARDEV_CLASS(oc);\n \n- cc->parse = vdagent_chr_parse;\n- cc->open = vdagent_chr_open;\n+ cc->chr_parse = vdagent_chr_parse;\n+ cc->chr_open = vdagent_chr_open;\n cc->chr_write = vdagent_chr_write;\n cc->chr_set_fe_open = vdagent_chr_set_fe_open;\n cc->chr_accept_input = vdagent_chr_accept_input;\ndiff --git a/scripts/codeconverter/codeconverter/test_regexps.py b/scripts/codeconverter/codeconverter/test_regexps.py\nindex b00e9ef15b2..d3a5cc3ad38 100644\n--- a/scripts/codeconverter/codeconverter/test_regexps.py\n+++ b/scripts/codeconverter/codeconverter/test_regexps.py\n@@ -57,7 +57,7 @@ def fullmatch(regexp, s):\n \n print(RE_TYPEINFO_START)\n assert re.search(RE_TYPEINFO_START, r'''\n- cc->open = qmp_chardev_open_file;\n+ cc->chr_open = qmp_chardev_open_file;\n }\n \n static const TypeInfo char_file_type_info = {\n", "prefixes": [ "PULL", "v2", "04/15" ] }