Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196260/?format=api
{ "id": 2196260, "url": "http://patchwork.ozlabs.org/api/patches/2196260/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260213094938.4074478-3-marcandre.lureau@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260213094938.4074478-3-marcandre.lureau@redhat.com>", "list_archive_url": null, "date": "2026-02-13T09:49:21", "name": "[PULL,v2,02/15] ui/spice: Require spice-server >= 0.15.0", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "593c92a4f047cbd8c60d4c5a817d1aad74cb704d", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260213094938.4074478-3-marcandre.lureau@redhat.com/mbox/", "series": [ { "id": 492070, "url": "http://patchwork.ozlabs.org/api/series/492070/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492070", "date": "2026-02-13T09:49:19", "name": "[PULL,v2,01/15] char-udp: Fix initial backend open status", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/492070/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196260/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196260/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=D0rGE2Gg;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fC6qH6fJLz1xpl\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 13 Feb 2026 20:50:35 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vqpoN-0006t8-K4; Fri, 13 Feb 2026 04:50:07 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vqpoJ-0006j4-PM\n for qemu-devel@nongnu.org; Fri, 13 Feb 2026 04:50:04 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1vqpoH-00073G-0T\n for qemu-devel@nongnu.org; Fri, 13 Feb 2026 04:50:02 -0500", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-658-aMc26E4sPAy9t4jQ84TMZQ-1; Fri,\n 13 Feb 2026 04:49:56 -0500", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 1714C185FCC3; Fri, 13 Feb 2026 09:49:49 +0000 (UTC)", "from localhost (unknown [10.44.22.41])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id E4B161800465; Fri, 13 Feb 2026 09:49:47 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1770976200;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=kwUJ3BjGqSrzivArY1rYym7qexid2kYuXoU98jIvc3E=;\n b=D0rGE2GgPe+ggVtJk8C4MVq56fdk+YlaTEoMLOjUHJ8V1f7U6CWHlmDlAIalnya1eBDK5A\n z3G6DU4oeObfISItegW6O33LS3zc4STM00ms7jLbrStK533N+WGcVwWIQe9v6/iPuHWtUY\n blZTWizlMJTEcasJC6O4wxubON5Iiro=", "X-MC-Unique": "aMc26E4sPAy9t4jQ84TMZQ-1", "X-Mimecast-MFC-AGG-ID": "aMc26E4sPAy9t4jQ84TMZQ_1770976194", "From": "marcandre.lureau@redhat.com", "To": "qemu-devel@nongnu.org", "Cc": "=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n \"Edgar E. Iglesias\" <edgar.iglesias@gmail.com>, =?utf-8?q?Daniel_P=2E_Berra?=\n\t=?utf-8?q?ng=C3=A9?= <berrange@redhat.com>, Eric Blake <eblake@redhat.com>,\n Markus Armbruster <armbru@redhat.com>, Paul Durrant <paul@xen.org>,\n Anthony PERARD <anthony@xenproject.org>, =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= <philmd@linaro.org>,\n Eduardo Habkost <eduardo@habkost.net>, Paolo Bonzini <pbonzini@redhat.com>,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org,\n Samuel Thibault <samuel.thibault@ens-lyon.org>,\n Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>", "Subject": "[PULL v2 02/15] ui/spice: Require spice-server >= 0.15.0", "Date": "Fri, 13 Feb 2026 10:49:21 +0100", "Message-ID": "<20260213094938.4074478-3-marcandre.lureau@redhat.com>", "In-Reply-To": "<20260213094938.4074478-1-marcandre.lureau@redhat.com>", "References": "<20260213094938.4074478-1-marcandre.lureau@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>\n\nFor major distributions we have now:\n\n Debian 13: 0.15.2\n Ubuntu 22.04: 0.15.0\n RHEL-9/CentOS Stream 9: SPICE is removed\n Fedora 42: 0.15.1\n OpenSUSE Leap 15.4: 0.15.0\n\nTime to update the dependancy in QEMU and drop almost all\nSPICE_SERVER_VERSION checks.\n\nSuggested-by: Marc-André Lureau <marcandre.lureau@redhat.com>\nSigned-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>\nReviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>\nMessage-Id: <20260115144606.233252-2-vsementsov@yandex-team.ru>\n---\n meson.build | 2 +-\n include/ui/qemu-spice.h | 4 ----\n chardev/spice.c | 6 ------\n hw/display/qxl.c | 11 ++---------\n ui/spice-display.c | 8 ++------\n 5 files changed, 5 insertions(+), 26 deletions(-)", "diff": "diff --git a/meson.build b/meson.build\nindex e8fd77aac00..4af32c3e1f2 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -1326,7 +1326,7 @@ if get_option('spice') \\\n .require(pixman.found(),\n error_message: 'cannot enable SPICE if pixman is not available') \\\n .allowed()\n- spice = dependency('spice-server', version: '>=0.14.0',\n+ spice = dependency('spice-server', version: '>=0.15.0',\n required: get_option('spice'),\n method: 'pkg-config')\n endif\ndiff --git a/include/ui/qemu-spice.h b/include/ui/qemu-spice.h\nindex b7d493742c4..8e5e6b2a744 100644\n--- a/include/ui/qemu-spice.h\n+++ b/include/ui/qemu-spice.h\n@@ -34,11 +34,7 @@ int qemu_spice_add_display_interface(QXLInstance *qxlin, QemuConsole *con);\n int qemu_spice_migrate_info(const char *hostname, int port, int tls_port,\n const char *subject);\n \n-#if SPICE_SERVER_VERSION >= 0x000f00 /* release 0.15.0 */\n #define SPICE_HAS_ATTACHED_WORKER 1\n-#else\n-#define SPICE_HAS_ATTACHED_WORKER 0\n-#endif\n \n #else /* CONFIG_SPICE */\n \ndiff --git a/chardev/spice.c b/chardev/spice.c\nindex db53b49da26..39b79d60fb4 100644\n--- a/chardev/spice.c\n+++ b/chardev/spice.c\n@@ -278,12 +278,6 @@ static void qemu_chr_open_spice_vmc(Chardev *chr,\n }\n \n *be_opened = false;\n-#if SPICE_SERVER_VERSION < 0x000e02\n- /* Spice < 0.14.2 doesn't explicitly open smartcard chardev */\n- if (strcmp(type, \"smartcard\") == 0) {\n- *be_opened = true;\n- }\n-#endif\n chr_open(chr, type);\n }\n \ndiff --git a/hw/display/qxl.c b/hw/display/qxl.c\nindex f29b736722c..fbba02113f7 100644\n--- a/hw/display/qxl.c\n+++ b/hw/display/qxl.c\n@@ -261,11 +261,6 @@ static void qxl_spice_monitors_config_async(PCIQXLDevice *qxl, int replay)\n QXL_COOKIE_TYPE_POST_LOAD_MONITORS_CONFIG,\n 0));\n } else {\n-#if SPICE_SERVER_VERSION < 0x000e02 /* release 0.14.2 */\n- if (qxl->max_outputs) {\n- spice_qxl_set_max_monitors(&qxl->ssd.qxl, qxl->max_outputs);\n- }\n-#endif\n qxl->guest_monitors_config = qxl->ram->monitors_config;\n spice_qxl_monitors_config_async(&qxl->ssd.qxl,\n qxl->ram->monitors_config,\n@@ -2109,6 +2104,8 @@ static void qxl_realize_common(PCIQXLDevice *qxl, Error **errp)\n uint8_t* config = qxl->pci.config;\n uint32_t pci_device_rev;\n uint32_t io_size;\n+ Error *err = NULL;\n+ char device_address[256] = \"\";\n \n qemu_spice_display_init_common(&qxl->ssd);\n qxl->mode = QXL_MODE_UNDEFINED;\n@@ -2208,9 +2205,6 @@ static void qxl_realize_common(PCIQXLDevice *qxl, Error **errp)\n return;\n }\n \n-#if SPICE_SERVER_VERSION >= 0x000e02 /* release 0.14.2 */\n- Error *err = NULL;\n- char device_address[256] = \"\";\n if (qemu_console_fill_device_address(qxl->vga.con,\n device_address, sizeof(device_address),\n &err)) {\n@@ -2221,7 +2215,6 @@ static void qxl_realize_common(PCIQXLDevice *qxl, Error **errp)\n } else {\n error_report_err(err);\n }\n-#endif\n \n qemu_add_vm_change_state_handler(qxl_vm_change_state_handler, qxl);\n \ndiff --git a/ui/spice-display.c b/ui/spice-display.c\nindex db71e866f89..f2304bb0ce2 100644\n--- a/ui/spice-display.c\n+++ b/ui/spice-display.c\n@@ -689,13 +689,11 @@ static int interface_client_monitors_config(QXLInstance *sin,\n if (mc->num_of_monitors > head) {\n info.width = mc->monitors[head].width;\n info.height = mc->monitors[head].height;\n-#if SPICE_SERVER_VERSION >= 0x000e04 /* release 0.14.4 */\n if (mc->flags & VD_AGENT_CONFIG_MONITORS_FLAG_PHYSICAL_SIZE) {\n VDAgentMonitorMM *mm = (void *)&mc->monitors[mc->num_of_monitors];\n info.width_mm = mm[head].width;\n info.height_mm = mm[head].height;\n }\n-#endif\n }\n \n trace_qemu_spice_ui_info(ssd->qxl.id, info.width, info.height);\n@@ -1393,6 +1391,8 @@ static const DisplayGLCtxOps gl_ctx_ops = {\n static void qemu_spice_display_init_one(QemuConsole *con)\n {\n SimpleSpiceDisplay *ssd = g_new0(SimpleSpiceDisplay, 1);\n+ Error *err = NULL;\n+ char device_address[256] = \"\";\n \n qemu_spice_display_init_common(ssd);\n \n@@ -1414,9 +1414,6 @@ static void qemu_spice_display_init_one(QemuConsole *con)\n ssd->qxl.base.sif = &dpy_interface.base;\n qemu_spice_add_display_interface(&ssd->qxl, con);\n \n-#if SPICE_SERVER_VERSION >= 0x000e02 /* release 0.14.2 */\n- Error *err = NULL;\n- char device_address[256] = \"\";\n if (qemu_console_fill_device_address(con, device_address, 256, &err)) {\n spice_qxl_set_device_info(&ssd->qxl,\n device_address,\n@@ -1425,7 +1422,6 @@ static void qemu_spice_display_init_one(QemuConsole *con)\n } else {\n error_report_err(err);\n }\n-#endif\n \n qemu_spice_create_host_memslot(ssd);\n \n", "prefixes": [ "PULL", "v2", "02/15" ] }