Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196256/?format=api
{ "id": 2196256, "url": "http://patchwork.ozlabs.org/api/patches/2196256/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/yddwm0hynve.fsf@CeBiTec.Uni-Bielefeld.DE/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<yddwm0hynve.fsf@CeBiTec.Uni-Bielefeld.DE>", "list_archive_url": null, "date": "2026-02-13T09:49:25", "name": "Remove HAVE_AS_SPARC_GOTDATA_OP", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "1265936a569d535003e8b2ecce4550385ede6498", "submitter": { "id": 4362, "url": "http://patchwork.ozlabs.org/api/people/4362/?format=api", "name": "Rainer Orth", "email": "ro@CeBiTec.Uni-Bielefeld.DE" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/yddwm0hynve.fsf@CeBiTec.Uni-Bielefeld.DE/mbox/", "series": [ { "id": 492069, "url": "http://patchwork.ozlabs.org/api/series/492069/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=492069", "date": "2026-02-13T09:49:25", "name": "Remove HAVE_AS_SPARC_GOTDATA_OP", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492069/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196256/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196256/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=cebitec.uni-bielefeld.de header.i=@cebitec.uni-bielefeld.de\n header.a=rsa-sha256 header.s=20200306 header.b=NxKkYpga;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=cebitec.uni-bielefeld.de header.i=@cebitec.uni-bielefeld.de\n header.a=rsa-sha256 header.s=20200306 header.b=NxKkYpga", "sourceware.org; dmarc=none (p=none dis=none)\n header.from=CeBiTec.Uni-Bielefeld.DE", "sourceware.org;\n spf=pass smtp.mailfrom=cebitec.uni-bielefeld.de", "server2.sourceware.org;\n arc=none smtp.remote-ip=129.70.160.84" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fC6pj5SmHz1xvQ\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 13 Feb 2026 20:50:04 +1100 (AEDT)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 5FF964B9DB66\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 13 Feb 2026 09:50:02 +0000 (GMT)", "from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE\n [129.70.160.84])\n by sourceware.org (Postfix) with ESMTPS id E7B884B9DB48\n for <gcc-patches@gcc.gnu.org>; Fri, 13 Feb 2026 09:49:27 +0000 (GMT)", "from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1])\n by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id CE21EDCD0E;\n Fri, 13 Feb 2026 10:49:26 +0100 (CET)", "from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1])\n by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new,\n port 10026)\n with ESMTP id 5JK2rc0qr7vI; Fri, 13 Feb 2026 10:49:25 +0100 (CET)", "from manam.CeBiTec.Uni-Bielefeld.DE (p508543ca.dip0.t-ipconnect.de\n [80.133.67.202]) (Authenticated sender: ro)\n by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 8D456DCD0D;\n Fri, 13 Feb 2026 10:49:25 +0100 (CET)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org 5FF964B9DB66", "OpenDKIM Filter v2.11.0 sourceware.org E7B884B9DB48" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org E7B884B9DB48", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org E7B884B9DB48", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770976168; cv=none;\n b=BuZgUSVm/rkCX7DsIe5l+7FIHtUubFeKiZDQYtgQkVKeP38nTwm+fUtmVIqIPkaiH/wMTdvIzrFIxmvzFMJ/QL3Ec9X5JnN0k+LY57p+SWp7ElmMpYEZzQZhF+hfvuJqaZgeInMksmtdGYTvZq0gdgww6lrOfY+tM7mcm2pr7pg=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1770976168; c=relaxed/simple;\n bh=JNuE5jLaB1ciQpP7J2f2Ay2dTvP9YQ1KBiHfR14PTPc=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=VsKZ6jWGcD/e8E1VyUiTVTZUIUhsvx6yrq18/GN0WXhoCbMXpo9MkDgZVb/3Er/BvFFYZz6EaDgoUuL6ePQW6BBTmvmdYxCThbuT6hQn+Tyy7j0NF99z2z401uLz2u5xCYVgKX0ZWQb6FhbsoF5CJilDIPa/LolkyOggMSTuzsc=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=\n cebitec.uni-bielefeld.de; h=content-type:content-type\n :mime-version:user-agent:message-id:date:date:subject:subject\n :from:from:received:received; s=20200306; t=1770976165; bh=JNuE5\n jLaB1ciQpP7J2f2Ay2dTvP9YQ1KBiHfR14PTPc=; b=NxKkYpgaqmOlZON1Txf3T\n bvGpoV8Wuz9BRfFzR7P9+Y6D1uUZ/llHMgvsdAzXSV1KeR1YTYSaxUl6Nwtar5KW\n 6PlSx31Pu795yHAAHAp/jbNz64wc7+72YhtYMNmdwEHfFZo8kUS1z/VNpI0DQbix\n R4JxUcWzSSi8nTtWWjWyq2aKUMKkPP4ozIwYpOC2jqJ9eWVkUqyvn/KYAp8MSQWN\n yZi0ZhiuxUM+SETrTXd4eTcIJb8O4NHXfB/OCtBoOTCFLzf6Jqru/4wxpg14iZr7\n FJr7uwTOcru1cRVCUOHrs2qiiz0M4s/sApbEER9gPPjsghBYsgaDBycLW1g4agOq\n w==", "X-Virus-Scanned": "amavisd-new at cebitec.uni-bielefeld.de", "From": "Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>", "To": "gcc-patches@gcc.gnu.org", "Cc": "Eric Botcazou <ebotcazou@adacore.com>", "Subject": "[PATCH] Remove HAVE_AS_SPARC_GOTDATA_OP", "Date": "Fri, 13 Feb 2026 10:49:25 +0100", "Message-ID": "<yddwm0hynve.fsf@CeBiTec.Uni-Bielefeld.DE>", "User-Agent": "Gnus/5.13 (Gnus v5.13)", "MIME-Version": "1.0", "Content-Type": "multipart/mixed; boundary=\"=-=-=\"", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "Since the introduction of gcc_cv_as_flags on SPARC,\nHAVE_AS_SPARC_GOTDATA_OP became undefined on sparcv9-sun-solaris2.11\nwith the native assembler. This happens because /bin/as is now invoked\nwith -m64, but the test fails to assemble:\n\n/bin/as: \"gotdata_op.s\", line 8: error: detect global register use not covered .register pseudo-op\n\nWhile the test can be adjusted by the addition of\n\n\t.register %g2, #scratch\n\nwhich makes it compile with both as -m32/-m64 and gas --32/--64, it\nturns out the whole workaround has become unnecessary:\n\nWhen trying all combinations of as/ld with -m32/-m64, with both the\noriginal Solaris 11.4 as/ld and the current one, as well as gas/gld\n2.20.1, 2.30, and 2.46, the only cases where the test fails are when\nusing gld 2.20.1. Solaris/SPARC requires binutils 2.30 now, and 2.20.1\ncan be considered ancient history on Linux/sparc64, too. Therefore the\ntest and the code guarded by it can just go.\n\nBootstrapped without regressions on sparc{,v9}-sun-solaris2.11 and\nsparc64-unknown-linux-gnu.\n\nOk for trunk?\n\n\tRainer", "diff": "# HG changeset patch\n# Parent 4cc502b602f439a3014d3ace815a7a29a50fa05d\nRemove HAVE_AS_SPARC_GOTDATA_OP\n\ndiff --git a/gcc/config.in b/gcc/config.in\n--- a/gcc/config.in\n+++ b/gcc/config.in\n@@ -804,12 +804,6 @@\n #endif\n \n \n-/* Define if your assembler and linker support GOTDATA_OP relocs. */\n-#ifndef USED_FOR_TARGET\n-#undef HAVE_AS_SPARC_GOTDATA_OP\n-#endif\n-\n-\n /* Define if your assembler supports call36 relocation. */\n #ifndef USED_FOR_TARGET\n #undef HAVE_AS_SUPPORT_CALL36\ndiff --git a/gcc/config/sparc/sparc.md b/gcc/config/sparc/sparc.md\n--- a/gcc/config/sparc/sparc.md\n+++ b/gcc/config/sparc/sparc.md\n@@ -1713,11 +1713,7 @@\n \t\t\t UNSPEC_MOVE_PIC)))]\n \"flag_pic\"\n {\n-#ifdef HAVE_AS_SPARC_GOTDATA_OP\n return \"xor\\t%1, %%gdop_lox10(%a2), %0\";\n-#else\n- return \"or\\t%1, %%lo(%a2), %0\";\n-#endif\n })\n \n (define_insn \"movsi_high_pic\"\n@@ -1725,11 +1721,7 @@\n (high:SI (unspec:SI [(match_operand 1 \"\" \"\")] UNSPEC_MOVE_PIC)))]\n \"flag_pic && check_pic (1)\"\n {\n-#ifdef HAVE_AS_SPARC_GOTDATA_OP\n return \"sethi\\t%%gdop_hix22(%a1), %0\";\n-#else\n- return \"sethi\\t%%hi(%a1), %0\";\n-#endif\n })\n \n (define_insn \"movsi_pic_gotdata_op\"\n@@ -1740,11 +1732,7 @@\n \t\t UNSPEC_MOVE_GOTDATA))]\n \"flag_pic && check_pic (1)\"\n {\n-#ifdef HAVE_AS_SPARC_GOTDATA_OP\n return \"ld\\t[%1 + %2], %0, %%gdop(%a3)\";\n-#else\n- return \"ld\\t[%1 + %2], %0\";\n-#endif\n }\n [(set_attr \"type\" \"load\")\n (set_attr \"subtype\" \"regular\")])\n@@ -1934,11 +1922,7 @@\n \t\t\t UNSPEC_MOVE_PIC)))]\n \"TARGET_ARCH64 && flag_pic\"\n {\n-#ifdef HAVE_AS_SPARC_GOTDATA_OP\n return \"xor\\t%1, %%gdop_lox10(%a2), %0\";\n-#else\n- return \"or\\t%1, %%lo(%a2), %0\";\n-#endif\n })\n \n (define_insn \"movdi_high_pic\"\n@@ -1946,11 +1930,7 @@\n (high:DI (unspec:DI [(match_operand 1 \"\" \"\")] UNSPEC_MOVE_PIC)))]\n \"TARGET_ARCH64 && flag_pic && check_pic (1)\"\n {\n-#ifdef HAVE_AS_SPARC_GOTDATA_OP\n return \"sethi\\t%%gdop_hix22(%a1), %0\";\n-#else\n- return \"sethi\\t%%hi(%a1), %0\";\n-#endif\n })\n \n (define_insn \"movdi_pic_gotdata_op\"\n@@ -1961,11 +1941,7 @@\n \t\t UNSPEC_MOVE_GOTDATA))]\n \"TARGET_ARCH64 && flag_pic && check_pic (1)\"\n {\n-#ifdef HAVE_AS_SPARC_GOTDATA_OP\n return \"ldx\\t[%1 + %2], %0, %%gdop(%a3)\";\n-#else\n- return \"ldx\\t[%1 + %2], %0\";\n-#endif\n }\n [(set_attr \"type\" \"load\")\n (set_attr \"subtype\" \"regular\")])\ndiff --git a/gcc/configure b/gcc/configure\n--- a/gcc/configure\n+++ b/gcc/configure\n@@ -29229,56 +29229,6 @@ if test $gcc_cv_as_sparc_relax = yes; th\n fi\n \n \n- { $as_echo \"$as_me:${as_lineno-$LINENO}: checking assembler for GOTDATA_OP relocs\" >&5\n-$as_echo_n \"checking assembler for GOTDATA_OP relocs... \" >&6; }\n-if ${gcc_cv_as_sparc_gotdata_op+:} false; then :\n- $as_echo_n \"(cached) \" >&6\n-else\n- gcc_cv_as_sparc_gotdata_op=no\n- if test x\"$gcc_cv_as\" != x; then\n- $as_echo '.text\n-.align 4\n-foo:\n-\tnop\n-bar:\n-\tsethi %gdop_hix22(foo), %g1\n-\txor %g1, %gdop_lox10(foo), %g1\n-\tld [%l7 + %g1], %g2, %gdop(foo)' > conftest.s\n- if { ac_try='$gcc_cv_as $gcc_cv_as_flags -K PIC -o conftest.o conftest.s >&5'\n- { { eval echo \"\\\"\\$as_me\\\":${as_lineno-$LINENO}: \\\"$ac_try\\\"\"; } >&5\n- (eval $ac_try) 2>&5\n- ac_status=$?\n- $as_echo \"$as_me:${as_lineno-$LINENO}: \\$? = $ac_status\" >&5\n- test $ac_status = 0; }; }\n- then\n-\tif test x$gcc_cv_ld != x \\\n- && $gcc_cv_ld -o conftest conftest.o -G > /dev/null 2>&1; then\n- if test x$gcc_cv_objdump != x; then\n- if $gcc_cv_objdump -s -j .text conftest 2> /dev/null \\\n- | grep ' 03000004 82186004 c405c001'> /dev/null 2>&1; then\n-\t gcc_cv_as_sparc_gotdata_op=no\n- else\n-\t gcc_cv_as_sparc_gotdata_op=yes\n- fi\n- fi\n- fi\n- rm -f conftest\n- else\n- echo \"configure: failed program was\" >&5\n- cat conftest.s >&5\n- fi\n- rm -f conftest.o conftest.s\n- fi\n-fi\n-{ $as_echo \"$as_me:${as_lineno-$LINENO}: result: $gcc_cv_as_sparc_gotdata_op\" >&5\n-$as_echo \"$gcc_cv_as_sparc_gotdata_op\" >&6; }\n-if test $gcc_cv_as_sparc_gotdata_op = yes; then\n-\n-$as_echo \"#define HAVE_AS_SPARC_GOTDATA_OP 1\" >>confdefs.h\n-\n-fi\n-\n-\n { $as_echo \"$as_me:${as_lineno-$LINENO}: checking assembler for offsetable %lo()\" >&5\n $as_echo_n \"checking assembler for offsetable %lo()... \" >&6; }\n if ${gcc_cv_as_sparc_offsetable_lo10+:} false; then :\ndiff --git a/gcc/configure.ac b/gcc/configure.ac\n--- a/gcc/configure.ac\n+++ b/gcc/configure.ac\n@@ -4730,32 +4730,6 @@ EOF\n [AC_DEFINE(HAVE_AS_RELAX_OPTION, 1,\n \t\t[Define if your assembler supports -relax option.])])\n \n- gcc_GAS_CHECK_FEATURE([GOTDATA_OP relocs],\n- gcc_cv_as_sparc_gotdata_op,\n- [-K PIC],\n-[.text\n-.align 4\n-foo:\n-\tnop\n-bar:\n-\tsethi %gdop_hix22(foo), %g1\n-\txor %g1, %gdop_lox10(foo), %g1\n-\tld [[%l7 + %g1]], %g2, %gdop(foo)],\n- [if test x$gcc_cv_ld != x \\\n- && $gcc_cv_ld -o conftest conftest.o -G > /dev/null 2>&1; then\n- if test x$gcc_cv_objdump != x; then\n- if $gcc_cv_objdump -s -j .text conftest 2> /dev/null \\\n- | grep ' 03000004 82186004 c405c001'> /dev/null 2>&1; then\n-\t gcc_cv_as_sparc_gotdata_op=no\n- else\n-\t gcc_cv_as_sparc_gotdata_op=yes\n- fi\n- fi\n- fi\n- rm -f conftest],\n- [AC_DEFINE(HAVE_AS_SPARC_GOTDATA_OP, 1,\n-\t\t[Define if your assembler and linker support GOTDATA_OP relocs.])])\n-\n gcc_GAS_CHECK_FEATURE([offsetable %lo()],\n gcc_cv_as_sparc_offsetable_lo10,\n [-xarch=v9],\n", "prefixes": [] }