Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196185/?format=api
{ "id": 2196185, "url": "http://patchwork.ozlabs.org/api/patches/2196185/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260213030940.1809797-1-aleksandr.loktionov@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260213030940.1809797-1-aleksandr.loktionov@intel.com>", "list_archive_url": null, "date": "2026-02-13T03:09:40", "name": "[iwl-next,v3] ixgbe: fix unaligned u32 access in ixgbe_update_flash_X550()", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "48f421e6f6a04a1a8692f8582303469f6f2a0d52", "submitter": { "id": 75597, "url": "http://patchwork.ozlabs.org/api/people/75597/?format=api", "name": "Loktionov, Aleksandr", "email": "aleksandr.loktionov@intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260213030940.1809797-1-aleksandr.loktionov@intel.com/mbox/", "series": [ { "id": 492053, "url": "http://patchwork.ozlabs.org/api/series/492053/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=492053", "date": "2026-02-13T03:09:40", "name": "[iwl-next,v3] ixgbe: fix unaligned u32 access in ixgbe_update_flash_X550()", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/492053/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196185/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196185/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=M9BhFe8v;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fBxww06fCz1xpl\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 13 Feb 2026 14:09:49 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 0391241901;\n\tFri, 13 Feb 2026 03:09:47 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id MQHJKpHTBfIR; Fri, 13 Feb 2026 03:09:46 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id F3FB441904;\n\tFri, 13 Feb 2026 03:09:45 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists1.osuosl.org (Postfix) with ESMTP id D79DA1D6\n for <intel-wired-lan@lists.osuosl.org>; Fri, 13 Feb 2026 03:09:44 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id D517580EF5\n for <intel-wired-lan@lists.osuosl.org>; Fri, 13 Feb 2026 03:09:44 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id zoJZwcH0gIqs for <intel-wired-lan@lists.osuosl.org>;\n Fri, 13 Feb 2026 03:09:44 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.13])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 166CC80EE7\n for <intel-wired-lan@lists.osuosl.org>; Fri, 13 Feb 2026 03:09:43 +0000 (UTC)", "from fmviesa004.fm.intel.com ([10.60.135.144])\n by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 12 Feb 2026 19:09:43 -0800", "from amlin-019-225.igk.intel.com ([10.102.19.225])\n by fmviesa004.fm.intel.com with ESMTP; 12 Feb 2026 19:09:41 -0800" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp4.osuosl.org F3FB441904", "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 166CC80EE7" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1770952186;\n\tbh=YmwAwS9TPRqB7vJ29waSVrHA0A0Eo0mzwo3uF07m2AY=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=M9BhFe8vE7jDsHW0oagdtx6XUmH6Ol9CVAcS4btGsPJeew5qdVjpRN6I6yTpqcqeN\n\t 2pCyGtkaLZGy9gZqJma86SgIGhvM1M97sN8WAQRTwhcOasArZXAR4He/4GMrhLYenL\n\t Wolf4Mz4f8tqGrLWY94/iDWCF2s3C6H4MoY1P1DCizBmHkc5zK5jxkbwvszViATPi3\n\t yRwlew4S859VGSxvftdicDa5qz4BQgY1eQMXHm2QgEcCuaChr5V4qc/nOjTpa+Xfht\n\t tTHVT2rVPkgEy53L/C5EvguNUh/H6UceJrnY6eQqZcZfi0GvGzIfqZDVrDbmRKBoH/\n\t yRF3JH66rwHXg==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.13;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp1.osuosl.org 166CC80EE7", "X-CSE-ConnectionGUID": [ "NCfDpxI/SBORpNZbBGgGqw==", "/j0lBH1YSICoiznS8hw5kw==" ], "X-CSE-MsgGUID": [ "hHIrYsgUQdCH21/YQc//hg==", "b+eQ2ka0RQya3RN6mumxyQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11699\"; a=\"74738758\"", "E=Sophos;i=\"6.21,287,1763452800\"; d=\"scan'208\";a=\"74738758\"", "E=Sophos;i=\"6.21,287,1763452800\"; d=\"scan'208\";a=\"216969781\"" ], "X-ExtLoop1": "1", "From": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com", "Cc": "netdev@vger.kernel.org, Jedrzej Jagielski <jedrzej.jagielski@intel.com>,\n Paul Menzel <pmenzel@molgen.mpg.de>", "Date": "Fri, 13 Feb 2026 04:09:40 +0100", "Message-ID": "<20260213030940.1809797-1-aleksandr.loktionov@intel.com>", "X-Mailer": "git-send-email 2.52.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1770952184; x=1802488184;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=3Y7Q6Au/X2ZyR/wPpqJXyfm6utcskF47IufYsRLqZL0=;\n b=GYeJI21yyI7mVsU7YfBzH8Rda3Yk1kPyrizbSwsgmyEzuF6qhs7k7g1s\n yF1a23BnqcdaXDBAx4qmkkwejLv4nSwd1y4tAjw+unDopT6KpG4ltza7/\n +bSEf7WBgI79soy4vp4nDW1bTIWXMiy4awkJBujzbvPkQGIitU8v0CnqP\n sBPM8lbH7UyER1Wm0x0zdNzJiOp31ebnN/enD7VMWYO10gduYAeNgE0K+\n iqKqtR5yEXCBLImjAcu/MR3WSkJ/9YYT4Add2Go4hFbylFsqOLynRuU2h\n Q6cB1aNzNgVl3t3Wrw87WSXLmRSDO6ncazTrEk6P0CXyQ2vTY6EZjJ0M3\n Q==;", "X-Mailman-Original-Authentication-Results": [ "smtp1.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp1.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=GYeJI21y" ], "Subject": "[Intel-wired-lan] [PATCH iwl-next v3] ixgbe: fix unaligned u32\n access in ixgbe_update_flash_X550()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "ixgbe_host_interface_command() treats its buffer as a u32 array. The \nlocal buffer we pass in was a union of byte-sized fields, which gives \nit 1-byte alignment on the stack. On strict-align architectures this \ncan cause unaligned 32-bit accesses.\n\nAdd a u32 member to union ixgbe_hic_hdr2 so the object is 4-byte \naligned, and pass the u32 member when calling\nixgbe_host_interface_command().\n\nNo functional change on x86; prevents unaligned accesses on \narchitectures that enforce natural alignment.\n \nFixes: 49425dfc7451 (\"ixgbe: Add support for x550em_a 10G MAC type\")\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\nReviewed-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>\nReviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>\n---\nv2 -> v3 commit message line wraps\nv1 -> v2 change title and concentrate on alignement issue\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_type.h | 1 +\n drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 2 +-\n 2 files changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h b/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h\nindex 61f2ef6..eb5bf3b 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h\n@@ -2798,6 +2798,7 @@ struct ixgbe_hic_hdr2_rsp {\n };\n \n union ixgbe_hic_hdr2 {\n+\tu32 buf[1];\n \tstruct ixgbe_hic_hdr2_req req;\n \tstruct ixgbe_hic_hdr2_rsp rsp;\n };\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\nindex 76d2fa3..4a0ccbf 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n@@ -1228,7 +1228,7 @@ static int ixgbe_update_flash_X550(struct ixgbe_hw *hw)\n \tbuffer.req.buf_lenl = FW_SHADOW_RAM_DUMP_LEN;\n \tbuffer.req.checksum = FW_DEFAULT_CHECKSUM;\n \n-\tstatus = ixgbe_host_interface_command(hw, &buffer, sizeof(buffer),\n+\tstatus = ixgbe_host_interface_command(hw, buffer.buf, sizeof(buffer),\n \t\t\t\t\t IXGBE_HI_COMMAND_TIMEOUT, false);\n \treturn status;\n }\n", "prefixes": [ "iwl-next", "v3" ] }