Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196154/?format=api
{ "id": 2196154, "url": "http://patchwork.ozlabs.org/api/patches/2196154/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260212234602.338131-3-pierrick.bouvier@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260212234602.338131-3-pierrick.bouvier@linaro.org>", "list_archive_url": null, "date": "2026-02-12T23:46:01", "name": "[2/3] hw/virtio: rename virtio_is_big_endian to virtio_vdev_is_big_endian", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4f3d7a2859ae9a5c7fc956035d4fc03165bbacf0", "submitter": { "id": 85798, "url": "http://patchwork.ozlabs.org/api/people/85798/?format=api", "name": "Pierrick Bouvier", "email": "pierrick.bouvier@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260212234602.338131-3-pierrick.bouvier@linaro.org/mbox/", "series": [ { "id": 492041, "url": "http://patchwork.ozlabs.org/api/series/492041/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492041", "date": "2026-02-12T23:45:59", "name": "hw/virtio/virtio-access.h: remove target specific code", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492041/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196154/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196154/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=JMRz/3Li;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fBsR31jrrz1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 13 Feb 2026 10:47:11 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vqgO2-0004iX-Kb; Thu, 12 Feb 2026 18:46:18 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pierrick.bouvier@linaro.org>)\n id 1vqgNy-0004gO-DY\n for qemu-devel@nongnu.org; Thu, 12 Feb 2026 18:46:14 -0500", "from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <pierrick.bouvier@linaro.org>)\n id 1vqgNv-0008BG-En\n for qemu-devel@nongnu.org; Thu, 12 Feb 2026 18:46:13 -0500", "by mail-pf1-x434.google.com with SMTP id\n d2e1a72fcca58-82311f4070cso217541b3a.0\n for <qemu-devel@nongnu.org>; Thu, 12 Feb 2026 15:46:11 -0800 (PST)", "from pc.taild8403c.ts.net (216-71-219-44.dyn.novuscom.net.\n [216.71.219.44]) by smtp.gmail.com with ESMTPSA id\n 41be03b00d2f7-c6e1ac0e004sm5609936a12.6.2026.02.12.15.46.09\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 12 Feb 2026 15:46:09 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1770939970; x=1771544770; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=gEmb+NuIA92kpdVxEe8MYTCkuvizaCU9Eyv3aVlm5ok=;\n b=JMRz/3Liil+BgWILxGICt2E54KOZhcjo1lYPjGG3fKlnAFnSfntFrLgZugihDbkEbp\n 81wbom1rWIpwWlvaICXOusuNUZmP1uihiUG4xBWhVjd3xBcLbnwpO+BoraIPOh8soFn+\n f3UhLnobEuIxM5HOE/A/uTYofKs9j9H5WRuUVmZ3TY22xy2dkcbUeojST0AenzdFfYH2\n SUQ1Mc9pp1l/SfYkAo3gW7ieSNAb30IKNDLhctomWOseb+SGTiTTF9t13Nda9brDnJJ4\n xgAYDQlo6LfhkXGAPX0LKFPwmZsdWG5CvpVDkRdlNTZXzi8WPqpgxcGXrFCEQTbEzebC\n F92w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1770939970; x=1771544770;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=gEmb+NuIA92kpdVxEe8MYTCkuvizaCU9Eyv3aVlm5ok=;\n b=MRu85AfBPACyLXV+Q3dWFzwf4zXyFojIdxA+9sUBEHskV8ek9aPDyAqolV+3PpOV4N\n 2d7jcoGyfM3Tejyc9K9/XaHdnBbmwygAQ+/XZYSObhyj2MKKCKDlL7ij1DPaZCKsUR5s\n jIvleLnYk/MvPHxEQpIa1r0DwS5WKRpIAqcPiMpOGlMzczER3I856woaRLNwNtcAHKc4\n wHUvTlKd5LasNtgtj6rLWUwjr6PJgDVEMm0Hb5DsPGpJH/1yX/oNHu0AaIrayC+0iumY\n SBcIpGF89m81MNpKpOZRhPs4oM5IMOX7Whty52YzZ3BBaLusguUBjUaPVZB5QGqh3oUu\n 6y0g==", "X-Gm-Message-State": "AOJu0YyICLCuNqfeTnzWDUZexOuy7eM8Kp0/1CYoW+hRsnfByTmifWoT\n LE07T9SVJ9R76PT4ZlSivWKj5GCiTRtOCpXfvJlDJUmVOyUczyZp6Z/T8Oy6KAMyYHOoIwfGyVc\n LQX75", "X-Gm-Gg": "AZuq6aLGjjaLDyLud1rtIEKGIILOiO6vCBcm/WSIx3gcA2pdRxs3MF8jm1u82e5TQ/l\n 50ShN1jW3AksPztryfZDN8CR617ewhsYYrSrNqePx2E6QSyGSsgP8Y0NWO5F0m37XH02jiouuQz\n s9yHbIV9okHbRhVra4KW6O9oW3yWo0sL35ZkEs/iw6nH/isKb7K615lc0fSryD2w73o1UcX9YdW\n ZoGUK+PtE44ZMaGqDUrDnAu9yP3F5FezhpXmQ6B2H7T5+tzZh161lgmq1HfCKaXL4piD/hzSE1R\n gPWZ2KDH+Pj+mQAYz1HNL8JUWZkf/VhmrmobEmVANW3Lz3PbvILrWVyM6wYNIB19BhyoLdJL4J7\n 41l5iicCDAkAuIq2vs0JML66z0Z7Kh4KxXt3Z8Ys7AJ0WJLPdHUB/45We/5yniafn0hXnKFozLr\n A9ja4KXALkT3DlaahIgjcg0607BUcdv+Y+MyGmOBbbX5VJ6K4u8LCdYvKUY0tMhpeM5sTaILyhQ\n T2j", "X-Received": "by 2002:a05:6a21:6f0d:b0:37c:b74c:d8c7 with SMTP id\n adf61e73a8af0-3946a887081mr31448637.22.1770939969849;\n Thu, 12 Feb 2026 15:46:09 -0800 (PST)", "From": "Pierrick Bouvier <pierrick.bouvier@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-ppc@nongnu.org, Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Harsh Prateek Bora <harshpb@linux.ibm.com>,\n Stefano Garzarella <sgarzare@redhat.com>, Jason Wang <jasowang@redhat.com>,\n Nicholas Piggin <npiggin@gmail.com>, stefanha@redhat.com,\n richard.henderson@linaro.org, \"Michael S. Tsirkin\" <mst@redhat.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "Subject": "[PATCH 2/3] hw/virtio: rename virtio_is_big_endian to\n virtio_vdev_is_big_endian", "Date": "Thu, 12 Feb 2026 15:46:01 -0800", "Message-ID": "<20260212234602.338131-3-pierrick.bouvier@linaro.org>", "X-Mailer": "git-send-email 2.47.3", "In-Reply-To": "<20260212234602.338131-1-pierrick.bouvier@linaro.org>", "References": "<20260212234602.338131-1-pierrick.bouvier@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::434;\n envelope-from=pierrick.bouvier@linaro.org; helo=mail-pf1-x434.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Renaming this function removes the confusion with\nexisting virtio_is_big_endian cpu ops.\n\nIndeed, virtio_vdev_is_big_endian is *not* calling cpu\nvirtio_is_big_endian everytime.\n\nSigned-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>\n---\n include/hw/virtio/virtio-access.h | 2 +-\n include/hw/virtio/virtio.h | 2 +-\n hw/net/virtio-net.c | 4 ++--\n hw/virtio/vhost.c | 4 ++--\n hw/virtio/virtio-pci.c | 8 ++++----\n 5 files changed, 10 insertions(+), 10 deletions(-)", "diff": "diff --git a/include/hw/virtio/virtio-access.h b/include/hw/virtio/virtio-access.h\nindex 324ba907e93..0c5514178e4 100644\n--- a/include/hw/virtio/virtio-access.h\n+++ b/include/hw/virtio/virtio-access.h\n@@ -28,7 +28,7 @@\n static inline bool virtio_access_is_big_endian(VirtIODevice *vdev)\n {\n #if defined(LEGACY_VIRTIO_IS_BIENDIAN)\n- return virtio_is_big_endian(vdev);\n+ return virtio_vdev_is_big_endian(vdev);\n #elif TARGET_BIG_ENDIAN\n if (virtio_vdev_is_modern(vdev)) {\n return false;\ndiff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h\nindex 8f1e4323599..ed1a0967ed8 100644\n--- a/include/hw/virtio/virtio.h\n+++ b/include/hw/virtio/virtio.h\n@@ -478,7 +478,7 @@ static inline bool virtio_vdev_is_legacy(const VirtIODevice *vdev)\n return !virtio_vdev_is_modern(vdev);\n }\n \n-static inline bool virtio_is_big_endian(VirtIODevice *vdev)\n+static inline bool virtio_vdev_is_big_endian(VirtIODevice *vdev)\n {\n if (virtio_vdev_is_legacy(vdev)) {\n assert(vdev->device_endian != VIRTIO_DEVICE_ENDIAN_UNKNOWN);\ndiff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c\nindex 313d3b88400..ec85e5a949a 100644\n--- a/hw/net/virtio-net.c\n+++ b/hw/net/virtio-net.c\n@@ -301,7 +301,7 @@ static void virtio_net_vhost_status(VirtIONet *n, uint8_t status)\n if (n->needs_vnet_hdr_swap) {\n error_report(\"backend does not support %s vnet headers; \"\n \"falling back on userspace virtio\",\n- virtio_is_big_endian(vdev) ? \"BE\" : \"LE\");\n+ virtio_vdev_is_big_endian(vdev) ? \"BE\" : \"LE\");\n return;\n }\n \n@@ -343,7 +343,7 @@ static int virtio_net_set_vnet_endian_one(VirtIODevice *vdev,\n NetClientState *peer,\n bool enable)\n {\n- if (virtio_is_big_endian(vdev)) {\n+ if (virtio_vdev_is_big_endian(vdev)) {\n return qemu_set_vnet_be(peer, enable);\n } else {\n return qemu_set_vnet_le(peer, enable);\ndiff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c\nindex 70a112242b0..1f5e70ad197 100644\n--- a/hw/virtio/vhost.c\n+++ b/hw/virtio/vhost.c\n@@ -1306,7 +1306,7 @@ int vhost_virtqueue_start(struct vhost_dev *dev,\n \n if (vhost_needs_vring_endian(vdev)) {\n r = vhost_virtqueue_set_vring_endian_legacy(dev,\n- virtio_is_big_endian(vdev),\n+ virtio_vdev_is_big_endian(vdev),\n vhost_vq_index);\n if (r) {\n return r;\n@@ -1423,7 +1423,7 @@ static int do_vhost_virtqueue_stop(struct vhost_dev *dev,\n */\n if (vhost_needs_vring_endian(vdev)) {\n vhost_virtqueue_set_vring_endian_legacy(dev,\n- !virtio_is_big_endian(vdev),\n+ !virtio_vdev_is_big_endian(vdev),\n vhost_vq_index);\n }\n \ndiff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c\nindex 6126187a164..33c5cec01cd 100644\n--- a/hw/virtio/virtio-pci.c\n+++ b/hw/virtio/virtio-pci.c\n@@ -586,13 +586,13 @@ static uint64_t virtio_pci_config_read(void *opaque, hwaddr addr,\n break;\n case 2:\n val = virtio_config_readw(vdev, addr);\n- if (virtio_is_big_endian(vdev)) {\n+ if (virtio_vdev_is_big_endian(vdev)) {\n val = bswap16(val);\n }\n break;\n case 4:\n val = virtio_config_readl(vdev, addr);\n- if (virtio_is_big_endian(vdev)) {\n+ if (virtio_vdev_is_big_endian(vdev)) {\n val = bswap32(val);\n }\n break;\n@@ -625,13 +625,13 @@ static void virtio_pci_config_write(void *opaque, hwaddr addr,\n virtio_config_writeb(vdev, addr, val);\n break;\n case 2:\n- if (virtio_is_big_endian(vdev)) {\n+ if (virtio_vdev_is_big_endian(vdev)) {\n val = bswap16(val);\n }\n virtio_config_writew(vdev, addr, val);\n break;\n case 4:\n- if (virtio_is_big_endian(vdev)) {\n+ if (virtio_vdev_is_big_endian(vdev)) {\n val = bswap32(val);\n }\n virtio_config_writel(vdev, addr, val);\n", "prefixes": [ "2/3" ] }