Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196152/?format=api
{ "id": 2196152, "url": "http://patchwork.ozlabs.org/api/patches/2196152/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260212234602.338131-4-pierrick.bouvier@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260212234602.338131-4-pierrick.bouvier@linaro.org>", "list_archive_url": null, "date": "2026-02-12T23:46:02", "name": "[3/3] hw/virtio: remove virtio_access_is_big_endian", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9d69d4f23fe3409be6123b4917c97ea9abe7032a", "submitter": { "id": 85798, "url": "http://patchwork.ozlabs.org/api/people/85798/?format=api", "name": "Pierrick Bouvier", "email": "pierrick.bouvier@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260212234602.338131-4-pierrick.bouvier@linaro.org/mbox/", "series": [ { "id": 492041, "url": "http://patchwork.ozlabs.org/api/series/492041/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492041", "date": "2026-02-12T23:45:59", "name": "hw/virtio/virtio-access.h: remove target specific code", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492041/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196152/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196152/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=Y0dXnkYZ;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fBsQp0FYJz1xxR\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 13 Feb 2026 10:46:57 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vqgO0-0004hj-Vt; Thu, 12 Feb 2026 18:46:17 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pierrick.bouvier@linaro.org>)\n id 1vqgNy-0004gS-F0\n for qemu-devel@nongnu.org; Thu, 12 Feb 2026 18:46:14 -0500", "from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <pierrick.bouvier@linaro.org>)\n id 1vqgNw-0008BO-AV\n for qemu-devel@nongnu.org; Thu, 12 Feb 2026 18:46:14 -0500", "by mail-pf1-x435.google.com with SMTP id\n d2e1a72fcca58-824a3ba5222so224596b3a.2\n for <qemu-devel@nongnu.org>; Thu, 12 Feb 2026 15:46:11 -0800 (PST)", "from pc.taild8403c.ts.net (216-71-219-44.dyn.novuscom.net.\n [216.71.219.44]) by smtp.gmail.com with ESMTPSA id\n 41be03b00d2f7-c6e1ac0e004sm5609936a12.6.2026.02.12.15.46.10\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 12 Feb 2026 15:46:10 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1770939971; x=1771544771; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=JsSjHgAuxzH7z5UZfo3F29FRTsMy8IItwqoYG77XBoE=;\n b=Y0dXnkYZGeGu4oLZZEftJRpA5qqVcsECGTFzjSqnzWH1XPHOiX/G9f5jBBbio8hIuV\n lZJWs3ZAedv6G/7Qt6x+KZdfwxEt7U24FzgRyzLdUcNvG2rw1Oed/DwtXvB9NlGmCpTK\n t4yv15VgG3vV6ckpMJuuteL8g16oMjfzlbSAbhWVE1QBFk0UpBHp5Ggq7VFf6WSsFUqS\n wc9hyNNIa07CsMwsVAI8HcdUPcDmhNx8gI/nTWbTOqojtM3VgNxEV2Nk9pGcxcad2c/5\n m2DI83d8EzGUulMdlHyQFLB/bNFueithqUOvQ0O882soIp/u8eaBaniJWRsLHK5bUwug\n gTqQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1770939971; x=1771544771;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=JsSjHgAuxzH7z5UZfo3F29FRTsMy8IItwqoYG77XBoE=;\n b=hckB69QLTq8IVXfA3N3NgRV1enQ4qrLPRg/tGgm20ryvp/h0Wz+oybdK/m+SZogvFc\n wXzAvq8J7Z9Buyjr7PNobrBbrt7FeaOQBaaQ5Z7FdOK1R62lF284RVbd/mCpmFc4xZhd\n wigNeOy1cAaqlE2v5dSGjU7/BFiS8q51OS52mTB8uhS5R4HVXmQnQikiNyiUZ+jAKMfS\n 0WEMitJWPY6Q7qqRUVeRhZhOpYhLEG9V+hBrYhVcGAszdoQtyEfv37eThOna4ZwovKqu\n Umc/gFsIHqQIMJP/lcJJVZkVzQH+TcfZBKYs2BoRxI/ttnaqKenTVOVf3DE/98BPqLbG\n HrLw==", "X-Gm-Message-State": "AOJu0Yw7Jq09rPFoaWa7WQy0nQUfDZ5jKVM1Hv0+SKenP70DXjbkrqvn\n sMvr58PkkamVZTZIvTGPFmRZJ+AjgMO6Khg8+Lt0HGkFfMLn+4HUL0wT69mwc9+OZTTnwc3Zatz\n 6V/3v", "X-Gm-Gg": "AZuq6aIF/xeL0YY5gjnHlDKFYosOvSuQ5Mr+Ww7yGC/6yhCo4NRCqFAW0uTDtK5EauK\n s4ge7Ck6RJXfixRnK/HeTlAKFU8deFS6JAawxrapsk9TBJGt1PcqUhLXHIg/BqPghLEqNhxpPkn\n qTwYUtyKhDQZtw6NkDP5DcJgVHnMvWsIZzb19p2yiRB8U3+Rj901xh3TTtdk4Dap6ZPGJqFuNWw\n 8TT1GLn3YQsbHPAO8+K8JIind7MezoSzWMCNl4wt5GwgQd80v1ge/Ac8oa9qDiIHy8GK8X9GNJ/\n GNogDUoEUhylX3nkU/lxc7cP9laaeCHDPcxQTxrizWOV1Uz7EBtef3tk1qhWLuolvFjW5SL6tDm\n IcIzfzmjdSQQxH0bxJB1UlcalCfHID4U04dc/RCM3nUDMYGwO+D8/udklQR3uQXT5/7zH7BUQXV\n my9Zi1HtYxcG5bgDvA8WAqXQqQ2UBtMNk1ZHqbDOIGd+OD9TDFmlam8YkKi3cg/xWosgaLE+evp\n Rb5", "X-Received": "by 2002:a05:6a20:2d21:b0:38e:9ebe:5267 with SMTP id\n adf61e73a8af0-394673315aemr444713637.57.1770939970664;\n Thu, 12 Feb 2026 15:46:10 -0800 (PST)", "From": "Pierrick Bouvier <pierrick.bouvier@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-ppc@nongnu.org, Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Harsh Prateek Bora <harshpb@linux.ibm.com>,\n Stefano Garzarella <sgarzare@redhat.com>, Jason Wang <jasowang@redhat.com>,\n Nicholas Piggin <npiggin@gmail.com>, stefanha@redhat.com,\n richard.henderson@linaro.org, \"Michael S. Tsirkin\" <mst@redhat.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "Subject": "[PATCH 3/3] hw/virtio: remove virtio_access_is_big_endian", "Date": "Thu, 12 Feb 2026 15:46:02 -0800", "Message-ID": "<20260212234602.338131-4-pierrick.bouvier@linaro.org>", "X-Mailer": "git-send-email 2.47.3", "In-Reply-To": "<20260212234602.338131-1-pierrick.bouvier@linaro.org>", "References": "<20260212234602.338131-1-pierrick.bouvier@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::435;\n envelope-from=pierrick.bouvier@linaro.org; helo=mail-pf1-x435.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Thanks to previous refactoring, we can see more easily it is strictly\nequivalent to always call virtio_vdev_is_big_endian.\n\nstatic inline bool virtio_vdev_is_big_endian(VirtIODevice *vdev)\n{\n if (virtio_vdev_is_legacy(vdev)) {\n assert(vdev->device_endian != VIRTIO_DEVICE_ENDIAN_UNKNOWN);\n return vdev->device_endian == VIRTIO_DEVICE_ENDIAN_BIG;\n }\n /* Devices conforming to VIRTIO 1.0 or later are always LE. */\n return false;\n}\n\nThe key is to understand that vdev->device_endian is initialized as\nexpected. It always contains cpu endianness, and not\ndevice endianness, ignoring if device is legacy or not.\n\nBy default, it's initialized to vdev->device_endian =\nvirtio_default_endian(), which matches target default endianness.\nThen, on virtio_reset, it will be initialized with current_cpu\nendianness (if there is one current_cpu).\n\nvoid virtio_reset() {\n ...\n if (current_cpu) {\n /* Guest initiated reset */\n vdev->device_endian = virtio_current_cpu_endian();\n } else {\n /* System reset */\n vdev->device_endian = virtio_default_endian();\n }\n\nNow, we can see how existing virtio_access_is_big_endian is equivalent\nto virtio_vdev_is_big_endian. Let's break the existing function in its 3\nvariants, and compare that to virtio_vdev_is_big_endian.\n\nstatic inline bool virtio_access_is_big_endian(VirtIODevice *vdev)\n- #if defined(LEGACY_VIRTIO_IS_BIENDIAN)\n return virtio_vdev_is_big_endian(vdev);\n This is the exact replacement we did, so equivalent.\n- #elif TARGET_BIG_ENDIAN\n if (virtio_vdev_is_modern(vdev)) {\n return false;\n }\n return true;\n\n we know target_is_big_endian(), so\n vdev->device_endian == VIRTIO_DEVICE_ENDIAN_BIG.\n if (virtio_vdev_is_legacy(vdev)) {\n return VIRTIO_DEVICE_ENDIAN_BIG == VIRTIO_DEVICE_ENDIAN_BIG;\n }\n return false;\n It's written in opposite style compared to existing code (if legacy vs\n if modern), but it's strictly equivalent.\n- #else\n return false;\n we know !target_is_big_endian(), so\n vdev->device_endian == VIRTIO_DEVICE_ENDIAN_LITTLE.\n if virtio_vdev_is_legacy(vdev) {\n return VIRTIO_DEVICE_ENDIAN_LITTLE == VIRTIO_DEVICE_ENDIAN_BIG;\n }\n return false;\n So it always return false, as expected.\n\nSigned-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>\n---\n include/hw/virtio/virtio-access.h | 42 +++++++++----------------------\n hw/virtio/virtio.c | 4 +--\n 2 files changed, 14 insertions(+), 32 deletions(-)", "diff": "diff --git a/include/hw/virtio/virtio-access.h b/include/hw/virtio/virtio-access.h\nindex 0c5514178e4..506be642c9f 100644\n--- a/include/hw/virtio/virtio-access.h\n+++ b/include/hw/virtio/virtio-access.h\n@@ -21,27 +21,9 @@\n #include \"hw/virtio/virtio.h\"\n #include \"hw/virtio/virtio-bus.h\"\n \n-#if defined(TARGET_PPC64) || defined(TARGET_ARM)\n-#define LEGACY_VIRTIO_IS_BIENDIAN 1\n-#endif\n-\n-static inline bool virtio_access_is_big_endian(VirtIODevice *vdev)\n-{\n-#if defined(LEGACY_VIRTIO_IS_BIENDIAN)\n- return virtio_vdev_is_big_endian(vdev);\n-#elif TARGET_BIG_ENDIAN\n- if (virtio_vdev_is_modern(vdev)) {\n- return false;\n- }\n- return true;\n-#else\n- return false;\n-#endif\n-}\n-\n static inline void virtio_stw_p(VirtIODevice *vdev, void *ptr, uint16_t v)\n {\n- if (virtio_access_is_big_endian(vdev)) {\n+ if (virtio_vdev_is_big_endian(vdev)) {\n stw_be_p(ptr, v);\n } else {\n stw_le_p(ptr, v);\n@@ -50,7 +32,7 @@ static inline void virtio_stw_p(VirtIODevice *vdev, void *ptr, uint16_t v)\n \n static inline void virtio_stl_p(VirtIODevice *vdev, void *ptr, uint32_t v)\n {\n- if (virtio_access_is_big_endian(vdev)) {\n+ if (virtio_vdev_is_big_endian(vdev)) {\n stl_be_p(ptr, v);\n } else {\n stl_le_p(ptr, v);\n@@ -59,7 +41,7 @@ static inline void virtio_stl_p(VirtIODevice *vdev, void *ptr, uint32_t v)\n \n static inline void virtio_stq_p(VirtIODevice *vdev, void *ptr, uint64_t v)\n {\n- if (virtio_access_is_big_endian(vdev)) {\n+ if (virtio_vdev_is_big_endian(vdev)) {\n stq_be_p(ptr, v);\n } else {\n stq_le_p(ptr, v);\n@@ -68,7 +50,7 @@ static inline void virtio_stq_p(VirtIODevice *vdev, void *ptr, uint64_t v)\n \n static inline int virtio_lduw_p(VirtIODevice *vdev, const void *ptr)\n {\n- if (virtio_access_is_big_endian(vdev)) {\n+ if (virtio_vdev_is_big_endian(vdev)) {\n return lduw_be_p(ptr);\n } else {\n return lduw_le_p(ptr);\n@@ -77,7 +59,7 @@ static inline int virtio_lduw_p(VirtIODevice *vdev, const void *ptr)\n \n static inline int virtio_ldl_p(VirtIODevice *vdev, const void *ptr)\n {\n- if (virtio_access_is_big_endian(vdev)) {\n+ if (virtio_vdev_is_big_endian(vdev)) {\n return ldl_be_p(ptr);\n } else {\n return ldl_le_p(ptr);\n@@ -86,7 +68,7 @@ static inline int virtio_ldl_p(VirtIODevice *vdev, const void *ptr)\n \n static inline uint64_t virtio_ldq_p(VirtIODevice *vdev, const void *ptr)\n {\n- if (virtio_access_is_big_endian(vdev)) {\n+ if (virtio_vdev_is_big_endian(vdev)) {\n return ldq_be_p(ptr);\n } else {\n return ldq_le_p(ptr);\n@@ -96,9 +78,9 @@ static inline uint64_t virtio_ldq_p(VirtIODevice *vdev, const void *ptr)\n static inline uint16_t virtio_tswap16(VirtIODevice *vdev, uint16_t s)\n {\n #if HOST_BIG_ENDIAN\n- return virtio_access_is_big_endian(vdev) ? s : bswap16(s);\n+ return virtio_vdev_is_big_endian(vdev) ? s : bswap16(s);\n #else\n- return virtio_access_is_big_endian(vdev) ? bswap16(s) : s;\n+ return virtio_vdev_is_big_endian(vdev) ? bswap16(s) : s;\n #endif\n }\n \n@@ -110,9 +92,9 @@ static inline void virtio_tswap16s(VirtIODevice *vdev, uint16_t *s)\n static inline uint32_t virtio_tswap32(VirtIODevice *vdev, uint32_t s)\n {\n #if HOST_BIG_ENDIAN\n- return virtio_access_is_big_endian(vdev) ? s : bswap32(s);\n+ return virtio_vdev_is_big_endian(vdev) ? s : bswap32(s);\n #else\n- return virtio_access_is_big_endian(vdev) ? bswap32(s) : s;\n+ return virtio_vdev_is_big_endian(vdev) ? bswap32(s) : s;\n #endif\n }\n \n@@ -124,9 +106,9 @@ static inline void virtio_tswap32s(VirtIODevice *vdev, uint32_t *s)\n static inline uint64_t virtio_tswap64(VirtIODevice *vdev, uint64_t s)\n {\n #if HOST_BIG_ENDIAN\n- return virtio_access_is_big_endian(vdev) ? s : bswap64(s);\n+ return virtio_vdev_is_big_endian(vdev) ? s : bswap64(s);\n #else\n- return virtio_access_is_big_endian(vdev) ? bswap64(s) : s;\n+ return virtio_vdev_is_big_endian(vdev) ? bswap64(s) : s;\n #endif\n }\n \ndiff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c\nindex b0987e66d5b..2ae238001dc 100644\n--- a/hw/virtio/virtio.c\n+++ b/hw/virtio/virtio.c\n@@ -222,7 +222,7 @@ static inline uint16_t virtio_lduw_phys_cached(VirtIODevice *vdev,\n MemoryRegionCache *cache,\n hwaddr pa)\n {\n- if (virtio_access_is_big_endian(vdev)) {\n+ if (virtio_vdev_is_big_endian(vdev)) {\n return lduw_be_phys_cached(cache, pa);\n }\n return lduw_le_phys_cached(cache, pa);\n@@ -232,7 +232,7 @@ static inline void virtio_stw_phys_cached(VirtIODevice *vdev,\n MemoryRegionCache *cache,\n hwaddr pa, uint16_t value)\n {\n- if (virtio_access_is_big_endian(vdev)) {\n+ if (virtio_vdev_is_big_endian(vdev)) {\n stw_be_phys_cached(cache, pa, value);\n } else {\n stw_le_phys_cached(cache, pa, value);\n", "prefixes": [ "3/3" ] }