Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196096/?format=api
{ "id": 2196096, "url": "http://patchwork.ozlabs.org/api/patches/2196096/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260212204352.1044699-7-zycai@linux.ibm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260212204352.1044699-7-zycai@linux.ibm.com>", "list_archive_url": null, "date": "2026-02-12T20:43:27", "name": "[v8,06/30] s390x/diag: Refactor address validation check from diag308_parm_check", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "70d9fb05daf4aea056826a96bdd95634d072e53f", "submitter": { "id": 90643, "url": "http://patchwork.ozlabs.org/api/people/90643/?format=api", "name": "Zhuoying Cai", "email": "zycai@linux.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260212204352.1044699-7-zycai@linux.ibm.com/mbox/", "series": [ { "id": 492021, "url": "http://patchwork.ozlabs.org/api/series/492021/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492021", "date": "2026-02-12T20:43:36", "name": "Secure IPL Support for SCSI Scheme of virtio-blk/virtio-scsi Devices", "version": 8, "mbox": "http://patchwork.ozlabs.org/series/492021/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196096/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196096/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=Lk43C1pS;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fBnST18Hbz1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 13 Feb 2026 07:48:09 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vqdXr-0000eM-CF; Thu, 12 Feb 2026 15:44:15 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zycai@linux.ibm.com>)\n id 1vqdXp-0000cz-E1; Thu, 12 Feb 2026 15:44:13 -0500", "from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zycai@linux.ibm.com>)\n id 1vqdXn-0007Sp-Uk; Thu, 12 Feb 2026 15:44:13 -0500", "from pps.filterd (m0353725.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 61CJusM6448421; Thu, 12 Feb 2026 20:44:09 GMT", "from ppma23.wdc07v.mail.ibm.com\n (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4c696vd8rk-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 12 Feb 2026 20:44:08 +0000 (GMT)", "from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 61CHR36l012610;\n Thu, 12 Feb 2026 20:44:08 GMT", "from smtprelay06.wdc07v.mail.ibm.com ([172.16.1.73])\n by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4c6h7km143-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 12 Feb 2026 20:44:08 +0000", "from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com\n [10.39.53.233])\n by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 61CKi6H421627622\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Thu, 12 Feb 2026 20:44:06 GMT", "from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id BBEEC58054;\n Thu, 12 Feb 2026 20:44:06 +0000 (GMT)", "from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 0ABD65804E;\n Thu, 12 Feb 2026 20:44:05 +0000 (GMT)", "from fedora-workstation.ibmuc.com (unknown [9.61.112.15])\n by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n Thu, 12 Feb 2026 20:44:04 +0000 (GMT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=Kk/E7qeXz2AzQv1v3\n WwGnoLU8iF/gVVR3UHpOKA3MUo=; b=Lk43C1pS3/JA5CRbsBD1GJEbkXL/mCpmW\n wIfiRK+NhKXJSNT1rl48XVt5mIm9fRUq+L9UzyALbjhep+O2Q8qtjhvj2pkrWZ4t\n 75A1oyeyI2MUfno52gimRdeRU+zMi39CpxAJluEDr8nnTo+MMMRY7ibg7m36kp8G\n XjG45BdLjlJTOZgH34WvFY/dyfV9j/qgEpKA3aOhqNlMCzuk7ByCgAzudNMbRMzj\n U0jVXO6zNyjD5OSKESqVtb3RDnttvnz/Pm3X7BAAQsckV2r2bdj/o4KINufApvL2\n qHTggzHmLtkSzylTIhea5zdzBUcAaLvCAQk1p9GXEiotAoGQETYOg==", "From": "Zhuoying Cai <zycai@linux.ibm.com>", "To": "thuth@redhat.com, berrange@redhat.com, richard.henderson@linaro.org,\n jrossi@linux.ibm.com, qemu-s390x@nongnu.org, qemu-devel@nongnu.org", "Cc": "david@kernel.org, walling@linux.ibm.com, jjherne@linux.ibm.com,\n pasic@linux.ibm.com, borntraeger@linux.ibm.com, farman@linux.ibm.com,\n mjrosato@linux.ibm.com, iii@linux.ibm.com, eblake@redhat.com,\n armbru@redhat.com, zycai@linux.ibm.com, alifm@linux.ibm.com,\n brueckner@linux.ibm.com", "Subject": "[PATCH v8 06/30] s390x/diag: Refactor address validation check from\n diag308_parm_check", "Date": "Thu, 12 Feb 2026 15:43:27 -0500", "Message-ID": "<20260212204352.1044699-7-zycai@linux.ibm.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260212204352.1044699-1-zycai@linux.ibm.com>", "References": "<20260212204352.1044699-1-zycai@linux.ibm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Proofpoint-GUID": "Z0PL7CN6AQzDaFl1uYOPnObHAKKebg0l", "X-Proofpoint-ORIG-GUID": "Z0PL7CN6AQzDaFl1uYOPnObHAKKebg0l", "X-Authority-Analysis": "v=2.4 cv=JdWxbEKV c=1 sm=1 tr=0 ts=698e3b98 cx=c_pps\n a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17\n a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22\n a=GgsMoib0sEa3-_RKJdDe:22 a=VnNF1IyMAAAA:8 a=130TwiEZxdn8fhqcL5YA:9", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMjEyMDE1NyBTYWx0ZWRfX82/IIPaFsMrb\n 0+HpyPu6R8SUlC6OxbpF2/q1IzTtYETt1AaFyxUp+am7B2vgVp0bBRcqs6mYJ2mCV8JXPw/ngfP\n zCgd+mvasTvgFVjQ8Mkr6IAn9PHOeMH+W9+NW/Ik6s0ydzxQylrbsD3h2PxiXLoz0K+KYw6PsSl\n EpSJphhNzGekmeFDLGDVUMKDcm4MfsVzg09J6QSP2WG3Vursi49eEftwyWxyKxOyMUC+IaW1Adl\n viKb/aZGmcG6DQKGlOZrT8ATh6KLYajzmsmV+3WtG8Yu59HWEuh564mA3ipMUzotGKlX/bOdC3L\n +oN5Q1mQa0+TnRz2Gi1dcNPyY+tQBmRKA+DP9r4UvCg2bHpH7YsZm8V8QZfrU7ZEqRWSGIC5tm3\n Djb0F1gaKux04qu9zXV6R4KwthJy913B0NF3qCWRzDNG6EsbjM7QozG4uluFDCQjKqUXucK06v0\n Jd4KblLnXfH6geEIqgQ==", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-02-12_05,2026-02-12_03,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n priorityscore=1501 clxscore=1015 impostorscore=0 bulkscore=0\n lowpriorityscore=0 suspectscore=0 adultscore=0 spamscore=0 malwarescore=0\n phishscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2602120157", "Received-SPF": "pass client-ip=148.163.158.5; envelope-from=zycai@linux.ibm.com;\n helo=mx0b-001b2d01.pphosted.com", "X-Spam_score_int": "-26", "X-Spam_score": "-2.7", "X-Spam_bar": "--", "X-Spam_report": "(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Create a function to validate the address parameter of DIAGNOSE.\n\nRefactor the function for reuse in the next patch, which allows address\nvalidation in read or write operation of DIAGNOSE.\n\nSigned-off-by: Zhuoying Cai <zycai@linux.ibm.com>\nReviewed-by: Farhan Ali <alifm@linux.ibm.com>\nReviewed-by: Collin Walling <walling@linux.ibm.com>\nReviewed-by: Hendrik Brueckner <brueckner@linux.ibm.com>\n---\n target/s390x/diag.c | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/target/s390x/diag.c b/target/s390x/diag.c\nindex d82eedfeca..e867fc2156 100644\n--- a/target/s390x/diag.c\n+++ b/target/s390x/diag.c\n@@ -26,6 +26,12 @@\n #include \"qemu/error-report.h\"\n \n \n+static inline bool diag_parm_addr_valid(uint64_t addr, size_t size, bool write)\n+{\n+ return address_space_access_valid(&address_space_memory, addr,\n+ size, write, MEMTXATTRS_UNSPECIFIED);\n+}\n+\n int handle_diag_288(CPUS390XState *env, uint64_t r1, uint64_t r3)\n {\n uint64_t func = env->regs[r1];\n@@ -65,9 +71,7 @@ static int diag308_parm_check(CPUS390XState *env, uint64_t r1, uint64_t addr,\n s390_program_interrupt(env, PGM_SPECIFICATION, ra);\n return -1;\n }\n- if (!address_space_access_valid(&address_space_memory, addr,\n- sizeof(IplParameterBlock), write,\n- MEMTXATTRS_UNSPECIFIED)) {\n+ if (!diag_parm_addr_valid(addr, sizeof(IplParameterBlock), write)) {\n s390_program_interrupt(env, PGM_ADDRESSING, ra);\n return -1;\n }\n", "prefixes": [ "v8", "06/30" ] }