Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196090/?format=api
{ "id": 2196090, "url": "http://patchwork.ozlabs.org/api/patches/2196090/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260212204352.1044699-27-zycai@linux.ibm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260212204352.1044699-27-zycai@linux.ibm.com>", "list_archive_url": null, "date": "2026-02-12T20:43:47", "name": "[v8,26/30] hw/s390x/ipl: Handle secure boot with multiple boot devices", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "1952de835d410ae79684a5c48e98fb50f2f24103", "submitter": { "id": 90643, "url": "http://patchwork.ozlabs.org/api/people/90643/?format=api", "name": "Zhuoying Cai", "email": "zycai@linux.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260212204352.1044699-27-zycai@linux.ibm.com/mbox/", "series": [ { "id": 492021, "url": "http://patchwork.ozlabs.org/api/series/492021/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492021", "date": "2026-02-12T20:43:36", "name": "Secure IPL Support for SCSI Scheme of virtio-blk/virtio-scsi Devices", "version": 8, "mbox": "http://patchwork.ozlabs.org/series/492021/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196090/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196090/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=VX6Y92hb;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fBnSF4ncYz1xr1\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 13 Feb 2026 07:47:57 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vqdYU-0001Cn-Gz; Thu, 12 Feb 2026 15:44:54 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zycai@linux.ibm.com>)\n id 1vqdYS-0001C5-Qo; Thu, 12 Feb 2026 15:44:52 -0500", "from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zycai@linux.ibm.com>)\n id 1vqdYR-0008Hz-89; Thu, 12 Feb 2026 15:44:52 -0500", "from pps.filterd (m0356516.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 61CI5kSb328612; Thu, 12 Feb 2026 20:44:48 GMT", "from ppma21.wdc07v.mail.ibm.com\n (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4c696v5bb8-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 12 Feb 2026 20:44:47 +0000 (GMT)", "from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 61CHU3ZR001427;\n Thu, 12 Feb 2026 20:44:47 GMT", "from smtprelay06.wdc07v.mail.ibm.com ([172.16.1.73])\n by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4c6gqnc4p9-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 12 Feb 2026 20:44:47 +0000", "from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com\n [10.39.53.233])\n by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 61CKijuq30343844\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Thu, 12 Feb 2026 20:44:45 GMT", "from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 4F92558054;\n Thu, 12 Feb 2026 20:44:45 +0000 (GMT)", "from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 8E4115804E;\n Thu, 12 Feb 2026 20:44:43 +0000 (GMT)", "from fedora-workstation.ibmuc.com (unknown [9.61.112.15])\n by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n Thu, 12 Feb 2026 20:44:43 +0000 (GMT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=Nka937iiC45rlorMU\n nLcf3JnebtNciPBq/8ZThOSQjA=; b=VX6Y92hbSlD+lzunh/RBJEiuC7mDjz8jX\n 2g28LHNmQmFctmbEniZYVztW2xsobx+EIIWNy4KWkGzYpqvCk+gnP+0FJh6Qmu8u\n BpFA+T9AWt56js0PTlnHk+KoFghmGL9ltQgd2pm0Z9W6PKDnwGwZoEQcJBRahasd\n W/eTsuw6ftub101oI9jRYVTxSxAHNLKLKX/xpdUnTEltu7UbdVo/E+0EnlLVFt+x\n WAzE/1ZRIX+Y3kI4/KLfYVntNCGCMyKtxsSUR52Reb0Hl/fa9iXTJtsOVpLe48Bw\n b7djMFCo0FcLCmVpPHBRgqRbsoQ8V41nr1oJx6h7XH2XrGdFJ1l+g==", "From": "Zhuoying Cai <zycai@linux.ibm.com>", "To": "thuth@redhat.com, berrange@redhat.com, richard.henderson@linaro.org,\n jrossi@linux.ibm.com, qemu-s390x@nongnu.org, qemu-devel@nongnu.org", "Cc": "david@kernel.org, walling@linux.ibm.com, jjherne@linux.ibm.com,\n pasic@linux.ibm.com, borntraeger@linux.ibm.com, farman@linux.ibm.com,\n mjrosato@linux.ibm.com, iii@linux.ibm.com, eblake@redhat.com,\n armbru@redhat.com, zycai@linux.ibm.com, alifm@linux.ibm.com,\n brueckner@linux.ibm.com", "Subject": "[PATCH v8 26/30] hw/s390x/ipl: Handle secure boot with multiple boot\n devices", "Date": "Thu, 12 Feb 2026 15:43:47 -0500", "Message-ID": "<20260212204352.1044699-27-zycai@linux.ibm.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260212204352.1044699-1-zycai@linux.ibm.com>", "References": "<20260212204352.1044699-1-zycai@linux.ibm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMjEyMDE1NyBTYWx0ZWRfXwSUqUGj/w3G2\n NmW2EQyH0LIkjDYwQG81ktLZvQc+r2yI4l9xT6vwnvN8cvcWqrnaMm8Hiez+o9PzJ7v206JOTLQ\n z+Rlt22hYc9H3iHd3G4zMT17rJoVwJzeEJ6IPkqyvZuWSXlxTWfJ2TqsoteJpIFMc5Zaibs+Rkh\n 2681VnReh/5zK8Ekxk7aAyI062/35PStJgajMgnS/3ymhHY2oUN3/4iO7m5BJr5f8yk1+xrtYaV\n 0s5DdvvHUDbZXI1Jad8vrXpq5B9GEiPWxmI9lhVj/mZMN9HrXiANY11nF3Rw2eVJUUJbx8VdN/7\n E/QDRhWTZ3dAfl6gzuK2aMVrwRsQ5wzR/YtKWDiopVgP4puZjXdinIJMcPvkm4s8KjZik/811Qr\n vg8a5N8QKo/nQpgI87MbJhZFFjAU3Fu6b7f4M4aZ+tvZoAIi25CC+IFrfbwlvuxH3A8xL3Uu2Xw\n n2L8iZQVUoTK3pYn2hA==", "X-Proofpoint-ORIG-GUID": "3Q_6DBR8zEd2mkBJkrFHzsJb0DgbB8p_", "X-Proofpoint-GUID": "3Q_6DBR8zEd2mkBJkrFHzsJb0DgbB8p_", "X-Authority-Analysis": "v=2.4 cv=O+Y0fR9W c=1 sm=1 tr=0 ts=698e3bbf cx=c_pps\n a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17\n a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22\n a=GgsMoib0sEa3-_RKJdDe:22 a=VnNF1IyMAAAA:8 a=Q8-XYP680VqNmkEzHFAA:9", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-02-12_05,2026-02-12_03,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n lowpriorityscore=0 priorityscore=1501 phishscore=0 adultscore=0\n malwarescore=0 impostorscore=0 bulkscore=0 clxscore=1015 spamscore=0\n suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2602120157", "Received-SPF": "pass client-ip=148.163.158.5; envelope-from=zycai@linux.ibm.com;\n helo=mx0b-001b2d01.pphosted.com", "X-Spam_score_int": "-26", "X-Spam_score": "-2.7", "X-Spam_bar": "--", "X-Spam_report": "(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "The current approach to enable secure boot relies on providing\nsecure-boot and boot-certs parameters of s390-ccw-virtio machine\ntype option, which apply to all boot devices.\n\nWith the possibility of multiple boot devices, secure boot expects all\nprovided devices to be supported and eligible (e.g.,\nvirtio-blk/virtio-scsi using the SCSI scheme).\n\nIf multiple boot devices are provided and include an unsupported (e.g.,\nECKD, VFIO) or a non-eligible (e.g., Net) device, the boot process will\nterminate with an error logged to the console.\n\nSigned-off-by: Zhuoying Cai <zycai@linux.ibm.com>\n---\n hw/s390x/ipl.c | 79 ++++++++++++++++++++++++++++-------------\n pc-bios/s390-ccw/main.c | 3 --\n 2 files changed, 54 insertions(+), 28 deletions(-)", "diff": "diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c\nindex f8dd50f69d..e46e655ef1 100644\n--- a/hw/s390x/ipl.c\n+++ b/hw/s390x/ipl.c\n@@ -445,6 +445,58 @@ static bool s390_secure_boot_enabled(void)\n return S390_CCW_MACHINE(qdev_get_machine())->secure_boot;\n }\n \n+static bool s390_validate_secure_boot_device(int devtype, Error **errp)\n+{\n+ switch (devtype) {\n+ case CCW_DEVTYPE_VFIO:\n+ error_setg(errp, \"Passthrough (vfio) CCW device does not support secure boot!\");\n+ return false;\n+ case CCW_DEVTYPE_VIRTIO_NET:\n+ error_setg(errp, \"Virtio net boot device does not support secure boot!\");\n+ return false;\n+ default:\n+ return true;\n+ }\n+}\n+\n+static void s390_apply_secure_boot(IplParameterBlock *iplb, int devtype,\n+ bool secure_boot, bool audit_mode)\n+{\n+ Error *local_error = NULL;\n+\n+ if (!secure_boot && !audit_mode) {\n+ return;\n+ }\n+\n+ if (!s390_validate_secure_boot_device(devtype, &local_error)) {\n+ error_report_err(local_error);\n+ exit(1);\n+ }\n+\n+ /*\n+ * If secure-boot is enabled, then toggle the secure IPL flags (SIPL) to\n+ * trigger secure boot in the s390 BIOS.\n+ *\n+ * Boot process will terminate if any error occurs during secure boot.\n+ */\n+ if (secure_boot) {\n+ iplb->hdr_flags |= DIAG308_IPIB_FLAGS_SIPL;\n+ }\n+\n+ /*\n+ * For both secure boot and audit mode, enable the IPL Information\n+ * Report (IPLIR) flag so that the firmware generates an IPL\n+ * Information Report Block (IIRB).\n+ *\n+ * Results of secure boot will be stored in IIRB.\n+ *\n+ * Extend the IPL parameter block to its maximum length to ensure\n+ * sufficient space for the BIOS to populate the IIRB.\n+ */\n+ iplb->hdr_flags |= DIAG308_IPIB_FLAGS_IPLIR;\n+ iplb->len = cpu_to_be32(S390_IPLB_MAX_LEN);\n+}\n+\n static bool s390_build_iplb(DeviceState *dev_st, IplParameterBlock *iplb)\n {\n CcwDevice *ccw_dev = NULL;\n@@ -502,31 +554,8 @@ static bool s390_build_iplb(DeviceState *dev_st, IplParameterBlock *iplb)\n s390_ipl_convert_loadparm((char *)lp, iplb->loadparm);\n iplb->flags |= DIAG308_FLAGS_LP_VALID;\n \n- /*\n- * If secure-boot is enabled, then toggle the secure IPL flags to\n- * trigger secure boot in the s390 BIOS.\n- *\n- * Boot process will terminate if any error occurs during secure boot.\n- *\n- * If SIPL is on, IPLIR must also be on.\n- */\n- if (s390_secure_boot_enabled()) {\n- iplb->hdr_flags |= (DIAG308_IPIB_FLAGS_SIPL | DIAG308_IPIB_FLAGS_IPLIR);\n- iplb->len = cpu_to_be32(S390_IPLB_MAX_LEN);\n- }\n- /*\n- * Secure boot in audit mode will perform\n- * if certificate(s) exist in the key store.\n- *\n- * IPL Information Report Block (IIRB) will exist\n- * for secure boot in audit mode.\n- *\n- * Results of secure boot will be stored in IIRB.\n- */\n- else if (s390_has_certificate()) {\n- iplb->hdr_flags |= DIAG308_IPIB_FLAGS_IPLIR;\n- iplb->len = cpu_to_be32(S390_IPLB_MAX_LEN);\n- }\n+ s390_apply_secure_boot(iplb, devtype, s390_secure_boot_enabled(),\n+ s390_has_certificate());\n \n return true;\n }\ndiff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/main.c\nindex 1678ede8fb..6633a2cbaf 100644\n--- a/pc-bios/s390-ccw/main.c\n+++ b/pc-bios/s390-ccw/main.c\n@@ -276,9 +276,6 @@ static void ipl_boot_device(void)\n switch (cutype) {\n case CU_TYPE_DASD_3990:\n case CU_TYPE_DASD_2107:\n- IPL_assert((boot_mode == ZIPL_BOOT_MODE_NORMAL),\n- \"Passthrough (vfio) CCW device does not support secure boot!\");\n-\n dasd_ipl(blk_schid, cutype);\n break;\n case CU_TYPE_VIRTIO:\n", "prefixes": [ "v8", "26/30" ] }