Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196088/?format=api
{ "id": 2196088, "url": "http://patchwork.ozlabs.org/api/patches/2196088/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260212204352.1044699-19-zycai@linux.ibm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260212204352.1044699-19-zycai@linux.ibm.com>", "list_archive_url": null, "date": "2026-02-12T20:43:39", "name": "[v8,18/30] pc-bios/s390-ccw: Rework zipl_load_segment function", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "edda935511edb0bb2ad5db25b4b9c1e971061630", "submitter": { "id": 90643, "url": "http://patchwork.ozlabs.org/api/people/90643/?format=api", "name": "Zhuoying Cai", "email": "zycai@linux.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260212204352.1044699-19-zycai@linux.ibm.com/mbox/", "series": [ { "id": 492021, "url": "http://patchwork.ozlabs.org/api/series/492021/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492021", "date": "2026-02-12T20:43:36", "name": "Secure IPL Support for SCSI Scheme of virtio-blk/virtio-scsi Devices", "version": 8, "mbox": "http://patchwork.ozlabs.org/series/492021/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196088/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196088/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=pCXVsS5H;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fBnRz6HVKz1xxR\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 13 Feb 2026 07:47:43 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vqdYF-0000u1-AB; Thu, 12 Feb 2026 15:44:39 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zycai@linux.ibm.com>)\n id 1vqdYD-0000sq-Tb; Thu, 12 Feb 2026 15:44:37 -0500", "from mx0a-001b2d01.pphosted.com ([148.163.156.1])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zycai@linux.ibm.com>)\n id 1vqdYC-0007nj-CF; Thu, 12 Feb 2026 15:44:37 -0500", "from pps.filterd (m0353729.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 61C9x5LZ483862; Thu, 12 Feb 2026 20:44:32 GMT", "from ppma23.wdc07v.mail.ibm.com\n (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4c696wg4mv-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 12 Feb 2026 20:44:32 +0000 (GMT)", "from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 61CHn0NF012623;\n Thu, 12 Feb 2026 20:44:31 GMT", "from smtprelay04.wdc07v.mail.ibm.com ([172.16.1.71])\n by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4c6h7km154-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 12 Feb 2026 20:44:31 +0000", "from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com\n [10.39.53.233])\n by smtprelay04.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 61CKiUdn38470326\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Thu, 12 Feb 2026 20:44:30 GMT", "from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id F331358054;\n Thu, 12 Feb 2026 20:44:29 +0000 (GMT)", "from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 447095804E;\n Thu, 12 Feb 2026 20:44:28 +0000 (GMT)", "from fedora-workstation.ibmuc.com (unknown [9.61.112.15])\n by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n Thu, 12 Feb 2026 20:44:28 +0000 (GMT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=zMNphC1yBqjauBkyP\n aKpyyRX7aIz36E8YVyOJ1Xsj0w=; b=pCXVsS5H6Lts18o9pG70bN6bqySAyFN4S\n 3WUX85EgC1JsZ/aufyUi0epfqzVvy2f06TfPs9FPsnDdcyU5jW9OMmLoQ9ds7s9Z\n HRS0KshHwyIR+PPC1wzkMQWd64s824XSU2QyCDAU45TgQNNGQrOkx036GWTm2BuN\n VUK5RDadiFrsKNscvzfzY+8pNTqVPQV3HGLuUb9hhxJoGlQkzUNZ4+1AveDMGBM2\n LjgifKZjCYtIm4JGYSv8d/cNBZz9J7ZyvnJoWOw0dvuXl/M3+AKYR7+JpAbQ2Qx6\n BgSpJl/lQkBngzRUpihlSRVbSuYMHjh0wqrQUKLK0+kjc3pbWJrvw==", "From": "Zhuoying Cai <zycai@linux.ibm.com>", "To": "thuth@redhat.com, berrange@redhat.com, richard.henderson@linaro.org,\n jrossi@linux.ibm.com, qemu-s390x@nongnu.org, qemu-devel@nongnu.org", "Cc": "david@kernel.org, walling@linux.ibm.com, jjherne@linux.ibm.com,\n pasic@linux.ibm.com, borntraeger@linux.ibm.com, farman@linux.ibm.com,\n mjrosato@linux.ibm.com, iii@linux.ibm.com, eblake@redhat.com,\n armbru@redhat.com, zycai@linux.ibm.com, alifm@linux.ibm.com,\n brueckner@linux.ibm.com", "Subject": "[PATCH v8 18/30] pc-bios/s390-ccw: Rework zipl_load_segment function", "Date": "Thu, 12 Feb 2026 15:43:39 -0500", "Message-ID": "<20260212204352.1044699-19-zycai@linux.ibm.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260212204352.1044699-1-zycai@linux.ibm.com>", "References": "<20260212204352.1044699-1-zycai@linux.ibm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Authority-Analysis": "v=2.4 cv=YeCwJgRf c=1 sm=1 tr=0 ts=698e3bb0 cx=c_pps\n a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17\n a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22\n a=GgsMoib0sEa3-_RKJdDe:22 a=VnNF1IyMAAAA:8 a=20KFwNOVAAAA:8\n a=wVZWP19Ib8Popp5rDVAA:9", "X-Proofpoint-GUID": "Obr_NfKCpdUPlW6O4wJlBZwHucvhm4OX", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMjEyMDE1NyBTYWx0ZWRfX51WwH/JhRoDR\n 9o+8NRgrL6NqpiGSwaHgfAKKJEiOPgebW7t6O2o/7kgBHADoageoA/m7UiN4yl5uOV+W8C1PNRO\n LaDoridXcSTtLL/UgCkOtARVecFIz4vl06eZZTJeGbAiWXookJwxXlHsBd0mXpPKP0y3r/RCNzQ\n V+2BtmT0IxoMVQYND0X7yKlhwTRmphe7sWtfO1aUG/AKKf9LN/bCdEqFE45Wqcm4SYPjH++LwE4\n ehv9O5jhxUcid4lvdJ++D/nr5E9iAGatPCcCBRwUV6VnKYhjI7oVoLJ/TMtdMAlOVxU4KIXCImr\n 5LceB0EJoPDIoy+8oNt69bHUWfIkBL1S1ka7ZKWeEz2VRO9IDw/zxsrfYgj44GO3pMLWOrLD/Jx\n yvRDxFHwfG8WLdyMpzMsCXVWsfWRTKLgB+/FB3bHvr6qzOPqmkKTvGtGap1lIyzpRZEYpKIDdEO\n 39q4Bm3MNfcrJGwCLMw==", "X-Proofpoint-ORIG-GUID": "Obr_NfKCpdUPlW6O4wJlBZwHucvhm4OX", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-02-12_05,2026-02-12_03,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n suspectscore=0 adultscore=0 bulkscore=0 malwarescore=0 phishscore=0\n priorityscore=1501 lowpriorityscore=0 clxscore=1015 impostorscore=0\n spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound\n adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2602120157", "Received-SPF": "pass client-ip=148.163.156.1; envelope-from=zycai@linux.ibm.com;\n helo=mx0a-001b2d01.pphosted.com", "X-Spam_score_int": "-19", "X-Spam_score": "-2.0", "X-Spam_bar": "--", "X-Spam_report": "(-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Make the address variable a parameter of zipl_load_segment and return\nsegment length.\n\nModify this function to allow the caller to specify a memory address\nwhere segment data should be loaded into.\n\nseg_len variable is necessary to store the calculated segment length and\nis used during signature verification. Return the length on success, or\na negative return code on failure.\n\nSigned-off-by: Zhuoying Cai <zycai@linux.ibm.com>\nReviewed-by: Thomas Huth <thuth@redhat.com>\n---\n pc-bios/s390-ccw/bootmap.c | 15 ++++++++++-----\n 1 file changed, 10 insertions(+), 5 deletions(-)", "diff": "diff --git a/pc-bios/s390-ccw/bootmap.c b/pc-bios/s390-ccw/bootmap.c\nindex 22801ca746..9a03eab6ed 100644\n--- a/pc-bios/s390-ccw/bootmap.c\n+++ b/pc-bios/s390-ccw/bootmap.c\n@@ -613,19 +613,22 @@ static int ipl_eckd(void)\n * IPL a SCSI disk\n */\n \n-static int zipl_load_segment(ComponentEntry *entry)\n+/*\n+ * Returns: length of the segment on success,\n+ * negative value on error.\n+ */\n+static int zipl_load_segment(ComponentEntry *entry, uint64_t address)\n {\n const int max_entries = (MAX_SECTOR_SIZE / sizeof(ScsiBlockPtr));\n ScsiBlockPtr *bprs = (void *)sec;\n const int bprs_size = sizeof(sec);\n block_number_t blockno;\n- uint64_t address;\n int i;\n char err_msg[] = \"zIPL failed to read BPRS at 0xZZZZZZZZZZZZZZZZ\";\n char *blk_no = &err_msg[30]; /* where to print blockno in (those ZZs) */\n+ int seg_len = 0;\n \n blockno = entry->data.blockno;\n- address = entry->compdat.load_addr;\n \n debug_print_int(\"loading segment at block\", blockno);\n debug_print_int(\"addr\", address);\n@@ -668,10 +671,12 @@ static int zipl_load_segment(ComponentEntry *entry)\n puts(\"zIPL load segment failed\");\n return -EIO;\n }\n+\n+ seg_len += bprs->size * (bprs[i].blockct + 1);\n }\n } while (blockno);\n \n- return 0;\n+ return seg_len;\n }\n \n static int zipl_run_normal(ComponentEntry **entry_ptr, uint8_t *tmp_sec)\n@@ -687,7 +692,7 @@ static int zipl_run_normal(ComponentEntry **entry_ptr, uint8_t *tmp_sec)\n continue;\n }\n \n- if (zipl_load_segment(entry)) {\n+ if (zipl_load_segment(entry, entry->compdat.load_addr) < 0) {\n return -1;\n }\n \n", "prefixes": [ "v8", "18/30" ] }