Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196085/?format=api
{ "id": 2196085, "url": "http://patchwork.ozlabs.org/api/patches/2196085/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260212204352.1044699-15-zycai@linux.ibm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260212204352.1044699-15-zycai@linux.ibm.com>", "list_archive_url": null, "date": "2026-02-12T20:43:35", "name": "[v8,14/30] pc-bios/s390-ccw: Define memory for IPLB and convert IPLB to pointers", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "95b255a891720905e8f0619199c51e938f45b304", "submitter": { "id": 90643, "url": "http://patchwork.ozlabs.org/api/people/90643/?format=api", "name": "Zhuoying Cai", "email": "zycai@linux.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260212204352.1044699-15-zycai@linux.ibm.com/mbox/", "series": [ { "id": 492021, "url": "http://patchwork.ozlabs.org/api/series/492021/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492021", "date": "2026-02-12T20:43:36", "name": "Secure IPL Support for SCSI Scheme of virtio-blk/virtio-scsi Devices", "version": 8, "mbox": "http://patchwork.ozlabs.org/series/492021/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196085/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196085/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=gfL7FfB+;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fBnRn6xc2z1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 13 Feb 2026 07:47:33 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vqdY8-0000nF-BF; Thu, 12 Feb 2026 15:44:32 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zycai@linux.ibm.com>)\n id 1vqdY6-0000lk-6q; Thu, 12 Feb 2026 15:44:30 -0500", "from mx0a-001b2d01.pphosted.com ([148.163.156.1])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zycai@linux.ibm.com>)\n id 1vqdY4-0007dw-Bj; Thu, 12 Feb 2026 15:44:29 -0500", "from pps.filterd (m0353729.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 61CFw5Pc3988415; Thu, 12 Feb 2026 20:44:24 GMT", "from ppma13.dal12v.mail.ibm.com\n (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4c696wg4md-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 12 Feb 2026 20:44:24 +0000 (GMT)", "from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1])\n by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 61CHRXX0019336;\n Thu, 12 Feb 2026 20:44:23 GMT", "from smtprelay03.dal12v.mail.ibm.com ([172.16.1.5])\n by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4c6hxkbyvq-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 12 Feb 2026 20:44:23 +0000", "from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com\n [10.39.53.233])\n by smtprelay03.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 61CKiMhs29033132\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Thu, 12 Feb 2026 20:44:22 GMT", "from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 487975804E;\n Thu, 12 Feb 2026 20:44:22 +0000 (GMT)", "from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 88F9A58054;\n Thu, 12 Feb 2026 20:44:20 +0000 (GMT)", "from fedora-workstation.ibmuc.com (unknown [9.61.112.15])\n by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n Thu, 12 Feb 2026 20:44:20 +0000 (GMT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=TFR0iZ5PCu1X3gkdq\n GyqKhkaG9vNN6okuQAOj9yj6RU=; b=gfL7FfB+EmKyP5+j9wWzrinBSHUDOtIMU\n 0bYC9euU4+G39ODxN/kYULU9YM28/MNAK4QCLe/pNX42sy1P8VxedafLq7bwpDc0\n ibtWUwqLV6N4yhp5jaaOXBItXUmTXbl6nTbcGiWnglJ1ZoLd/Kf/YBiW02CZDtU+\n hztG5y+ikXrBFCaiyqXj36lvE8Ntt4r5XBwheRDmfmdwsfPToLkAlUPRQHPITwwc\n VBBu8zZZ2suzeyuzsGJh7/MsKoTT5ShdRmXtH/QZmEB5HqyQwabT8eoZWjHm5cJe\n EZ0KpmbJm7WN5dF46Qk6c7YyTY0sNC9E6RPhLVQzOoSU3WyfNU9oA==", "From": "Zhuoying Cai <zycai@linux.ibm.com>", "To": "thuth@redhat.com, berrange@redhat.com, richard.henderson@linaro.org,\n jrossi@linux.ibm.com, qemu-s390x@nongnu.org, qemu-devel@nongnu.org", "Cc": "david@kernel.org, walling@linux.ibm.com, jjherne@linux.ibm.com,\n pasic@linux.ibm.com, borntraeger@linux.ibm.com, farman@linux.ibm.com,\n mjrosato@linux.ibm.com, iii@linux.ibm.com, eblake@redhat.com,\n armbru@redhat.com, zycai@linux.ibm.com, alifm@linux.ibm.com,\n brueckner@linux.ibm.com", "Subject": "[PATCH v8 14/30] pc-bios/s390-ccw: Define memory for IPLB and convert\n IPLB to pointers", "Date": "Thu, 12 Feb 2026 15:43:35 -0500", "Message-ID": "<20260212204352.1044699-15-zycai@linux.ibm.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260212204352.1044699-1-zycai@linux.ibm.com>", "References": "<20260212204352.1044699-1-zycai@linux.ibm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Authority-Analysis": "v=2.4 cv=YeCwJgRf c=1 sm=1 tr=0 ts=698e3ba8 cx=c_pps\n a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17\n a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22\n a=GgsMoib0sEa3-_RKJdDe:22 a=VnNF1IyMAAAA:8 a=_GZQR2ZoBes7ElOevS0A:9", "X-Proofpoint-GUID": "jCMrH2DYvnO8Jhx-pcuUJHJczXWsjB5p", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMjEyMDE1NyBTYWx0ZWRfXzbpF0AcTsQzW\n q9CIhNPJFmlEWsBhNiSayZFzs5cQ4r7sz8DF0tR1Y9+cdqDli45MSIcnZ8JdnEGAx5cH6Hed4OZ\n jJUMN8bO6UsH21YTlBmGNIN2wCMI24m2vYhn32NFcVYROxx2Scd+7H9OsUOWitxTUHFQVFbgtI6\n s6tZYrkKxsf/rbG8jQK1I7twdbJLvjM5Pq98t9GfUIqu8b5I7oidJzOVHziDzS8DRucVY35Tg8f\n 8K4lfA/HwyM8VDJuT5SyEF3NfVNI5Wimy5sc1Pnn2DwWJrez9/KStk9MG87qtmKGIxqoAhfn+Vs\n 4eW5IO/C+dccgwAwRQQ+T5F/WwsvfowY8ekLvaVdj8rmpmfQQYE5LVEOrPzkcFp0zV/hSVu9KgZ\n /L0GBh9bKn4m5Ph0XpuLhpWcAILSh1kPKptb459nlw8OMFhbkH6e7YEoyUOILm/dtovici6nSoT\n r7Uq/DUa5n4VxMrNTjA==", "X-Proofpoint-ORIG-GUID": "jCMrH2DYvnO8Jhx-pcuUJHJczXWsjB5p", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-02-12_05,2026-02-12_03,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n suspectscore=0 adultscore=0 bulkscore=0 malwarescore=0 phishscore=0\n priorityscore=1501 lowpriorityscore=0 clxscore=1015 impostorscore=0\n spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound\n adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2602120157", "Received-SPF": "pass client-ip=148.163.156.1; envelope-from=zycai@linux.ibm.com;\n helo=mx0a-001b2d01.pphosted.com", "X-Spam_score_int": "-19", "X-Spam_score": "-2.0", "X-Spam_bar": "--", "X-Spam_report": "(-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Define a memory space for both IPL Parameter Block (IPLB) and\nIPL Information Report Block (IIRB) since IIRB is stored immediately\nfollowing IPLB.\n\nConvert IPLB to pointer and it points to the start of the defined memory space.\nIIRB points to the end of IPLB.\n\nSigned-off-by: Zhuoying Cai <zycai@linux.ibm.com>\n---\n include/hw/s390x/ipl/qipl.h | 6 ++++++\n pc-bios/s390-ccw/iplb.h | 5 +++--\n pc-bios/s390-ccw/jump2ipl.c | 6 +++---\n pc-bios/s390-ccw/main.c | 34 +++++++++++++++++++---------------\n pc-bios/s390-ccw/netmain.c | 8 ++++----\n 5 files changed, 35 insertions(+), 24 deletions(-)", "diff": "diff --git a/include/hw/s390x/ipl/qipl.h b/include/hw/s390x/ipl/qipl.h\nindex 0f1f55c428..f5e63a2fdb 100644\n--- a/include/hw/s390x/ipl/qipl.h\n+++ b/include/hw/s390x/ipl/qipl.h\n@@ -185,4 +185,10 @@ struct IplInfoReportBlock {\n };\n typedef struct IplInfoReportBlock IplInfoReportBlock;\n \n+struct IplBlocks {\n+ IplParameterBlock iplb;\n+ IplInfoReportBlock iirb;\n+};\n+typedef struct IplBlocks IplBlocks;\n+\n #endif\ndiff --git a/pc-bios/s390-ccw/iplb.h b/pc-bios/s390-ccw/iplb.h\nindex 08f259ff31..fefca65ac6 100644\n--- a/pc-bios/s390-ccw/iplb.h\n+++ b/pc-bios/s390-ccw/iplb.h\n@@ -20,8 +20,9 @@\n #include <string.h>\n \n extern QemuIplParameters qipl;\n-extern IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE)));\n+extern IplParameterBlock *iplb;\n extern bool have_iplb;\n+extern IplBlocks ipl_data;\n \n #define S390_IPL_TYPE_FCP 0x00\n #define S390_IPL_TYPE_CCW 0x02\n@@ -65,7 +66,7 @@ static inline bool load_next_iplb(void)\n \n qipl.index++;\n next_iplb = (IplParameterBlock *) qipl.next_iplb;\n- memcpy(&iplb, next_iplb, sizeof(IplParameterBlock));\n+ memcpy(iplb, next_iplb, sizeof(IplParameterBlock));\n \n qipl.chain_len--;\n qipl.next_iplb = qipl.next_iplb + sizeof(IplParameterBlock);\ndiff --git a/pc-bios/s390-ccw/jump2ipl.c b/pc-bios/s390-ccw/jump2ipl.c\nindex 86321d0f46..fa2ca5cbe1 100644\n--- a/pc-bios/s390-ccw/jump2ipl.c\n+++ b/pc-bios/s390-ccw/jump2ipl.c\n@@ -43,11 +43,11 @@ int jump_to_IPL_code(uint64_t address)\n * The IPLB for QEMU SCSI type devices must be rebuilt during re-ipl. The\n * iplb.devno is set to the boot position of the target SCSI device.\n */\n- if (iplb.pbt == S390_IPL_TYPE_QEMU_SCSI) {\n- iplb.devno = qipl.index;\n+ if (iplb->pbt == S390_IPL_TYPE_QEMU_SCSI) {\n+ iplb->devno = qipl.index;\n }\n \n- if (have_iplb && !set_iplb(&iplb)) {\n+ if (have_iplb && !set_iplb(iplb)) {\n panic(\"Failed to set IPLB\");\n }\n \ndiff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/main.c\nindex 76bf743900..819f053009 100644\n--- a/pc-bios/s390-ccw/main.c\n+++ b/pc-bios/s390-ccw/main.c\n@@ -22,7 +22,9 @@\n static SubChannelId blk_schid = { .one = 1 };\n static char loadparm_str[LOADPARM_LEN + 1];\n QemuIplParameters qipl;\n-IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE)));\n+/* Ensure that IPLB and IIRB are page aligned and sequential in memory */\n+IplBlocks ipl_data __attribute__((__aligned__(PAGE_SIZE)));\n+IplParameterBlock *iplb;\n bool have_iplb;\n static uint16_t cutype;\n LowCore *lowcore; /* Yes, this *is* a pointer to address 0 */\n@@ -51,7 +53,7 @@ void write_subsystem_identification(void)\n void write_iplb_location(void)\n {\n if (cutype == CU_TYPE_VIRTIO && virtio_get_device_type() != VIRTIO_ID_NET) {\n- lowcore->ptr_iplb = ptr2u32(&iplb);\n+ lowcore->ptr_iplb = ptr2u32(iplb);\n }\n }\n \n@@ -162,7 +164,7 @@ static void menu_setup(void)\n return;\n }\n \n- switch (iplb.pbt) {\n+ switch (iplb->pbt) {\n case S390_IPL_TYPE_CCW:\n case S390_IPL_TYPE_QEMU_SCSI:\n menu_set_parms(qipl.qipl_flags & BOOT_MENU_FLAG_MASK,\n@@ -191,8 +193,8 @@ static void boot_setup(void)\n {\n char lpmsg[] = \"LOADPARM=[________]\\n\";\n \n- if (have_iplb && memcmp(iplb.loadparm, NO_LOADPARM, LOADPARM_LEN) != 0) {\n- ebcdic_to_ascii((char *) iplb.loadparm, loadparm_str, LOADPARM_LEN);\n+ if (have_iplb && memcmp(iplb->loadparm, NO_LOADPARM, LOADPARM_LEN) != 0) {\n+ ebcdic_to_ascii((char *) iplb->loadparm, loadparm_str, LOADPARM_LEN);\n } else {\n sclp_get_loadparm_ascii(loadparm_str);\n }\n@@ -216,21 +218,21 @@ static bool find_boot_device(void)\n VDev *vdev = virtio_get_device();\n bool found = false;\n \n- switch (iplb.pbt) {\n+ switch (iplb->pbt) {\n case S390_IPL_TYPE_CCW:\n vdev->scsi_device_selected = false;\n- debug_print_int(\"device no. \", iplb.ccw.devno);\n- blk_schid.ssid = iplb.ccw.ssid & 0x3;\n+ debug_print_int(\"device no. \", iplb->ccw.devno);\n+ blk_schid.ssid = iplb->ccw.ssid & 0x3;\n debug_print_int(\"ssid \", blk_schid.ssid);\n- found = find_subch(iplb.ccw.devno);\n+ found = find_subch(iplb->ccw.devno);\n break;\n case S390_IPL_TYPE_QEMU_SCSI:\n vdev->scsi_device_selected = true;\n- vdev->selected_scsi_device.channel = iplb.scsi.channel;\n- vdev->selected_scsi_device.target = iplb.scsi.target;\n- vdev->selected_scsi_device.lun = iplb.scsi.lun;\n- blk_schid.ssid = iplb.scsi.ssid & 0x3;\n- found = find_subch(iplb.scsi.devno);\n+ vdev->selected_scsi_device.channel = iplb->scsi.channel;\n+ vdev->selected_scsi_device.target = iplb->scsi.target;\n+ vdev->selected_scsi_device.lun = iplb->scsi.lun;\n+ blk_schid.ssid = iplb->scsi.ssid & 0x3;\n+ found = find_subch(iplb->scsi.devno);\n break;\n default:\n puts(\"Unsupported IPLB\");\n@@ -311,10 +313,12 @@ static void probe_boot_device(void)\n \n void main(void)\n {\n+ iplb = &ipl_data.iplb;\n+\n copy_qipl();\n sclp_setup();\n css_setup();\n- have_iplb = store_iplb(&iplb);\n+ have_iplb = store_iplb(iplb);\n if (!have_iplb) {\n boot_setup();\n probe_boot_device();\ndiff --git a/pc-bios/s390-ccw/netmain.c b/pc-bios/s390-ccw/netmain.c\nindex a9521dff41..457fbc3095 100644\n--- a/pc-bios/s390-ccw/netmain.c\n+++ b/pc-bios/s390-ccw/netmain.c\n@@ -528,11 +528,11 @@ static bool virtio_setup(void)\n */\n enable_mss_facility();\n \n- if (have_iplb || store_iplb(&iplb)) {\n- IPL_assert(iplb.pbt == S390_IPL_TYPE_CCW, \"IPL_TYPE_CCW expected\");\n- dev_no = iplb.ccw.devno;\n+ if (have_iplb || store_iplb(iplb)) {\n+ IPL_assert(iplb->pbt == S390_IPL_TYPE_CCW, \"IPL_TYPE_CCW expected\");\n+ dev_no = iplb->ccw.devno;\n debug_print_int(\"device no. \", dev_no);\n- net_schid.ssid = iplb.ccw.ssid & 0x3;\n+ net_schid.ssid = iplb->ccw.ssid & 0x3;\n debug_print_int(\"ssid \", net_schid.ssid);\n found = find_net_dev(&schib, dev_no);\n } else {\n", "prefixes": [ "v8", "14/30" ] }