Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196076/?format=api
{ "id": 2196076, "url": "http://patchwork.ozlabs.org/api/patches/2196076/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260212204511.619392-4-javierm@redhat.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260212204511.619392-4-javierm@redhat.com>", "list_archive_url": null, "date": "2026-02-12T20:44:57", "name": "[v2,3/7] disk: part_efi: Remove redundant struct partition definition", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4d99d95981b91ca08df3942814669038170292aa", "submitter": { "id": 72132, "url": "http://patchwork.ozlabs.org/api/people/72132/?format=api", "name": "Javier Martinez Canillas", "email": "javierm@redhat.com" }, "delegate": { "id": 68728, "url": "http://patchwork.ozlabs.org/api/users/68728/?format=api", "username": "xypron", "first_name": "Heinrich", "last_name": "Schuchardt", "email": "xypron.glpk@gmx.de" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260212204511.619392-4-javierm@redhat.com/mbox/", "series": [ { "id": 492022, "url": "http://patchwork.ozlabs.org/api/series/492022/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=492022", "date": "2026-02-12T20:44:54", "name": "efi_loader: disk: Add EFI_PARTITION_INFO_PROTOCOL support for MBR", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/492022/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196076/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196076/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=BA1s+RGr;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.b=\"BA1s+RGr\";\n\tdkim-atps=neutral", "phobos.denx.de; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=javierm@redhat.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fBnPp58C0z1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 13 Feb 2026 07:45:50 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 7B72183D6C;\n\tThu, 12 Feb 2026 21:45:31 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 746B383DCA; Thu, 12 Feb 2026 21:45:28 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 5530183D5D\n for <u-boot@lists.denx.de>; Thu, 12 Feb 2026 21:45:25 +0100 (CET)", "from mail-wm1-f71.google.com (mail-wm1-f71.google.com\n [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-77-vmYbA8MxOhGm7H0pLYSNNQ-1; Thu, 12 Feb 2026 15:45:23 -0500", "by mail-wm1-f71.google.com with SMTP id\n 5b1f17b1804b1-4802bb29400so1840395e9.0\n for <u-boot@lists.denx.de>; Thu, 12 Feb 2026 12:45:23 -0800 (PST)", "from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48370a3ecadsm3205185e9.3.2026.02.12.12.45.19\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 12 Feb 2026 12:45:20 -0800 (PST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED,\n SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1770929124;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Z20qoABZ2CA0QB1vSCQ9Zi0sSxjQk09IoYggdGSkk+8=;\n b=BA1s+RGrwDr/TEIy+o2PIceUdQqRl3qVdbvtqEiQUkRaSKapQmHGivAIRINY01taYdYbB0\n SN8alBOJXSRwu06AVevHmTtf6r405BOObsvG+GMcgRDBuQHCQsnAJtUgYqCi4F1ZAIuZAz\n N6cKNk/82uz1uvZZI41oQaWuxGJhLDQ=", "X-MC-Unique": "vmYbA8MxOhGm7H0pLYSNNQ-1", "X-Mimecast-MFC-AGG-ID": "vmYbA8MxOhGm7H0pLYSNNQ_1770929122", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1770929121; x=1771533921;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=Z20qoABZ2CA0QB1vSCQ9Zi0sSxjQk09IoYggdGSkk+8=;\n b=YJfxqP6T8bhZW92hERHkB3MvPk/gXKjxfEpYVgs0qVihCR4KQl48eJ9lQ7qzd2rkVk\n r+UDla75n6vV+LfUpHBbC7FonSPWupdmpR2vWwBOmL9y4ZHeHz8BIS1eXp+OKwpK08cn\n 4904imCf9QvQZB96E606ve9scnNMXOEmSRqt7quZsfqdyxlLokK37BCn6T0IyJMCUE1R\n SNNGpN9IQkOn0pZ4v2HlfnHYxyB/Mvue5BCQ4xxW95J9TOH1YthNhUDMcO4iDBxSxMJt\n DGV6p5dftTDzN6Dp1ZYdmFcdTWfyBTu51yDFc/1RWyrm5bvSl+ENTZDUvDsOSBeK0Fde\n Wx0w==", "X-Gm-Message-State": "AOJu0YxMHUtABNTlkRFOdGzFu9MJ64TtLhj8xmx635ppf5CUgbUDzQbd\n DATpja1NR293MioXJftAPiBiN16kO483XYhH8jMwzA3DqRUiWiFdlDMSFQwiJOox20C/mRqriIe\n BqUhSMvrLOUHivcBRzM/SvtEV4D66wlHybyhjPmKegY8noi54JSCw7zwn39oR0s1IAD7lVHZV+8\n ZTKsugLxjXj1hQKj+Ja+X8VFaaygUp9AK5MsHCGQ==", "X-Gm-Gg": "AZuq6aJHG9R7bFYNPYl0wIyZrxpHmA1jiGc8EJdibVyJLZYx0dWJsRl0kM3Y3Q1K+gN\n uDHI6RXzGRExYCn/QNNnSalbgTCK3QrVRIYJ8dPsAkQef/PJ9qr4HE0/6DsNGYEFAeYHgusivO5\n 31BfOhcLDUSQxkbjkN13dFdaNjjE4miCouOdDyFufmHBod4lMI6JzcqMVGGF9HWqdnR9ExuxJRy\n pYl3tFbPN8bDvjVB1cGltoY9o8XYJ/ZggskvGJ+LyI9KpA71e3NSYOtXW6Qjg6pEHxB9K9FX5eY\n ZYYEagXvRQAyYRwofPLhtcYC7JDmUE3keLMcb5BiSkw0kPdKBzpEaix8NHCGahHxeHWMgDRK8rm\n GoxKw18NS81D1z4Ryk8OA2LMDzJQ2M/qFXXmhasi+8Vmz6wo=", "X-Received": [ "by 2002:a05:600c:3b8b:b0:483:43d8:8d68 with SMTP id\n 5b1f17b1804b1-48371040571mr7338495e9.28.1770929121290;\n Thu, 12 Feb 2026 12:45:21 -0800 (PST)", "by 2002:a05:600c:3b8b:b0:483:43d8:8d68 with SMTP id\n 5b1f17b1804b1-48371040571mr7338015e9.28.1770929120726;\n Thu, 12 Feb 2026 12:45:20 -0800 (PST)" ], "From": "Javier Martinez Canillas <javierm@redhat.com>", "To": "u-boot@lists.denx.de", "Cc": "Heinrich Schuchardt <xypron.glpk@gmx.de>, eballetb@redhat.com,\n Ilias Apalodimas <ilias.apalodimas@linaro.org>,\n Tom Rini <trini@konsulko.com>,\n Javier Martinez Canillas <javierm@redhat.com>", "Subject": "[PATCH v2 3/7] disk: part_efi: Remove redundant struct partition\n definition", "Date": "Thu, 12 Feb 2026 21:44:57 +0100", "Message-ID": "<20260212204511.619392-4-javierm@redhat.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260212204511.619392-1-javierm@redhat.com>", "References": "<20260212204511.619392-1-javierm@redhat.com>", "MIME-Version": "1.0", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "waoFTyp5Nb4lUw3OUZ2FyujC5g1lrXxsAubBNTuInkI_1770929122", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Now that dos_partition_t and struct partition are identical, the duplicated\ndata structure definition in the part_efi.h header can just be removed.\n\nThis results in a single, shared definition for MBR partition table\nentries, instead of having the same definition in two different places.\n\nSigned-off-by: Javier Martinez Canillas <javierm@redhat.com>\nReviewed-by: Tom Rini <trini@konsulko.com>\n---\n\n(no changes since v1)\n\n disk/part_efi.c | 4 ++--\n include/part_efi.h | 19 +++----------------\n 2 files changed, 5 insertions(+), 18 deletions(-)", "diff": "diff --git a/disk/part_efi.c b/disk/part_efi.c\nindex fb1ed534f861..d8b17ec2e91a 100644\n--- a/disk/part_efi.c\n+++ b/disk/part_efi.c\n@@ -51,7 +51,7 @@ static inline u32 efi_crc32(const void *buf, u32 len)\n * Private function prototypes\n */\n \n-static int pmbr_part_valid(struct partition *part);\n+static int pmbr_part_valid(dos_partition_t *part);\n static int is_pmbr_valid(legacy_mbr * mbr);\n static int is_gpt_valid(struct blk_desc *desc, u64 lba, gpt_header *pgpt_head,\n \t\t\tgpt_entry **pgpt_pte);\n@@ -990,7 +990,7 @@ int write_mbr_and_gpt_partitions(struct blk_desc *desc, void *buf)\n *\n * Returns: 1 if EFI GPT partition type is found.\n */\n-static int pmbr_part_valid(struct partition *part)\n+static int pmbr_part_valid(dos_partition_t *part)\n {\n \tif (part->sys_ind == EFI_PMBR_OSTYPE_EFI_GPT &&\n \t\tget_unaligned_le32(&part->start_sect) == 1UL) {\ndiff --git a/include/part_efi.h b/include/part_efi.h\nindex fb402df6f13e..2cea50880465 100644\n--- a/include/part_efi.h\n+++ b/include/part_efi.h\n@@ -18,6 +18,7 @@\n #define _DISK_PART_EFI_H\n \n #include <efi.h>\n+#include <part_dos.h>\n \n #define MSDOS_MBR_SIGNATURE 0xAA55\n #define MSDOS_MBR_BOOT_CODE_SIZE 440\n@@ -77,20 +78,6 @@\n /* linux/include/efi.h */\n typedef u16 efi_char16_t;\n \n-/* based on linux/include/genhd.h */\n-struct partition {\n-\tu8 boot_ind;\t\t/* 0x80 - active */\n-\tu8 head;\t\t/* starting head */\n-\tu8 sector;\t\t/* starting sector */\n-\tu8 cyl;\t\t\t/* starting cylinder */\n-\tu8 sys_ind;\t\t/* What partition type */\n-\tu8 end_head;\t\t/* end head */\n-\tu8 end_sector;\t\t/* end sector */\n-\tu8 end_cyl;\t\t/* end cylinder */\n-\t__le32 start_sect;\t/* starting sector counting from 0 */\n-\t__le32 nr_sects;\t/* nr of sectors in partition */\n-} __packed;\n-\n /* based on linux/fs/partitions/efi.h */\n typedef struct _gpt_header {\n \t__le64 signature;\n@@ -134,7 +121,7 @@ typedef struct _legacy_mbr {\n \tu8 boot_code[MSDOS_MBR_BOOT_CODE_SIZE];\n \t__le32 unique_mbr_signature;\n \t__le16 unknown;\n-\tstruct partition partition_record[4];\n+\tdos_partition_t partition_record[4];\n \t__le16 signature;\n } __packed legacy_mbr;\n \n@@ -153,7 +140,7 @@ struct efi_partition_info {\n \tu8 system;\n \tu8 reserved[7];\n \tunion {\n-\t\tstruct partition mbr;\n+\t\tdos_partition_t mbr;\n \t\tgpt_entry gpt;\n \t} info;\n } __packed;\n", "prefixes": [ "v2", "3/7" ] }