Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196071/?format=api
{ "id": 2196071, "url": "http://patchwork.ozlabs.org/api/patches/2196071/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260212204352.1044699-8-zycai@linux.ibm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260212204352.1044699-8-zycai@linux.ibm.com>", "list_archive_url": null, "date": "2026-02-12T20:43:28", "name": "[v8,07/30] s390x/diag: Implement DIAG 320 subcode 1", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "d5c346d8763d585410bfd9ce3594e11b569e8ad9", "submitter": { "id": 90643, "url": "http://patchwork.ozlabs.org/api/people/90643/?format=api", "name": "Zhuoying Cai", "email": "zycai@linux.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260212204352.1044699-8-zycai@linux.ibm.com/mbox/", "series": [ { "id": 492021, "url": "http://patchwork.ozlabs.org/api/series/492021/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492021", "date": "2026-02-12T20:43:36", "name": "Secure IPL Support for SCSI Scheme of virtio-blk/virtio-scsi Devices", "version": 8, "mbox": "http://patchwork.ozlabs.org/series/492021/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196071/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196071/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=BKbxvLoo;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fBnPC0mSrz1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 13 Feb 2026 07:45:19 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vqdXv-0000gB-LU; Thu, 12 Feb 2026 15:44:19 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zycai@linux.ibm.com>)\n id 1vqdXs-0000ej-Iq; Thu, 12 Feb 2026 15:44:16 -0500", "from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zycai@linux.ibm.com>)\n id 1vqdXq-0007Va-Nh; Thu, 12 Feb 2026 15:44:16 -0500", "from pps.filterd (m0356516.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 61CD0fYd3344155; Thu, 12 Feb 2026 20:44:11 GMT", "from ppma22.wdc07v.mail.ibm.com\n (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4c696v5b9u-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 12 Feb 2026 20:44:10 +0000 (GMT)", "from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 61CKclrg008378;\n Thu, 12 Feb 2026 20:44:10 GMT", "from smtprelay02.dal12v.mail.ibm.com ([172.16.1.4])\n by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4c6g3ym7uf-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 12 Feb 2026 20:44:10 +0000", "from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com\n [10.39.53.233])\n by smtprelay02.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 61CKi8BP26870516\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Thu, 12 Feb 2026 20:44:09 GMT", "from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id A0C0258054;\n Thu, 12 Feb 2026 20:44:08 +0000 (GMT)", "from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id E42885804E;\n Thu, 12 Feb 2026 20:44:06 +0000 (GMT)", "from fedora-workstation.ibmuc.com (unknown [9.61.112.15])\n by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n Thu, 12 Feb 2026 20:44:06 +0000 (GMT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=JEqhTVSlgYZPIsMBP\n XqqfesOYW070ykvooRDsqZWbXc=; b=BKbxvLooi4QERQSYoqzFNeE+X+EuTfOh9\n ol9m3OYau4E9xjodUyU+F6J6dw2+FTqdhJcqlR0saWW9kgWvgetrQ2FsRa9j4p89\n 1iBFJaftTm1BjEYNwC1EAIlFtfGJ9OZTVpj/vMSD/RLzBGsZnbiJMvPkxoCQj9Z1\n IsuxwTOat0sgO5hpQgOuiu5dn3ro7ny4D7uSOfkAINEKZigIqHf3JVtyXH2Yz7MW\n zAFb5ag1xOiYsQG7q0PROfRVHjrLQXJz2R7ZTydGHaGdmTkVVwWKKYnSPD/c/9+C\n ahcdRpapW4eYpn9NSzryBvR+ou3eK/lwob9yjcy0jH7rtTiHoHbjA==", "From": "Zhuoying Cai <zycai@linux.ibm.com>", "To": "thuth@redhat.com, berrange@redhat.com, richard.henderson@linaro.org,\n jrossi@linux.ibm.com, qemu-s390x@nongnu.org, qemu-devel@nongnu.org", "Cc": "david@kernel.org, walling@linux.ibm.com, jjherne@linux.ibm.com,\n pasic@linux.ibm.com, borntraeger@linux.ibm.com, farman@linux.ibm.com,\n mjrosato@linux.ibm.com, iii@linux.ibm.com, eblake@redhat.com,\n armbru@redhat.com, zycai@linux.ibm.com, alifm@linux.ibm.com,\n brueckner@linux.ibm.com", "Subject": "[PATCH v8 07/30] s390x/diag: Implement DIAG 320 subcode 1", "Date": "Thu, 12 Feb 2026 15:43:28 -0500", "Message-ID": "<20260212204352.1044699-8-zycai@linux.ibm.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260212204352.1044699-1-zycai@linux.ibm.com>", "References": "<20260212204352.1044699-1-zycai@linux.ibm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMjEyMDE1NyBTYWx0ZWRfX9cq6Y/6FBldn\n cdVlTp10hvWUmxIliJmiAj0S4EfIIL4BOnBw3Hm//CsiYmNNgaesm389F/6h9rpv+TSSF3sBT/x\n 2Nk/ZSg+RFxVRgJmIOMP0ElRFyBjwgeoZd9ivoRlB/D5zkYWjjjHxatuFciaXHIi8ChyEAQc9aF\n mf4ExY9/Wcv9ha5IVyz5MJxKpYo8qH6o9KGVa075BSeaxtQM/Ie7QMI78ONApfzLzLNgoghwbVo\n JjPt6p+AO34hfgkOz1ZcQVJGuZ0Y2nSGYJwwp++/DxH5yRXn6OaeJe0HSUYuNxsa22qiR9zpyAo\n RnYt855L3IXO4J0qoT2nilfP5IhbApvIzoCBeBZF0gyR1YVlPInYcLDkgbrJJ1XyyA8nQZrHoUw\n 7+LrAYwv6WpdEY8vtWbWMrXdDbEuaFZGZ3kR8ibT5TcHzHq7nqIOe085AYarHPWSpt/kFKc80xc\n miPCEFsJ80YpSSc69Fg==", "X-Proofpoint-ORIG-GUID": "u8WPbZoEHhgQd18dneV4_VTDCyXGKbHw", "X-Proofpoint-GUID": "u8WPbZoEHhgQd18dneV4_VTDCyXGKbHw", "X-Authority-Analysis": "v=2.4 cv=O+Y0fR9W c=1 sm=1 tr=0 ts=698e3b9a cx=c_pps\n a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17\n a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22\n a=GgsMoib0sEa3-_RKJdDe:22 a=VnNF1IyMAAAA:8 a=vmAlfMB145uIY6ZofiUA:9", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-02-12_05,2026-02-12_03,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n lowpriorityscore=0 priorityscore=1501 phishscore=0 adultscore=0\n malwarescore=0 impostorscore=0 bulkscore=0 clxscore=1015 spamscore=0\n suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2602120157", "Received-SPF": "pass client-ip=148.163.158.5; envelope-from=zycai@linux.ibm.com;\n helo=mx0b-001b2d01.pphosted.com", "X-Spam_score_int": "-26", "X-Spam_score": "-2.7", "X-Spam_bar": "--", "X-Spam_report": "(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "DIAG 320 subcode 1 provides information needed to determine\nthe amount of storage to store one or more certificates from the\ncertificate store.\n\nUpon successful completion, this subcode returns information of the current\ncert store, such as the number of certificates stored and allowed in the cert\nstore, amount of space may need to be allocate to store a certificate,\netc for verification-certificate blocks (VCBs).\n\nThe subcode value is denoted by setting the left-most bit\nof an 8-byte field.\n\nThe verification-certificate-storage-size block (VCSSB) contains\nthe output data when the operation completes successfully. A VCSSB\nlength of 4 indicates that no certificate are available in the cert\nstore.\n\nSigned-off-by: Zhuoying Cai <zycai@linux.ibm.com>\nReviewed-by: Farhan Ali <alifm@linux.ibm.com>\nReviewed-by: Collin Walling <walling@linux.ibm.com>\n---\n docs/specs/s390x-secure-ipl.rst | 12 +++++++\n include/hw/s390x/ipl/diag320.h | 22 ++++++++++++\n target/s390x/diag.c | 63 ++++++++++++++++++++++++++++++++-\n 3 files changed, 96 insertions(+), 1 deletion(-)", "diff": "diff --git a/docs/specs/s390x-secure-ipl.rst b/docs/specs/s390x-secure-ipl.rst\nindex c2e8f7aba5..d3ece8a82d 100644\n--- a/docs/specs/s390x-secure-ipl.rst\n+++ b/docs/specs/s390x-secure-ipl.rst\n@@ -26,3 +26,15 @@ Subcode 0 - query installed subcodes\n Returns a 256-bit installed subcodes mask (ISM) stored in the installed\n subcodes block (ISB). This mask indicates which subcodes are currently\n installed and available for use.\n+\n+Subcode 1 - query verification certificate storage information\n+ Provides the information required to determine the amount of memory needed\n+ to store one or more verification-certificates (VCs) from the certificate\n+ store (CS).\n+\n+ Upon successful completion, this subcode returns various storage size values\n+ for verification-certificate blocks (VCBs).\n+\n+ The output is returned in the verification-certificate-storage-size block\n+ (VCSSB). A VCSSB length of 4 indicates that no certificates are available\n+ in the CS.\ndiff --git a/include/hw/s390x/ipl/diag320.h b/include/hw/s390x/ipl/diag320.h\nindex aa04b699c6..6e4779c699 100644\n--- a/include/hw/s390x/ipl/diag320.h\n+++ b/include/hw/s390x/ipl/diag320.h\n@@ -11,10 +11,32 @@\n #define S390X_DIAG320_H\n \n #define DIAG_320_SUBC_QUERY_ISM 0\n+#define DIAG_320_SUBC_QUERY_VCSI 1\n \n #define DIAG_320_RC_OK 0x0001\n #define DIAG_320_RC_NOT_SUPPORTED 0x0102\n+#define DIAG_320_RC_INVAL_VCSSB_LEN 0x0202\n \n #define DIAG_320_ISM_QUERY_SUBCODES 0x80000000\n+#define DIAG_320_ISM_QUERY_VCSI 0x40000000\n+\n+#define VCSSB_NO_VC 4\n+#define VCSSB_MIN_LEN 128\n+#define VCE_HEADER_LEN 128\n+#define VCB_HEADER_LEN 64\n+\n+struct VCStorageSizeBlock {\n+ uint32_t length;\n+ uint8_t reserved0[3];\n+ uint8_t version;\n+ uint32_t reserved1[6];\n+ uint16_t total_vc_ct;\n+ uint16_t max_vc_ct;\n+ uint32_t reserved3[11];\n+ uint32_t max_single_vcb_len;\n+ uint32_t total_vcb_len;\n+ uint32_t reserved4[10];\n+};\n+typedef struct VCStorageSizeBlock VCStorageSizeBlock;\n \n #endif\ndiff --git a/target/s390x/diag.c b/target/s390x/diag.c\nindex e867fc2156..3c7e64eb05 100644\n--- a/target/s390x/diag.c\n+++ b/target/s390x/diag.c\n@@ -197,11 +197,54 @@ out:\n }\n }\n \n+static int handle_diag320_query_vcsi(S390CPU *cpu, uint64_t addr, uint64_t r1,\n+ uintptr_t ra, S390IPLCertificateStore *cs)\n+{\n+ g_autofree VCStorageSizeBlock *vcssb = NULL;\n+\n+ vcssb = g_new0(VCStorageSizeBlock, 1);\n+ if (s390_cpu_virt_mem_read(cpu, addr, r1, vcssb, sizeof(*vcssb))) {\n+ s390_cpu_virt_mem_handle_exc(cpu, ra);\n+ return -1;\n+ }\n+\n+ if (be32_to_cpu(vcssb->length) > sizeof(*vcssb)) {\n+ return -1;\n+ }\n+\n+ if (be32_to_cpu(vcssb->length) < VCSSB_MIN_LEN) {\n+ return DIAG_320_RC_INVAL_VCSSB_LEN;\n+ }\n+\n+ if (!cs->count) {\n+ vcssb->length = cpu_to_be32(VCSSB_NO_VC);\n+ } else {\n+ vcssb->version = 0;\n+ vcssb->total_vc_ct = cpu_to_be16(cs->count);\n+ vcssb->max_vc_ct = cpu_to_be16(MAX_CERTIFICATES);\n+ vcssb->max_single_vcb_len = cpu_to_be32(VCB_HEADER_LEN + VCE_HEADER_LEN +\n+ cs->largest_cert_size);\n+ vcssb->total_vcb_len = cpu_to_be32(VCB_HEADER_LEN + cs->count * VCE_HEADER_LEN +\n+ cs->total_bytes);\n+ }\n+\n+ if (s390_cpu_virt_mem_write(cpu, addr, r1, vcssb, be32_to_cpu(vcssb->length))) {\n+ s390_cpu_virt_mem_handle_exc(cpu, ra);\n+ return -1;\n+ }\n+ return DIAG_320_RC_OK;\n+}\n+\n+QEMU_BUILD_BUG_MSG(sizeof(VCStorageSizeBlock) != VCSSB_MIN_LEN,\n+ \"size of VCStorageSizeBlock is wrong\");\n+\n void handle_diag_320(CPUS390XState *env, uint64_t r1, uint64_t r3, uintptr_t ra)\n {\n S390CPU *cpu = env_archcpu(env);\n+ S390IPLCertificateStore *cs = s390_ipl_get_certificate_store();\n uint64_t subcode = env->regs[r3];\n uint64_t addr = env->regs[r1];\n+ int rc;\n \n if (env->psw.mask & PSW_MASK_PSTATE) {\n s390_program_interrupt(env, PGM_PRIVILEGED, ra);\n@@ -223,7 +266,8 @@ void handle_diag_320(CPUS390XState *env, uint64_t r1, uint64_t r3, uintptr_t ra)\n * but the current set of subcodes can fit within a single word\n * for now.\n */\n- uint32_t ism_word0 = cpu_to_be32(DIAG_320_ISM_QUERY_SUBCODES);\n+ uint32_t ism_word0 = cpu_to_be32(DIAG_320_ISM_QUERY_SUBCODES |\n+ DIAG_320_ISM_QUERY_VCSI);\n \n if (s390_cpu_virt_mem_write(cpu, addr, r1, &ism_word0, sizeof(ism_word0))) {\n s390_cpu_virt_mem_handle_exc(cpu, ra);\n@@ -232,6 +276,23 @@ void handle_diag_320(CPUS390XState *env, uint64_t r1, uint64_t r3, uintptr_t ra)\n \n env->regs[r1 + 1] = DIAG_320_RC_OK;\n break;\n+ case DIAG_320_SUBC_QUERY_VCSI:\n+ if (!diag_parm_addr_valid(addr, sizeof(VCStorageSizeBlock), true)) {\n+ s390_program_interrupt(env, PGM_ADDRESSING, ra);\n+ return;\n+ }\n+\n+ if (addr & 0x7) {\n+ s390_program_interrupt(env, PGM_ADDRESSING, ra);\n+ return;\n+ }\n+\n+ rc = handle_diag320_query_vcsi(cpu, addr, r1, ra, cs);\n+ if (rc == -1) {\n+ return;\n+ }\n+ env->regs[r1 + 1] = rc;\n+ break;\n default:\n env->regs[r1 + 1] = DIAG_320_RC_NOT_SUPPORTED;\n break;\n", "prefixes": [ "v8", "07/30" ] }