Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196066/?format=api
{ "id": 2196066, "url": "http://patchwork.ozlabs.org/api/patches/2196066/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260212204352.1044699-11-zycai@linux.ibm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260212204352.1044699-11-zycai@linux.ibm.com>", "list_archive_url": null, "date": "2026-02-12T20:43:31", "name": "[v8,10/30] s390x/diag: Introduce DIAG 508 for secure IPL operations", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e10be8dbcec677c1a693fad956c9e582e6aa8745", "submitter": { "id": 90643, "url": "http://patchwork.ozlabs.org/api/people/90643/?format=api", "name": "Zhuoying Cai", "email": "zycai@linux.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260212204352.1044699-11-zycai@linux.ibm.com/mbox/", "series": [ { "id": 492021, "url": "http://patchwork.ozlabs.org/api/series/492021/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492021", "date": "2026-02-12T20:43:36", "name": "Secure IPL Support for SCSI Scheme of virtio-blk/virtio-scsi Devices", "version": 8, "mbox": "http://patchwork.ozlabs.org/series/492021/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196066/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196066/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=g+ovsCNU;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fBnNt5y96z1xxM\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 13 Feb 2026 07:45:02 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vqdY0-0000j9-Lm; Thu, 12 Feb 2026 15:44:24 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zycai@linux.ibm.com>)\n id 1vqdXy-0000hR-1j; Thu, 12 Feb 2026 15:44:22 -0500", "from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zycai@linux.ibm.com>)\n id 1vqdXw-0007WB-67; Thu, 12 Feb 2026 15:44:21 -0500", "from pps.filterd (m0360072.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 61CAOJrp3125577; Thu, 12 Feb 2026 20:44:16 GMT", "from ppma23.wdc07v.mail.ibm.com\n (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4c696x5c27-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 12 Feb 2026 20:44:16 +0000 (GMT)", "from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 61CHR36n012610;\n Thu, 12 Feb 2026 20:44:15 GMT", "from smtprelay01.wdc07v.mail.ibm.com ([172.16.1.68])\n by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4c6h7km14g-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 12 Feb 2026 20:44:15 +0000", "from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com\n [10.39.53.233])\n by smtprelay01.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 61CKiE9F5047170\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Thu, 12 Feb 2026 20:44:14 GMT", "from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 66C845804E;\n Thu, 12 Feb 2026 20:44:14 +0000 (GMT)", "from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id A769158055;\n Thu, 12 Feb 2026 20:44:12 +0000 (GMT)", "from fedora-workstation.ibmuc.com (unknown [9.61.112.15])\n by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n Thu, 12 Feb 2026 20:44:12 +0000 (GMT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=R7dQWMpiaSvRRgBQ+\n GiCt0D51DJRLQETqroJAr86YLE=; b=g+ovsCNUqQQOweTZD7rQyhSFRWg98iR3c\n QRdzgdzziCCuiUCx26oYikPAr7BqShWpwyjmrMuprvjaxBr0pUf/6vZ2m2Ox4bh5\n mNy4L/bp29qjBPf6AgIi3YS/Bqol8Lp+0rWENn2DUF4cN2FkjzrbTQpoLYdlL3DX\n R+FccwXeMyfXiqy+I0+cx6BLK3TwF/SEDE5b4QaCPD/CuAhuhQL/25ctJpW7lLVq\n PpdX3revjlPXqNprxjgzcUPv6aPD4BNYinRagPmYogi3zOG3lzDZTIMBpHkfSjLF\n JtqFj55l3oYJr6er3v+nQchWCrIKVVrBAFBnFwjcBmkwO7NQhrtHQ==", "From": "Zhuoying Cai <zycai@linux.ibm.com>", "To": "thuth@redhat.com, berrange@redhat.com, richard.henderson@linaro.org,\n jrossi@linux.ibm.com, qemu-s390x@nongnu.org, qemu-devel@nongnu.org", "Cc": "david@kernel.org, walling@linux.ibm.com, jjherne@linux.ibm.com,\n pasic@linux.ibm.com, borntraeger@linux.ibm.com, farman@linux.ibm.com,\n mjrosato@linux.ibm.com, iii@linux.ibm.com, eblake@redhat.com,\n armbru@redhat.com, zycai@linux.ibm.com, alifm@linux.ibm.com,\n brueckner@linux.ibm.com", "Subject": "[PATCH v8 10/30] s390x/diag: Introduce DIAG 508 for secure IPL\n operations", "Date": "Thu, 12 Feb 2026 15:43:31 -0500", "Message-ID": "<20260212204352.1044699-11-zycai@linux.ibm.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260212204352.1044699-1-zycai@linux.ibm.com>", "References": "<20260212204352.1044699-1-zycai@linux.ibm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Authority-Analysis": "v=2.4 cv=WZYBqkhX c=1 sm=1 tr=0 ts=698e3ba0 cx=c_pps\n a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17\n a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22\n a=GgsMoib0sEa3-_RKJdDe:22 a=VnNF1IyMAAAA:8 a=20KFwNOVAAAA:8\n a=hXQcL9AfcS-IPDpH2m0A:9", "X-Proofpoint-GUID": "xZH10DVhi1PbdKi_6z5MyDZjLXvWlzmI", "X-Proofpoint-ORIG-GUID": "xZH10DVhi1PbdKi_6z5MyDZjLXvWlzmI", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMjEyMDE1NyBTYWx0ZWRfX8ExHkqlaid6k\n UMZH8RDkR3BS9WtQE5USfuWV2YAjr85TYiOchG3bPWBXdr5+awV1CUdqu2xzOqmoHU/TDYjjV6Y\n 8yQyYWSs/wkjktZCzLV2OFpYRCeXdc5XtLLmyvAlvcvTGu+akWLRi4FpM0Gxcxw1WdeokmG23hf\n SiLIQJbEg/RUE21ARdM7X9Ke/p4iDOCA20yrQAJhu6qK0uGeH0NZh1UHwzzw+0v7TKVEgwSg+Pm\n jMzv6ThCatpBEbtztjCHANUNzE3YCp1AcriGWapVEfShW9pTmHhqd8uQZKGrhrad/ONtVJFCNn9\n K7HknA/6mEUsuESxPPl/baZoyBEvReVx5w0qr5MoZfoD+XmMwwEyAVMtuJEWOqrsUdQ5m8uYoca\n HJsFqUjqcJSm8lFAkIQnwscDCcV49Awa+Z893mShHy6YtkE8YkLB2Zio8948LjD0C1vP1pQtV0R\n CGh8rt3NBWb1Ju0pwdw==", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-02-12_05,2026-02-12_03,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n spamscore=0 clxscore=1015 phishscore=0 bulkscore=0 adultscore=0\n priorityscore=1501 lowpriorityscore=0 suspectscore=0 impostorscore=0\n malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2602120157", "Received-SPF": "pass client-ip=148.163.158.5; envelope-from=zycai@linux.ibm.com;\n helo=mx0b-001b2d01.pphosted.com", "X-Spam_score_int": "-26", "X-Spam_score": "-2.7", "X-Spam_bar": "--", "X-Spam_report": "(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Collin Walling <walling@linux.ibm.com>\n\nIn order to support secure IPL (aka secure boot) for the s390-ccw BIOS,\na new s390 DIAGNOSE instruction is introduced to leverage QEMU for\nhandling operations such as signature verification and certificate\nretrieval.\n\nCurrently, only subcode 0 is supported with this patch, which is used to\nquery a bitmap of which subcodes are supported.\n\nSigned-off-by: Collin Walling <walling@linux.ibm.com>\nReviewed-by: Farhan Ali <alifm@linux.ibm.com>\nReviewed-by: Thomas Huth <thuth@redhat.com>\n---\n docs/specs/s390x-secure-ipl.rst | 18 ++++++++++++++++++\n include/hw/s390x/ipl/diag508.h | 15 +++++++++++++++\n target/s390x/diag.c | 27 +++++++++++++++++++++++++++\n target/s390x/kvm/kvm.c | 14 ++++++++++++++\n target/s390x/s390x-internal.h | 2 ++\n target/s390x/tcg/misc_helper.c | 7 +++++++\n 6 files changed, 83 insertions(+)\n create mode 100644 include/hw/s390x/ipl/diag508.h", "diff": "diff --git a/docs/specs/s390x-secure-ipl.rst b/docs/specs/s390x-secure-ipl.rst\nindex 22da589162..867d92fa68 100644\n--- a/docs/specs/s390x-secure-ipl.rst\n+++ b/docs/specs/s390x-secure-ipl.rst\n@@ -60,3 +60,21 @@ Subcode 2 - store verification certificates\n contiguously in a VCE (with zero-padding). Following the header, the\n key-id is immediately stored. The hash and certificate data follow and\n may be accessed via the respective offset fields stored in the VCE.\n+\n+\n+Secure IPL Data Structures, Facilities, and Functions\n+=====================================================\n+\n+DIAGNOSE function code 'X'508' - IPL extensions\n+---------------------------------------------------\n+\n+DIAGNOSE 'X'508' is reserved for guest use in order to facilitate communication\n+of additional IPL operations that cannot be handled by userspace, such as\n+signature verification for secure IPL.\n+\n+If the function code specifies 0x508, IPL extension functions are performed.\n+These functions are meant to provide extended functionality for s390 guest boot\n+that requires assistance from QEMU.\n+\n+Subcode 0 - query installed subcodes\n+ Returns a 64-bit mask indicating which subcodes are supported.\ndiff --git a/include/hw/s390x/ipl/diag508.h b/include/hw/s390x/ipl/diag508.h\nnew file mode 100644\nindex 0000000000..6281ad8299\n--- /dev/null\n+++ b/include/hw/s390x/ipl/diag508.h\n@@ -0,0 +1,15 @@\n+/*\n+ * S/390 DIAGNOSE 508 definitions and structures\n+ *\n+ * Copyright 2025 IBM Corp.\n+ * Author(s): Collin Walling <walling@linux.ibm.com>\n+ *\n+ * SPDX-License-Identifier: GPL-2.0-or-later\n+ */\n+\n+#ifndef S390X_DIAG508_H\n+#define S390X_DIAG508_H\n+\n+#define DIAG_508_SUBC_QUERY_SUBC 0x0000\n+\n+#endif\ndiff --git a/target/s390x/diag.c b/target/s390x/diag.c\nindex e70375d2a9..0b56023bb8 100644\n--- a/target/s390x/diag.c\n+++ b/target/s390x/diag.c\n@@ -20,6 +20,7 @@\n #include \"hw/s390x/cert-store.h\"\n #include \"hw/s390x/ipl.h\"\n #include \"hw/s390x/ipl/diag320.h\"\n+#include \"hw/s390x/ipl/diag508.h\"\n #include \"hw/s390x/s390-virtio-ccw.h\"\n #include \"system/kvm.h\"\n #include \"kvm/kvm_s390x.h\"\n@@ -624,3 +625,29 @@ void handle_diag_320(CPUS390XState *env, uint64_t r1, uint64_t r3, uintptr_t ra)\n break;\n }\n }\n+\n+void handle_diag_508(CPUS390XState *env, uint64_t r1, uint64_t r3, uintptr_t ra)\n+{\n+ uint64_t subcode = env->regs[r3];\n+ int rc;\n+\n+ if (env->psw.mask & PSW_MASK_PSTATE) {\n+ s390_program_interrupt(env, PGM_PRIVILEGED, ra);\n+ return;\n+ }\n+\n+ if ((subcode & ~0x0ffffULL) || (r1 & 1)) {\n+ s390_program_interrupt(env, PGM_SPECIFICATION, ra);\n+ return;\n+ }\n+\n+ switch (subcode) {\n+ case DIAG_508_SUBC_QUERY_SUBC:\n+ rc = 0;\n+ break;\n+ default:\n+ s390_program_interrupt(env, PGM_SPECIFICATION, ra);\n+ return;\n+ }\n+ env->regs[r1 + 1] = rc;\n+}\ndiff --git a/target/s390x/kvm/kvm.c b/target/s390x/kvm/kvm.c\nindex 636d2d8f01..e06b760e03 100644\n--- a/target/s390x/kvm/kvm.c\n+++ b/target/s390x/kvm/kvm.c\n@@ -101,6 +101,7 @@\n #define DIAG_CERT_STORE 0x320\n #define DIAG_KVM_HYPERCALL 0x500\n #define DIAG_KVM_BREAKPOINT 0x501\n+#define DIAG_SECURE_IPL 0x508\n \n #define ICPT_INSTRUCTION 0x04\n #define ICPT_PROGRAM 0x08\n@@ -1571,6 +1572,16 @@ static void kvm_handle_diag_320(S390CPU *cpu, struct kvm_run *run)\n handle_diag_320(&cpu->env, r1, r3, RA_IGNORED);\n }\n \n+static void kvm_handle_diag_508(S390CPU *cpu, struct kvm_run *run)\n+{\n+ uint64_t r1, r3;\n+\n+ r1 = (run->s390_sieic.ipa & 0x00f0) >> 4;\n+ r3 = run->s390_sieic.ipa & 0x000f;\n+\n+ handle_diag_508(&cpu->env, r1, r3, RA_IGNORED);\n+}\n+\n #define DIAG_KVM_CODE_MASK 0x000000000000ffff\n \n static int handle_diag(S390CPU *cpu, struct kvm_run *run, uint32_t ipb)\n@@ -1604,6 +1615,9 @@ static int handle_diag(S390CPU *cpu, struct kvm_run *run, uint32_t ipb)\n case DIAG_CERT_STORE:\n kvm_handle_diag_320(cpu, run);\n break;\n+ case DIAG_SECURE_IPL:\n+ kvm_handle_diag_508(cpu, run);\n+ break;\n default:\n trace_kvm_insn_diag(func_code);\n kvm_s390_program_interrupt(cpu, PGM_SPECIFICATION);\ndiff --git a/target/s390x/s390x-internal.h b/target/s390x/s390x-internal.h\nindex 771b62fbe2..949a6a4552 100644\n--- a/target/s390x/s390x-internal.h\n+++ b/target/s390x/s390x-internal.h\n@@ -390,6 +390,8 @@ void handle_diag_308(CPUS390XState *env, uint64_t r1, uint64_t r3,\n uintptr_t ra);\n void handle_diag_320(CPUS390XState *env, uint64_t r1, uint64_t r3,\n uintptr_t ra);\n+void handle_diag_508(CPUS390XState *env, uint64_t r1, uint64_t r3,\n+ uintptr_t ra);\n \n \n /* translate.c */\ndiff --git a/target/s390x/tcg/misc_helper.c b/target/s390x/tcg/misc_helper.c\nindex 4d73475d95..562dde9cb3 100644\n--- a/target/s390x/tcg/misc_helper.c\n+++ b/target/s390x/tcg/misc_helper.c\n@@ -149,6 +149,13 @@ void HELPER(diag)(CPUS390XState *env, uint32_t r1, uint32_t r3, uint32_t num)\n bql_unlock();\n r = 0;\n break;\n+ case 0x508:\n+ /* secure ipl operations */\n+ bql_lock();\n+ handle_diag_508(env, r1, r3, GETPC());\n+ bql_unlock();\n+ r = 0;\n+ break;\n default:\n r = -1;\n break;\n", "prefixes": [ "v8", "10/30" ] }