Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196063/?format=api
{ "id": 2196063, "url": "http://patchwork.ozlabs.org/api/patches/2196063/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260212204352.1044699-16-zycai@linux.ibm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260212204352.1044699-16-zycai@linux.ibm.com>", "list_archive_url": null, "date": "2026-02-12T20:43:36", "name": "[v8,15/30] hw/s390x/ipl: Add IPIB flags to IPL Parameter Block", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "42423c68f12d390d6183c0210b571261185c2c83", "submitter": { "id": 90643, "url": "http://patchwork.ozlabs.org/api/people/90643/?format=api", "name": "Zhuoying Cai", "email": "zycai@linux.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260212204352.1044699-16-zycai@linux.ibm.com/mbox/", "series": [ { "id": 492021, "url": "http://patchwork.ozlabs.org/api/series/492021/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492021", "date": "2026-02-12T20:43:36", "name": "Secure IPL Support for SCSI Scheme of virtio-blk/virtio-scsi Devices", "version": 8, "mbox": "http://patchwork.ozlabs.org/series/492021/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196063/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196063/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=kcWOasfT;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fBnNh4trJz1xvQ\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 13 Feb 2026 07:44:51 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vqdYB-0000q2-Pf; Thu, 12 Feb 2026 15:44:35 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zycai@linux.ibm.com>)\n id 1vqdY9-0000nj-GC; Thu, 12 Feb 2026 15:44:33 -0500", "from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zycai@linux.ibm.com>)\n id 1vqdY7-0007il-Nv; Thu, 12 Feb 2026 15:44:33 -0500", "from pps.filterd (m0353725.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 61CArChW1927470; Thu, 12 Feb 2026 20:44:26 GMT", "from ppma23.wdc07v.mail.ibm.com\n (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4c696vd8s7-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 12 Feb 2026 20:44:26 +0000 (GMT)", "from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 61CHCh7U012996;\n Thu, 12 Feb 2026 20:44:25 GMT", "from smtprelay05.dal12v.mail.ibm.com ([172.16.1.7])\n by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4c6h7km14t-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 12 Feb 2026 20:44:25 +0000", "from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com\n [10.39.53.233])\n by smtprelay05.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 61CKiO4A33686124\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Thu, 12 Feb 2026 20:44:24 GMT", "from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 325015804E;\n Thu, 12 Feb 2026 20:44:24 +0000 (GMT)", "from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 70CE558054;\n Thu, 12 Feb 2026 20:44:22 +0000 (GMT)", "from fedora-workstation.ibmuc.com (unknown [9.61.112.15])\n by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n Thu, 12 Feb 2026 20:44:22 +0000 (GMT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=pJ2050/yoLIuTeniI\n eCJolWb5yrj4790xEgyq9YOCT8=; b=kcWOasfTWe6+7C4XbRpy2gyWme5fT8aD5\n mLlZqzRgK53y9iSKa0s2k+kzyUaxyY7GxBD8eqkoCZ7yxCym42dfSdnxjCw9bmmJ\n QDifWR8WEcQiOPbYZaY4Ktei+wySpYKZb0pVrlWqLOs3vhE1KEbN7Uxb466F8CLm\n fE+LAxMDq/sD144ZpgN/ANbxylR3BmiysjnjHc/+SA1Yex8IhAGqWDwQDWI0gx/+\n mmrjoLHQupF1eFI31Tdp4M48IgT4Bw37qjUr4DNehXCToBmx0AqeGchTSzhR+tV5\n FH7eR5SlDVetsigNaKaC4j7i/7CnkGHd1PWfieVq5gKleSh+4hbNA==", "From": "Zhuoying Cai <zycai@linux.ibm.com>", "To": "thuth@redhat.com, berrange@redhat.com, richard.henderson@linaro.org,\n jrossi@linux.ibm.com, qemu-s390x@nongnu.org, qemu-devel@nongnu.org", "Cc": "david@kernel.org, walling@linux.ibm.com, jjherne@linux.ibm.com,\n pasic@linux.ibm.com, borntraeger@linux.ibm.com, farman@linux.ibm.com,\n mjrosato@linux.ibm.com, iii@linux.ibm.com, eblake@redhat.com,\n armbru@redhat.com, zycai@linux.ibm.com, alifm@linux.ibm.com,\n brueckner@linux.ibm.com", "Subject": "[PATCH v8 15/30] hw/s390x/ipl: Add IPIB flags to IPL Parameter Block", "Date": "Thu, 12 Feb 2026 15:43:36 -0500", "Message-ID": "<20260212204352.1044699-16-zycai@linux.ibm.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260212204352.1044699-1-zycai@linux.ibm.com>", "References": "<20260212204352.1044699-1-zycai@linux.ibm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Proofpoint-GUID": "fgnH6lDPkS2dcGmDqaw4yaeWYKw0dGoC", "X-Proofpoint-ORIG-GUID": "fgnH6lDPkS2dcGmDqaw4yaeWYKw0dGoC", "X-Authority-Analysis": "v=2.4 cv=JdWxbEKV c=1 sm=1 tr=0 ts=698e3baa cx=c_pps\n a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17\n a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22\n a=GgsMoib0sEa3-_RKJdDe:22 a=VnNF1IyMAAAA:8 a=20KFwNOVAAAA:8\n a=0RU0I6ilb4cTaI3NU4AA:9", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMjEyMDE1NyBTYWx0ZWRfXxNPklmSrXBJs\n NVXolM7jF6JSPcjKN8IwwUMeA6oh6qzhRc9hqjkuIV3XJWCf1PVxuExdyLNqBsSyy6YR18qLk8b\n W5YhcE/4BE3AjhEe69nQESEEwz5hbQjPFTZMAQrxALHbc6yBnNMqTfQ8EmQtf0Cr03nR3U7FRVJ\n JMCGY6Odw6lUrTi/8SWDncQkbMeLCa9jTc8sGuzExf38+rRnp4e2TqoRVC24xGs3i/Nl4Pab+Mt\n sb0f9nh3kDcBzJYCISHq/RvHvQahEGjkEnWK6xDNmLAAXZ9h2sShUeFIl4oovc0bT44JA1iH7gy\n EVMLNJYqpDwx2M9UtMUTKyytCzbt/9+CiWaxJKvjsuHOLPVJH/WLpIwH7diRbAC2LAJEO2VHlGt\n DTqw12CGqsJ/VWiKr4a6pei05fGccV2VrOdut8EX/x22WoWldPqyZxg+lntY/4WKzP2CpAD3qiw\n s95sfeMkPYn1GcTMD+w==", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-02-12_05,2026-02-12_03,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n priorityscore=1501 clxscore=1015 impostorscore=0 bulkscore=0\n lowpriorityscore=0 suspectscore=0 adultscore=0 spamscore=0 malwarescore=0\n phishscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2602120157", "Received-SPF": "pass client-ip=148.163.158.5; envelope-from=zycai@linux.ibm.com;\n helo=mx0b-001b2d01.pphosted.com", "X-Spam_score_int": "-26", "X-Spam_score": "-2.7", "X-Spam_bar": "--", "X-Spam_report": "(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Add IPIB flags to IPL Parameter Block to determine if IPL needs to\nperform securely and if IPL Information Report Block (IIRB) exists.\n\nMove DIAG308 flags to a separated header file and add flags for secure IPL.\n\nSecure boot in audit mode will perform if certificate(s) exist in the\nkey store. IIRB will exist and results of verification will be stored in\nIIRB.\n\nTo ensure proper alignment of the IIRB and prevent overlap, set\niplb->len to the maximum length of the IPLB, allowing alignment\nconstraints to be determined based on its size.\n\nSigned-off-by: Zhuoying Cai <zycai@linux.ibm.com>\nReviewed-by: Thomas Huth <thuth@redhat.com>\n---\n hw/s390x/ipl.c | 21 +++++++++++++++++++++\n hw/s390x/ipl.h | 18 +-----------------\n include/hw/s390x/ipl/diag308.h | 34 ++++++++++++++++++++++++++++++++++\n include/hw/s390x/ipl/qipl.h | 5 ++++-\n 4 files changed, 60 insertions(+), 18 deletions(-)\n create mode 100644 include/hw/s390x/ipl/diag308.h", "diff": "diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c\nindex ea108fe370..b66dfd06bd 100644\n--- a/hw/s390x/ipl.c\n+++ b/hw/s390x/ipl.c\n@@ -433,6 +433,13 @@ S390IPLCertificateStore *s390_ipl_get_certificate_store(void)\n return &ipl->cert_store;\n }\n \n+static bool s390_has_certificate(void)\n+{\n+ S390IPLState *ipl = get_ipl_device();\n+\n+ return ipl->cert_store.count > 0;\n+}\n+\n static bool s390_build_iplb(DeviceState *dev_st, IplParameterBlock *iplb)\n {\n CcwDevice *ccw_dev = NULL;\n@@ -490,6 +497,20 @@ static bool s390_build_iplb(DeviceState *dev_st, IplParameterBlock *iplb)\n s390_ipl_convert_loadparm((char *)lp, iplb->loadparm);\n iplb->flags |= DIAG308_FLAGS_LP_VALID;\n \n+ /*\n+ * Secure boot in audit mode will perform\n+ * if certificate(s) exist in the key store.\n+ *\n+ * IPL Information Report Block (IIRB) will exist\n+ * for secure boot in audit mode.\n+ *\n+ * Results of secure boot will be stored in IIRB.\n+ */\n+ if (s390_has_certificate()) {\n+ iplb->hdr_flags |= DIAG308_IPIB_FLAGS_IPLIR;\n+ iplb->len = cpu_to_be32(S390_IPLB_MAX_LEN);\n+ }\n+\n return true;\n }\n \ndiff --git a/hw/s390x/ipl.h b/hw/s390x/ipl.h\nindex 0c773ac8ce..1f9d200f1b 100644\n--- a/hw/s390x/ipl.h\n+++ b/hw/s390x/ipl.h\n@@ -23,7 +23,6 @@\n #include \"qom/object.h\"\n #include \"target/s390x/kvm/pv.h\"\n \n-#define DIAG308_FLAGS_LP_VALID 0x80\n #define MAX_BOOT_DEVS 8 /* Max number of devices that may have a bootindex */\n \n void s390_ipl_convert_loadparm(char *ascii_lp, uint8_t *ebcdic_lp);\n@@ -91,22 +90,6 @@ struct S390IPLState {\n };\n QEMU_BUILD_BUG_MSG(offsetof(S390IPLState, iplb) & 3, \"alignment of iplb wrong\");\n \n-#define DIAG_308_RC_OK 0x0001\n-#define DIAG_308_RC_NO_CONF 0x0102\n-#define DIAG_308_RC_INVALID 0x0402\n-#define DIAG_308_RC_NO_PV_CONF 0x0902\n-#define DIAG_308_RC_INVAL_FOR_PV 0x0a02\n-\n-#define DIAG308_RESET_MOD_CLR 0\n-#define DIAG308_RESET_LOAD_NORM 1\n-#define DIAG308_LOAD_CLEAR 3\n-#define DIAG308_LOAD_NORMAL_DUMP 4\n-#define DIAG308_SET 5\n-#define DIAG308_STORE 6\n-#define DIAG308_PV_SET 8\n-#define DIAG308_PV_STORE 9\n-#define DIAG308_PV_START 10\n-\n #define S390_IPL_TYPE_FCP 0x00\n #define S390_IPL_TYPE_CCW 0x02\n #define S390_IPL_TYPE_PV 0x05\n@@ -117,6 +100,7 @@ QEMU_BUILD_BUG_MSG(offsetof(S390IPLState, iplb) & 3, \"alignment of iplb wrong\");\n #define S390_IPLB_MIN_CCW_LEN 200\n #define S390_IPLB_MIN_FCP_LEN 384\n #define S390_IPLB_MIN_QEMU_SCSI_LEN 200\n+#define S390_IPLB_MAX_LEN 4096\n \n static inline bool iplb_valid_len(IplParameterBlock *iplb)\n {\ndiff --git a/include/hw/s390x/ipl/diag308.h b/include/hw/s390x/ipl/diag308.h\nnew file mode 100644\nindex 0000000000..6e62f29215\n--- /dev/null\n+++ b/include/hw/s390x/ipl/diag308.h\n@@ -0,0 +1,34 @@\n+/*\n+ * S/390 DIAGNOSE 308 definitions and structures\n+ *\n+ * Copyright 2025 IBM Corp.\n+ * Author(s): Zhuoying Cai <zycai@linux.ibm.com>\n+ *\n+ * SPDX-License-Identifier: GPL-2.0-or-later\n+ */\n+\n+#ifndef S390X_DIAG308_H\n+#define S390X_DIAG308_H\n+\n+#define DIAG_308_RC_OK 0x0001\n+#define DIAG_308_RC_NO_CONF 0x0102\n+#define DIAG_308_RC_INVALID 0x0402\n+#define DIAG_308_RC_NO_PV_CONF 0x0902\n+#define DIAG_308_RC_INVAL_FOR_PV 0x0a02\n+\n+#define DIAG308_RESET_MOD_CLR 0\n+#define DIAG308_RESET_LOAD_NORM 1\n+#define DIAG308_LOAD_CLEAR 3\n+#define DIAG308_LOAD_NORMAL_DUMP 4\n+#define DIAG308_SET 5\n+#define DIAG308_STORE 6\n+#define DIAG308_PV_SET 8\n+#define DIAG308_PV_STORE 9\n+#define DIAG308_PV_START 10\n+\n+#define DIAG308_FLAGS_LP_VALID 0x80\n+\n+#define DIAG308_IPIB_FLAGS_SIPL 0x40\n+#define DIAG308_IPIB_FLAGS_IPLIR 0x20\n+\n+#endif\ndiff --git a/include/hw/s390x/ipl/qipl.h b/include/hw/s390x/ipl/qipl.h\nindex f5e63a2fdb..1b6cb3231d 100644\n--- a/include/hw/s390x/ipl/qipl.h\n+++ b/include/hw/s390x/ipl/qipl.h\n@@ -12,6 +12,8 @@\n #ifndef S390X_QIPL_H\n #define S390X_QIPL_H\n \n+#include \"diag308.h\"\n+\n /* Boot Menu flags */\n #define QIPL_FLAG_BM_OPTS_CMD 0x80\n #define QIPL_FLAG_BM_OPTS_ZIPL 0x40\n@@ -103,7 +105,8 @@ typedef struct IplBlockQemuScsi IplBlockQemuScsi;\n union IplParameterBlock {\n struct {\n uint32_t len;\n- uint8_t reserved0[3];\n+ uint8_t hdr_flags;\n+ uint8_t reserved0[2];\n uint8_t version;\n uint32_t blk0_len;\n uint8_t pbt;\n", "prefixes": [ "v8", "15/30" ] }