Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2196009/?format=api
{ "id": 2196009, "url": "http://patchwork.ozlabs.org/api/patches/2196009/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260212162730.440855-2-adamhet@scaleway.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260212162730.440855-2-adamhet@scaleway.com>", "list_archive_url": null, "date": "2026-02-12T16:27:24", "name": "[1/2] block/curl: fix concurrent completion handling", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "550fda60c52c54263802942bb3f5e5634e987875", "submitter": { "id": 90623, "url": "http://patchwork.ozlabs.org/api/people/90623/?format=api", "name": "Antoine Damhet", "email": "adamhet@scaleway.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260212162730.440855-2-adamhet@scaleway.com/mbox/", "series": [ { "id": 491995, "url": "http://patchwork.ozlabs.org/api/series/491995/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491995", "date": "2026-02-12T16:27:23", "name": "block/curl: fix S3 presigned URL support", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491995/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2196009/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2196009/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=scaleway.com header.i=@scaleway.com header.a=rsa-sha256\n header.s=google header.b=R8zw03sH;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fBgjV420Yz1xr1\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 13 Feb 2026 03:29:02 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vqZYT-0001Z4-5K; Thu, 12 Feb 2026 11:28:37 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <adamhet@scaleway.com>)\n id 1vqZY9-0001Pb-3t\n for qemu-devel@nongnu.org; Thu, 12 Feb 2026 11:28:17 -0500", "from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <adamhet@scaleway.com>)\n id 1vqZY5-0007jN-Qa\n for qemu-devel@nongnu.org; Thu, 12 Feb 2026 11:28:16 -0500", "by mail-wm1-x32e.google.com with SMTP id\n 5b1f17b1804b1-481188b7760so299295e9.0\n for <qemu-devel@nongnu.org>; Thu, 12 Feb 2026 08:28:10 -0800 (PST)", "from localhost (710304585.box.freepro.com. [130.180.219.188])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4836131d484sm33198425e9.27.2026.02.12.08.28.07\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 12 Feb 2026 08:28:07 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=scaleway.com; s=google; t=1770913688; x=1771518488; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=l7WdD2zHkBagt+yCXYN+euTN8kOLoPQP3BR3Isyndvk=;\n b=R8zw03sH7C+rHDXJo22KP+vXFQOZls9Ntkd8iL4V/lSYoJXUJBJdD46snXO+m/mm4b\n lvlpeSEgWQR6PidhVzvtJz49yZHNsh5iSChQOiBxGrXKtC+SJgzx/8xLl9oUVB1eidRC\n +8ciufWIS1QoLBD09XGTc2FOPRvS7ul76sb46fDZNxMwfZalpI7K2HPu5myAd6VpsEqM\n clSdnUPf0ZHNFAn8Merocy+o/MXLo9G67DWsVPy7kUju1G2CItpDsblmgnoMafcZR8ts\n 8VmJdIt4mARN8h5/3WyZmi022WxnuC1k95txYSVpoeNwjA217dCluwtdkIGuqEfbZMLS\n cbUQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1770913688; x=1771518488;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=l7WdD2zHkBagt+yCXYN+euTN8kOLoPQP3BR3Isyndvk=;\n b=fJ99Lqxud/NTq6I0YGOe1eLCtfaCr38Qh3eVnSyhNKgUzdk1MiMrHsatOktoWL3lkD\n XWx/3Q1N6yKftCv+AGzEqQQJfbx/WJ5PsmLRMjM43w5bW+xkz4rnz/lR7mMEqeT2NAul\n NeEdBwvNno2RDyPJQbLrd9v8mrWI5fiODDzBzmDT45szOSjsAgFoH1NX7xOElVrp0Zwg\n EcEkegGeRcCGtmnf3+CObo02dt1XeozNeNWut5a2nmIuBNKKaCH+dQt0E8/eBASJfBng\n FbmNFi2AJqTQEQEitxVjQ77Q0z+8Hm5jqKWLVOcph0jspGvTrLU5wW3y9flSMMVv7ZYY\n CODQ==", "X-Gm-Message-State": "AOJu0YwwuG9+v7ksTmFyN9p+BNKfqacPBtixTst/qP282wNYGSyd8vMm\n p8FU+lLroLFGvrm69vYg22Qtz+DI+45+LQZKKUWDkeVLH7/u2493UMA+Ihfq734iQwm0rffKv3+\n ylfeT", "X-Gm-Gg": "AZuq6aKW2k/pu8xTqZ5TpuD6h0z3Rkr4a6ZACfjhnpVAPJ5qeS53RFMi2U0VyTk4QuZ\n KKn0sRUrOggwWIWNfrzfF2sO3KeKi6IbTq1IEMefe5hUZ55hXYFIAea1cwTcIiB/BoMqO9oNkXr\n StgyHoOYB0uc2mY1xCFGf9VG+cHOHn0XoD3HuhXqNmsXG7MY36shCmMsZM8zlPY0XGkkceH9Q0B\n qM8qdEzz6FBvIdbiYb70LdeEB5lG1uAM80iRJR1L0hRsIA2XaPjkuV3vTvcJXfCF0y2Ci4PbqVD\n NsX1PDB40ZhyurWNVbeZL8UKkDne5+1Yu0kigMnrD0R5HLwfghfJQkA+4NaWjVAW5aQ6uyP8zZA\n uawVBCI0S0WrtbN/Y1hK2FqZdepaNdoqwj2MBlOHpRv+y63Rdk9Z+X2BRrf5r7zM6mItiQNwOVg\n y3Xp4GrDNnudwK62Rg/yYduZmAldgKa/AqKJ1iDMByTx/NnTG3", "X-Received": "by 2002:a05:600c:354c:b0:480:3230:6c89 with SMTP id\n 5b1f17b1804b1-483656c8246mr51006065e9.12.1770913687845;\n Thu, 12 Feb 2026 08:28:07 -0800 (PST)", "From": "Antoine Damhet <adamhet@scaleway.com>", "To": "qemu-devel@nongnu.org", "Cc": "Antoine Damhet <adamhet@scaleway.com>, qemu-block@nongnu.org,\n Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>,\n qemu-stable@nongnu.org", "Subject": "[PATCH 1/2] block/curl: fix concurrent completion handling", "Date": "Thu, 12 Feb 2026 17:27:24 +0100", "Message-ID": "<20260212162730.440855-2-adamhet@scaleway.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260212162730.440855-1-adamhet@scaleway.com>", "References": "<20260212162730.440855-1-adamhet@scaleway.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::32e;\n envelope-from=adamhet@scaleway.com; helo=mail-wm1-x32e.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "curl_multi_check_completion would bail upon the first completed\ntransfer even if more completion messages were available thus leaving\nsome in flight IOs stuck.\n\nRework a bit the loop to make the iterations clearer and drop the breaks.\n\nThe original hang can be somewhat reproduced with the following command:\n\n$ qemu-img convert -p -m 16 -O qcow2 -c --image-opts \\\n 'file.driver=https,file.url=https://scaleway.testdebit.info/10G.iso,file.readahead=1M' \\\n /tmp/test.qcow2\n\nFixes: 1f2cead32443 (\"curl: Ensure all informationals are checked for completion\")\nCc: qemu-stable@nongnu.org\nSigned-off-by: Antoine Damhet <adamhet@scaleway.com>\n---\n block/curl.c | 11 ++---------\n 1 file changed, 2 insertions(+), 9 deletions(-)", "diff": "diff --git a/block/curl.c b/block/curl.c\nindex 4e77c93b46e6..6dccf002564e 100644\n--- a/block/curl.c\n+++ b/block/curl.c\n@@ -324,17 +324,11 @@ curl_find_buf(BDRVCURLState *s, uint64_t start, uint64_t len, CURLAIOCB *acb)\n static void curl_multi_check_completion(BDRVCURLState *s)\n {\n int msgs_in_queue;\n+ CURLMsg *msg;\n \n /* Try to find done transfers, so we can free the easy\n * handle again. */\n- for (;;) {\n- CURLMsg *msg;\n- msg = curl_multi_info_read(s->multi, &msgs_in_queue);\n-\n- /* Quit when there are no more completions */\n- if (!msg)\n- break;\n-\n+ while ((msg = curl_multi_info_read(s->multi, &msgs_in_queue))) {\n if (msg->msg == CURLMSG_DONE) {\n int i;\n CURLState *state = NULL;\n@@ -397,7 +391,6 @@ static void curl_multi_check_completion(BDRVCURLState *s)\n }\n \n curl_clean_state(state);\n- break;\n }\n }\n }\n", "prefixes": [ "1/2" ] }